zas: When you say to have the accel attached to P, would <Open in &Player> suffice?
2015-12-10 34401, 2015
LordSputnik
Leftmost: any idea why our editor IDs are so sparse?
2015-12-10 34425, 2015
LordSputnik
The last 5 registered users were 131, 132, 133, 142, 143
2015-12-10 34400, 2015
LordSputnik
Oh, or maybe not, ignore me :P
2015-12-10 34404, 2015
LordSputnik
But we definitely have gaps
2015-12-10 34417, 2015
Leftmost
Not sure.
2015-12-10 34420, 2015
Leftmost
Oh, hey, I hit a bug in prod and found another testing case: I went to Publication, created a new edition from there, and it failed creating the data. The revision and entity were created but not the data.
2015-12-10 34425, 2015
Leo_Verto
LordSputnik, my idea for improving error handling back then was to have unified error displaying system, of course our architecture has changed a lot since then
2015-12-10 34435, 2015
Leftmost
(I suspect doing it from publisher will do the same.)
2015-12-10 34436, 2015
Leo_Verto
so I'm unsure of how relevant that is these days
2015-12-10 34414, 2015
Leftmost
Heh, very relevant.
2015-12-10 34430, 2015
Leftmost
Our error handling is bottom-notch right now.
2015-12-10 34417, 2015
LordSputnik
Leftmost: eww, that's a WS error isn't it
2015-12-10 34445, 2015
LordSputnik
Hopefully that'll get caught by the GCI tasks
2015-12-10 34442, 2015
LordSputnik
Leftmost: are you looking into it? It's probably a site bug in incorporating the publication ID into the data sent to the handler
2015-12-10 34448, 2015
Leftmost
That's a WS error and a UI error. I suspect the publication BBID didn't get set properly in the interface and that the WS isn't doing insertion transactionally.
2015-12-10 34403, 2015
Leftmost
I can look into it, just haven't gotten to it yet.
2015-12-10 34408, 2015
LordSputnik
OK
2015-12-10 34432, 2015
LordSputnik
And yes, all of the revisions (CRUMB) should be transactional, I don't know why we haven't done that already :P
2015-12-10 34435, 2015
yeeeargh has quit
2015-12-10 34456, 2015
LordSputnik
Leftmost: hmm, a WS error while making entity data should result in an Exception, which would prevent the transaction occurring
2015-12-10 34439, 2015
LordSputnik
Effectively at the moment a transaction is begun at the start of each WS request, and committed when session.commit() is called
2015-12-10 34455, 2015
LordSputnik
But that shouldn't ever be called if there's an exception
2015-12-10 34424, 2015
Leftmost
Can you look into the WS side and I'll look into the site side?
2015-12-10 34441, 2015
opatel99
Hmm. Dropdown is not working for the Bookbrainz site. I have the site server , ws, and redis all running on the correct, default ports
opatel99, did you run gulp before starting the site code?
2015-12-10 34401, 2015
LordSputnik
opatel99: yeah that's what I would suggest too
2015-12-10 34406, 2015
LordSputnik
^
2015-12-10 34446, 2015
Leftmost
We have to make alias set ID on entity data NULLable, don't we? We have historical data that requires it.
2015-12-10 34436, 2015
LordSputnik
I think it probably should be any way
2015-12-10 34441, 2015
opatel99
Thanks. I thought gulp watch would also compile it, but I guess not...
2015-12-10 34441, 2015
LordSputnik
Oh
2015-12-10 34455, 2015
LordSputnik
opatel99: yeah, I tend to run "gulp; gulp watch"
2015-12-10 34417, 2015
LordSputnik
That way, when gulp watch encounters an error, I just press "up" and hit enter to start things off again
2015-12-10 34446, 2015
LordSputnik
Leftmost: We could make it so that every entity data has an alias set, even if the alias set has no aliases?
2015-12-10 34436, 2015
Leftmost
I did think of that, but I'm not sure how I feel about it. I'll set it as NULLable for now and think more on it.
2015-12-10 34438, 2015
opatel99
This may be that I have not yet understood Bookbrainz yet, but why are books like Pride and Prejudice or Old Yeller entered? Does it still need to be done, or is there a reason?
2015-12-10 34451, 2015
opatel99
not entered^
2015-12-10 34457, 2015
Leftmost
opatel99, just hasn't been done yet.
2015-12-10 34451, 2015
opatel99
Can that be automated from another database?
2015-12-10 34429, 2015
Leftmost
We've had some discussion about pulling in data from the Library of Congress and/or Deutsche Nationalbibliothek.
2015-12-10 34425, 2015
Leftmost
We've also talked about using user scripts to prepopulate BookBrainz forms, and actually about making some GCI tasks for that. LordSputnik, did those ever get entered?
2015-12-10 34420, 2015
opatel99
I would enjoy doing that. When a book title is entered, automatically search that via an official API like Lib of Con and populate known fields?
2015-12-10 34432, 2015
Leftmost
I think the idea was along the lines of going to the LoC site, finding the book you wanted, and inserting a button like "Add to BookBrainz". That's how I'd envisioned it, at least.
Leftmost: It doesn't give me any revision/entity locally...
2015-12-10 34422, 2015
Leftmost
Double the fun.
2015-12-10 34447, 2015
LordSputnik
opatel99: Fixed now.
2015-12-10 34450, 2015
LordSputnik
I was in copy mode :P
2015-12-10 34400, 2015
LordSputnik
It seems to have the effect of pausing the running process on the server
2015-12-10 34445, 2015
LordSputnik
Leftmost: I suggest we just fix the bit of broken code in the site for now, because I can't see for the life of my how a revision can possibly be made in this case :P
2015-12-10 34453, 2015
opatel99
LordSputnik: Thank you
2015-12-10 34413, 2015
LordSputnik
Even the SQLAlchemy docs say that in the event of a commit raising an exception, the data will be rolled back
2015-12-10 34457, 2015
LordSputnik
opatel99: no problem :)
2015-12-10 34433, 2015
Ramswaroop__ joined the channel
2015-12-10 34434, 2015
LordSputnik
Leftmost: we could perhaps make edition_data.create return None if there's no publication set, and then abort the request handler if that happens?
LordSputnik: I saw the github issue you ported to Jira today. Since the project is heavily based on React, would you consider it natural to perhaps change the select2 dependency to https://github.com/JedWatson/react-select
2015-12-10 34434, 2015
LordSputnik
opatel99: we've looked into that already, but decided against it
2015-12-10 34437, 2015
Leftmost
I'd consider a proposal on it, but I've worked with it in the past and it's pretty inflexible.
2015-12-10 34452, 2015
LordSputnik
We've got a good React.js wrapper for select2 already
2015-12-10 34409, 2015
opatel99
Gotcha.
2015-12-10 34424, 2015
Leftmost
LordSputnik, were we still considering trying the other thing that I can't quite remember?
2015-12-10 34430, 2015
Bookzombie has quit
2015-12-10 34445, 2015
Bookzombie joined the channel
2015-12-10 34414, 2015
LordSputnik
Leftmost: If we were I've also forgotten, but I'm happy with select2 now
2015-12-10 34443, 2015
LordSputnik
Apart from 4.0.1, which is not good :P
2015-12-10 34454, 2015
Leftmost
There are a couple things that annoy me a little. Worth investigating them when we get there. :-P
2015-12-10 34414, 2015
LordSputnik
Leftmost: keep a note :)
2015-12-10 34436, 2015
LordSputnik
(although I kind of doubt we'll find a better alternative)
At my day job. We were working with keystone.js (the project react-select was written for) and had trouble even making it do what we wanted within keystone.
2015-12-10 34417, 2015
LordSputnik
opatel99: about 6 months ago, I think
2015-12-10 34426, 2015
D4RK-PH0ENiX has quit
2015-12-10 34430, 2015
LordSputnik
(well, I tried it out on BB locally)
2015-12-10 34440, 2015
Techtronix has quit
2015-12-10 34440, 2015
Leftmost
Oh, you did? Huh. :)
2015-12-10 34454, 2015
Techtronix joined the channel
2015-12-10 34401, 2015
LordSputnik
Leftmost: yeah, just before I made the new select2 component :)
2015-12-10 34437, 2015
Leftmost
My excuse for not knowing that is that UI scares me. :-P
2015-12-10 34452, 2015
LordSputnik heads off
2015-12-10 34414, 2015
Leftmost
Have a good one.
2015-12-10 34433, 2015
LordSputnik
Leftmost: before closing that jade task, if Annie finishes, check the files have copyright headers, thanks!
2015-12-10 34424, 2015
opatel99 has quit
2015-12-10 34428, 2015
Leftmost
Will do.
2015-12-10 34449, 2015
dpmittal joined the channel
2015-12-10 34435, 2015
dpmittal
Hi Freso
2015-12-10 34428, 2015
dpmittal
Hi reosarevok
2015-12-10 34448, 2015
dpmittal has left the channel
2015-12-10 34420, 2015
opatel99 joined the channel
2015-12-10 34436, 2015
opatel99
LordSputnik: Working on sandbox again?
2015-12-10 34407, 2015
Leftmost
I suspect he's in bed, and it looks to be working.
2015-12-10 34422, 2015
Leftmost
What error are you getting?
2015-12-10 34450, 2015
opatel99
Same as when he was in copy mode. Error: There was an error accessing the web service
2015-12-10 34427, 2015
Leftmost
Can you give the full error message? The HTTP code and URL are relevant.
