Freso: There are two ways of doing things - without a JSON endpoint on MB, we'd need to do https://meta.discourse.org/t/login-to-discourse-w… which is what would require all the Ruby. If we can add a JSON endpoint to MB for authenticated users, then we can use the ready-made basic OAuth2 plugin (which is the easier option, IMO)
2016-01-04 00459, 2016
Freso
Ah, right.
2016-01-04 00401, 2016
Freso
Okay. :)
2016-01-04 00411, 2016
Freso
Then we agree. 🙌
2016-01-04 00409, 2016
Freso
(I would love to do a custom MusicBrainz OAuth2 provider module which we could also contribute upstream to Discourse, but I also agree the 2nd option is likely easier.)
2016-01-04 00429, 2016
Freso
Hm. Maybe we could lure some volunteer at Discourse to do the former option?
2016-01-04 00450, 2016
weeksio_ joined the channel
2016-01-04 00457, 2016
LordSputnik
Not sure whether they'd see the value in that
2016-01-04 00424, 2016
Freso
opatel99: How's your Ruby? XD
2016-01-04 00435, 2016
Freso
(Poor opatel99 :p)
2016-01-04 00441, 2016
weeksio_
chirlu`: where can I find the patch you used to get solr to work with your sandbox yesterday?
didn't you have it working yesterday? running `python run.py`?
2016-01-04 00428, 2016
Gentlecat
in vagrant
2016-01-04 00400, 2016
weeksio_
CJ_: service solr restart
2016-01-04 00409, 2016
gcilou
OK. Im still not sure that it is working correctly. yes, python run.py works but it tells me nothing
2016-01-04 00419, 2016
CJ_
weeksio_, Trying now.
2016-01-04 00409, 2016
Gentlecat
gcilou: what do you mean tells you nothing? it's not supposed to, apart from log output
2016-01-04 00427, 2016
Gentlecat
if you can open local server from your browser, it's working
2016-01-04 00401, 2016
CJ_
weeksio_, Odd. Both con and docs have values.
2016-01-04 00401, 2016
CJ_
NM. Apparently it is only an occasional NPE.
2016-01-04 00427, 2016
CJ_
weeksio_, For some reason there is not always a ResultContext.
2016-01-04 00435, 2016
weeksio_
CJ_: I really don't know much about what's happening in this code
2016-01-04 00439, 2016
CJ_
I am not positive what this method is trying to achieve so I am not sure of the best resolution.
2016-01-04 00459, 2016
CJ_
But the short term fix would be to check if con is null and then skip the rest of the code.
2016-01-04 00425, 2016
weeksio_
Mineo ^ ?
2016-01-04 00429, 2016
CJ_
It looks like nothing would happen if there are no docs, so that should be a safe solution.
2016-01-04 00442, 2016
gcilou
Gentlecat, Ok. Is the profiler supposed to say 'inactive'?
2016-01-04 00444, 2016
CJ_
weeksio_, Without thoroughly digging through the entire infrastructure that is the best solution I have for you currently.
2016-01-04 00400, 2016
weeksio_
sounds good to me
2016-01-04 00410, 2016
stanislas
LordSputnik: I forgot to add test_publication.py :) Sorry if you started the tests already.
2016-01-04 00416, 2016
CJ_
Also, logging should be configured and used. printStackTrace should never be used.
2016-01-04 00440, 2016
CJ_
weeksio_, I will take a look at this more tomorrow and see what I can come up with.
2016-01-04 00455, 2016
weeksio_
great....thanks again
2016-01-04 00408, 2016
CJ_
No problem. :)
2016-01-04 00432, 2016
Gentlecat
gcilou: you mean in the debug panel on the page?
2016-01-04 00451, 2016
gcilou
Yes
2016-01-04 00454, 2016
Gentlecat
yeah, you shouldn't need it
2016-01-04 00451, 2016
gcilou
OK. So if when i press 'browse reviews', 'no reviews found' comes up, I'm assuming that that means im doing something wrong right?
2016-01-04 00423, 2016
ariscop joined the channel
2016-01-04 00410, 2016
Gentlecat
why would it be wrong?
2016-01-04 00427, 2016
Gentlecat
you modified review editor, so that's what you need to check
2016-01-04 00440, 2016
opatel99
Freso: sorry I missed ^. Ruby was the first web framework I learned and I believe I have enough knowledge of it to get by. I am pretty confident i could definitely do some work if you need me to. Of course, that is dependent on the level of the assignment. I'd like to give it a shot at least
2016-01-04 00446, 2016
Gentlecat
make sure that spotify player shows up on these pages
2016-01-04 00447, 2016
gcilou
Right but I can't enter the review editor when there aren't any reviews, can I?
2016-01-04 00423, 2016
gcilou
Or what am I missing?
2016-01-04 00430, 2016
Freso
opatel99: :) I'd like to make a GCI task for making an OAuth2 plugin (or get as close to making one as possible with current MB code). There are several already existing modules on this, but it's unlikely you'd be able to get much Ruby related help from us.
2016-01-04 00441, 2016
Freso
*Discourse plugin
2016-01-04 00451, 2016
Freso
If you think it sounds doable/reasonable, let me know.
stanislas: your master branch on the repo looks OK to me, should be possible to just add the missing file
2016-01-04 00404, 2016
stanislas
Can I make a separate commit and not reset the last two ?
2016-01-04 00422, 2016
stanislas
I've found reseting the merge not very easy.
2016-01-04 00430, 2016
Gentlecat
gcilou: yes
2016-01-04 00401, 2016
stanislas
LordSputnik: It is easy, but after that I've incidentaly deleted all my non-commited changes.
2016-01-04 00405, 2016
Gentlecat
that will require registering an app in MusicBrainz
2016-01-04 00416, 2016
Gentlecat
see installation instructions
2016-01-04 00424, 2016
gcilou
OK. Thank you I will try that
2016-01-04 00415, 2016
stanislas
LordSputnik: Could you give me the line in /config/test.py which I should change, It erased itself after the merge.
2016-01-04 00428, 2016
gcilou
Gentlecat, after following the instructions in the docs and at MusicBrainz, I recieved this error when trying to run `python run.py` socket.error: [Errno 98] Address already in use
2016-01-04 00406, 2016
chirlu`
Mineo: It might be better not to close SOLR issues that are fixed, but not deployed. (cc: yeeeargh)
