0:00 AM
johtso
hehe, just being nosey :)
2015-04-01 09137, 2015
0:10 AM
Sput|Away
So, the question is, if my browser is saying that the "Host" header is
bookbrainz.org , why is the HTTP_HOST in the wsgi environment just "bookbrainz"
2015-04-01 09116, 2015
0:15 AM
johtso
Sput|Away, is the nginx config somewhere?
2015-04-01 09143, 2015
0:16 AM
Sput|Away
2015-04-01 09157, 2015
0:16 AM
Sput|Away
(for the uwsgi stuff)
2015-04-01 09152, 2015
0:17 AM
johtso
is there a `server_name bookbrainz` somewhere?
2015-04-01 09138, 2015
0:19 AM
Sput|Away
nope, only "server_name bookbrainz.org"
2015-04-01 09100, 2015
0:20 AM
Sput|Away
bitmap: is the load balancer doing anything funny with the HTTP_HOST header?
2015-04-01 09125, 2015
0:21 AM
johtso
All I can thinking of it try to enable more logging to pinpoint where it starts looking odd
2015-04-01 09128, 2015
0:27 AM
bitmap
I'll try adding a proxy_set_header directive
2015-04-01 09130, 2015
0:29 AM
bitmap
did that help?
2015-04-01 09129, 2015
0:30 AM
Sput|Away
hold on
2015-04-01 09132, 2015
0:30 AM
Sput|Away
checking
2015-04-01 09111, 2015
0:31 AM
Sput|Away
wow
2015-04-01 09120, 2015
0:31 AM
Sput|Away
bitmap: You GentleCat'd it
2015-04-01 09129, 2015
0:31 AM
bitmap
haha
2015-04-01 09133, 2015
0:31 AM
Sput|Away
HTTP_HOST='bookbrainz.org'
2015-04-01 09141, 2015
0:31 AM
bitmap
awesome
2015-04-01 09103, 2015
0:32 AM
Sput|Away
was that on the load balancer or in our bookbrainz config?
2015-04-01 09142, 2015
0:32 AM
bitmap
load balancer, it was losing the original host and using the name of the upstream
2015-04-01 09109, 2015
0:33 AM
bitmap
sorry I didn't see that sooner
2015-04-01 09143, 2015
0:33 AM
Sput|Away
That's OK, I learnt a lot about Flask and Werkzeug ;)
2015-04-01 09132, 2015
0:36 AM
Sput|Away
Ahh, so that did fix HTTP_HOST, but still getting the same issue in Flask... I'll continue looking tomorrow
2015-04-01 09106, 2015
0:44 AM
Sput|Away
Oh nope, that's just my cache...
2015-04-01 09125, 2015
0:49 AM
Sput|Away
hmm Leftmost: Not Found (GET: /ws/ws/publication/a4dc4915-9d57-4b75-9465-a33f960275b2/disambiguation)
2015-04-01 09149, 2015
0:59 AM
Sput|Away
Ah, it now seems that relative URLs once again have the /ws prefix - I'll see what I can do to fix that tomorrow
2015-04-01 09106, 2015
1:00 AM
Sput|Away has left the channel
2015-04-01 09111, 2015
9:53 AM
LordSputnik joined the channel
2015-04-01 09117, 2015
9:59 AM
LordSputnik
Leftmost: If you're here, I'm not sure we should try to avoid the "/ws" part of the relative URL
2015-04-01 09101, 2015
10:02 AM
ZaphodBeeblebrox joined the channel
2015-04-01 09142, 2015
10:07 AM
LordSputnik
2015-04-01 09147, 2015
11:16 AM
bookzombie
bookbrainz-schema/master c300981 Ben Ockmore: Added option to not create tables during bootstrap.
2015-04-01 09144, 2015
11:19 AM
bookzombie
bookbrainz-schema/master 93329eb Ben Ockmore: Corrected mistakes in arguments to bootstrap.
2015-04-01 09154, 2015
11:29 AM
LordSputnik
Leftmost: Leo_Verto: ping?
2015-04-01 09135, 2015
11:49 AM
Leo_Verto
pong
2015-04-01 09120, 2015
11:52 AM
LordSputnik
Ok, I'm not exactly sure what to about Leftmost and ID #2, he doesn't seem to be here and the launch is in 8 minutes
2015-04-01 09133, 2015
11:52 AM
LordSputnik
Might make a placeholder...
2015-04-01 09142, 2015
11:53 AM
LordSputnik
Leo_Verto: see PM
2015-04-01 09105, 2015
11:56 AM
Leo_Verto
um
2015-04-01 09111, 2015
11:56 AM
Leo_Verto
something's broken
2015-04-01 09114, 2015
11:56 AM
LordSputnik
Fixing it now
2015-04-01 09122, 2015
11:56 AM
Leo_Verto
I end up on /login/handler
2015-04-01 09107, 2015
11:57 AM
LordSputnik
Leo_Verto: now?
2015-04-01 09115, 2015
11:57 AM
Leo_Verto
yay
2015-04-01 09122, 2015
11:57 AM
Leo_Verto
logged in and #3 :D
2015-04-01 09124, 2015
11:58 AM
LordSputnik
Freso: here, and want to claim #5?
2015-04-01 09140, 2015
11:58 AM
LordSputnik
2015-04-01 09105, 2015
11:59 AM
LordSputnik
We're going to need to do something about those times
2015-04-01 09110, 2015
11:59 AM
LordSputnik
I wonder why that's happened
2015-04-01 09138, 2015
11:59 AM
LordSputnik
At least there should be a constant offset, so it should be fairly simple to fix once we find out why
2015-04-01 09121, 2015
12:00 PM
Leftmost
I am here.
2015-04-01 09139, 2015
12:00 PM
LordSputnik
Ok, register now and I'll move you to #2
2015-04-01 09147, 2015
12:01 PM
Leftmost
Done.
2015-04-01 09127, 2015
12:03 PM
Leftmost
LordSputnik, why was it you don't think we should strip the /ws from relative URIs?
2015-04-01 09153, 2015
12:04 PM
LordSputnik
2015-04-01 09132, 2015
12:05 PM
LordSputnik
Leftmost: because with "/..." urls, the URL is meant to be relative to the domain name
2015-04-01 09129, 2015
12:06 PM
LordSputnik
err
2015-04-01 09141, 2015
12:06 PM
LordSputnik
We may be missing some of the languages - not sure why yet
2015-04-01 09146, 2015
12:06 PM
LordSputnik
taken things down just to be safe
2015-04-01 09105, 2015
12:11 PM
LordSputnik
Got it
2015-04-01 09118, 2015
12:14 PM
LordSputnik
2015-04-01 09129, 2015
12:14 PM
LordSputnik
2015-04-01 09103, 2015
12:15 PM
LordSputnik thinks Terry Pratchett should be #8 if not #1
2015-04-01 09112, 2015
12:15 PM
LordSputnik
since 8 is particularly important in Discworld
2015-04-01 09126, 2015
12:15 PM
Leo_Verto
hmm, 404 on messageForm
2015-04-01 09145, 2015
12:18 PM
LordSputnik
ah, should be message send, I'll fix that
2015-04-01 09128, 2015
12:21 PM
bookzombie
bookbrainz-site/master a77e816 Ben Ockmore: Updated message form URL in editor page link.
2015-04-01 09124, 2015
12:24 PM
LordSputnik
ah, client JS ws endpoint needs updating - relationships form (and editor profile form) currently out of action
2015-04-01 09143, 2015
12:26 PM
Leftmost
LordSputnik, there's just no way to be graceful about how we construct URLs if we include /ws.
2015-04-01 09102, 2015
12:27 PM
LordSputnik
Leftmost: well, if we keep using absolute URLs, we're fine
2015-04-01 09105, 2015
12:27 PM
Leftmost
Sorry, phone company's April Fool's gag is to make tethering not work properly.
2015-04-01 09134, 2015
12:27 PM
LordSputnik
if not, can't we just add /ws to the front of any hand-types urls, and use
bookbrainz.org as the ws setting?
2015-04-01 09156, 2015
12:27 PM
LordSputnik
Ahh, I forgot to update the relationship templates in the bootstrap script
2015-04-01 09141, 2015
12:28 PM
Leftmost
We could. Mostly we just need to decide if we're going to hardcode /ws or if we're going to allow that to be a config thing.
2015-04-01 09134, 2015
12:29 PM
Leftmost
What's up with the editor page?
2015-04-01 09149, 2015
12:29 PM
LordSputnik
Looks fine to me?
2015-04-01 09110, 2015
12:30 PM
Leftmost
I'm getting "Cannot read property 'id' of undefined".
2015-04-01 09105, 2015
12:31 PM
LordSputnik
Still? I thought I fixed that :(
2015-04-01 09131, 2015
12:31 PM
Leftmost
Oh, it's because I'm not logged in and there's no check to make sure that req.user exists before accessing it.
2015-04-01 09144, 2015
12:31 PM
LordSputnik
There is as of 5 minutes ago
2015-04-01 09123, 2015
12:32 PM
Leftmost
Not in routes/editor.js for the /:id route.
2015-04-01 09134, 2015
12:32 PM
LordSputnik
It's in view/editor/editor.jade
2015-04-01 09154, 2015
12:32 PM
LordSputnik
Ohhh
2015-04-01 09158, 2015
12:32 PM
LordSputnik
Not a template error...
2015-04-01 09136, 2015
12:33 PM
LordSputnik
fixed
2015-04-01 09140, 2015
12:34 PM
Leftmost
By the way, you violated style guidelines for our first publication. ;)
2015-04-01 09106, 2015
12:36 PM
LordSputnik
the "The" ?
2015-04-01 09121, 2015
12:36 PM
Leftmost
Yep.
2015-04-01 09130, 2015
12:36 PM
LordSputnik
well, it'll give someone something to do when entity updates come in :D
2015-04-01 09140, 2015
12:36 PM
Leftmost
Hehe.
2015-04-01 09148, 2015
12:36 PM
Leo_Verto
umm
2015-04-01 09159, 2015
12:36 PM
Leo_Verto
so it says "Person" under persons but nothing under the publication?
2015-04-01 09135, 2015
12:38 PM
LordSputnik
Leo_Verto: I couldn't set a type for the first publication - there wasn't really an appropriate one
2015-04-01 09142, 2015
12:38 PM
Leo_Verto
ah
2015-04-01 09150, 2015
12:38 PM
LordSputnik
There's journal, but I don't think that covers it
2015-04-01 09112, 2015
12:39 PM
LordSputnik
Is it a book, maybe?
2015-04-01 09109, 2015
12:43 PM
Leftmost
Okay, I need to go back to bed now. Back in a little while.
2015-04-01 09136, 2015
12:46 PM
Leo_Verto
do we really want the type to be part of the <a>?
2015-04-01 09107, 2015
12:47 PM
LordSputnik
Leftmost: Don't forget twitter, before you go
2015-04-01 09127, 2015
12:47 PM
LordSputnik
Leo_Verto: I tweaked it so the whole box was clickable, like a button
2015-04-01 09136, 2015
12:47 PM
Leo_Verto
ah nice
2015-04-01 09137, 2015
12:47 PM
LordSputnik
easier for mobile users
2015-04-01 09153, 2015
12:47 PM
LordSputnik
(and less fiddly for desktop users)
2015-04-01 09130, 2015
12:48 PM
LordSputnik
Ahh damn
2015-04-01 09139, 2015
12:48 PM
LordSputnik
I made a bad edit
2015-04-01 09147, 2015
12:48 PM
LordSputnik wishes we had reverting in now
2015-04-01 09106, 2015
12:51 PM
LordSputnik
Hmm, and it's debatable whether I should've made those relationships between creator->publication anyway
2015-04-01 09118, 2015
12:51 PM
LordSputnik
probably creator<->work would be more appropriate
2015-04-01 09108, 2015
12:52 PM
Leo_Verto
well, MB has the same problem
2015-04-01 09135, 2015
13:00 PM
Leo_Verto
oh
2015-04-01 09106, 2015
13:04 PM
Leo_Verto
hmm, the pre-commit hook prevents me from pushing
2015-04-01 09121, 2015
13:04 PM
Leo_Verto
*commiting
2015-04-01 09141, 2015
13:04 PM
johtso
What does language mean for a creator? and what does the "primary" checkbox signify?
2015-04-01 09149, 2015
13:05 PM
bookzombie
bookbrainz-site/master e622cfe LeoVerto: Updated message form URL in message reply link.
2015-04-01 09119, 2015
13:06 PM
LordSputnik
johtso: you should tick the primary checkbox if the alias you enter is the most commonly used on for the language you specify
2015-04-01 09127, 2015
13:06 PM
johtso
aha
2015-04-01 09141, 2015
13:06 PM
johtso
I see, so it's like adding an alias in MB
2015-04-01 09106, 2015
13:07 PM
Leo_Verto
LordSputnik, can you update the server?
2015-04-01 09136, 2015
13:07 PM
LordSputnik
johtso: yeah exactly
2015-04-01 09105, 2015
13:08 PM
LordSputnik
johtso: up until about a week ago, you could add many aliases in the creation form, but we removed it because the interface wasn't very clear
2015-04-01 09119, 2015
13:08 PM
LordSputnik
Leo_Verto: yup, sure, just doing a tweak of my own, then I'll pull
2015-04-01 09107, 2015
13:11 PM
johtso
Is a translation a different work?
2015-04-01 09150, 2015
13:12 PM
LordSputnik
Yeah, it is
2015-04-01 09104, 2015
13:13 PM
zag joined the channel
2015-04-01 09128, 2015
13:13 PM
LordSputnik
hey zag :)
2015-04-01 09119, 2015
13:14 PM
bookzombie
bookbrainz-site/master 6a4c8df Ben Ockmore: Add beta notice onto homepage.
2015-04-01 09125, 2015
13:14 PM
johtso
LordSputnik, does that mean it wouldn't make sense to add multiple language aliases to a work then?
2015-04-01 09136, 2015
13:14 PM
johtso
as a different language alias would be a different translation..
2015-04-01 09113, 2015
13:15 PM
LordSputnik
johtso: I can't see a reason to right now, unless the work hadn't been translated, but still had a different title outside the original country
2015-04-01 09136, 2015
13:15 PM
johtso
I'm sure stranger things have happened :)
2015-04-01 09145, 2015
13:15 PM
LordSputnik
site going down for 20 seconds, just updating a few pages
2015-04-01 09152, 2015
13:15 PM
zag
afternoon
2015-04-01 09105, 2015
13:16 PM
johtso
Hmm, not sure what the right type would be for a "series of short stories"
2015-04-01 09131, 2015
13:16 PM
LordSputnik
johtso: that's probably an anthology or something - we don't have that yet
2015-04-01 09159, 2015
13:16 PM
LordSputnik
I'd add each story as a separate short story work, then when we add sets/series, we can deal with anthologies properly :)
2015-04-01 09116, 2015
13:17 PM
johtso
2015-04-01 09108, 2015
13:19 PM
LordSputnik
hmm, that seems a little more tricky, since the stories could probably also be considered as a single work
2015-04-01 09142, 2015
13:19 PM
LordSputnik
perhaps an "Anthology" work would be best for now?
2015-04-01 09136, 2015
13:20 PM
johtso
yeah, don't think the stories were every published individually, and there's some kind of continuity between the stories
2015-04-01 09141, 2015
13:20 PM
Leo_Verto
apparently you removed the multiple alias thing but why is the "Primary" checkbox still there?
2015-04-01 09131, 2015
13:21 PM
LordSputnik
Leo_Verto: the checkbox we removed was default - it's still possible to add an initial "non-primary" alias though
2015-04-01 09155, 2015
13:21 PM
LordSputnik
eg. if you only know some colloquial name or a nickname for the entity
2015-04-01 09105, 2015
13:22 PM
LordSputnik
johtso: added "Anthology" for you :)
2015-04-01 09152, 2015
13:25 PM
LordSputnik
Leo_Verto: ahh, adding the culture novels?
2015-04-01 09119, 2015
13:26 PM
Leo_Verto
yup :D
2015-04-01 09132, 2015
13:26 PM
johtso
ah, nice one
2015-04-01 09144, 2015
13:26 PM
johtso
although... I'm thinking anthology doesn't fit quite right
2015-04-01 09128, 2015
13:27 PM
johtso
anthology seems to imply a bunch of works that were selected by a complier and released as a group
2015-04-01 09137, 2015
13:27 PM
johtso
often spanning multiple authors
2015-04-01 09128, 2015
13:28 PM
LordSputnik
Yeah I think you're probably right - not sure what to call a collection of short stories by the same person
