#bookbrainz-devel

hehe, just being nosey :)

So, the question is, if my browser is saying that the "Host" header is bookbrainz.org, why is the HTTP_HOST in the wsgi environment just "bookbrainz"

Sput|Away, is the nginx config somewhere?

It's just the default from http://uwsgi-docs.readthedocs.org/en/latest/Ngi...

(for the uwsgi stuff)

is there a `server_name bookbrainz` somewhere?

nope, only "server_name bookbrainz.org"

bitmap: is the load balancer doing anything funny with the HTTP_HOST header?

All I can thinking of it try to enable more logging to pinpoint where it starts looking odd

I'll try adding a proxy_set_header directive

did that help?

hold on

checking

wow

bitmap: You GentleCat'd it

haha

HTTP_HOST='bookbrainz.org'

awesome

was that on the load balancer or in our bookbrainz config?

load balancer, it was losing the original host and using the name of the upstream

sorry I didn't see that sooner

That's OK, I learnt a lot about Flask and Werkzeug ;)

Ahh, so that did fix HTTP_HOST, but still getting the same issue in Flask... I'll continue looking tomorrow

Oh nope, that's just my cache...

hmm Leftmost: Not Found (GET: /ws/ws/publication/a4dc4915-9d57-4b75-9465-a33f960275b2/disambiguation)

Ah, it now seems that relative URLs once again have the /ws prefix - I'll see what I can do to fix that tomorrow

Leftmost: If you're here, I'm not sure we should try to avoid the "/ws" part of the relative URL

Actually, absolute URLs work too - the prefix depends on the HTTP_HOST, so internally, the urls all start with http://localhost:9101, while externally, they all start with https://bookbrainz.org

bookbrainz-schema/master c300981 Ben Ockmore: Added option to not create tables during bootstrap.

bookbrainz-schema/master 93329eb Ben Ockmore: Corrected mistakes in arguments to bootstrap.

Leftmost: Leo_Verto: ping?

pong

Ok, I'm not exactly sure what to about Leftmost and ID #2, he doesn't seem to be here and the launch is in 8 minutes

Might make a placeholder...

Leo_Verto: see PM

um

something's broken

Fixing it now

I end up on /login/handler

Leo_Verto: now?

yay

logged in and #3 :D

Freso: here, and want to claim #5?

https://bookbrainz.org/editor/2 :P

We're going to need to do something about those times

I wonder why that's happened

At least there should be a constant offset, so it should be fairly simple to fix once we find out why

I am here.

Ok, register now and I'll move you to #2

Done.

LordSputnik, why was it you don't think we should strip the /ws from relative URIs?

Leftmost: because with "/..." urls, the URL is meant to be relative to the domain name

err

We may be missing some of the languages - not sure why yet

taken things down just to be safe

Got it

So, here we go: https://bookbrainz.org/publication/0b7a785c-42a...

since 8 is particularly important in Discworld

hmm, 404 on messageForm

ah, should be message send, I'll fix that

bookbrainz-site/master a77e816 Ben Ockmore: Updated message form URL in editor page link.

ah, client JS ws endpoint needs updating - relationships form (and editor profile form) currently out of action

LordSputnik, there's just no way to be graceful about how we construct URLs if we include /ws.

Leftmost: well, if we keep using absolute URLs, we're fine

Sorry, phone company's April Fool's gag is to make tethering not work properly.

if not, can't we just add /ws to the front of any hand-types urls, and use bookbrainz.org as the ws setting?

Ahh, I forgot to update the relationship templates in the bootstrap script

We could. Mostly we just need to decide if we're going to hardcode /ws or if we're going to allow that to be a config thing.

What's up with the editor page?

Looks fine to me?

I'm getting "Cannot read property 'id' of undefined".

Still? I thought I fixed that :(

Oh, it's because I'm not logged in and there's no check to make sure that req.user exists before accessing it.

There is as of 5 minutes ago

Not in routes/editor.js for the /:id route.

It's in view/editor/editor.jade

Ohhh

Not a template error...

fixed

By the way, you violated style guidelines for our first publication. ;)

the "The" ?

Yep.

well, it'll give someone something to do when entity updates come in :D

Hehe.

umm

so it says "Person" under persons but nothing under the publication?

Leo_Verto: I couldn't set a type for the first publication - there wasn't really an appropriate one

ah

There's journal, but I don't think that covers it

Is it a book, maybe?

Okay, I need to go back to bed now. Back in a little while.

do we really want the type to be part of the <a>?

Leftmost: Don't forget twitter, before you go

Leo_Verto: I tweaked it so the whole box was clickable, like a button

ah nice

easier for mobile users

(and less fiddly for desktop users)

Ahh damn

I made a bad edit

Hmm, and it's debatable whether I should've made those relationships between creator->publication anyway

probably creator<->work would be more appropriate

well, MB has the same problem

oh

hmm, the pre-commit hook prevents me from pushing

*commiting

What does language mean for a creator? and what does the "primary" checkbox signify?

bookbrainz-site/master e622cfe LeoVerto: Updated message form URL in message reply link.

johtso: you should tick the primary checkbox if the alias you enter is the most commonly used on for the language you specify

aha

I see, so it's like adding an alias in MB

LordSputnik, can you update the server?

johtso: yeah exactly

johtso: up until about a week ago, you could add many aliases in the creation form, but we removed it because the interface wasn't very clear

Leo_Verto: yup, sure, just doing a tweak of my own, then I'll pull

Is a translation a different work?

Yeah, it is

hey zag :)

bookbrainz-site/master 6a4c8df Ben Ockmore: Add beta notice onto homepage.

LordSputnik, does that mean it wouldn't make sense to add multiple language aliases to a work then?

as a different language alias would be a different translation..

johtso: I can't see a reason to right now, unless the work hadn't been translated, but still had a different title outside the original country

I'm sure stranger things have happened :)

site going down for 20 seconds, just updating a few pages

afternoon

Hmm, not sure what the right type would be for a "series of short stories"

johtso: that's probably an anthology or something - we don't have that yet

I'd add each story as a separate short story work, then when we add sets/series, we can deal with anthologies properly :)

LordSputnik, https://en.wikipedia.org/wiki/The_Cyberiad

hmm, that seems a little more tricky, since the stories could probably also be considered as a single work

perhaps an "Anthology" work would be best for now?

yeah, don't think the stories were every published individually, and there's some kind of continuity between the stories

Leo_Verto: the checkbox we removed was default - it's still possible to add an initial "non-primary" alias though

eg. if you only know some colloquial name or a nickname for the entity

johtso: added "Anthology" for you :)

Leo_Verto: ahh, adding the culture novels?

yup :D

ah, nice one

although... I'm thinking anthology doesn't fit quite right

anthology seems to imply a bunch of works that were selected by a complier and released as a group

often spanning multiple authors

Yeah I think you're probably right - not sure what to call a collection of short stories by the same person