So I know that testing -site is still broken, and that's because we lack a fake web service to hit. I'm looking at https://github.com/typicode/json-server as a way to fix that.
2015-03-13 07256, 2015
Freso
Uhm.
2015-03-13 07216, 2015
Freso
Tests in -site shouldn't rely on a live -ws, it should be testable on its own.
2015-03-13 07228, 2015
Freso
You should mock some WS responses instead.
2015-03-13 07227, 2015
Freso
I don't know any mocking libraries for JavaScript though, so I can't guide you in the right direction, but relying on a live ws is not best practice.
2015-03-13 07233, 2015
Freso
Leftmost: ^
2015-03-13 07235, 2015
Leftmost
Freso, that's what I'm doing.
2015-03-13 07250, 2015
Leftmost
json-server and its ilk are mock web services.
2015-03-13 07224, 2015
Freso
Alright then.
2015-03-13 07219, 2015
Leftmost
Looks like json-server doesn't have the flexibility we need, but the idea is to create a simple, static web service which is run by the testing suite as needed.
2015-03-13 07226, 2015
bookzombie
[bookbrainz-site] leftmostcat pushed 1 new commit to master: http://git.io/pSde
2015-03-13 07227, 2015
bookzombie
bookbrainz-site/master 97c6619 Seán de Búrca: Don't silently fail and spin if we can't get updates
2015-03-13 07219, 2015
bookzombie
bookbrainz-site/master 4df3da2 Seán de Búrca: gulp before running mocha
2015-03-13 07214, 2015
bookzombie
bookbrainz-site/master e175679 Seán de Búrca: Ensure public/js/ exists in git
2015-03-13 07245, 2015
kepstin-laptop joined the channel
2015-03-13 07207, 2015
CatQuest joined the channel
2015-03-13 07233, 2015
LordSputnik joined the channel
2015-03-13 07212, 2015
LordSputnik
Hey guys
2015-03-13 07219, 2015
Leo_Verto
hey
2015-03-13 07207, 2015
Leftmost
Hey, how goes?
2015-03-13 07206, 2015
CatQuest joined the channel
2015-03-13 07226, 2015
LordSputnik
Good, I've fixed alembic, so I can get a proper set of schema migrations saved
2015-03-13 07231, 2015
Leftmost
Sweet.
2015-03-13 07246, 2015
Leftmost
Are we all here?
2015-03-13 07210, 2015
Leftmost
Or, dammit, did I fail to account for DST?
2015-03-13 07230, 2015
Leo_Verto
DST has started?
2015-03-13 07241, 2015
LordSputnik
Leftmost: yes you did, has it started for you?
2015-03-13 07245, 2015
Leftmost
It has.
2015-03-13 07203, 2015
Leftmost
I forgot about that when I put the meeting in my calendar, then forgot I had forgotten about it.
2015-03-13 07216, 2015
LordSputnik
Ahh, will an hour's time be too late for you?
2015-03-13 07219, 2015
Leftmost
Nope.
2015-03-13 07246, 2015
Leftmost
I have nothing scheduled for this evening except DS9, beer and hacking.
Apparently the best Star Trek series, though the only one I've never seen an episode of :(
2015-03-13 07224, 2015
Leftmost
I personally like TNG more, but that's partly a nostalgia thing, since the first two seasons are awful.
2015-03-13 07200, 2015
LordSputnik
Yeah, I'm stuck on episode 4 or something
2015-03-13 07224, 2015
LordSputnik
original series I've seen about 20, but I still haven't got into it, and don't think I will
2015-03-13 07247, 2015
LordSputnik
The episodes are all a bit
2015-03-13 07251, 2015
LordSputnik
... old
2015-03-13 07202, 2015
Leftmost
I feel a need to get through TOS, but it's kind of a struggle.
2015-03-13 07213, 2015
Leftmost
I played around with json-server last night, but I'm afraid we'll have to write our own fake web service because it assumes too much about the structure of output.
2015-03-13 07215, 2015
LordSputnik
So something like an express server serving static content?
2015-03-13 07243, 2015
LordSputnik
ohhh
2015-03-13 07200, 2015
LordSputnik
Actually, I think we get a mock server with apiary.io, which I've started adding us to
2015-03-13 07230, 2015
Leftmost
LordSputnik, testing should be able to be independent of any of that.
As Freso said last night, we shouldn't depend on another service being up to run tests.
2015-03-13 07224, 2015
Leftmost
We should have an internal service which we can feed test data to and get a static response. It shouldn't be difficult to write, just annoying.
2015-03-13 07216, 2015
LordSputnik
And time consuming, when we get the apiary.io one for free
2015-03-13 07237, 2015
LordSputnik
(if we document properly, that is)
2015-03-13 07208, 2015
Leftmost
Not that time-consuming, and as I said, we shouldn't rely on an outside service for testing.
2015-03-13 07227, 2015
Leftmost
The apiary.io one can be useful for making sure something you've just written is sane, but running `npm test' shouldn't touch any service we're not running ourselves.
2015-03-13 07214, 2015
LordSputnik
Ah, I didn't know you meant local testing
2015-03-13 07230, 2015
Leftmost
Oh, yeah. Sorry if I was unclear about that.
2015-03-13 07220, 2015
Leftmost
For just testing code you're writing, I don't care what any of us does as long as it works. :) I just meant for automated tests.
2015-03-13 07225, 2015
LordSputnik
On travis-ci?
2015-03-13 07220, 2015
Leftmost
Yeah, that sort of thing.
2015-03-13 07212, 2015
LordSputnik
eurghh
2015-03-13 07227, 2015
LordSputnik
Committed a fix, then forgot to push it before regenerating the schema migration scripts
2015-03-13 07234, 2015
LordSputnik
now I've reset and lost it :P
2015-03-13 07258, 2015
Leftmost
Ack.
2015-03-13 07233, 2015
bookzombie
bookbrainz-schema/master 46a7b92 Ben Ockmore: Fixed alembic env.py script to deal with bookbrainz and musicbrainz schemas.
2015-03-13 07206, 2015
LordSputnik will be back in 10-15 mins.... :/ It seems like whatever time we set the start of the meeting, I always have to miss it
2015-03-13 07219, 2015
Freso
Y'all should fire that slacker.
2015-03-13 07223, 2015
Freso
Tsk.
2015-03-13 07255, 2015
Leftmost
I don't even know who has firing power, so it's not easy.
2015-03-13 07214, 2015
Leo_Verto
I think we'd have to hire him ifrst
2015-03-13 07245, 2015
Freso
Shh, Leo.
2015-03-13 07206, 2015
Freso
Don't you come here and be talking all no sense like to me.
2015-03-13 07241, 2015
Leo_Verto
there's a fallout mod for EU4
2015-03-13 07212, 2015
Freso
EU4?
2015-03-13 07221, 2015
Leo_Verto
Europa Universalis
2015-03-13 07228, 2015
Leo_Verto
Grand strategy
2015-03-13 07239, 2015
Freso
Right.
2015-03-13 07211, 2015
Leo_Verto
got it during a sale two weeks ago, downloading right now
2015-03-13 07239, 2015
Sput|Away is here
2015-03-13 07200, 2015
Leftmost
Hurray!
2015-03-13 07250, 2015
LordSputnik
Leo_Verto: here? :)
2015-03-13 07255, 2015
Leo_Verto
yup
2015-03-13 07256, 2015
Leftmost
We ready to get this row on the showed?
2015-03-13 07208, 2015
LordSputnik
mhmm
2015-03-13 07255, 2015
Leftmost
So the first thing I had wanted to discuss was some set of criteria for a "go/no-go" when it comes to saying we'll start collecting data for real.
2015-03-13 07215, 2015
Leftmost
Basically, what we want to have place and what we don't need to have in place.
2015-03-13 07239, 2015
LordSputnik
Ok
2015-03-13 07248, 2015
LordSputnik
Well, we need to have registration and login, for a start :P
2015-03-13 07222, 2015
Leftmost
Things I think we should have in place: somewhat stable code structure and deps, though this is a vague requirement. Things I don't think we need: guaranteed-stable schema, guaranteed-stable WS API, an absolute guarantee that we won't be wiping data.
2015-03-13 07229, 2015
Freso
I still think you should aim for an April 1st release.
2015-03-13 07235, 2015
Freso
FWIW, ruaok agrees.
2015-03-13 07238, 2015
Leftmost
Freso, I agree.
2015-03-13 07244, 2015
Freso
Leftmost: \o/
2015-03-13 07202, 2015
Leftmost
LordSputnik, so that folds into the HTTPS thing, plus some testing of the current auth code with that.
2015-03-13 07207, 2015
LordSputnik
I think we should guarantee preservation of data
2015-03-13 07224, 2015
LordSputnik
No-one will want to contribute if their effort will be wasted
2015-03-13 07244, 2015
LordSputnik
And I think we'll be in a position to do that on April 1st
2015-03-13 07209, 2015
Leftmost
Alright. If we want to do that, it puts somewhat a somewhat heavier testing burden on us. I'd say we should freeze before release in that case.
2015-03-13 07216, 2015
Leo_Verto
do we have issues for everything we need to get done by then?
2015-03-13 07235, 2015
LordSputnik
Leftmost: we could start dumping the database, so we have backups if anything is broken
2015-03-13 07255, 2015
LordSputnik
I'd rather not have a freeze or limitation on development at this point in the project
2015-03-13 07206, 2015
Leftmost
LordSputnik, I think that's a good idea, but we also want to make sure that we don't have any serious schema issues.
2015-03-13 07207, 2015
LordSputnik
Good testing is definitely a +1 though
2015-03-13 07229, 2015
Leftmost
I don't think we do, but it's a good idea to shake it out and make sure.
2015-03-13 07230, 2015
LordSputnik
Leo_Verto: I think so, yes
2015-03-13 07243, 2015
Leftmost
I don't think it'd need to be a long freeze. Even just a couple days, and not a hard freeze either.
2015-03-13 07259, 2015
Leftmost
I'm just thinking a soft freeze of a few days where we can fix bugs and hammer the crap out of it.
2015-03-13 07217, 2015
Leo_Verto
I'm probably going to hold off less integration until the server-side stuff is sorted out
2015-03-13 07237, 2015
LordSputnik
The thing is, *when* do we freeze when we're continuously developing?
2015-03-13 07258, 2015
LordSputnik
I'd understand if we had a formal release, and no other changes to bb.org until then, but we don't
2015-03-13 07215, 2015
Leftmost
LordSputnik, I'm not sure I follow the question.
2015-03-13 07224, 2015
Leo_Verto
Hmm, freeze the week before the grand opening?
2015-03-13 07245, 2015
Leo_Verto
that'd mean only 1 week left for features though
2015-03-13 07207, 2015
LordSputnik
Leftmost: do you mean just for 1st April, or for future releases too?
2015-03-13 07210, 2015
Leftmost
I'm just thinking that we take the 30th and 31st, maybe the 29th, to do no major structural changes and just test and fix bugs to make sure our data guarantee can hold.
2015-03-13 07216, 2015
LordSputnik
ah
2015-03-13 07224, 2015
LordSputnik
Ok, then that seems like a good idea to me
2015-03-13 07229, 2015
Freso
Maybe someone call out for user testing in -devel (maillist and IRC both).
2015-03-13 07236, 2015
Freso
*?
2015-03-13 07249, 2015
LordSputnik
I thought you meant somehow regularly freeze development like MB does with beta/hot/cold weeks
2015-03-13 07259, 2015
LordSputnik
Freso: good plan
2015-03-13 07203, 2015
Leo_Verto
yeah, we also need to populate the mailing lists
2015-03-13 07225, 2015
Leftmost
Oh. No, I don't think that's necessary yet. Just something so that we can be sure there's nothing seriously wrong before we institute a preservation guarantee.
2015-03-13 07230, 2015
LordSputnik
Ok
2015-03-13 07239, 2015
LordSputnik
So, back to the milestone thing
2015-03-13 07201, 2015
LordSputnik
We already have relationship support
2015-03-13 07214, 2015
LordSputnik
And support for adding/removing entities
2015-03-13 07213, 2015
LordSputnik
So long as the entity properties we have now won't go away, I don't think any schema issues will stop us from starting collecting data
2015-03-13 07218, 2015
Leftmost
To me, the most important entities to have in place would be Creator, Publication, Edition, and Publisher. That would cover most of the "basic" data you could give about any given book.
2015-03-13 07229, 2015
LordSputnik
Work?
2015-03-13 07236, 2015
Leftmost
We could make do with less, though, and I don't see anything there being a blocker.
2015-03-13 07250, 2015
Leftmost
Work is definitely important, but I'd place it second tier.
2015-03-13 07211, 2015
LordSputnik
Well, the only things stopping us having Edition and Publisher are forms and display on the site
2015-03-13 07221, 2015
Leftmost
Okay.
2015-03-13 07229, 2015
LordSputnik
They're present in the ws (although there may need to be some small tweaks)
2015-03-13 07232, 2015
LordSputnik
Ok, so, freeze at 00:01, 2015-03-30?
2015-03-13 07235, 2015
Leftmost
LordSputnik, do you have some time after to chat about the schema? Nothing important, I just want to continue our series on Making Sure Leftmost Knows What the Hell He's Doing.
