#bookbrainz

ah, I just came across a good logic for the use of languages on author names - to determin the orde of sortingname !

for example dutch names sort differently with "von" than english names. and norwegian ones for example will sort last names first regardless (apparently a last name becomes a middle name if the person has several in english/american)

BenOckmore: Sorry, just seeing this now. I'll merge since I'm here :)

:| something is broken

i cant associate an other author

i am adding https://beta.bookbrainz.org/work/create?author=... and i cannot link https://beta.bookbrainz.org/author/fa143253-10b...

it worked fine just before the current 504

Let me reindex the search server

Restarting the beta website

Hm, something is broken, looking into it

alright. i'll go to the library in the mean time :)

OK, search is fixed, and reindexed :)

BenOckmore: Well, we might have been a bit rash with merging that PR. I'm running into some errors when building the front-end code (`npm run build-client`):

Lots of errors (630 errors, 7 warnings), most of them being `Type annotations require valid Flow declaration (flowtype/no-types-missing-file-annotation)`.

Clearly not a big issue and just a consequence of running typescript and flow side-by-side, but worth keeping in mind as another check for next PRs.

I'll see if I find some time today to have a look.

Mr_Monkey: I have a follow up PR to remove the (now-unused) flow type checking, which should fix that...

I don't know why it didn't show up in the CI or locally

The issues showed up in a github workflow that builds docs (that's what alerted me).

CI doesn't run the same build command, that's why it didn't show up.

Hmm, but I've been running "npm run build" to test, which calls build-client

ah, interesting

Ahhh, I think it's because the eslint-loader is now running on TS files because of the change to the extensions config for build

That would make sense. Perhaps it would be best to wait until the next PR, I'll see today if there's a good solution until then.

Next PR in about 10 minutes :)

Oh, well then that's dandy :D

It was a tricky one - if I didn't update the last PR, then "build" would've just skipped over all TS/TSX files, so it would have been broken. But updating it broke things anyway. Probably could've just put it all in one PR...

Honestly it's fine, we even didn't realise yesterday, and it's not like there's an army of people working on the master branch. Especially with a fix within the day, it's all fine.

Yep, reading it now

Just double checked, and both lint and build are working locally now too

:)

Same here

I'll merge as soon as the CI passes, thanks !