ah, I just came across a good logic for the use of languages on author names - to determin the orde of sortingname !
2020-12-01 33651, 2020
CatQuest
for example dutch names sort differently with "von" than english names. and norwegian ones for example will sort last names first regardless (apparently a last name becomes a middle name if the person has several in english/american)
2020-12-01 33633, 2020
TOPIC: Community and Development channel for BookBrainz | Channel is logged: https://chatlogs.metabrainz.org/brainzbot/bookbrainz/
2020-12-01 33606, 2020
BrainzGit has quit
2020-12-01 33614, 2020
BrainzGit joined the channel
2020-12-01 33656, 2020
Mr_Monkey
BenOckmore: Sorry, just seeing this now. I'll merge since I'm here :)
alright. i'll go to the library in the mean time :)
2020-12-01 33605, 2020
Mr_Monkey
OK, search is fixed, and reindexed :)
2020-12-01 33635, 2020
Mr_Monkey
BenOckmore: Well, we might have been a bit rash with merging that PR. I'm running into some errors when building the front-end code (`npm run build-client`):
2020-12-01 33635, 2020
Mr_Monkey
Lots of errors (630 errors, 7 warnings), most of them being `Type annotations require valid Flow declaration (flowtype/no-types-missing-file-annotation)`.
2020-12-01 33635, 2020
Mr_Monkey
Clearly not a big issue and just a consequence of running typescript and flow side-by-side, but worth keeping in mind as another check for next PRs.
2020-12-01 33635, 2020
Mr_Monkey
I'll see if I find some time today to have a look.
2020-12-01 33613, 2020
BenOckmore
Mr_Monkey: I have a follow up PR to remove the (now-unused) flow type checking, which should fix that...
2020-12-01 33625, 2020
BenOckmore
I don't know why it didn't show up in the CI or locally
2020-12-01 33658, 2020
Mr_Monkey
The issues showed up in a github workflow that builds docs (that's what alerted me).
2020-12-01 33658, 2020
Mr_Monkey
CI doesn't run the same build command, that's why it didn't show up.
2020-12-01 33642, 2020
BenOckmore
Hmm, but I've been running "npm run build" to test, which calls build-client
2020-12-01 33655, 2020
Mr_Monkey
ah, interesting
2020-12-01 33602, 2020
BenOckmore
Ahhh, I think it's because the eslint-loader is now running on TS files because of the change to the extensions config for build
2020-12-01 33641, 2020
Mr_Monkey
That would make sense. Perhaps it would be best to wait until the next PR, I'll see today if there's a good solution until then.
2020-12-01 33607, 2020
BenOckmore
Next PR in about 10 minutes :)
2020-12-01 33650, 2020
Mr_Monkey
Oh, well then that's dandy :D
2020-12-01 33657, 2020
BenOckmore
It was a tricky one - if I didn't update the last PR, then "build" would've just skipped over all TS/TSX files, so it would have been broken. But updating it broke things anyway. Probably could've just put it all in one PR...
2020-12-01 33647, 2020
Mr_Monkey
Honestly it's fine, we even didn't realise yesterday, and it's not like there's an army of people working on the master branch. Especially with a fix within the day, it's all fine.
Just double checked, and both lint and build are working locally now too
2020-12-01 33635, 2020
BenOckmore
:)
2020-12-01 33619, 2020
Mr_Monkey
Same here
2020-12-01 33603, 2020
Mr_Monkey
I'll merge as soon as the CI passes, thanks !
2020-12-01 33610, 2020
BrainzGit has quit
2020-12-01 33629, 2020
BrainzGit joined the channel
2020-12-01 33651, 2020
Mr_Monkey
<Mr_Monkey> maybe some of those formats that include some notion of content should be EG types instead.
2020-12-01 33651, 2020
Mr_Monkey
That could also possibly be useful in the discussion of whether a collection of works should be considered a work into itself: if we have a collection and/or anthology Edition Group type (provided we have author credits for EGs to to attribute them to authors and show them on author pages).
