#metabrainz

/

      • samj1912
        antlarr: just update_metadata_images(obj) then, and we can avoid state altogether and make then into variables? they are just 3 variables right?
      • 2017-03-20 07940, 2017

      • antlarr
        nop, 6 variables in the general case
      • 2017-03-20 07900, 2017

      • antlarr
        (look at Album)
      • 2017-03-20 07954, 2017

      • antlarr
        also, boolean variables are not passed by reference, so... how would you change that inside process_images if they're not part of a class?
      • 2017-03-20 07928, 2017

      • regagain joined the channel
      • 2017-03-20 07944, 2017

      • antlarr
        and even more, The whole state-machine concept is better represented by a state class in my opinion
      • 2017-03-20 07911, 2017

      • antlarr
        I would move the three methods to a common one in order to deduplicate code, but I don't think the State class should be removed
      • 2017-03-20 07936, 2017

      • samj1912
        hmm, not a fan of nested functions and classes
      • 2017-03-20 07944, 2017

      • samj1912
        can't think of a better way right now
      • 2017-03-20 07907, 2017

      • samj1912
        zas, Mineo ^?
      • 2017-03-20 07924, 2017

      • hibiscuskazeneko joined the channel
      • 2017-03-20 07926, 2017

      • arbenina_ joined the channel
      • 2017-03-20 07904, 2017

      • antlarr
        samj1912: is this what you wanted http://pastebin.com/Std6e7FL ?
      • 2017-03-20 07921, 2017

      • antlarr
        (with respect to an ImageList class)
      • 2017-03-20 07904, 2017

      • antlarr
        (just trying to save me some possible commit fixes/reverts...)
      • 2017-03-20 07908, 2017

      • arbenina_ has quit
      • 2017-03-20 07943, 2017

      • deeptibaghel joined the channel
      • 2017-03-20 07932, 2017

      • samj1912
        antlarr: 👍
      • 2017-03-20 07900, 2017

      • zas
        antlarr: +1
      • 2017-03-20 07907, 2017

      • antlarr
        cool, thanks :)
      • 2017-03-20 07927, 2017

      • Freso
        Notes from last Monday's meeting are now up: https://community.metabrainz.org/t/notes-from-met…
      • 2017-03-20 07937, 2017

      • Zastai joined the channel
      • 2017-03-20 07934, 2017

      • Kashif has quit
      • 2017-03-20 07936, 2017

      • Zastai
        is it sir or mb-solrquerywriter that _creates_ the _store field containing the MMD XML metadata format?
      • 2017-03-20 07920, 2017

      • Zastai|2 joined the channel
      • 2017-03-20 07912, 2017

      • Zastai has quit
      • 2017-03-20 07935, 2017

      • Zastai|2 is now known as Zastai
      • 2017-03-20 07942, 2017

      • iliekcomputers
        alastairp: what exactly would we have to do to get jenkins working for LB?
      • 2017-03-20 07953, 2017

      • deeptibaghel has left the channel
      • 2017-03-20 07930, 2017

      • Slurpee has quit
      • 2017-03-20 07949, 2017

      • kyan joined the channel
      • 2017-03-20 07915, 2017

      • arbenina_ joined the channel
      • 2017-03-20 07908, 2017

      • Zastai has quit
      • 2017-03-20 07959, 2017

      • alastairp
        iliekcomputers: not much. You just need to make sure that https://gist.github.com/gentlecat/f2395947eb28f48… can run
      • 2017-03-20 07952, 2017

      • nupurbaghel has quit
      • 2017-03-20 07903, 2017

      • alastairp
        like critiquebrainz, we could just have a separate docker compose file (or could we use the integration test one???), and maybe a separate Dockerfile which installs any of the test tools that we need
      • 2017-03-20 07920, 2017

      • alastairp
        that script would have to be modified to run unit and integration tests
      • 2017-03-20 07902, 2017

      • samj1912
        antlarr build failing with latest push
      • 2017-03-20 07911, 2017

      • samj1912
        Circular dependencies?
      • 2017-03-20 07909, 2017

      • Freso
        <BANG>
      • 2017-03-20 07913, 2017

      • Freso
        🙋
      • 2017-03-20 07936, 2017

      • Freso
        A bundle of DRs on the menu today. Mmm.
      • 2017-03-20 07942, 2017

      • Freso
        samj1912: Go!
      • 2017-03-20 07930, 2017

      • samj1912
        Hi
      • 2017-03-20 07957, 2017

      • ferbncode
        hi! :)
      • 2017-03-20 07920, 2017

      • samj1912
        Nothing much to report this week, did PR reviews and just submitted my Gsoc proposal draft. Was out most of the week for vacation.
      • 2017-03-20 07921, 2017

      • nupurbaghel joined the channel
      • 2017-03-20 07930, 2017

      • samj1912
        Freso go
      • 2017-03-20 07936, 2017

      • Freso
        🙋
      • 2017-03-20 07937, 2017

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC Getting Started: https://goo.gl/JTNkn0 | MeB meeting agenda: reviews, DR: MBS-7133 (yvanzo), DR: MBS-7108 (yvanzo); next week: DR: CB-244 (Gentlecat)
      • 2017-03-20 07952, 2017

      • Freso
        I facilitated a Google Code-in mail and apart from that mostly kept up with IRC and forums.
      • 2017-03-20 07930, 2017

      • Freso
        I came to Sweden on Tuesday and also got my passport renewed on Tuesday. Should be able to pick up my new passport this week. 🙏🏼
      • 2017-03-20 07907, 2017

      • Freso
        I've spent a fair amount of time this week working on the slides, and my presentation in general, for my talk at Open Source Days this just-past Saturday.
      • 2017-03-20 07922, 2017

      • CatQuest
        \o
      • 2017-03-20 07924, 2017

      • Freso
        And then I spent this just-past Saturday at Open Source Days in Copenhagen, giving a talk.
      • 2017-03-20 07929, 2017

      • Freso
        I'm trying to get a link to the slides on Google Drive right now, but it's being slow. :|
      • 2017-03-20 07943, 2017

      • Freso
      • 2017-03-20 07956, 2017

      • Freso
        I will add it to the Presentations WikiPage later.
      • 2017-03-20 07957, 2017

      • Freso
        fin.
      • 2017-03-20 07900, 2017

      • Freso
        CatQuest: 🙋
      • 2017-03-20 07908, 2017

      • CatQuest
        \o/
      • 2017-03-20 07915, 2017

      • CatQuest
        I asked and was told that it's ok for me to create "Fix Versions" so now I can group instrument tickets into batches. This will let me group things and set aside the "hard" ones from the "easy" ones so I can get those done faster and hopefully whittle down the list of tickets so only the actual difficult DR ones remain.
      • 2017-03-20 07922, 2017

      • CatQuest
        also creating "do all these in this group" groups which are decidedly smaller than the entire list helps things from feeling too overwhelming.
      • 2017-03-20 07930, 2017

      • CatQuest
        o if you've got a INST ticket that's _straightforward_ and important to you, you can put Fix Version as "next" on it (I reserve the right to alter it, of course :D)
      • 2017-03-20 07933, 2017

      • Freso
        (Slide 9 is "Alot of Brainz")
      • 2017-03-20 07941, 2017

      • CatQuest
        aha
      • 2017-03-20 07947, 2017

      • CatQuest
        also if Instrument families and variants interest you: https://community.metabrainz.org/t/instrument-fam…
      • 2017-03-20 07901, 2017

      • CatQuest
        finitare!
      • 2017-03-20 07901, 2017

      • CatQuest
        next is.. gcilou?
      • 2017-03-20 07922, 2017

      • gcilou
        Pass for me :)
      • 2017-03-20 07928, 2017

      • CatQuest
        damn, ok
      • 2017-03-20 07930, 2017

      • CatQuest
        uhm..
      • 2017-03-20 07946, 2017

      • CatQuest
        yvanzo?
      • 2017-03-20 07955, 2017

      • yvanzo
        hi
      • 2017-03-20 07903, 2017

      • reosarevok
        <3 Alot of Brainz
      • 2017-03-20 07907, 2017

      • yvanzo
        I started with grasping a variety of MeB accounts and tools.
      • 2017-03-20 07915, 2017

      • yvanzo
        Then, I mainly worked on extending dynamic attributes for the next schema change.
      • 2017-03-20 07922, 2017

      • yvanzo
        I also made auto-edit issues archaeology and implemented MBS-8134.
      • 2017-03-20 07922, 2017

      • BrainzBot
        MBS-8134: Allow unreviewed edits on new entries for a period of time https://tickets.metabrainz.org/browse/MBS-8134
      • 2017-03-20 07929, 2017

      • yvanzo
        On reosarevok's request, I coded a small enhancement with a bugfix to change artist credits in the relationship editor.
      • 2017-03-20 07943, 2017

      • yvanzo
        reosarevok, your turn :)
      • 2017-03-20 07957, 2017

      • Freso
        (Still up: ferbncode Gentlecat ruaok bitmap Quesito iliekcomputers; possibly: LordSputnik Leftmost Leo_Verto alastairp; who did I miss?)
      • 2017-03-20 07912, 2017

      • reosarevok mostly dealt with even more MBID questions
      • 2017-03-20 07915, 2017

      • CatQuest
        Freso: you hould totes credit your gf for that a lot, it's awesome :D
      • 2017-03-20 07925, 2017

      • reosarevok hopes the BBC makes that clearer on their side soon
      • 2017-03-20 07926, 2017

      • CatQuest
        alot*
      • 2017-03-20 07942, 2017

      • Freso
        reosarevok: +100
      • 2017-03-20 07947, 2017

      • Leo_Verto is here
      • 2017-03-20 07950, 2017

      • CatQuest nods
      • 2017-03-20 07959, 2017

      • reosarevok
        Other than that, I'm right now answering https://community.metabrainz.org/t/style-747-even… and hoping to get some proper discussion on events up with that
      • 2017-03-20 07923, 2017

      • reosarevok
        That's about it I'd say, other than just editing
      • 2017-03-20 07932, 2017

      • Leftmost is here but has no update.
      • 2017-03-20 07933, 2017

      • reosarevok
        ferbncode: go?
      • 2017-03-20 07945, 2017

      • ferbncode
        hi!
      • 2017-03-20 07950, 2017

      • Freso
        CatQuest: Yeah, I agree.
      • 2017-03-20 07955, 2017

      • ferbncode
        nothing much..opened a quite big PR for migrating reviews off ORM. Part of CB-230.also, working on more migration :)
      • 2017-03-20 07955, 2017

      • BrainzBot
        CB-230: Migrate away from the SQLAlchemy ORM https://tickets.metabrainz.org/browse/CB-230
      • 2017-03-20 07903, 2017

      • ferbncode
        I am trying something with the docker setup for the musicbrainz database. hope to get something basic done :)
      • 2017-03-20 07922, 2017

      • ferbncode
        Quesito: go!
      • 2017-03-20 07929, 2017

      • Quesito
        Hi!
      • 2017-03-20 07944, 2017

      • aron_kexp joined the channel
      • 2017-03-20 07944, 2017

      • Quesito
        Mostly verbiage work on the MeB site last week for me. I’ll be needing some help this week, as far as other eyes reading/editing/commenting.
      • 2017-03-20 07949, 2017

      • Quesito
        Mostly verbiage work on the MeB site last week for me. I’ll be needing some help this week, as far as other eyes reading/editing/commenting.
      • 2017-03-20 07911, 2017

      • Quesito
        I’ve come up with a general workflow of verbiage edits for the project pages (upcoming), mostly to be time efficient for the developers involved.
      • 2017-03-20 07943, 2017

      • Quesito
        More learning of the ins and outs of jira, which will also continue this week. Worked a bit with Leo_Verto on the MB user survey, in hope we get some really good feedback.
      • 2017-03-20 07901, 2017

      • Leftmost
        Quesito, I'm a good proofreader!
      • 2017-03-20 07916, 2017

      • Quesito
        Noted Leftmost! You will be tasked! :)
      • 2017-03-20 07944, 2017

      • CatQuest
        oh yes, I did a bit of leo verto feedback too , forgot to mention :o
      • 2017-03-20 07952, 2017

      • Quesito
        Chatted with iliekcomputers about his gsoc proposal, but I didn’t explain my idea very clearly at the time--so I quickly gathered my thoughts together and posted it to the forum.
      • 2017-03-20 07902, 2017

      • Quesito
        So far that’s crickets, but I’m holding out hope for some feedback.
      • 2017-03-20 07909, 2017

      • CatQuest
        link plox?
      • 2017-03-20 07928, 2017

      • nawcom has quit
      • 2017-03-20 07933, 2017

      • Quesito
      • 2017-03-20 07945, 2017

      • nawcom_ (~nawcom@c-68-41-7-55.hsd1.mi.comcast.net) has joined #metabrainz
      • 2017-03-20 07958, 2017

      • Quesito
        And I'm continuing trying to open up my workflow to make it more transparent
      • 2017-03-20 07904, 2017

      • Quesito
        fin!
      • 2017-03-20 07913, 2017

      • Quesito
        Leftmost: Go!
      • 2017-03-20 07913, 2017

      • CatQuest
        wow those visulas :o
      • 2017-03-20 07937, 2017

      • nupurbaghel_
        nupurbaghel_ (~nupurbagh@106.222.183.175) has joined #metabrainz
      • 2017-03-20 07939, 2017

      • Freso
        (Still up: Leo_Verto Gentlecat ruaok bitmap iliekcomputers; possibly: LordSputnik alastairp; who did I miss?)
      • 2017-03-20 07941, 2017

      • reosarevok
        reosarevok has changed the topic to: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC Getting Started: https://goo.gl/JTNkn0 | MeB meeting agenda: reviews, DR: MBS-7133 (yvanzo), DR: MBS-7108 (yvanzo); next week: DR: CB-244 (Gentlecat), Picard feat. plugin (reo)
      • 2017-03-20 07946, 2017

      • reosarevok
        (is that DR really next week?)
      • 2017-03-20 07952, 2017

      • Freso
        Quesito: Leftmost said he had no update. :) Leo_Verto, go!
      • 2017-03-20 07903, 2017

      • Freso
        reosarevok: Gentlecat moved it at the beginning of the meeting, so I guess?
      • 2017-03-20 07904, 2017

      • Quesito
        oops!
      • 2017-03-20 07907, 2017

      • reosarevok
        Oh, ok
      • 2017-03-20 07916, 2017

      • reosarevok
        reosarevok has changed the topic to: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC Getting Started: https://goo.gl/JTNkn0 | MeB meeting agenda: reviews, DR: MBS-7133 (yvanzo), DR: MBS-7108 (yvanzo), Picard feat. plugin (reo); next week: DR: CB-244 (Gentlecat)
      • 2017-03-20 07931, 2017

      • Gentlecat
        reosarevok: one that I added, yes. don't feel like discussing it today
      • 2017-03-20 07939, 2017

      • reosarevok
        Ok :)
      • 2017-03-20 07957, 2017

      • reosarevok
        No Leo_Verto?
      • 2017-03-20 07903, 2017

      • Freso
        Seems like it. :/
      • 2017-03-20 07905, 2017

      • Freso
        Gentlecat: Go!
      • 2017-03-20 07908, 2017

      • rembo10_
        rembo10_ (~rembo10@2a01:4f8:c17:5b49::2) has joined #metabrainz
      • 2017-03-20 07912, 2017

      • Leo_Verto[m]
        Sorry
      • 2017-03-20 07914, 2017

      • Leo_Verto[m]
        IRC crashed
      • 2017-03-20 07930, 2017

      • -- BotBot disconnected, possible missing messages --
      • 2017-03-20 07939, 2017

      • Leo_Verto[m]
        I spent the last week continuing working on Botbot and took up work on the survey again (thanks CatQuest and Quesito)
      • 2017-03-20 07905, 2017

      • __shymega__
        __shymega__ (~shymega@shymega.vps.bitfolk.com) has joined #metabrainz
      • 2017-03-20 07910, 2017

      • Leo_Verto[m]
        I spent the last few days doing IRL stuff after getting home again but will continue what I started this week
      • 2017-03-20 07912, 2017

      • d4rkie
        d4rkie (~D4RK-PH0E@104.254.90.187) has joined #metabrainz
      • 2017-03-20 07912, 2017

      • djinni`_
        djinni`_ (~djinni@68.ip-149-56-14.net) has joined #metabrainz
      • 2017-03-20 07914, 2017

      • Leo_Verto[m]
        Gentlecat: go!
      • 2017-03-20 07930, 2017

      • Gentlecat
        I finished implementing trigger generation for SIR. Just need to test them now.
      • 2017-03-20 07943, 2017

      • Freso
        🙌
      • 2017-03-20 07956, 2017

      • Tyklol
        Tyklol (tykling@znc.tyknet.dk) has joined #metabrainz
      • 2017-03-20 07900, 2017

      • reosarevok
        :)
      • 2017-03-20 07900, 2017

      • Gentlecat
        tested imports in listenbrainz and opened some tickets related to that
      • 2017-03-20 07911, 2017

      • esmiurium
        esmiurium (U2FsdGVkX1@ma.sdf.org) has joined #metabrainz
      • 2017-03-20 07922, 2017

      • Gentlecat
        and reviewed some things, as usual
      • 2017-03-20 07926, 2017

      • Gentlecat
        bitmap: ?