thankyou to the mentors for helping me put! Sadly my first and last GCI but the expereince was amazing thankyou!
2018-01-08 00819, 2018
chhavi_
no issue. next time :)
2018-01-08 00836, 2018
Freso
SKGCI: Still a week more!
2018-01-08 00851, 2018
SKGCI
hahah yeah :D
2018-01-08 00805, 2018
SKGCI
fin. Leftmost you're next
2018-01-08 00808, 2018
Leftmost
o/
2018-01-08 00810, 2018
Leftmost
I processed some GCI tasks and did a bit of code review. I also kicked out some BB PRs to fix a number of issues or improve things, the most visible of which is that now identifiers are tied to the appropriate entity types, preventing users from adding new identifiers which can't apply to the entity they're editing.
2018-01-08 00815, 2018
Leftmost
Fin. naiveai?
2018-01-08 00822, 2018
naiveai
oh, that was quick
2018-01-08 00851, 2018
Freso
Let's try and keep reviews short now. Only 12 more minutes, and still 7 people up for reviews.
2018-01-08 00855, 2018
naiveai
I did a variety of things. I added two reports to MB which I am very proud of. First time I've worked with SQL significantly
2018-01-08 00857, 2018
Freso
(Still up: darkhorse, IsaacZanoria__, anshuman73, ferbncode, chhavi_, Leo_Verto – other people maybe up (please confirm): LordSputnik, alastairp, ListMyCDs; anyone else?)
2018-01-08 00808, 2018
samj1912
and topics left
2018-01-08 00824, 2018
naiveai
did some duplicate refactoring for BB which was also very nice :) thanks Leftmost and LordSputnik!
2018-01-08 00825, 2018
Freso
samj1912: Topics will get pushed to next week.
2018-01-08 00841, 2018
naiveai
also improved french guess-case, and did a thing on whipper
2018-01-08 00846, 2018
naiveai
fin. darkhorse?
2018-01-08 00852, 2018
Freso
Thanks naiveai!
2018-01-08 00822, 2018
Freso
darkhorse: Ping?
2018-01-08 00825, 2018
Freso
anshuman73: Go!
2018-01-08 00834, 2018
anshuman73
Seeing there are a lot of people in line for reports today, I'll keep it short.
2018-01-08 00840, 2018
anshuman73
been busy with exams/new year/college applications/exams again.
2018-01-08 00840, 2018
anshuman73
picked up GCI again today, will make sure I get my duties done; but another set of exams start friday, so :meh:. But seeing only a week is left for GCI, I'm really happy with what all we've got done this year.
So we made another round of progress on BB mockups. I did round 2 mockups of the landing page, bulk editing interface and relationship editor.
2018-01-08 00815, 2018
chhavi_
Since I am familiar with UX messups in MusicBrainz now, I am really trying to keep Leftmost and Ben aware of them and avoid them. Both have been really cool about it :)
2018-01-08 00816, 2018
chhavi_
This week I will be moving things for MusicBrainz mockups.
2018-01-08 00816, 2018
chhavi_
Also started learning React, so far so good :)
2018-01-08 00825, 2018
chhavi_
Fin.
2018-01-08 00832, 2018
Freso
(Still up: darkhorse, IsaacZanoria__, Leo_Verto.)
2018-01-08 00833, 2018
chhavi_
IsaacZanoria__: ?
2018-01-08 00850, 2018
reosarevok
chhavi_: messups? :'( :p
2018-01-08 00859, 2018
vishalchoudhary[
Drakhorse here. Was adding a common button for adding files and folder in picard. Got to know a lot of stuff ..
2018-01-08 00801, 2018
IsaacZanoria__
Hi
2018-01-08 00830, 2018
chhavi_
reosarevok: you know, the things people keep complaining about. Only from the interface perspective. Nothing else :)
2018-01-08 00848, 2018
IsaacZanoria__
Uh, I’ve been working on tasks for critiquebrainz and bookbrainz, with a couple of no code tasks in the beginning
2018-01-08 00803, 2018
IsaacZanoria__
Was having trouble with the first critiquebrainz task because I couldn’t set up the env through docker, but the other tasks helped with furthering my understanding of sql and data structures in general, which I think will be helpful down the line
2018-01-08 00835, 2018
naiveai
IsaacZanoria__: as Freso said, keep the reviews short for today, don't go into specifics
2018-01-08 00853, 2018
drsaunders jumps quickly in
2018-01-08 00853, 2018
IsaacZanoria__
And, uh, thanks to all the mentors here who’ve helped me, or anyone else who’s answered my questions in irc, fin
2018-01-08 00800, 2018
drsaunders
finished my 3rd NXNE
2018-01-08 00812, 2018
anshuman73 thinks it's fine to have the reviews, doesn't matter if we go over a minute or two, considering this is IsaacZanoria__ 's first review
I mentored some more GCI tasks, mostly BrainzBot and did some own work on that project and while it's not perfect yet, the setup has been improved quite a lot and is actually pretty fast now (now it won't download and compile Node.js if you already have npm installed!)
2018-01-08 00859, 2018
Leo_Verto
I also went to the 34th Chaos Communication Congress which was great fun and my MusicBrainz sticker was even recognized by a few people :D
2018-01-08 00808, 2018
Leo_Verto
If more people are planning to attend next year's C3, we could maybe even organize an assembly like the OSM community does.
2018-01-08 00818, 2018
Leo_Verto
fin.
2018-01-08 00827, 2018
Freso
Leo_Verto: Poke me about that when we get closer. :)
2018-01-08 00850, 2018
Leo_Verto
will do :D
2018-01-08 00854, 2018
Freso
Alright. darkhorse/vishalchoudhary[ seems to not have more to add.
2018-01-08 00801, 2018
Freso
And no more people are up for reviews.
2018-01-08 00804, 2018
reosarevok
Leo_Verto: nerd. I think ruaok has gone to some of those in the past?
2018-01-08 00814, 2018
ruaok nods
2018-01-08 00827, 2018
naiveai
Freso: if it's possible, could I go into my agenda thing? i just want to bring it up, nothing more.
2018-01-08 00828, 2018
Freso
naiveai's and chhavi_'s agenda items will get pushed to next week, since there's no way we can make any of thse in 2½ minutes. :)
2018-01-08 00830, 2018
Leo_Verto
yeah, I somehow managed to miss him last year
2018-01-08 00837, 2018
naiveai
ok, np
2018-01-08 00839, 2018
Freso
naiveai: Preferably not
2018-01-08 00843, 2018
ruaok
ya know, there is only 2 people there.
2018-01-08 00854, 2018
Freso
So thanks for your time tonight!
2018-01-08 00800, 2018
anshuman73
ferbncode: you still up ? I'd like to discuss some stuff regarding CB
2018-01-08 00800, 2018
reosarevok
ruaok: tbf it's usually hard to miss you
2018-01-08 00804, 2018
Freso
</BANG>
2018-01-08 00812, 2018
naiveai is going to sleep
2018-01-08 00816, 2018
naiveai has quit
2018-01-08 00820, 2018
Freso
naiveai: As you should. Goodnight!
2018-01-08 00822, 2018
Freso
Ah well.
2018-01-08 00836, 2018
ferbncode
anshuman73: yup, I was going to ask you after the meeting :)
2018-01-08 00853, 2018
reosarevok
ruaok: make sure you wear that purple jacket if you go next year, then you're 100% unmissable :D
2018-01-08 00804, 2018
ruaok
and dying of heat indoors.
2018-01-08 00811, 2018
anshuman73
ferbncode: oh, mine is regarding publish date task, one IsaacZanoria__ is working on
2018-01-08 00830, 2018
reosarevok
sometimes you need to suffer for fashion
2018-01-08 00843, 2018
drsaunders
ruaok is already unmissable....unless he's wearing a hat (or helmet)
2018-01-08 00801, 2018
anshuman73
ferbncode: what's your preferred fix ? I like the ability to have a published column in the DB rather than have the publish date being the revios date
2018-01-08 00807, 2018
reosarevok
drsaunders: knowing the kind of hats or helmets he'd wear, he'd still be unmissable :D
2018-01-08 00810, 2018
CatQuest
inb4 hat or helmet is orang and purple
2018-01-08 00822, 2018
CatQuest
dammit reo
2018-01-08 00830, 2018
CatQuest
:D
2018-01-08 00840, 2018
IsaacZanoria__
Oh, that’s me
2018-01-08 00856, 2018
Rahul_India
Hey I'm not known to any programming language, can more 'no code' editing tasks be aaded to GCI
2018-01-08 00857, 2018
IsaacZanoria__
Did you want me to just mark published as the last revision time stamp?
2018-01-08 00829, 2018
IsaacZanoria__
Cuz I could do that, but I thought you wanted this solution because you tagged it python and sql
2018-01-08 00828, 2018
IsaacZanoria__
anshuman73: but do the changes work? Because I still wasn’t able to set up the env to test it muself
2018-01-08 00854, 2018
anshuman73
IsaacZanoria__: no no, I wanted to discuss what the best solution would be
2018-01-08 00800, 2018
heyoni joined the channel
2018-01-08 00820, 2018
IsaacZanoria__
ok
2018-01-08 00832, 2018
anshuman73
I like your current fix, but I still haven't tested it locally, mostly because it involves DB changes so I didn't wanna mess with my local setup before ferbncode and I agreed on a solution
2018-01-08 00800, 2018
anshuman73
as I've said in a discussion regarding this before, I prefer to show the original publish date and then a "revised on" tag
2018-01-08 00806, 2018
anshuman73
(if necessary)
2018-01-08 00814, 2018
ferbncode
I think that adding the publish date as a column in the review table would be a good option
2018-01-08 00815, 2018
anshuman73
Wanted reviews from other people on this too
2018-01-08 00831, 2018
IsaacZanoria__
yeah, that’s what I tried to do
2018-01-08 00849, 2018
ferbncode
that should be an ideal solution, given that the older revisions before the review was published can also be seem
2018-01-08 00852, 2018
ferbncode
*seen
2018-01-08 00805, 2018
anshuman73
yes
2018-01-08 00850, 2018
anshuman73
I think we should have a "revised on" link as well in case a revision exists which then links to the revision history
2018-01-08 00856, 2018
anshuman73
what do you say ferbncode ?
2018-01-08 00835, 2018
ferbncode
We have the "view older revisions" link at the bottom and yes, it would be good to show last revised date in case its different from the publish date
2018-01-08 00855, 2018
Leo__Verto has quit
2018-01-08 00812, 2018
ferbncode
IsaacZanoria__: I will try and test/review your PR soon :)
2018-01-08 00834, 2018
IsaacZanoria__
Thank you
2018-01-08 00836, 2018
ferbncode
anshuman73: we can make a task for that too :)
2018-01-08 00803, 2018
anshuman73
for adding the conditional revised on date ?
2018-01-08 00805, 2018
anshuman73
+1
2018-01-08 00841, 2018
ferbncode
yup, I will make a ticket
2018-01-08 00843, 2018
ferbncode
:)
2018-01-08 00855, 2018
IsaacZanoria__
Is that gonna be a task?
2018-01-08 00831, 2018
anshuman73
IsaacZanoria__: hopefully yes
2018-01-08 00840, 2018
anshuman73
unless you'd like to fix it in this PR itself
2018-01-08 00856, 2018
ferbncode
anshuman73: what do you suggest we do with the existing reviews? keep their publishing date same as now, right?
2018-01-08 00811, 2018
anshuman73
oh boy
2018-01-08 00830, 2018
anshuman73
you don't have access to the prod DB do you ?
2018-01-08 00857, 2018
Rahul_India
with this also add some more 'no code' tasks too if possible
2018-01-08 00801, 2018
Rahul_India
thanks
2018-01-08 00847, 2018
ferbncode
no, not now, we can ask bitmap to help us. Also, I am not very familiar with the production setup however
2018-01-08 00803, 2018
SKGCI has quit
2018-01-08 00810, 2018
anshuman73
ferbncode: I think the best step is that when that PR is merged, we'll need to restart the server, and fill the publish date columns with the review's revision 1 date
2018-01-08 00829, 2018
Rahul_India has left the channel
2018-01-08 00842, 2018
anshuman73
yeah, bitmap or zas will have to help, I'm not familiar with prod server either
2018-01-08 00809, 2018
anshuman73
plus no clue how we'll populate the new column for all previous reviews
2018-01-08 00846, 2018
anshuman73 screams for help
2018-01-08 00822, 2018
ferbncode
that can be done using insert..select sql queries
2018-01-08 00857, 2018
anshuman73
yeah, but prod access to do that
2018-01-08 00858, 2018
ferbncode
but we need to take care about that while the PR is merged 😅
2018-01-08 00805, 2018
anshuman73
yeah
2018-01-08 00857, 2018
ferbncode
I think we can proceed with the solution, or think some more, and take care when the PR gets merged. right?
2018-01-08 00851, 2018
anshuman73
yes
2018-01-08 00815, 2018
anshuman73
I'm cool with this solution
2018-01-08 00818, 2018
ferbncode
Also, as you suggested, i think that ticket about "last revision date" is unnessary and can be made part of the same ticket
2018-01-08 00835, 2018
anshuman73
+1
2018-01-08 00842, 2018
ferbncode
okay, great :)
2018-01-08 00851, 2018
anshuman73
perfect :)
2018-01-08 00846, 2018
dragonzeron joined the channel
2018-01-08 00858, 2018
dragonzeron
did you guys get my message for the meeting
2018-01-08 00809, 2018
dragonzeron
cause I was in school so I coudnt join in sadely
2018-01-08 00852, 2018
anshuman73
dragonzeron: yes we did :)
2018-01-08 00830, 2018
dragonzeron
ok yeah hopefully I was able to contribute a lot cause I have been working on this site and what not and help remove Wikipedia links
