#metabrainz

samj1912: pong

spellew_: you have to initiate the tablesorter plugin in componentDidMount https://reactjs.org/docs/react-component.html#c...

script_manifest('statistics.js') includes the statistics bundle on the page - the entry point for that is root/static/scripts/statistics.js

it's used to map statistics.js to the specific version of that resource, e.g. root/static/build/scripts/statistics-08c62734ba.js

that macro has been ported to JavaScript under a slightly different name. see https://github.com/metabrainz/musicbrainz-serve...

upgrade of discourse in progress, community.mb.o downtime

moin everyone!

iliekcomputers: what is the general status of the last 4 PRs for LB? They all seem not ready one way or another.

samj1912: Btw, phw is outsidecontext and he's apparently around right now.

ruaok: the bigquerywriter tests one could be merged for now, I guess.

this one seems redundant to me: https://github.com/metabrainz/listenbrainz-serv...

ok, I'll take a look at it.

not sure about 318. we have total play counts. the PR adds playcounts over time.

and in general we don't want to use influx for querying data, so it might be useful to keep.

still not sure.

yeah, I am around

samj1912: libdiscid builds are looking fine,see https://ci.appveyor.com/project/MetaBrainz/libd...

hey ruaok :)

I tweaked the build a bit and tested the binaries on my windows VM

outsidecontext: thanks! :D

on other good news: the Lollypop player for Linux got ListenBrainz support!

outsidecontext: can you export the appveyor.yaml and make a PR to libdiscid?

my patch got accepted: https://gitlab.gnome.org/gnumdk/lollypop/merge_...

sampsyo: yes, will do

samj1912: sorry, wrong sam.*

zas: can you publish these to our ftp server ^^

MBS-9619: Remove ws/1 support after August 1, 2018.

ruaok: finally :D

we can prolly do it before that though

[libdiscid] phw opened pull request #54: Added appveyor.yml (master...appveyor) https://git.io/vNdKz

outsidecontext: they are failing?

yes, I suppose it didn't like the line endings :/

outsidecontext: https://usercontent.irccloud-cdn.com/file/GZB6F...

ok, it really needs these stupid blank lines between commands. i had removed them for nicer looks

yeah :P

now it looks good, who can merge this?

[libdiscid] samj1912 closed pull request #54: Added appveyor.yml (master...appveyor) https://git.io/vNdKz

outsidecontext: thanks :D

I will update the new picard builds to use this :D

samj1912: for stuff to be put on ftp what are "theses" ?

zas: https://ci.appveyor.com/project/MetaBrainz/libd...

which server hosts the ftp?

ah, williams

as is, i won't

zas, samj1912: just as a reminder, appveyor can be setup to publish to FTP automatically

name files with versions etc..

outsidecontext: our ftp is not open for upload

I tried to figure out whether the build artifacts can get a version number, but couldn't find anything

zas: isn't it possible to setup a ftp user with write access for appveyor? or is write access disabled in general?

anonymous read only, we don't want to bother with write access and user management. But we could do the inverse, using https://www.appveyor.com/docs/packaging-artifac..., a script on ftp server could run and put files on the ftp

in fact, it is a way to name files properly

what about pushing those on github releases instead ?

samj1912: ^^

zas: I figured out how to include the version in the filenames

that link actually points to the latest overview, but I don't think there is a permalink to the latest ZIP itself

outsidecontext: you might want to rename that to win32 and win64 just for consistency

samj1912: consistency with what?

the existing binaries?

:) done

should we actually build the latest master here or set it to only build tags?

I think build tags would be better

yes

outsidecontext: do we need the MSYS variable in path?

if not, I will just remove it

nope