[musicbrainz-server] mwiencek opened pull request #619: Add an Object.assign polyfill for IE11 (master...object-assign-polyfill) https://git.io/vAwav
2018-02-25 05627, 2018
github has left the channel
2018-02-25 05604, 2018
heyoni has quit
2018-02-25 05651, 2018
Slurpee has quit
2018-02-25 05617, 2018
D4RK-PH0ENiX joined the channel
2018-02-25 05607, 2018
Nyanko-sensei has quit
2018-02-25 05631, 2018
D4RK-PH0ENiX has quit
2018-02-25 05602, 2018
D4RK-PH0ENiX joined the channel
2018-02-25 05631, 2018
udayraj_ has quit
2018-02-25 05619, 2018
heyoni joined the channel
2018-02-25 05626, 2018
heyoni has quit
2018-02-25 05603, 2018
mzfr joined the channel
2018-02-25 05639, 2018
joel_ joined the channel
2018-02-25 05650, 2018
joel_ has quit
2018-02-25 05611, 2018
UmkaDK joined the channel
2018-02-25 05654, 2018
cats has quit
2018-02-25 05635, 2018
antlarr has quit
2018-02-25 05647, 2018
ListMyCDs has quit
2018-02-25 05649, 2018
yokel has quit
2018-02-25 05650, 2018
Leftmost has quit
2018-02-25 05650, 2018
zas has quit
2018-02-25 05650, 2018
Somasis has quit
2018-02-25 05650, 2018
d4rkie has quit
2018-02-25 05650, 2018
Leftmost joined the channel
2018-02-25 05627, 2018
ListMyCDs joined the channel
2018-02-25 05627, 2018
yokel joined the channel
2018-02-25 05627, 2018
zas joined the channel
2018-02-25 05627, 2018
Somasis joined the channel
2018-02-25 05627, 2018
d4rkie joined the channel
2018-02-25 05649, 2018
akhilesh has quit
2018-02-25 05623, 2018
kgz has quit
2018-02-25 05637, 2018
akhilesh joined the channel
2018-02-25 05614, 2018
colbydray joined the channel
2018-02-25 05632, 2018
UmkaDK has quit
2018-02-25 05609, 2018
fhe joined the channel
2018-02-25 05613, 2018
kgz joined the channel
2018-02-25 05625, 2018
yokel has quit
2018-02-25 05617, 2018
drsaunders has quit
2018-02-25 05650, 2018
drsaunders joined the channel
2018-02-25 05635, 2018
Nyanko-sensei joined the channel
2018-02-25 05629, 2018
D4RK-PH0_ joined the channel
2018-02-25 05631, 2018
D4RK-PH0_ has quit
2018-02-25 05639, 2018
D4RK-PH0_ joined the channel
2018-02-25 05645, 2018
D4RK-PH0ENiX has quit
2018-02-25 05617, 2018
D4RK-PH0_ has quit
2018-02-25 05648, 2018
D4RK-PH0ENiX joined the channel
2018-02-25 05613, 2018
Nyanko-sensei has quit
2018-02-25 05619, 2018
D4RK-PH0ENiX has quit
2018-02-25 05620, 2018
Lotheric_ joined the channel
2018-02-25 05632, 2018
Lotheric has quit
2018-02-25 05608, 2018
D4RK-PH0ENiX joined the channel
2018-02-25 05645, 2018
D4RK-PH0ENiX has quit
2018-02-25 05603, 2018
D4RK-PH0ENiX joined the channel
2018-02-25 05639, 2018
cats joined the channel
2018-02-25 05613, 2018
D4RK-PH0ENiX has quit
2018-02-25 05624, 2018
D4RK-PH0ENiX joined the channel
2018-02-25 05633, 2018
mzfr has quit
2018-02-25 05656, 2018
antlarr joined the channel
2018-02-25 05638, 2018
CatQuest has quit
2018-02-25 05612, 2018
CatQuest joined the channel
2018-02-25 05638, 2018
kgz has quit
2018-02-25 05620, 2018
samj1912
zas: you can merge 846 if you are finished with it
2018-02-25 05650, 2018
zas
well, i'm still wondering about it, and i would like it to be tested on win/mac
2018-02-25 05602, 2018
zas
also i wonder about those "defaults", because they are set once, on first startup, but those paths may change after
2018-02-25 05623, 2018
samj1912
zas, what do you mean about testing on windows and osx?
2018-02-25 05630, 2018
samj1912
It works as intended.
2018-02-25 05646, 2018
zas
i was thinking about something else: defaulting to None, and if not set, use "currrent" path returned by those methods (at runtime)
2018-02-25 05620, 2018
zas
if you see what i mean ...
2018-02-25 05650, 2018
zas
for sure, it is already better than defaulting to "." ...
2018-02-25 05602, 2018
kragniz joined the channel
2018-02-25 05623, 2018
zas
if the user didn't set any value, i think we should keep it dynamic
2018-02-25 05651, 2018
zas
for example, if Picard is first started with no existing "Music" dir, it will prolly fallback on user's home (or whatever). And subsequent starts will use this value, even if, in the meantime, an actual "Music" directory is created.
2018-02-25 05629, 2018
zas
But the patch would be more complex
2018-02-25 05623, 2018
Mineo
is that likely to happen? AFAIK all users on windows and linux usually start with a music directory somewhere.
2018-02-25 05629, 2018
samj1912
I don't think we need to overthink this that much. The defaults are nice.
2018-02-25 05640, 2018
samj1912
Yeah, same for osx.
2018-02-25 05651, 2018
zas
Mineo, samj1912 : ok, i'm fine with it ;)
2018-02-25 05603, 2018
zas
Mineo: since you are here, can we discuss about plugins ?
2018-02-25 05626, 2018
discopatrick has quit
2018-02-25 05635, 2018
Slurpee joined the channel
2018-02-25 05646, 2018
github joined the channel
2018-02-25 05646, 2018
github
[picard] zas closed pull request #846: Set default paths to standard locations (master...stdpaths) https://git.io/vAa1p
2018-02-25 05646, 2018
github has left the channel
2018-02-25 05644, 2018
travis-ci joined the channel
2018-02-25 05645, 2018
travis-ci
metabrainz/picard#3208 (master - e51d998 : Laurent Monin): The build passed.
as i said, current plugins V2 isn't really great, we made a step forward having a manifest file, which is a good thing imho
2018-02-25 05609, 2018
zas
but the code is over complicated, we still don't support i18n properly, and python imp module is getting deprecated
2018-02-25 05627, 2018
zas
also we have no *real* plugin API (no way to enforce it), plugin authors use whatever they want, we mitigate things having plugin API versions
2018-02-25 05639, 2018
zas
the plugin webservice on picard's website isn't that great, because it requires sync with plugin sources, and it is unclear what they are (picard-plugins repo is one)
2018-02-25 05609, 2018
samj1912
I thought that was the only one?
2018-02-25 05642, 2018
samj1912
as far as PW is concerned
2018-02-25 05650, 2018
zas
samj1912: nope, we can't really force plugin authors to manage their code within this repo.
2018-02-25 05638, 2018
zas
so, how can we improve things ?
2018-02-25 05639, 2018
samj1912
well a better way would be to have it how other stores have it
2018-02-25 05659, 2018
samj1912
industry tested methods should be the best
2018-02-25 05611, 2018
Mineo
for how many plugins is this a problem? the only one I can think of right now is the classical extras one
2018-02-25 05614, 2018
travis-ci joined the channel
2018-02-25 05615, 2018
travis-ci
metabrainz/picard#3208 (master - e51d998 : Laurent Monin): The build passed.
keep a simple way to for authors to upload new versions and store that latest per major version
2018-02-25 05610, 2018
samj1912
we can also enforce plugin metadata this way
2018-02-25 05619, 2018
zas
ok, let say someone is writing a plugin, he's using bitbucket, and wants to make it available to all picard users, how does he proceed ?
2018-02-25 05616, 2018
samj1912
downloads a release zip and uploads it with the right manifest, if the manifest does not exist, PW can provide a simple form to fill it in
2018-02-25 05604, 2018
samj1912
we also have the now defunct picard-plugin-tools repo if we want to make use of that
2018-02-25 05647, 2018
zas
upload it where ?
2018-02-25 05600, 2018
samj1912
PW
2018-02-25 05605, 2018
zas
how?
2018-02-25 05654, 2018
zas
should we provide a "register your plugin" page ?
2018-02-25 05655, 2018
samj1912
well, we will have to add the concept of accounts, preferably via mb oauth and then lead the dev to a plugin upload dashboard
2018-02-25 05643, 2018
samj1912
we can approve the first version of a plugin(via an admin dashboard) and then let the dev upload revisions without approval
2018-02-25 05604, 2018
zas
do we really need to go this way for <30 plugins ?
2018-02-25 05609, 2018
samj1912
ofc we will also have the right to take down any plugin
2018-02-25 05624, 2018
samj1912
well currently it is 30, this will just make it easier for new devs to make plugins
2018-02-25 05642, 2018
zas
Mineo: what do you think ?
2018-02-25 05654, 2018
samj1912
plus I have seen plugin repos with lesser plugins
2018-02-25 05606, 2018
Mineo
zas: given the frequency of changes to our plugins, I think this is solving a problem that doesn't exist
2018-02-25 05650, 2018
zas
Mineo: elaborate please
2018-02-25 05648, 2018
Mineo
well, most of our plugins don't see any development anymore at all and if, it's usually some small bug fix from someone in MeB's inner circle
2018-02-25 05603, 2018
samj1912
I think a major reason for that is a lack of proper plugin dev docs. I see a lot of community threads/tickets created for something that can easily be solved by a plugin
2018-02-25 05608, 2018
Mineo
but it sounds like the problem we're trying to solve at the moment is making it easier for external contributors to get their plugins into picards plugin list. I get that it's a chicken and egg problem - there's no way to do that at the moment, so we don't know how many people would use it
2018-02-25 05631, 2018
zas
yes, but imho that's the result of: lack of documentation, lack of clear path to distribute, constraints resulting from single repo + PR reviews + lack of reviewers, etc...
2018-02-25 05655, 2018
samj1912
maybe a plugin request category in discourse to start it off and better documentation/contribution tools
2018-02-25 05657, 2018
Mineo
but I don't know, I'd say even if we invest some time into making a nice plugin management site where everyone can register etc. there won't be plugin authors popping up left and right
2018-02-25 05640, 2018
samj1912
but this way we can mitigate plugin issues slightly, if someone has a problem with a plugin they can simply contact author in the plugin info on PW
2018-02-25 05652, 2018
samj1912
currently the way plugin issues are handled are also bad
2018-02-25 05605, 2018
zas
ok, i think having a plugin registration page, requiring auth, etc, is overkill, i'm thinking about another approach, requiring only access to a zip somewhere (this can be a github "release"), and managing plugin "sources": remote and/or local, website could jjust display list of plugins from known "sources"
