0:04 AM
bukwurm has quit
1:04 AM
D4RK-PH0ENiX has quit
1:06 AM
Tykling has quit
1:08 AM
Tykling joined the channel
2:07 AM
D4RK-PH0ENiX joined the channel
2:35 AM
Leo_Verto_ joined the channel
2:37 AM
Leo_Verto has quit
2:37 AM
Leo_Verto_ is now known as Leo_Verto
2:44 AM
Leo_Verto
reosarevok, why is ORG-27 still open?
2:44 AM
BrainzBot
4:27 AM
iliekcomputers
4:27 AM
Gelato!
4:39 AM
chhavi_
iliekcomputers: seems you played safe with the flavor
4:40 AM
iliekcomputers
They didn't have many
4:40 AM
I was tempted by green tea, but I decided to go with espresso
4:59 AM
chhavi_
Ahh
6:01 AM
Major_Lurker has quit
6:14 AM
outsidecontext joined the channel
7:10 AM
Lotheric_ joined the channel
7:11 AM
reosarevok
Leo_Verto: because we still don't have a cover IIRC
7:13 AM
Lotheric has quit
7:16 AM
bukwurm joined the channel
7:23 AM
samj1912: do you know how annotation search works? Someone is reporting it seems to be returning no-longer-existing annotations
8:12 AM
D4RK-PH0ENiX has quit
9:00 AM
jwf has quit
9:09 AM
jwf joined the channel
10:30 AM
zas
11:29 AM
code_master5 joined the channel
11:50 AM
D4RK-PH0ENiX joined the channel
12:02 PM
Lotheric_ is now known as Lotheric
12:21 PM
haruute joined the channel
12:43 PM
ZaphodBeeblebrox is now known as CatQuest
13:02 PM
kartikeyaSh joined the channel
13:07 PM
bukwurm
Mr_Monkey: How is the work on merge tool going? :)
13:11 PM
AfroThundr has quit
13:25 PM
Mr_Monkey
Hi bukwurm !
13:25 PM
I'm making slow progress on the merging tool, but progress onwards !
13:25 PM
bukwurm
Great!
13:26 PM
If there's anything I can do to help, do tell :)
13:26 PM
Mr_Monkey
How about you? Need any assistance with the name search?
13:26 PM
bukwurm
Mr_Monkey: I've been a little busy lately.
13:27 PM
But I'll try to wrap up the PR for duplication today/tomorrow.
13:28 PM
Actually, it's done for first test.
13:28 PM
Mr_Monkey
Well done you ! :)
13:28 PM
bukwurm
I just wanted to add some more features, like making exact name matching case insensitive.
13:28 PM
And having similar entity search restricted to matching entity type only.
13:29 PM
I yet have to merge master with all new changes, that might take some time.
13:29 PM
:)
13:31 PM
Mr_Monkey
Cool! Let me know if you want some help with the merging
13:37 PM
code_master5 has quit
14:01 PM
Sigyn has quit
14:04 PM
Sigyn joined the channel
14:31 PM
haruute has quit
14:42 PM
Mineo
SothoTalKer: MineoBot might be looking at wikipedia urls because (at least at some point in the past) not all entities in MB had wikidata links, only wikipedia ones and it's possible to go to the wikidata item from a wikipedia page to add the mbid there
14:45 PM
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | Meeting agenda: Reviews
14:45 PM
Mr_Monkey
"ERROR [ undefined, undefined ]" Why thank you, javascript, that's very helpful
14:46 PM
Freso
reosarevok: I didn't receive any reviews to my mail (yet). If I get any later ones, I won't be able to forward them.
14:46 PM
(I'm boarding my 2nd flight in ~20–30 minutes.)
14:46 PM
reosarevok
Oh, true, I was supposed to run today
14:46 PM
Ok!
14:46 PM
Freso
I'll write up mine and send it your way now. :)
14:46 PM
reosarevok
ruaok: do the same maybe ;)
14:47 PM
Freso
Did you get any from ruaok or iliekcomputers?
14:47 PM
I guess not. :)
14:47 PM
reosarevok
Not yet at least
14:47 PM
Freso
Rob should be somewhere here in ZRH as well, but the BCN flight is in the A gates and the CPH one is in B.
14:48 PM
Leo_Verto
haha
14:48 PM
iliekcomputers
Sorry, completely forgot, didn't do anything other than the gsoc summit
14:48 PM
ruaok
🧟♂️🧟♂️
14:48 PM
iliekcomputers
Gonna board a flight in a few hours
14:48 PM
Leo_Verto
how was the summit?
14:48 PM
ruaok
I can't seriously remember what happened before I left.
14:49 PM
Freso
Leo_Verto: Great. :)
14:49 PM
ruaok
Fabulous. JB from VLC were plotting to overthrow thenworld.
14:49 PM
The was way too much chocolate.
14:49 PM
Leo_Verto
how does this fit in with our own world domination plans?
14:49 PM
ruaok
But we ate it all.
14:49 PM
iliekcomputers
I was talking to till about cameras again :D
14:50 PM
ruaok
Leo_Verto: we're an integral part.
14:50 PM
Leo_Verto
wonderful!
14:50 PM
ruaok
(not a derivative one)
14:55 PM
Reo: my summary: finishing taxes, quartely finances, at summit I gave two seasons on business was and business models.
14:55 PM
And coerced 300+ people to way way toouch chocolate for everyone's good.
14:55 PM
Leo_Verto
iliekcomputers, did you get a chance to go explore the city with your camera?
14:55 PM
ruaok
14:56 PM
Leo_Verto
oh wow
14:56 PM
ruaok
Really, that picture should be my status update. The only real accomplishment worth talking about.
15:01 PM
Freso
reosarevok: Sent.
15:01 PM
Looks like boarding is about to start, so just in time! 😅
15:01 PM
See y'all later!
15:01 PM
Leo_Verto
see ya!
15:02 PM
CatQuest
👋
15:03 PM
rsh7
lots of chocolates :o
15:04 PM
Mr_Monkey
That is quite the chocolate table.
15:04 PM
Mr_Monkey is impressed.
15:17 PM
reosarevok
ruaok: "business was"?
15:18 PM
CatQuest
toouch?
15:18 PM
or wait, "too much"
15:20 PM
ruaok
Business and oss stuffs, reosarevok
15:20 PM
reosarevok
k
15:23 PM
CatQuest
basiclaly, blup
15:23 PM
:D
15:31 PM
reosarevok
bitmap: halp
15:31 PM
What exactly causes Error: No translation key found.?
15:32 PM
bitmap
when you pass undefined/null/'' to l()
15:32 PM
(or any string not in the message catalog, but it's usually because it's one of those)
15:33 PM
reosarevok
Yup. Found it, thanks
15:35 PM
Huh
15:35 PM
Our RG page choices are... weird
15:35 PM
15:35 PM
Why is RG type a header *there* anyway?
15:35 PM
Just over the release list?
15:38 PM
(in fact, if there are no releases, the RG type doesn't show in the main area at all, just on the sidebar :D )
15:40 PM
bitmap
heh... interesting
15:40 PM
the second link has a release but doesn't show it either?
15:41 PM
ah because it's not set, nvm
15:41 PM
reosarevok
Yeah
15:41 PM
15:46 PM
15:46 PM
I mean, we want to show it even with 0 anyway (in fact we do) right?
15:49 PM
bitmap
seems to be so that it hides it if it fails to fetch the reviews from CB for some reason, instead of saying it has 0 reviews
15:51 PM
reosarevok
Oh, ok
15:58 PM
outsidecontext has quit
15:59 PM
bitmap: more! :D What is preferred?
16:00 PM
releaseGroup.review_count != undefined or releaseGroup.review_count || releaseGroup.review_count === 0
16:03 PM
bitmap
the first one except releaseGroup.review_count != null is shorter and means the same thing as != undefined :)
16:04 PM
(as long as you are using != and not !==)
16:04 PM
reosarevok
Heh
16:04 PM
ESLint doesn't like that one
16:05 PM
bitmap
I don't think it likes != in general, unless it's buggy and accepts != undefined
16:06 PM
reosarevok
It doesn't like that because of type coercion
16:06 PM
With null it specifically says "use === to compare with null" :)
16:07 PM
bitmap
heh, we should make an exception for != null at least
16:07 PM
that's the only case where != or == is useful
16:08 PM
need to tweak the eslint rules
16:09 PM
reosarevok
So otherwise !== is preferred?
16:10 PM
bitmap
yeah
16:12 PM
kartikeyaSh has quit
16:13 PM
reosarevok
Hmm. Why is this not passing the reviews :/
16:17 PM
Well, it works if I pass them individually anyway, so eh
16:33 PM
bitmap
just deployed a new beta update
16:34 PM
CatQuest
what did you guys do
16:34 PM
CatQuest got "sleepy server"
16:34 PM
but I must have been extra "lucky" in pressing "vote" button right when you did it or smth :D
16:35 PM
worked second time
16:36 PM
reosarevok
Omg
16:37 PM
reosarevok sees genres in https://beta.musicbrainz.org/release-group/3bd76d40-7f0e-36b7-9348-91a33afee20e
16:37 PM
bitmap: were you planning to look at relationships.tt or should I?
16:37 PM
Right now I have RG index mostly done, other than "<h2>TODO: Relationships go here</h2>" :D
16:38 PM
I'm still not sure what to change so non-Index pages are also loaded from React rather than TT though :)