#metabrainz

Leo_Verto: have you seen https://github.com/goldfire/howler.js/tree/mast... ?

howler.js sounds like a great lib for BrainzPlayer.

also mooooin!

wow, I just added my first release after the solr search went live and it showed up in picard a few seconds later. this is amazing!

ikr

[listenbrainz-server] paramsingh opened pull request #448: Retry some times while trying to refresh user tokens (master...spotify-refresh-token-error) https://git.io/fxNyk

heyy, it's been 1 year since I joined the team officially 🎉

(well, 1 year since first invoice) 😅

iliekcomputers: happy brainzday!

zas: is anything in the picard website stack still using python 3.4 or could we get rid of https://github.com/metabrainz/picard-plugins/bl... ?

iliekcomputers: :)

Mineo: I don't think anything rely on 3.4 anymore, I'm OK to get rid of it. samj1912, what do you think?

zas: Mr_Monkey: invoices please!

iliekcomputers: we'd send you a cake, but you don't owe us money so

iliekcomputers: happy brainzday!

!m iliekcomputers

You're doing good work, iliekcomputers!

Happy Brainzday :D

iliekcomputers: done.. probably need to write some test before finishing the task

Project bookbrainz-data-js build #917: passed in 3 min 35 sec: https://travis-ci.org/bookbrainz/bookbrainz-dat...

ruaok: sent

thx

[listenbrainz-server] paramsingh closed pull request #448: Retry some times while trying to refresh user tokens (master...spotify-refresh-token-error) https://git.io/fxNyk

[listenbrainz-server] paramsingh opened pull request #449: Upgrade dependencies (master...upgrade-dependencies) https://git.io/fxAup

iliekcomputers: ping!

code_master5: pong

iliekcomputers: Is there anything else u wanted me do add here https://github.com/metabrainz/critiquebrainz/pu...

?

not that i remember, it is a schema change so i'll merge once i'm ready to actually deploy

otherwise it gets hard to track

iliekcomputers: Ok. Got it!

yo

iliekcomputers: https://tickets.metabrainz.org/browse/CB-234

CB-234: New Spotify mappings are not getting added

iliekcomputers: I've to build mbspotify locally to work on this. Right?

bitmap: For some reason, the 1823th and latest test keeps failing in production branch, whereas it doesn’t fail either in beta, or master, or local test runner.

that's odd

I'll trigger another build and see what it's doing inside the container

tx

it's not a problem with the test, since it passes when invoking ./node_modules/.bin/babel-node root/static/scripts/tests/utility.js directly

it fails when I do `sudo -E -H -u musicbrainz carton exec -- prove t/web.js -v` but passes with the same command when I run `./script/compile_resources.sh web-tests`

so it seems the web-tests bundle is old or corrupted or something in the image

not sure how to fix this but I think we can ignore it for now

bitmap: Ok, I will proceed to release now (cc reosarevok & zas)

I can code for picard again :D

Mineo: solr is awesome :D

zas, yes we can get rid of 3.4

Excellent news, samj1912!

samj1912: 🙌 🎉

samj1912: yay!

Mr_Monkey: reviewed your search PR

New interface looks great, just added one comment

bitmap: Hi, I was looking for some help on https://tickets.metabrainz.org/browse/MBS-9827 for Google Code-In, and was told you might be able to help. I'm trying to find the right place in the code to make the redirect, but i'm not sure where it should go. So far, I've made a redirect through the meta tag in the root/layout/Head.js file, but I realise that a 301 redirect would be more effective. I'm currently thinking of

putting it in the lib/MusicBrainz/Server/Controller/Artist.pm file--would this be a sensible thing to do? Thanks :)

MBS-9827: Redirect merged entity MBID pages to new MBID

Do you have the files tagged with Picard?

If so, the easiest way (in my opinion) is to use The AcoustID Fingerprinter, available from their website https://acoustid.org/fingerprinter

You just select the files and tell it to submit and it does all the work.

But in any case, the files need to be tagged with MusicBrainz MBID numbers and such (ideally using Picard) first so that they are properly identified in the database.

They all have MBID's but acousticID fingerprinted won't find any files to submit

Did you select the directory that the files are in? Also, what type of audio file are they?