I've created a prop that can display a warning message within FormRowSelectList, and a way to detect whether it should be displayed within work.js, but linking the two is proving tough
antara joined the channel
antara
hi! I've missed out on quite a lot of GCI, thanks to a lot of school stuff and upcoming exams :/
but hopefully I'll be able to claim a last task today and finish it quickly :)
CatQuest: happy belated birthday!
it has been a really awesome GCI and now I'm hopefully going to stick around :)
george
Oooo yeah today is the last claim day
Yikes
c1e0 has quit
c1e0 joined the channel
yvanzo
Hi george, can you possibly use FieldErrors instead?
(to display the warning message)
george
Sure, I hadn't looked into that
It looks like its using `_.identity` to pass in the fielderrors
yvanzo
I mean one FieldErrors for the whole set of languages.
george
But what's supposed to be passed in through getSelectField?
Because atm it seems like it's useless
Since _.identity just returns whatever value is passed in?
antara has quit
D4RK-PH0ENiX has quit
Especially considering that the getSelectField prop is used both within FieldErrors *and* SelectField
ruaok
zas: we no longer need mbsandbox.org, right? it just renewed... I can turn that off, right?
zas
yes, unused since a while
ruaok
ok
antara joined the channel
BestSteve joined the channel
Mr_Monkey
Hi antara ! Not sure if you saw my message but a Kindle version of the book is fine. Y'oull find a lot of details on the amazon page under "product details"
D4RK-PH0ENiX joined the channel
yvanzo
george: _;identity returns the FormRowSelectList instance
george
So I should add to the WorkAttribute errors, and it'll get reflected in the prop?
yvanzo
No, languages are apart from attributes.
Did you already succeed to hide the unneeded options/buttons depending on selected languages?
george
No, since I can't find a way to interact with the form from within work.js
I've found a way to hide the button, and a way to detect whether certain languages are selected, but the two aren't connected
antara
Mr_Monkey: yes, the Amazon page really helped! I've added an edition now :)
Mr_Monkey
I saw that antara !
antara
oh okay great :)
Mr_Monkey
For the Edition identifiers, you can at least add the Amazon ASIN that's easy to find
antara
oh yes I even copied the ASIN onto notepad
guess I forgot to add it, whoops
I'll just go add it
Mr_Monkey
OK. While you're at it, you can also find other identifiers for the Author.
I'll get some lunch now, so there's no huge rush :)
antara
Okay, sure! I'll try to finish in half an hour
yvanzo
george: what is the name of the property you added to FormRowSelectList?
george
`singleItem`
At the moment it disables the Add Language button, but I'm going to make it display an error instead
Lotheric_ joined the channel
Going for lunch brb :)
Lotheric has quit
antara
Mr_Monkey hi, so I've added the VIAF and LibraryThing identifiers, but how do you add identifiers (for example the OpenLibrary one you've linked) that aren't in the Type dropdown?
yvanzo
george: FormRowSelectList is missing a global FieldErrors, but it already features FieldErrors at item-level.
george: To make use of it from work.js, simply update 'errors' property for the related item (language).
antara has quit
This can be done within the reducing function on line 60.
antara joined the channel
chhavi_
Hi kapish, you can send in pngs here, and we can review the designs. With changes done, and general consensus on the channel..we can add it to the store :)
[picard] phw opened pull request #1066: PICARD-1437: Fix any deleted tags in new metadata mark file as changed (master...PICARD-1437) https://git.io/fpHzb
github has left the channel
zas
i noticed Picard 2.1.0dev2 is failing to load fr_FR translation for Qt, and it appears https://github.com/metabrainz/picard/blob/maste... doesn't work for me, i tried various things, but replacing 'qt_' with 'qtbase_' is fixing the issue (Yes/No buttons in native Qt dialogs aren't localized)
george
yvanzo: Editing the state doesn't seem to do anything, is it readonly unless edited with `set()`?
outsidecontext: also, this code is using system locale, but the app can force to a specific language and this isn't handled as is, as you may already know
Kapish joined the channel
george
Hey Kapish :)
zas
outsidecontext: can you test his 'qt_' vs 'qtbase_' thing on your system, and tell me if it's the same for you, before i submit a PR
zas: yes, this seems to be the proper way. what distro are you using? just wondering, there probably is a difference what package includes /usr/share/qt/translations/qt_fr.qm
Kapish
Hey chhavi_ i am sorry i couldnt see your message earlier, my pre boards are going :)
i will share the design in a few minutes
outsidecontext
but in any case this seems to be ok to change, since qt_fr.qm, when it exists, just imports all the translations, inlcuding those that are irrelevant here (e.g. for qt designer)
zas
ok, i'll make the PR for it
yvanzo
george: Did you succeed at disabling unneeded options first?
george
Disabling unneeded options?
yvanzo
Like, it is not needed to allow adding [No lyrics] if another language is already selected.
(But this is probably beyond the current task.)
iliekcomputers
ruaok: i'm here if you have the time to talk.
ruaok
let's.
I put some comments on the PR -- have a look.
I also don't have an appreciation for how large files should really get.
yvanzo
george: Getting "Add Language" button is just about all for this task really.