0:33 AM
legoktm is now known as legoktm[SJS]
2019-05-22 14212, 2019
1:30 AM
Nyanko-sensei joined the channel
2019-05-22 14208, 2019
1:34 AM
D4RK-PH0ENiX has quit
2019-05-22 14211, 2019
2:44 AM
legoktm[SJS] is now known as legoktm
2019-05-22 14229, 2019
3:01 AM
Nyanko-sensei has quit
2019-05-22 14209, 2019
3:02 AM
D4RK-PH0ENiX joined the channel
2019-05-22 14217, 2019
4:53 AM
samj1912 joined the channel
2019-05-22 14234, 2019
5:26 AM
kuno has quit
2019-05-22 14209, 2019
5:27 AM
samj1912 has quit
2019-05-22 14236, 2019
5:28 AM
xarph has quit
2019-05-22 14228, 2019
5:29 AM
Freso has quit
2019-05-22 14253, 2019
5:29 AM
Leftmost has quit
2019-05-22 14232, 2019
5:31 AM
amCap1712 has quit
2019-05-22 14219, 2019
5:33 AM
kuno joined the channel
2019-05-22 14234, 2019
5:33 AM
amCap1712 joined the channel
2019-05-22 14239, 2019
5:33 AM
Freso joined the channel
2019-05-22 14240, 2019
5:33 AM
xarph joined the channel
2019-05-22 14245, 2019
5:33 AM
samj1912 joined the channel
2019-05-22 14230, 2019
5:34 AM
Leftmost joined the channel
2019-05-22 14220, 2019
6:52 AM
BestSteve has quit
2019-05-22 14214, 2019
6:53 AM
BestSteve joined the channel
2019-05-22 14234, 2019
7:01 AM
yvanzo
mo’’in’
2019-05-22 14210, 2019
7:18 AM
BrainzGit
2019-05-22 14212, 2019
7:18 AM
BrainzBot
2019-05-22 14249, 2019
7:42 AM
Freso
2019-05-22 14201, 2019
7:54 AM
gr0uch0mars joined the channel
2019-05-22 14206, 2019
7:55 AM
amCap1712
hi gr0uch0mars
2019-05-22 14214, 2019
7:55 AM
gr0uch0mars
hi amCap1712
2019-05-22 14225, 2019
7:55 AM
gr0uch0mars
I saw that you opened a PR for recording details page
2019-05-22 14229, 2019
7:55 AM
amCap1712
yup
2019-05-22 14250, 2019
7:55 AM
amCap1712
looking forward to your review
2019-05-22 14233, 2019
7:59 AM
reosarevok
Sigh.
2019-05-22 14235, 2019
7:59 AM
reosarevok
yvanzo: around?
2019-05-22 14259, 2019
8:11 AM
ruaok
moooooin
2019-05-22 14205, 2019
8:13 AM
yvanzo
reosarevok: yup!
2019-05-22 14251, 2019
8:13 AM
reosarevok
2019-05-22 14228, 2019
8:14 AM
gr0uch0mars
amCap1712: I found a bug when navigating to a Recording from a Release. I put the error in the PR
2019-05-22 14230, 2019
8:14 AM
reosarevok
Do you know what do I have to put in the line so it will read it properly?
2019-05-22 14231, 2019
8:14 AM
reosarevok
2019-05-22 14257, 2019
8:15 AM
amCap1712
Ok I'll check it out gr0uch0mars
2019-05-22 14203, 2019
8:16 AM
gr0uch0mars
thanks!!!
2019-05-22 14235, 2019
8:17 AM
amCap1712
gr0uch0mars: does searching a release and clicking a recording work?
2019-05-22 14256, 2019
8:17 AM
gr0uch0mars
let me check
2019-05-22 14241, 2019
8:18 AM
gr0uch0mars
nope, same error in console
2019-05-22 14251, 2019
8:18 AM
gr0uch0mars
`… mbentity.Recording.getTitle()' on a null object reference`
2019-05-22 14237, 2019
8:19 AM
amCap1712
Ok thanks found the error I suppose then, I must have forgotten to send the mbid of recording with the intent when clicking a recording in a release
2019-05-22 14242, 2019
8:19 AM
amCap1712
Will fix it now
2019-05-22 14220, 2019
8:21 AM
gr0uch0mars
ok , let me know to re-review the PR
2019-05-22 14236, 2019
8:21 AM
yvanzo
reosarevok: use utf8;
2019-05-22 14224, 2019
8:26 AM
reosarevok
yvanzo: oh duh, thans
2019-05-22 14227, 2019
8:26 AM
reosarevok
*thanks
2019-05-22 14252, 2019
8:28 AM
samj1912 has quit
2019-05-22 14249, 2019
8:37 AM
Mr_Monkey
Moin !
2019-05-22 14257, 2019
8:37 AM
yvanzo
reosarevok: MBS-10108 is probably a style issue, do you want it to be moved under STYLE?
2019-05-22 14258, 2019
8:37 AM
BrainzBot
2019-05-22 14249, 2019
8:38 AM
Mr_Monkey
ruaok, iliekcomputers : I see the same as Freso: no LB listens since two days ago.
2019-05-22 14251, 2019
8:38 AM
yvanzo
(or just green-lighting it?)
2019-05-22 14210, 2019
8:39 AM
Mr_Monkey
And look at the recent page :p
2019-05-22 14247, 2019
8:39 AM
ruaok
yeah. seems like the spotify import is stuck again. :(
2019-05-22 14254, 2019
8:39 AM
ruaok
I can try restarting the container.
2019-05-22 14223, 2019
8:40 AM
Freso
ruaok: Not just Spotify. I have Simple Last.FM Scrobbler listens from yesterday that aren’t there either.
2019-05-22 14211, 2019
8:41 AM
Freso
Mr_Monkey: And thanks for verifying. :)
2019-05-22 14241, 2019
8:41 AM
reosarevok
yvanzo: oh, ffs. Tempted to say "Twitter videos don't count, fuck off with that noise" but I'm sure there's an artist out there somewhere who only puts music out as Twitter videos
2019-05-22 14244, 2019
8:41 AM
Mr_Monkey
No problem
2019-05-22 14257, 2019
8:41 AM
ruaok
confirmed spotify is not importing anything.
2019-05-22 14258, 2019
8:41 AM
reosarevok
But if we allow this people will start adding tweet links to artists, because people will be people
2019-05-22 14209, 2019
8:42 AM
reosarevok
yvanzo: can we whitelist this *only* for recordings?
2019-05-22 14217, 2019
8:42 AM
yvanzo
sure!
2019-05-22 14230, 2019
8:42 AM
reosarevok
And otherwise still clean it up automatically?
2019-05-22 14236, 2019
8:42 AM
reosarevok
If that can be done, then style says do it
2019-05-22 14213, 2019
8:44 AM
yvanzo
Yes, will only accept well-formated permalinks.
2019-05-22 14254, 2019
8:46 AM
ruaok
2019-05-22 14222, 2019
8:47 AM
ruaok
can you please set an alert on the listenbrainz queues growing?
2019-05-22 14240, 2019
8:47 AM
ruaok
if any of them grow past 1,000 it would be nice to get an alert.
2019-05-22 14245, 2019
8:47 AM
ruaok
400k is a problem. :)
2019-05-22 14217, 2019
8:48 AM
reosarevok
2019-05-22 14239, 2019
8:48 AM
ruaok
2019-05-22 14240, 2019
8:48 AM
BrainzBot
LB-450: Influx importer is stuck
2019-05-22 14242, 2019
8:48 AM
ruaok
iliekcomputers: ^^
2019-05-22 14255, 2019
8:49 AM
ruaok
2019-05-22 14209, 2019
8:50 AM
ruaok
and you'll get instant confirmation that something is busted.
2019-05-22 14220, 2019
8:50 AM
yvanzo
reosarevok: we should probably just deny it as it may not link to the appropriate entity.
2019-05-22 14234, 2019
9:01 AM
reosarevok
Eh, I guess
2019-05-22 14201, 2019
9:05 AM
Gazooo has quit
2019-05-22 14254, 2019
9:06 AM
Gazooo joined the channel
2019-05-22 14218, 2019
9:07 AM
spuniun has quit
2019-05-22 14214, 2019
9:08 AM
i7c has quit
2019-05-22 14217, 2019
9:08 AM
i9c joined the channel
2019-05-22 14247, 2019
9:09 AM
i9c is now known as i7c
2019-05-22 14242, 2019
9:11 AM
spuniun joined the channel
2019-05-22 14234, 2019
9:53 AM
pristine__
ruaok: moin!
2019-05-22 14256, 2019
9:57 AM
ruaok
moin pristine__!
2019-05-22 14238, 2019
10:09 AM
pristine__
ruaok: I was thinking to include cluster info in html files. People can help us that way, I guess.
2019-05-22 14239, 2019
10:09 AM
BrainzGit
2019-05-22 14239, 2019
10:09 AM
BrainzBot
2019-05-22 14259, 2019
10:09 AM
ruaok
pristine__: what cluster info?
2019-05-22 14230, 2019
10:10 AM
pristine__
Number of nodes, executors, memory etc
2019-05-22 14241, 2019
10:10 AM
ruaok
makes sense!
2019-05-22 14208, 2019
10:11 AM
pristine__
And what are your thoughts on making the scripts independent?
2019-05-22 14255, 2019
10:11 AM
ruaok
depends on what you mean with independent...
2019-05-22 14254, 2019
10:12 AM
pristine__
I mean....Storing output of each script in hdfs.
2019-05-22 14217, 2019
10:13 AM
pristine__
Because presently we have an order,
2019-05-22 14243, 2019
10:13 AM
pristine__
First create_dataframes.py then train_models.py and at laat recommend .py
2019-05-22 14248, 2019
10:13 AM
pristine__
So for instance
2019-05-22 14233, 2019
10:14 AM
pristine__
If I want to just run recommend.py I need to wait till the other two scripts are done executing,
2019-05-22 14248, 2019
10:14 AM
ruaok
oh, yes. that is a must.
2019-05-22 14201, 2019
10:15 AM
ruaok
we should be able to load the model and run recommendations right away.
2019-05-22 14206, 2019
10:15 AM
pristine__
Otherwise we could just fetch necessary data from hdfs and run the script.
2019-05-22 14236, 2019
10:15 AM
ruaok nods
2019-05-22 14237, 2019
10:15 AM
pristine__
Apart from model, we need a few data frames too for generating recommendations.
2019-05-22 14203, 2019
10:16 AM
pristine__
These dataframes are the outcome of the first script run.
2019-05-22 14225, 2019
10:16 AM
pristine__
So yes, we can save every imp info/result.
2019-05-22 14231, 2019
10:16 AM
ruaok
great
2019-05-22 14220, 2019
10:17 AM
pristine__
Do we have something for today? I was just doing hit and trial to reduce time which can wait if we have something up.
2019-05-22 14234, 2019
10:18 AM
ruaok
how about some of the open old pending PRs?
2019-05-22 14249, 2019
10:18 AM
pristine__
Yeah. Good idea.
2019-05-22 14206, 2019
10:19 AM
ruaok
every time I go back to look at the old PRs they seem to be missing stuff. maybe take a break and get some of those done?
2019-05-22 14221, 2019
10:19 AM
ruaok
that way param can work on getting user stats working while you're on the recommendation stuff.
2019-05-22 14231, 2019
10:20 AM
pristine__
there are two
2019-05-22 14233, 2019
10:20 AM
pristine__
2019-05-22 14258, 2019
10:20 AM
pristine__
2019-05-22 14248, 2019
10:21 AM
pristine__
I will just go through them :)
2019-05-22 14258, 2019
10:21 AM
ruaok
yep. great. :)
2019-05-22 14243, 2019
10:36 AM
ruaok
2019-05-22 14217, 2019
10:47 AM
Deathspe11 joined the channel
2019-05-22 14257, 2019
10:48 AM
ferbncode
spellew: looks right, To reproduce the issue in your local environment, please 1. update the docker-compose file image for `musicbrainz_db` to the new image (this is the one after schema change): `metabrainz/musicbrainz-test-database:beta`. 2. Remove `data/mbdata` directory and redo the steps for importing the sample dump (
https://critiquebrainz.readthedocs.io/intro.html#… ) It would be good if we make the changes
2019-05-22 14257, 2019
10:48 AM
ferbncode
ahead of the coding period as we should be using the latest musicbrainz_db schema anyway. :)
2019-05-22 14249, 2019
10:55 AM
reosarevok
2019-05-22 14240, 2019
11:06 AM
reosarevok
2019-05-22 14223, 2019
11:08 AM
yvanzo
reosarevok: thanks, on it
2019-05-22 14208, 2019
11:57 AM
dolina_ is now known as dolina
2019-05-22 14223, 2019
12:06 PM
yvanzo
bitmap, reosarevok: Module 'canvas' not found when running ./script/compile_resources.sh tests
2019-05-22 14254, 2019
12:08 PM
yvanzo
Fail with any previous MBS release…
2019-05-22 14242, 2019
12:11 PM
iliekcomputers
so the user was submitting track numbers as strings and then started sending them as ints
2019-05-22 14249, 2019
12:11 PM
iliekcomputers
which led to the error.
2019-05-22 14236, 2019
12:12 PM
iliekcomputers
i've added validation to the tracknumber field to keep it as always int for now, but not sure how to proceed for the current data, modifications to influx aren't easy.
2019-05-22 14200, 2019
12:13 PM
alastairp
iliekcomputers: hi, can we do an AB release today?
2019-05-22 14236, 2019
12:13 PM
iliekcomputers
alastairp: i don't think this week will work. :( (monday?)
2019-05-22 14256, 2019
12:13 PM
reosarevok
yvanzo: it's been like that for a while, yeah :/
2019-05-22 14219, 2019
12:14 PM
alastairp
if that's the earliest that you can, OK. We have a bit of a backlog for minimising frank load. I'm free now, so can get back on top of it
2019-05-22 14224, 2019
12:14 PM
BrainzGit
2019-05-22 14232, 2019
12:15 PM
iliekcomputers
i can work the weekend, but i can't be fully working until friday.
2019-05-22 14250, 2019
12:15 PM
zas
ruaok: added the alert, but in fact there was one already, it's up since one month....
2019-05-22 14225, 2019
12:16 PM
zas
note: the lb proxy alert didn't happen since i changed sysctl values on lemmy
2019-05-22 14249, 2019
12:16 PM
alastairp
I'm busy most of the weekend, but ping me when you're availalbe and let's see if we can make everything work. I'll try and prepare everything
2019-05-22 14239, 2019
12:17 PM
iliekcomputers
alastairp: sure, sorry about the unavailability.
2019-05-22 14252, 2019
12:17 PM
alastairp
np, we'll get to it when we can
2019-05-22 14243, 2019
12:18 PM
yvanzo
reosarevok: I also used to run URLCleanup tests locally but it doesn’t work anymore since the move to ES6.
2019-05-22 14204, 2019
12:19 PM
reosarevok
yvanzo: they work on static/scripts/tests/web.html
2019-05-22 14225, 2019
12:20 PM
yvanzo
alastairp: brainzutils 1.9.0 is broken, may AB switch to 1.10.0 at least?
