#metabrainz

/

      • alastairp
        yvanzo: I saw your comment earlier in the week
      • 2019-05-22 14204, 2019

      • alastairp
        yes, we should have a PR open which upgrades to 1.11 I think
      • 2019-05-22 14223, 2019

      • alastairp
        I'm interested in the problem, why did it stop working?
      • 2019-05-22 14228, 2019

      • yvanzo
        alastairp: how do you handle configuration with develop.sh while your containers are based on consul images?
      • 2019-05-22 14259, 2019

      • alastairp
        sorry - I don't understand
      • 2019-05-22 14218, 2019

      • yvanzo
        alastairp: actually mbdata releases prior to 25.0.0 have been removed from PyPI, that's why BU 1.9.0 is broken.
      • 2019-05-22 14224, 2019

      • alastairp
        how do we make a config.py file during development?
      • 2019-05-22 14207, 2019

      • yvanzo
        oh, you just mount the current folder on /code, right?
      • 2019-05-22 14210, 2019

      • alastairp
        yes
      • 2019-05-22 14224, 2019

      • alastairp
        so we just copy the sample file to config.py
      • 2019-05-22 14212, 2019

      • alastairp
        ah, I see the mbdata. I got confused with https://github.com/metabrainz/brainzutils-python/… and thought that the link was always on github
      • 2019-05-22 14222, 2019

      • alastairp
        but I see that it 1.9 it was linked to pypi
      • 2019-05-22 14238, 2019

      • alastairp
        OK, easy fix, I'll get this done for the release that I'll do with iliekcomputers this/next week
      • 2019-05-22 14254, 2019

      • yvanzo
        I had an issue with using sir/solr images locally and found out it was because of consul-template-base but I might be wrong after all.
      • 2019-05-22 14219, 2019

      • alastairp
        there's a change between the old and new consul base images in the way that we configure stuff - metabrainz.org uses the new one, I believe AB still uses the old one
      • 2019-05-22 14222, 2019

      • alastairp
        iliekcomputers: was working on that
      • 2019-05-22 14213, 2019

      • iliekcomputers
      • 2019-05-22 14230, 2019

      • iliekcomputers
        so the database has string values of tracknumber for a user.
      • 2019-05-22 14239, 2019

      • iliekcomputers
        and then the user submitted tracknumber as an int
      • 2019-05-22 14244, 2019

      • iliekcomputers
        leading to influx borking
      • 2019-05-22 14239, 2019

      • ruaok
        zas: > added the alert, but in fact there was one already, it's up since one month....
      • 2019-05-22 14256, 2019

      • ruaok
        ah, but I didn't see it fire off. does it fire off only once with no reminders?
      • 2019-05-22 14206, 2019

      • ruaok
        > note: the lb proxy alert didn't happen since i changed sysctl values on lemmy
      • 2019-05-22 14208, 2019

      • ruaok
        thank you!
      • 2019-05-22 14243, 2019

      • zas
        yes, that's a current limitation of grafana alerts, it triggers when the limit is reached, but has no "reminder"
      • 2019-05-22 14244, 2019

      • ruaok
        iliekcomputers: that PR you sent has failing tests.
      • 2019-05-22 14251, 2019

      • zas
        i missed it too
      • 2019-05-22 14214, 2019

      • ruaok
        that's not very useful when it gets lost under a pile of other alerts. :(
      • 2019-05-22 14216, 2019

      • zas
        but how can you have so many "incoming" messages in the queue ? aren't they processed ?
      • 2019-05-22 14226, 2019

      • ruaok
        yes, and that is the problem.
      • 2019-05-22 14236, 2019

      • zas
        ruaok: yes, agreed, but it will prolly be fixed in future versions
      • 2019-05-22 14238, 2019

      • ruaok
        we have one listen that fails and it plugs the whole pipeline.
      • 2019-05-22 14245, 2019

      • zas
        ouch
      • 2019-05-22 14208, 2019

      • ruaok
        iliekcomputers: that PR, will that fix the problem to hand? it almost seems that we need to nuke a series that has text tracknumber. no?
      • 2019-05-22 14258, 2019

      • zas
        ruaok: in fact, it's already in current grafana (since 5.3), but i wasn't aware of it, i'll enable it
      • 2019-05-22 14202, 2019

      • ruaok
        iliekcomputers: ok, this will allow us to get the pipeline going again, but that user's listens are stuck. permanently.
      • 2019-05-22 14210, 2019

      • D4RK-PH0ENiX has quit
      • 2019-05-22 14216, 2019

      • iliekcomputers
        ruaok: we can't rename that user's track number column, I'm not sure if we have any other option except nuking.
      • 2019-05-22 14236, 2019

      • ruaok
        or finally implement replay for a user...
      • 2019-05-22 14247, 2019

      • zas
      • 2019-05-22 14248, 2019

      • BrainzBot
        SEC-6: Upgrade pyyaml to version 4.2b1 or later.
      • 2019-05-22 14255, 2019

      • ruaok
        replay all the listens except some filtered ones, then rename the measurement.
      • 2019-05-22 14220, 2019

      • ruaok
        iliekcomputers: the failing test catches the int vs str case. should be easy to fix.
      • 2019-05-22 14233, 2019

      • ruaok
        can you fix that real quick so we can push this out asap?
      • 2019-05-22 14235, 2019

      • ruaok
        if not, I can.
      • 2019-05-22 14256, 2019

      • iliekcomputers
        I won't be near a computer for a few hours.
      • 2019-05-22 14207, 2019

      • ruaok
        ok, I'll hijack your branch then.
      • 2019-05-22 14219, 2019

      • iliekcomputers
        Great!
      • 2019-05-22 14223, 2019

      • ruaok
        I fix the test and use my own approval to approve the fix. :)
      • 2019-05-22 14236, 2019

      • iliekcomputers
        I can't approve my own pr but that sounds good
      • 2019-05-22 14211, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-05-22 14239, 2019

      • BrainzGit
        [listenbrainz-server] mayhem opened pull request #575 (master…influx-bug): Influx bug https://github.com/metabrainz/listenbrainz-server…
      • 2019-05-22 14207, 2019

      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #575 (master…influx-bug): Influx bug https://github.com/metabrainz/listenbrainz-server…
      • 2019-05-22 14208, 2019

      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #574 (master…influx-bug): Add validation for tracknumber field in data https://github.com/metabrainz/listenbrainz-server…
      • 2019-05-22 14210, 2019

      • yvanzo
        bitmap, reosarevok: would it be alright to push a new beta soon?
      • 2019-05-22 14202, 2019

      • reosarevok
        I guess so? I'd want to get a bunch more of the smaller open PRs reviewed and merged if possible, but
      • 2019-05-22 14241, 2019

      • yvanzo
        yeah, currently reviewing as much as possible of those
      • 2019-05-22 14200, 2019

      • ruaok
        iliekcomputers: oh doh. this doesn't fix the pipeline. of course not.
      • 2019-05-22 14215, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1020 (master…MBS-10127): MBS-10127: Convert relationships-table.tt to React https://github.com/metabrainz/musicbrainz-server/…
      • 2019-05-22 14216, 2019

      • BrainzBot
        MBS-10127: Convert root/components/relationships-table.tt to React https://tickets.metabrainz.org/browse/MBS-10127
      • 2019-05-22 14256, 2019

      • bitmap
        reosarevok: can you link to the ones you think we should include? I'll take a look at any I haven't
      • 2019-05-22 14230, 2019

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1079 (master…babel-eslint-11): Update babel-eslint to 11.0.0-beta.0 https://github.com/metabrainz/musicbrainz-server/…
      • 2019-05-22 14241, 2019

      • MusicbrainzB0T joined the channel
      • 2019-05-22 14215, 2019

      • MusicbrainzB0T1 has quit
      • 2019-05-22 14255, 2019

      • iliekcomputers
        ruaok: unless we replay or rename the column, it'll be fucked.
      • 2019-05-22 14223, 2019

      • iliekcomputers
        Because if we convert explicitly to strings it'll mess up some other person's measurement which only has integers
      • 2019-05-22 14253, 2019

      • ruaok
        and I see no way to rename anything, really.
      • 2019-05-22 14208, 2019

      • iliekcomputers
        Yeah, I looked
      • 2019-05-22 14213, 2019

      • iliekcomputers
        There isn't
      • 2019-05-22 14227, 2019

      • ruaok
        so, I am going to write a hack to filter that user's listens.
      • 2019-05-22 14228, 2019

      • iliekcomputers
        Influx can be really irritating
      • 2019-05-22 14242, 2019

      • ruaok
        and then contact the user to see how to proceed.
      • 2019-05-22 14242, 2019

      • iliekcomputers
        A hack and a ticket
      • 2019-05-22 14259, 2019

      • iliekcomputers
        Sounds good to me.
      • 2019-05-22 14212, 2019

      • ruaok
        perhaps deleting the measurements is ok.
      • 2019-05-22 14230, 2019

      • ruaok
        it is an escaped measurement name.
      • 2019-05-22 14241, 2019

      • ruaok
        I wonder how many fucking tries this will take
      • 2019-05-22 14248, 2019

      • ruaok
      • 2019-05-22 14219, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1058 (master…MBS-10142): MBS-10142: Weibo autoselect improvements + sidebar https://github.com/metabrainz/musicbrainz-server/…
      • 2019-05-22 14220, 2019

      • BrainzBot
        MBS-10142: Update URL cleanup for Sina Weibo URLs + add them to the sidebar https://tickets.metabrainz.org/browse/MBS-10142
      • 2019-05-22 14229, 2019

      • ruaok
      • 2019-05-22 14234, 2019

      • ruaok
        ah, it is now.
      • 2019-05-22 14235, 2019

      • ruaok
        not
      • 2019-05-22 14231, 2019

      • spuniun has quit
      • 2019-05-22 14239, 2019

      • spuniun joined the channel
      • 2019-05-22 14247, 2019

      • ruaok
        wtf does "Error response from daemon: manifest for metabrainz/listenbrainz:v-2019-05-22.1 not found" mean?
      • 2019-05-22 14232, 2019

      • amCap1712
        hi ruaok
      • 2019-05-22 14212, 2019

      • yvanzo
        ruaok: hub docker latency?
      • 2019-05-22 14234, 2019

      • ruaok
        recommended course of action? wait?
      • 2019-05-22 14243, 2019

      • yvanzo
      • 2019-05-22 14250, 2019

      • yvanzo
        should work already
      • 2019-05-22 14211, 2019

      • amCap1712
        i wanted to ask can we start offering the app through metabrainz google play account. you won't need to provide me access to the google account. I can just be given limited access to manage only the MusicBrainz for Android app.
      • 2019-05-22 14228, 2019

      • yvanzo
        or wait if still needed, yes
      • 2019-05-22 14232, 2019

      • ruaok
        it doesn't. :(
      • 2019-05-22 14212, 2019

      • yvanzo
        ruaok: oh uploaded version is missing dash '-' after 'v'
      • 2019-05-22 14246, 2019

      • yvanzo
        actually, the two latest tags have this issue.
      • 2019-05-22 14214, 2019

      • yvanzo
        uploaded v2019-05-22.1 whereas it should be v-2019-05-22.1
      • 2019-05-22 14230, 2019

      • ruaok
        doh.
      • 2019-05-22 14236, 2019

      • ruaok
        thanks for being my sanity checker.
      • 2019-05-22 14206, 2019

      • BrainzGit
        [listenbrainz-server] mayhem opened pull request #576 (production…omit-user-ovso): Omit user ovso https://github.com/metabrainz/listenbrainz-server…
      • 2019-05-22 14216, 2019

      • ruaok
        iliekcomputers: does this look sane to you?
      • 2019-05-22 14253, 2019

      • reosarevok
        bitmap: sure, but at a meeting now :) In 3 h or so!
      • 2019-05-22 14210, 2019

      • ruaok
      • 2019-05-22 14215, 2019

      • ruaok
        this is so not my day.
      • 2019-05-22 14200, 2019

      • bitmap
        reosarevok: np, already checking all the small ones I see that don't have changes requested
      • 2019-05-22 14208, 2019

      • reosarevok
        Thanks!
      • 2019-05-22 14218, 2019

      • ruaok
        iliekcomputers: this problem is happening for other users as well. :(
      • 2019-05-22 14238, 2019

      • reosarevok
        Ban all the users!
      • 2019-05-22 14250, 2019

      • alastairp
        column on profile table that says if they're string-endian or int-endian and cast accordingly?
      • 2019-05-22 14215, 2019

      • ruaok
        lol
      • 2019-05-22 14224, 2019

      • ruaok
        replaying the user would be the best thing.
      • 2019-05-22 14246, 2019

      • alastairp
        yeah, sure
      • 2019-05-22 14201, 2019

      • ruaok
        iliekcomputers: your fix does work, but the influx-writer crashes (but skips) the bad users listens.
      • 2019-05-22 14212, 2019

      • ruaok
        far from ideal, but we are catching up now.
      • 2019-05-22 14217, 2019

      • ruaok
        the osvo-fix has been reverted.
      • 2019-05-22 14220, 2019

      • yvanzo
        bitmap: Can we retag v-20110711-schema-change to v-2011-07-11-schema-change? It is the only mistagged release so far, always pops up first, and has no link to it from either blog or tickets.
      • 2019-05-22 14226, 2019

      • ruaok
        I'll update tickets appropriately next.
      • 2019-05-22 14200, 2019

      • yvanzo
        bitmap: Also it would be nice if we could add patch version .X as of the next release (btw, that would align with other MeB projects).
      • 2019-05-22 14258, 2019

      • bitmap
        yvanzo: sure
      • 2019-05-22 14204, 2019

      • yvanzo
        That would also help mirror maintainers with following releases and hotfixes.
      • 2019-05-22 14211, 2019

      • bitmap
        when would we use the patch version?
      • 2019-05-22 14221, 2019

      • ruaok
      • 2019-05-22 14222, 2019

      • BrainzBot
        LB-451: Improve tracknumber fix
      • 2019-05-22 14239, 2019

      • yvanzo
        bitmap: when pushing hotfixes to production.
      • 2019-05-22 14240, 2019

      • bitmap
        hotfixes always end up in the next release though
      • 2019-05-22 14231, 2019

      • bitmap
        if someone always needs current hotfixes I'm not sure why they wouldn't use the production branch instead of tags
      • 2019-05-22 14258, 2019

      • BrainzGit
        [listenbrainz-server] mayhem closed pull request #576 (production…omit-user-ovso): Omit user ovso https://github.com/metabrainz/listenbrainz-server…
      • 2019-05-22 14212, 2019

      • ruaok
      • 2019-05-22 14213, 2019

      • BrainzBot
        LB-452: Write user-replay script
      • 2019-05-22 14216, 2019

      • ruaok
      • 2019-05-22 14217, 2019

      • BrainzBot
        LB-453: Write script to identify users with string tracknumbers
      • 2019-05-22 14255, 2019

      • yvanzo
        bitmap: mostly because of breaking changes in database schema or prerequisites
      • 2019-05-22 14239, 2019

      • ruaok
      • 2019-05-22 14240, 2019

      • BrainzBot
        LB-454: Improve spotify recorder
      • 2019-05-22 14216, 2019

      • bitmap
        yvanzo: doesn't the same issue exist if they switch tags? unless we announce every hotfix and patch version on the blog with upgrade instructions
      • 2019-05-22 14238, 2019

      • bitmap
        which might be a good idea, but it's extra work and my thinking is that tags are only useful if people use them :)
      • 2019-05-22 14245, 2019

      • bitmap
        (I mean, we should definitely mention in the blog if a release requires some change in dependencies already)
      • 2019-05-22 14249, 2019

      • yvanzo
        bitmap: Hotpatches usually don’t break anything, but further releases may. MB VM relies on MBS release tags already.
      • 2019-05-22 14206, 2019

      • bitmap
        in my experience most of our hotfixes are for display/editing issues which are less likely to apply to someone using a mirror server, so it just doesn't seem like every hotfix necessarily needs a tag (though I agree some changes should)
      • 2019-05-22 14252, 2019

      • bitmap
        if the MB VM needs a tag for a certain patch then by all means we should add one
      • 2019-05-22 14205, 2019

      • bitmap
        I just wanna make sure someone/something will actually use them before changing my workflow for hotfixes
      • 2019-05-22 14216, 2019

      • bitmap
        like, a patch version to hotfix an issue in the webservice makes total sense to me
      • 2019-05-22 14242, 2019

      • gr0uch0mars has quit
      • 2019-05-22 14216, 2019

      • iliekcomputers
        ruaok: influx-writer is now skipping the listens for the users with type mismatches
      • 2019-05-22 14247, 2019

      • iliekcomputers
        but it doesn't seem like influx-writer is restarting...
      • 2019-05-22 14247, 2019

      • ruaok
        yep. see tickets above.
      • 2019-05-22 14217, 2019

      • ruaok
        but something causes it to slow down quite a lot everytime it encountered a bad user.
      • 2019-05-22 14229, 2019

      • ruaok
        restart or delay otherwise, our pipeline is freaking slow.
      • 2019-05-22 14252, 2019

      • iliekcomputers
        so it does a bunch of retries
      • 2019-05-22 14202, 2019

      • ruaok
        ohhhh, that's it.