0:26 AM
CatQuest
0:27 AM
(thing I could think of; haveing a medium with tracks and then *removing* them, but it still also works)
0:28 AM
SothoTalKer
removing tracks would be a destructive edit, no?
0:33 AM
CatQuest
aw man i hate that
0:33 AM
... but you're probably right
0:34 AM
SothoTalKer
you could remove all tracks and then tick the "unknown tracklist" checkbox, i guess
0:34 AM
i'm too dumb to login to test anyway :p
0:35 AM
CatQuest
just use "mb" aspassport
0:35 AM
erh word
0:35 AM
SothoTalKer
naughty
0:35 AM
CatQuest
all passwwords are reset to "mb" on test
0:35 AM
to aid testing
0:36 AM
it's not naughty
0:38 AM
D4RK-PH0ENiX has quit
0:39 AM
SothoTalKer
so yeah, it works :)
0:56 AM
D4RK-PH0ENiX joined the channel
3:02 AM
reosarevok: when is barcode and catalog numbers for mediums coming? ;)
6:16 AM
pristine__
6:16 AM
ruaok: Can you relate?
6:16 AM
I am pretty happy with my results :)
6:31 AM
zas
6:34 AM
6:38 AM
very high load (up to 40) happened between 13:50 and 16:00 UTC yesterday and 23:00 and 02:40 last night
8:17 AM
Cyna
8:33 AM
iliekcomputers
pristine__: the top artists, those are from collaborative filtering?
8:36 AM
pristine__
iliekcomputers: no
8:36 AM
Just the top 20 artists of feb 19.
8:37 AM
iliekcomputers
Ah
8:38 AM
Do you plan to run it with the entire data, or is just a recent month intentional?
8:38 AM
Also, we have data for May in the cluster now too, I'd be more curious to run it on that.
8:46 AM
pristine__
There is no plan as now since we are not sure how often we will be training the model and generating recommendations.
8:47 AM
I can run it with the data of month May and provide you with the results.
9:05 AM
Gazooo has quit
9:06 AM
Gazooo joined the channel
9:35 AM
reosarevok
SothoTalKer: thanks for volunteering!
10:00 AM
SothoTalKer: the report thing sounds reasonable, actually :)
10:00 AM
Thanks!
10:00 AM
The medium thing, thanks for volunteering :p
10:04 AM
flamingspinach has quit
10:15 AM
flamingspinach joined the channel
10:17 AM
pristine__
10:17 AM
iliekcomputers: ^
10:17 AM
for May.
10:34 AM
Freso
SothoTalKer reosarevok, I’d say the report should be in addition to, not instead of. Unless you’re making it so that you can no longer add entirely media‐less releases.
10:34 AM
reosarevok
Yeah, I thought in addition to :)
10:34 AM
But we should have one
10:35 AM
Freso
Yep.
10:35 AM
Did you ever look at my genre stat ticket?
10:35 AM
It’s still not linked to anything anyway.
10:36 AM
Lotheric
genre stat !!
10:36 AM
+1
10:36 AM
:)
10:36 AM
good idea
10:37 AM
Freso
10:37 AM
BrainzBot
MBS-10225: Add statistics for genre data
10:37 AM
Lotheric
voted
10:38 AM
I'm very curious to see stats on genres :)
10:39 AM
Freso
Yep. Me too.
10:41 AM
SothoTalKer
Freso, reosarevok: do we still need that option? I mean when it is implemented you can just tick both boxes "i don't know the medium type" & "i don't know the tracklist":
10:41 AM
10:41 AM
Freso
SothoTalKer: Seems better to leave it out entirely, esp. if you don’t know the amount of media.
10:42 AM
If you claim that a release has 1 medium though you don’t know the type or tracklist of, but it really has 4 media…
10:44 AM
SothoTalKer
the checkbox should probably be renamed then, that also the mediums are unknown "The tracklist for this release is currently unknown."
10:45 AM
like "mediums & tracklist are unknown"
10:46 AM
yvanzo
zas: found unusual entries in mb ws logs.
10:46 AM
SothoTalKer
(i hope it's not me)
10:49 AM
ruaok
yvanzo: zas is busy today. what sorts of weird entries?
10:50 AM
yvanzo
ruaok: yup, just replied to him about debug progress :)
10:53 AM
11:00 AM
reosarevok
SothoTalKer: that's a fair point, could change it to something like "We have no information about this release's media and tracklist"
11:00 AM
Freso: what do you think? :)
11:15 AM
D4RK-PH0ENiX has quit
11:17 AM
yvanzo
Cyna: 'state' should probably not be part of 'Props' in FormRowNameWithGuessCase.js
11:17 AM
See root/static/scripts/account/components/EditProfileForm.js for example
11:30 AM
D4RK-PH0ENiX joined the channel
11:32 AM
BrainzGit
11:32 AM
BrainzBot
11:34 AM
D4RK-PH0ENiX has quit
11:37 AM
D4RK-PH0ENiX joined the channel
11:40 AM
Cyna
if I want to have the input field value change, I have to pass in state
11:42 AM
I'm using hooks withs const so the only way I can get the state is by passing it through props
11:50 AM
SothoTalKer
reosarevok: good enough for me, i guess :)
12:04 PM
yvanzo
CatQuest: found 2 typos: 'saluang' and 'violin family' descriptions have </br> instead of <br/>
12:06 PM
SothoTalKer
is it <br/> or <br />?
12:10 PM
yvanzo
either way, but </br> is invalid (closing a tag that has not been opened)
12:15 PM
SothoTalKer
i prefer <p></p> anyway :D
12:18 PM
BrainzGit
12:18 PM
BrainzBot
12:22 PM
SothoTalKer
reosarevok: you could get it merged to beta aswell, i guess? :x
12:31 PM
yvanzo
reosarevok: should the two above be marked as regressions?
12:32 PM
SothoTalKer: definitely going to beta today or tomorrow :)
12:32 PM
SothoTalKer
yay
12:36 PM
reosarevok
yvanzo: probably :)
12:36 PM
SothoTalKer: not from my phone I can't :)
12:37 PM
SothoTalKer
oh
12:52 PM
yvanzo
not from my phone either, it's broken (warranty expired about 1 month ago) :P
17:37 PM
Cyna
bitmap: Can you help me with the state issue... yvanzo said I shouldn't be passing state as Props
17:38 PM
17:45 PM
yvanzo
Cyna: That might be legit after all but it is unclear which component this 'state' relates to.
17:46 PM
Cyna
state comes only from editForm.js
17:46 PM
yvanzo
Is there any type definition for this 'state'?
17:46 PM
Cyna
Yes
17:47 PM
Its in the Props part of wherever it is used
17:48 PM
for example, formRowNameWithGuesscase component
17:48 PM
17:49 PM
Its causing issue on editForm because FormRowSelect accepts value as both string or number. while the state property that is passed in is either of string or number but not both
18:13 PM
yvanzo
Cyna: A temporary workaround could be to enforce annoted type for target.value in onChange parameter given to FormRowSelect calls in EditForm.js
18:15 PM
Cyna
any idea how do I do it... seems confusing to me
18:19 PM
yvanzo
with : any
18:21 PM
((target.value: any): integer)
18:21 PM
((target.value: any): number)
18:28 PM
Cyna
```onChange={(e) => {
18:28 PM
const target = e.target;
18:28 PM
if (target instanceof HTMLInputElement) {
18:28 PM
return setState({
18:28 PM
...state,
18:28 PM
locale: {
18:28 PM
...state.locale,
18:28 PM
value: ((target.value: any): number),
18:28 PM
},
18:28 PM
});
18:28 PM
}
18:28 PM
return undefined;
18:33 PM
yvanzo
Cyna: yup, should do. A definitive fix would be to improve FormRowSelect with parameterized type
19:04 PM
19:05 PM
Gazooo has quit
19:06 PM
Gazooo joined the channel
19:47 PM
Freso
reosarevok: Late but: SGTM.
19:49 PM
SothoTalKer: `<br/>` vs. `<br />` is mostly a legacy thing. Any browser from the last 5 (if not more) years should handle either fine. When XHTML was first introduced, many browsers would not understand `<br/>` but would understand `<br />`, so `<br />` was the recommended way for most compatibility. I guess it’s still recommended if you need to support IE 3 or whatever. :)
19:50 PM
Probably more like 10 or more years.
19:50 PM
XHTML is from 2000, so ~15 or so years or more recent is probably a good estimate. :p
20:25 PM
CatQuest
not even *my* browser is *that* old :D
20:59 PM
Lotheric_ joined the channel
21:00 PM
Lotheric has quit
22:12 PM
Lotheric_ is now known as Lotheric
23:42 PM
D4RK-PH0ENiX has quit