I will switch to herb few minutes in order to upgrade and reboot kiki
2019-07-01 18253, 2019
BrainzGit has quit
2019-07-01 18213, 2019
BrainzGit joined the channel
2019-07-01 18211, 2019
zas
switching back to kiki
2019-07-01 18213, 2019
CatQuest
Hommik!
2019-07-01 18239, 2019
CatQuest
zas early up and working :D
2019-07-01 18241, 2019
CatQuest
!m zas
2019-07-01 18241, 2019
BrainzBot
You're doing good work, zas!
2019-07-01 18245, 2019
zas
Yup ;)
2019-07-01 18235, 2019
alastairp
iliekcomputers: thanks for the approvals
2019-07-01 18246, 2019
alastairp
can we do a release today?
2019-07-01 18227, 2019
alastairp
maybe 2 - I want to release all the PRs that are pending, and then do another release with rate limiting (so that we can roll back if needed and still have all the other changes merged)
2019-07-01 18253, 2019
Gazooo joined the channel
2019-07-01 18204, 2019
iliekcomputers
alastairp: sure, sounds good to me, 8 PM IST around?
2019-07-01 18203, 2019
alastairp
mmm, in about 5h30? that might be tight - I have plans this evening
2019-07-01 18213, 2019
alastairp
either 1h before or 3h after would be better if possible
2019-07-01 18259, 2019
iliekcomputers
either works for me, whichever is more convenient to you.
2019-07-01 18209, 2019
alastairp
let's do it earlier
2019-07-01 18256, 2019
iliekcomputers
cool!
2019-07-01 18220, 2019
alastairp
between 7-7:30 ist, then? planning to finish by about 8
it's trying to create a user in the database but it fails (because the user already exists). If you run tests, it'll work fine
2019-07-01 18254, 2019
alastairp
I wanted to fix that, too :)
2019-07-01 18214, 2019
alastairp
what did you run? test.sh -u ?
2019-07-01 18228, 2019
aidanlw17
That's right, the tests are continuing anyways. Ok it was existing?
2019-07-01 18235, 2019
aidanlw17
I ran ./test.sh -d
2019-07-01 18242, 2019
aidanlw17
then I ran ./test.sh
2019-07-01 18256, 2019
aidanlw17
and now this error occurs whenever I run ./test.sh
2019-07-01 18257, 2019
alastairp
right, no problem. tests will continue to run fine
2019-07-01 18220, 2019
alastairp
interesting, it didn't occur previously?
2019-07-01 18227, 2019
aidanlw17
This never happened before when I only ran ./test.sh
2019-07-01 18230, 2019
alastairp
this is something that I should look into - let me give you an overview
2019-07-01 18210, 2019
alastairp
if you just run test.sh, it builds the acousticbrainz image, sets up a separate space for database, starts the database, runs the tests, and then deletes everything
2019-07-01 18200, 2019
alastairp
for me, that was a process that took too long to do every time I wanted to run tests, so I added test.sh -u, to start the database server in the background. then, whenever you run test.sh, it'll skip the build/setup process
2019-07-01 18211, 2019
alastairp
then I added test.sh -d to shut the database server down
2019-07-01 18245, 2019
alastairp
it looks like there are still some small bugs here then, for example in some cases it doesn't seem to delete the database after finishing (which is why you're seeing the error)
2019-07-01 18258, 2019
alastairp
we should add some more documentation about how tests work
2019-07-01 18215, 2019
alastairp
and try and fix some of the remaining bugs that are in this script
2019-07-01 18250, 2019
aidanlw17
I see, that's interesting given my usage of it.
2019-07-01 18221, 2019
aidanlw17
After you run ./test.sh -u, do you then use ./test.sh every time with server running in the background?
ah, I see that I have a difference between -s (stop) and -d (down)
2019-07-01 18207, 2019
alastairp
it's possible that stop will stop it, but leave the data behind (so you'll get the create user error on startup), and down will actually delete it?
2019-07-01 18213, 2019
alastairp
I'll check that
2019-07-01 18224, 2019
iliekcomputers
alastairp: I'm around
2019-07-01 18232, 2019
D4RK-PH0ENiX has quit
2019-07-01 18239, 2019
aidanlw17
Okay yeah. This makes sense because usually if I run ./test.sh it doesn't do all of the setup, and it doesn't give output like this https://pastebin.com/zAuStGNS , but after running ./test.sh -d, I start getting that output (and the error I posted)
2019-07-01 18259, 2019
alastairp
ok, definitely something that we have to improve then
2019-07-01 18209, 2019
alastairp
iliekcomputers: cool, I haven't finished my final changes on the stats PR
2019-07-01 18237, 2019
alastairp
if you want to get stuff done now now, we could deploy what's already been merged, or we can wait a bit more
2019-07-01 18222, 2019
iliekcomputers
we can wait, no worries
2019-07-01 18228, 2019
alastairp
ok, cool
2019-07-01 18241, 2019
alastairp
actually, can I get you to do something for me?
2019-07-01 18212, 2019
aidanlw17
ok sounds good. I also agree that adding more documentation on the tests would be good - I can help with that!
2019-07-01 18227, 2019
iliekcomputers
Sure, what is it?
2019-07-01 18239, 2019
alastairp
aidanlw17: in listenbrainz we have a developers section that shows up on listenbrainz.readthedocs.io, we could do the same for ab
2019-07-01 18248, 2019
alastairp
iliekcomputers: AB-413 we have to fix this, it keeps on causing problems
can we force the login button to always go to https?
2019-07-01 18229, 2019
alastairp
we'll have to sniff to get the hostname/port that we're running on somehow - e.g. we can't just set the url to https://acousticbrainz.org/{url_for(login), because that won't work on development
2019-07-01 18241, 2019
aidanlw17
cool, I can make a ticket to add something along those lines?
2019-07-01 18248, 2019
alastairp
aidanlw17: yeah, go ahead
2019-07-01 18231, 2019
aidanlw17
alastairp: 👍 when you get the chance as well, let me know if there are anymore changes that need to be made on AB-404!
iliekcomputers: thanks. we've talked about a better way of doing this - one thing we might have to do is set up nginx in a local container so that we can force https rewrite for most of our URLs, but this specific error comes up once every few months, doing the rewrite in flask is probably going to be the easiest immediate fix
2019-07-01 18238, 2019
yokel has quit
2019-07-01 18228, 2019
yokel joined the channel
2019-07-01 18258, 2019
D4RK-PH0ENiX joined the channel
2019-07-01 18231, 2019
aidanlw17
Freso: it's Canada Day today and a national holiday, so I was hoping to be out this afternoon participating in some activities. Can I email you my review?
2019-07-01 18239, 2019
alastairp
aidanlw17: no problem 🇨🇦
2019-07-01 18203, 2019
alastairp
moving day today too? or is that just quebec?
2019-07-01 18226, 2019
aidanlw17
thanks alastairp! No moving day here in Toronto, what is that?
that sounds exhausting! Where I'm from, maybe kind of like the first couple days before school begins in September. Have you lived in Quebec alastairp?
