#metabrainz

/

      • d4rkie joined the channel
      • 2019-08-05 21710, 2019

      • D4RK-PH0ENiX has quit
      • 2019-08-05 21712, 2019

      • d4rkie has quit
      • 2019-08-05 21749, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-08-05 21701, 2019

      • adhawkins has quit
      • 2019-08-05 21720, 2019

      • adhawkins joined the channel
      • 2019-08-05 21734, 2019

      • sampsyo has quit
      • 2019-08-05 21721, 2019

      • sampsyo joined the channel
      • 2019-08-05 21751, 2019

      • nav2002__ joined the channel
      • 2019-08-05 21713, 2019

      • nav2002__ has quit
      • 2019-08-05 21719, 2019

      • bitmap
        zas: I'll restart the ws container and check what it's doing
      • 2019-08-05 21747, 2019

      • bitmap
        Cyna: converting the edit details is a necessary prerequisite, yes. how is that going?
      • 2019-08-05 21752, 2019

      • Cyna
        I've converted some
      • 2019-08-05 21700, 2019

      • Cyna
        I'll be over will all today
      • 2019-08-05 21724, 2019

      • yvanzo
        mo’’in’
      • 2019-08-05 21738, 2019

      • ankit63 joined the channel
      • 2019-08-05 21725, 2019

      • madmouser1 joined the channel
      • 2019-08-05 21733, 2019

      • ankit7 joined the channel
      • 2019-08-05 21727, 2019

      • ankit7 has quit
      • 2019-08-05 21727, 2019

      • ankit63 has quit
      • 2019-08-05 21705, 2019

      • alastairp
        yvanzo: right, cool. do you plan on also submitting those affected annotations? I think it makes sense to process them to remove the unexpected characters
      • 2019-08-05 21715, 2019

      • BrainzGit
        [sir] yvanzo opened pull request #107 (master…solr-113-skip-cc): SOLR-113: Skip indexing entity on unwanted control character https://github.com/metabrainz/sir/pull/107
      • 2019-08-05 21716, 2019

      • BrainzBot
        SOLR-113: XML incompatible strings abort reindexing annotation, recording, release, and url cores https://tickets.metabrainz.org/browse/SOLR-113
      • 2019-08-05 21707, 2019

      • yvanzo
        alastairp: Note that fixing these annotations in the database will send reindex messages to sir. Thus it seems safer to wait for sir update.
      • 2019-08-05 21703, 2019

      • alastairp
        sure, fixing in the database is probably a better core solution, but it means that you'll have to monitor logging to see if new items with bad characters get added to the database
      • 2019-08-05 21701, 2019

      • yvanzo
        that’s why MBS-9112 should be addressed too, at least for unwanted control characters
      • 2019-08-05 21702, 2019

      • BrainzBot
        MBS-9112: Sanitize input for multi-line fields https://tickets.metabrainz.org/browse/MBS-9112
      • 2019-08-05 21708, 2019

      • alastairp
        cool
      • 2019-08-05 21757, 2019

      • alastairp
        ah, I didn't realise that most fields are already filtered. yeah, extending this to multi-line fields would be great
      • 2019-08-05 21720, 2019

      • alastairp
        how would we go about fixing existing entities with control chars? They would need an edit applied to them I guess
      • 2019-08-05 21719, 2019

      • yvanzo
        Yes, editing (once server is able to sanitize these fields) should do, there are only 17 annotations to go through.
      • 2019-08-05 21742, 2019

      • yvanzo
        Let's hope there are as little affected entries for other entity types, test vm is currently doing a whole reindex.
      • 2019-08-05 21720, 2019

      • ruaok
        zas: I guess you're not getting paid today. transferwise just crashed. 🙄
      • 2019-08-05 21754, 2019

      • ruaok
        yvanzo: alastairp : thanks for whipping up that PR for the XML sir bug. <3
      • 2019-08-05 21701, 2019

      • zas
        ruaok: np
      • 2019-08-05 21714, 2019

      • alastairp
        i didn't write no PR!
      • 2019-08-05 21727, 2019

      • ruaok
        I think we take our uptime more seriously than they do, lol.
      • 2019-08-05 21729, 2019

      • ruaok
        !m zas
      • 2019-08-05 21729, 2019

      • BrainzBot
        You're doing good work, zas!
      • 2019-08-05 21752, 2019

      • ruaok
        alastairp: you know what I mean. it has your fingerprints all over it. :)
      • 2019-08-05 21740, 2019

      • zas
        ruaok: See https://community.metabrainz.org/t/fate-of-the-ol… (do you still have this archive somewhere?)
      • 2019-08-05 21722, 2019

      • ruaok
        reosarevok: Mr_Monkey : relevant to your interests: https://punpedia.org/
      • 2019-08-05 21742, 2019

      • zas
        ^^Are you sure it's wise to feed them? ;)
      • 2019-08-05 21728, 2019

      • ruaok
        perhaps not...
      • 2019-08-05 21743, 2019

      • yvanzo
        It is utterly professional, as they are interested in online encyclopedia.
      • 2019-08-05 21712, 2019

      • nav2002__ joined the channel
      • 2019-08-05 21752, 2019

      • nav2002__ has quit
      • 2019-08-05 21753, 2019

      • aidanlw17
        Hi alastairp, just to let you know I’ll be afk for most of the work day today because I’m traveling to our family’s house. I’ll be around working in the evening once I’ve arrived, instead!
      • 2019-08-05 21722, 2019

      • nav2002__ joined the channel
      • 2019-08-05 21709, 2019

      • Mr_Monkey
        ruaok: thanks! It was great to go with breakfast, a little pun au chocolat
      • 2019-08-05 21753, 2019

      • zas
        oh no... see what you did rob ;) (btw, Hi Mr_Monkey) :D
      • 2019-08-05 21758, 2019

      • ruaok instantly regrets his decision
      • 2019-08-05 21751, 2019

      • Mr_Monkey
        I'm allowed to be into cyber-pun, k?
      • 2019-08-05 21724, 2019

      • nav2002__ has quit
      • 2019-08-05 21708, 2019

      • nav2002__ joined the channel
      • 2019-08-05 21727, 2019

      • nav2002__ has quit
      • 2019-08-05 21720, 2019

      • CatQuest
        I like how on "jobs§ ther is only "pirate puns" :DDDD
      • 2019-08-05 21702, 2019

      • nav2002__ joined the channel
      • 2019-08-05 21701, 2019

      • CatQuest
        yvanzo: ruaok: re puns: Heaters gonna heat.
      • 2019-08-05 21731, 2019

      • CatQuest is but a neoPuNte :V
      • 2019-08-05 21714, 2019

      • CatQuest
        “The best things in life are furry”
      • 2019-08-05 21715, 2019

      • CatQuest
        yes
      • 2019-08-05 21719, 2019

      • D4RK-PH0ENiX has quit
      • 2019-08-05 21753, 2019

      • pristine__
        ruaok: hey
      • 2019-08-05 21759, 2019

      • pristine__
        Did you see the changes?
      • 2019-08-05 21744, 2019

      • ruaok
        PRs are on the agenda post lunch. :-)
      • 2019-08-05 21746, 2019

      • pristine__
        Ooo. What do you plan to cook today?
      • 2019-08-05 21723, 2019

      • ruaok
        Nothing. I just had some Asian fast food. I'm not home.
      • 2019-08-05 21735, 2019

      • ruaok
        In delft visiting a friend.
      • 2019-08-05 21738, 2019

      • ruaok
      • 2019-08-05 21704, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-08-05 21703, 2019

      • pristine__
        Asian food <3
      • 2019-08-05 21703, 2019

      • pristine__
        Like?
      • 2019-08-05 21747, 2019

      • pristine__
        I have seen some photos on insta
      • 2019-08-05 21703, 2019

      • travis-ci joined the channel
      • 2019-08-05 21703, 2019

      • travis-ci
        metabrainz/picard#4744 (master - 4124342 : Philipp Wolfer): The build passed.
      • 2019-08-05 21703, 2019

      • travis-ci
      • 2019-08-05 21703, 2019

      • travis-ci
      • 2019-08-05 21703, 2019

      • travis-ci has left the channel
      • 2019-08-05 21752, 2019

      • ruaok
        pristine__: PR reviewed. it was generic "asian" food. nothing impressive.
      • 2019-08-05 21706, 2019

      • pristine__
        ruaok: hey. Can we think of something else other than adjust_backwards?
      • 2019-08-05 21723, 2019

      • pristine__
        Because in the end, the function is actually adjusting months/dates.
      • 2019-08-05 21748, 2019

      • ruaok
        just backwards?
      • 2019-08-05 21703, 2019

      • pristine__
        ( I am fine with changing the name but adjust_backwards is weird)
      • 2019-08-05 21732, 2019

      • pristine__
        Umm.....But what is going backward?
      • 2019-08-05 21704, 2019

      • pristine__
        And it is not neccessary that it will go backward, if the variable is set to false it will go forward.
      • 2019-08-05 21722, 2019

      • pristine__
        shift_months, shift_days?
      • 2019-08-05 21736, 2019

      • ruaok
        shift_value? really, this isn't that important to me. go with what feels right.
      • 2019-08-05 21748, 2019

      • HenryG has quit
      • 2019-08-05 21736, 2019

      • HenryG joined the channel
      • 2019-08-05 21733, 2019

      • pristine__
        ruaok: I just want to include month/date.
      • 2019-08-05 21737, 2019

      • pristine__
        Yeah. Thanks:)
      • 2019-08-05 21729, 2019

      • Sophist_UK joined the channel
      • 2019-08-05 21755, 2019

      • Sophist-UK has quit
      • 2019-08-05 21723, 2019

      • Cyna
        bitmap: Having trouble with ReleaseGroup entity create form
      • 2019-08-05 21714, 2019

      • Cyna
      • 2019-08-05 21717, 2019

      • Cyna
        I havent touched the forms part, have been working only on details till now
      • 2019-08-05 21728, 2019

      • Cyna
        please have a look when you are around
      • 2019-08-05 21755, 2019

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | New GSoC students start here: https://goo.gl/7jsjG2 | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews
      • 2019-08-05 21741, 2019

      • nav2002__ has quit
      • 2019-08-05 21722, 2019

      • travis-ci joined the channel
      • 2019-08-05 21722, 2019

      • travis-ci
        metabrainz/picard#4749 (master - c727853 : Philipp Wolfer): The build passed.
      • 2019-08-05 21722, 2019

      • travis-ci
      • 2019-08-05 21722, 2019

      • travis-ci
      • 2019-08-05 21722, 2019

      • travis-ci has left the channel
      • 2019-08-05 21727, 2019

      • bitmap
        Cyna: what trouble are you having?
      • 2019-08-05 21756, 2019

      • Cyna
        I'm getting an error after clicking on `create release group`
      • 2019-08-05 21717, 2019

      • Cyna
        Gimme a sec, I'll send the error message
      • 2019-08-05 21712, 2019

      • Cyna
        bitmap: `Caught exception in MusicBrainz::Server::Controller::ReleaseGroup->create "Can't locate object method "options_type_id" via package "MusicBrainz::Server::Form::ReleaseGroup" at lib/MusicBrainz/Server/Controller/Role/Create.pm line 102."`
      • 2019-08-05 21713, 2019

      • Cyna
        Ohh I found the problem
      • 2019-08-05 21747, 2019

      • travis-ci joined the channel
      • 2019-08-05 21747, 2019

      • travis-ci
        metabrainz/picard#4750 (master - 7120412 : Philipp Wolfer): The build passed.
      • 2019-08-05 21747, 2019

      • travis-ci
      • 2019-08-05 21747, 2019

      • travis-ci
      • 2019-08-05 21747, 2019

      • travis-ci has left the channel
      • 2019-08-05 21753, 2019

      • bitmap
        you compare strings with eq, not ==
      • 2019-08-05 21713, 2019

      • Cyna
      • 2019-08-05 21753, 2019

      • bitmap
        see my message above ^^
      • 2019-08-05 21701, 2019

      • Cyna
        ohh thanks
      • 2019-08-05 21731, 2019

      • Cyna
        bitmap: there are some entities where some values that are supposed to exist are undefined
      • 2019-08-05 21755, 2019

      • Cyna
        Cant find it even in the entity's console log
      • 2019-08-05 21755, 2019

      • Cyna
      • 2019-08-05 21710, 2019

      • Cyna
        I've commented these out temporarily as they were causing error
      • 2019-08-05 21733, 2019

      • bitmap
        right, so those will only exist if the attribute (in this case iswc) is actually changed by the edit
      • 2019-08-05 21702, 2019

      • bitmap
        you can just output null if edit.display_data.iswc is undefined
      • 2019-08-05 21718, 2019

      • bitmap
        that applies to any of the attributes, including name, comment, etc.
      • 2019-08-05 21744, 2019

      • Cyna
        okay
      • 2019-08-05 21711, 2019

      • Freso
        <BANG>
      • 2019-08-05 21711, 2019

      • Freso
        It’s International Traffic Light Monday!
      • 2019-08-05 21711, 2019

      • Freso
      • 2019-08-05 21711, 2019

      • Freso
        People up today: aidanlw17, iliekcomputers, bitmap, Mr_Monkey, Freso, zas, yvanzo, ruaok, reosarevok, amCap1712, akhilesh, spellew, Cyna, pristine__, CatQuest – anyone else that wants to go, please let me know explicitly ASAP!
      • 2019-08-05 21711, 2019

      • Freso
        aidanlw17: Go!
      • 2019-08-05 21711, 2019

      • Freso
        aidanlw17 says:
      • 2019-08-05 21711, 2019

      • Freso
        """
      • 2019-08-05 21727, 2019

      • CatQuest
        derp i was in the other chna expecting meeting there :P
      • 2019-08-05 21727, 2019

      • Freso
        Hi everyone,
      • 2019-08-05 21728, 2019

      • Freso
        Sorry I'm not able to make the meeting time today. In the past week I continued to work with building the similarity eval for AB, which took up most of my time.
      • 2019-08-05 21728, 2019

      • Freso
        Also spent time getting work from the PRs for the similarity pipeline all working on the same branch, and doing some final testing as I adapted parts of the pipeline to work with the eval.
      • 2019-08-05 21728, 2019

      • Freso
        That's all!
      • 2019-08-05 21728, 2019

      • Freso
        Thanks :)
      • 2019-08-05 21728, 2019

      • Freso
        """
      • 2019-08-05 21728, 2019

      • Freso
        iliekcomputers: Go!
      • 2019-08-05 21739, 2019

      • Freso
        iliekcomputers says:
      • 2019-08-05 21739, 2019

      • Freso
        """
      • 2019-08-05 21739, 2019

      • Freso
        I worked with alastairp to release new stuff for AB. We now have ratelimiting and http to https redirects. Other than that, created a dump to help out aidanlw17's project, but I'm waiting on access to bono to copy it over.
      • 2019-08-05 21739, 2019

      • Freso
        """
      • 2019-08-05 21739, 2019

      • Freso
        bitmap: Go!
      • 2019-08-05 21746, 2019

      • bitmap
        hey
      • 2019-08-05 21751, 2019

      • CatQuest
        hi!!
      • 2019-08-05 21724, 2019

      • bitmap
        at the start of the week I was fixing more small issues in the repmgr setup for postgres, and working on the `make test` setup for local testing