now I wish to add full information of entity, I am facing diffuculty on that Mr_Monkey
2019-08-19 23157, 2019
alastairp
e.g. urlunparse(('hdfs', 'hadoop-master:9000', os.path.join(path.DATAFRAME_DIR, 'filename')))
2019-08-19 23132, 2019
alastairp
but I don't think that this is clearer to understand. I think it would be fine to use os.path.join for the paths, and then join the url and path with +
2019-08-19 23138, 2019
Mr_Monkey
What's the issue?
2019-08-19 23108, 2019
alastairp
I think that each command that you run should create the directories that it needs before it runs
2019-08-19 23132, 2019
akhilesh
at `api/helpers/utils.js` I wish to load entity detail at line 67, but unable to pass orm from this place, means from the .map Mr_Monkey
2019-08-19 23100, 2019
pristine__
alastairp: you mean, before running any script I should create all the req directories in HDFS?
2019-08-19 23144, 2019
alastairp
if a command needs path.DATAFRAME_DIR, create it at the beginning of that command
2019-08-19 23128, 2019
alastairp
does the command to create a directory in hdfs fail if the directory already exists?
2019-08-19 23136, 2019
alastairp
does the operation take a long time, or is it quite quick?
2019-08-19 23115, 2019
Mr_Monkey
akhilesh: Do you need the ORM there? I think the `getEntityInfoMethod` parameter you call the
I created manage.py to create all the required directories in hdfs. There are three scripts, all of which need different directories, earlier I was creating these dir in the script itself. But then I thought of centralizing it so I made manage.py. not sure if it is a good idea. No, if the dir already exists, nothing is happening, it will create a new if it does not exit.
2019-08-19 23142, 2019
pristine__
The operation is quick. Not an overhead
2019-08-19 23109, 2019
Mr_Monkey
akhilesh: I think it's as simple as doing `entity: getEntityInfoMethod(relationship.target),` and same for relationship.source a few line slower
2019-08-19 23112, 2019
Mr_Monkey
Let me try it out
2019-08-19 23115, 2019
pristine__
Exist*
2019-08-19 23121, 2019
pristine__
alastairp: ^
2019-08-19 23153, 2019
akhilesh
pass orm also with loadEntity function Mr_Monkey
2019-08-19 23116, 2019
alastairp
if it's low overhead then I'd just do it every time
2019-08-19 23136, 2019
alastairp
because you don't want to have a situation where you run a 3 hour job and then it fails just because you forgot to run a different command first
2019-08-19 23103, 2019
pristine__
ruaok: ^
2019-08-19 23109, 2019
pristine__
Okay
2019-08-19 23112, 2019
akhilesh
`getEntityInfoMethod` does only formating of data, `relationship.target` does not have full data of entity Mr_Monkey
2019-08-19 23153, 2019
Mr_Monkey
akhilesh: Then you probably want to load more related data in `loadEntityRelationshipsForBrowse`
2019-08-19 23102, 2019
Mr_Monkey
I'll give it a quick try
2019-08-19 23130, 2019
pristine__
alastairp: one more thing. Since I am a beginner, I am not so good at writing beautiful code. These three scripts, it will great if you could just have a look and suggest me things. Like whenever you are free. I can create another gist for an overview.
2019-08-19 23133, 2019
akhilesh
that is also good option but how to load more data at `loadEntityRelationshipsForBrowse` Mr_Monkey , take a look on it and help please
2019-08-19 23132, 2019
pristine__
If you are okay with it.
2019-08-19 23134, 2019
pristine__
:)
2019-08-19 23104, 2019
akhilesh
`loadEntity` funtion also written at line 102, in middleware.js , help call this some how for each relationship Mr_Monkey , for source and target both
2019-08-19 23118, 2019
alastairp
yeah, that's fine. you're welcome to request a review from me on PRs
2019-08-19 23127, 2019
Darkloke has quit
2019-08-19 23159, 2019
pristine__
<3
2019-08-19 23153, 2019
chaban joined the channel
2019-08-19 23115, 2019
Mr_Monkey
akhilesh: Just pushed some code for browse relationships that should get you going. ORM passed to `getBrowsedRelationships` properly (from req.app.locals, not res.locals), and fetching the entities in the same method.
2019-08-19 23141, 2019
gr0uch0mars joined the channel
2019-08-19 23113, 2019
akhilesh
Yes, I am looking that code Mr_Monkey
2019-08-19 23124, 2019
Mr_Monkey
I'll be back in a bit
2019-08-19 23153, 2019
akhilesh
Going?
2019-08-19 23155, 2019
Mr_Monkey
Here but doing other things
2019-08-19 23153, 2019
rdswift joined the channel
2019-08-19 23154, 2019
akhilesh
Mr_Monkey: I have two more queries, free?
2019-08-19 23152, 2019
chaban has quit
2019-08-19 23133, 2019
amCap1712
hi gr0uch0mars
2019-08-19 23156, 2019
gr0uch0mars
Hi amCap1712
2019-08-19 23104, 2019
gr0uch0mars
How are u doing the last week?
2019-08-19 23124, 2019
amCap1712
doing well
2019-08-19 23140, 2019
amCap1712
most of the work on initial tagger is complete
2019-08-19 23113, 2019
amCap1712
gr0uch0mars: will most probably merge the pr today
2019-08-19 23120, 2019
gr0uch0mars
Glad to hear that!
2019-08-19 23135, 2019
amCap1712
i have released couple of updates for testing
2019-08-19 23153, 2019
amCap1712
CatQuest: has tested the tagger and i have refined some of it parts
2019-08-19 23110, 2019
CatQuest
sounds good!
2019-08-19 23113, 2019
gr0uch0mars
👏🏻
2019-08-19 23113, 2019
amCap1712
the metadata lookup is acting strangely will work on fixing it
2019-08-19 23126, 2019
amCap1712
hows your trip going?
2019-08-19 23142, 2019
amCap1712
also since the final evals open up later today
2019-08-19 23151, 2019
CatQuest
:o
2019-08-19 23158, 2019
amCap1712
i wanted to ask how should i submit my work?
2019-08-19 23125, 2019
amCap1712
gr0uch0mars: the work submission guidelines say i should discuss with the mentor on how to submit the work
2019-08-19 23139, 2019
amCap1712
a blog post, github readme or what?
2019-08-19 23147, 2019
CatQuest
gr0uch0mars: ping
2019-08-19 23144, 2019
Mr_Monkey
akhilesh: You're always encouraged to post the questions even if I'm not here, and I can answer when I'm free
2019-08-19 23154, 2019
gr0uch0mars
I think, reading the guidelines, that your Github repo is fine. Add a good README.md at the root so what has been done and what is left is clear to anyone.
Remember: the goal is not only to make it work, but to make a good Open Source code: write a good documentation, good code comments, what is left (in case anybody wants to collaborate)…
2019-08-19 23110, 2019
amCap1712
yeah sure
2019-08-19 23148, 2019
gr0uch0mars
amCap1712: I arrive at home this Saturday afternoon. Then I’ll make sure the code compiles and some basic testing
2019-08-19 23116, 2019
gr0uch0mars
Just to given you some (deserved) feedback on your work 🙂
2019-08-19 23125, 2019
amCap1712
that would be great
2019-08-19 23143, 2019
ruaok
Freso: sorry can't make the meeting. Limited connectivity, slightly tricky circumstances.
2019-08-19 23127, 2019
ruaok
My review: PRs. Background meb stuff. Conversations with Microsoft, not too much work. I hope to make it next week.
2019-08-19 23120, 2019
oknozor joined the channel
2019-08-19 23158, 2019
oknozor has quit
2019-08-19 23122, 2019
akhilesh
Mr_Monkey: Request validator written at middleware.js are not the exact validator, Those are only for basic use. First questions, what are the exact and valid URLs for browse request? how to validate query params passed in these requests like multiple bbid, any other unrelated params? What will be the response if invalid params? It is very helpful if you will explain one browse request and with one
2019-08-19 23122, 2019
akhilesh
browseRequestValidator function. You may respond on PR itself. Sorry for all the mistakes.
People up for reviews: yvanzo, ruaok, zas, Mr_Monkey, iliekcomputers, reosarevok, bitmap, Freso, akhilesh, spellew, pristine__, aidanlw17, Cyna, amCap1712, CatQuest – anyone else, please let me know explicitly ASAP.
2019-08-19 23131, 2019
Freso
yvanzo: Go!
2019-08-19 23131, 2019
Freso
yvanzo says:
2019-08-19 23131, 2019
Freso
"""
2019-08-19 23144, 2019
Freso
Last week, I continued to work on MB dockerization with new search.
2019-08-19 23144, 2019
Freso
Released and deployed a new SIR, fixing regressions only.
2019-08-19 23144, 2019
Freso
Started to test MB/SIR/SOLR in a new Azure VM.
2019-08-19 23144, 2019
Freso
Pushed a new branch for early testers of musicbrainz-docker: mbvm-38-dev
2019-08-19 23144, 2019
Freso
Also, MB Server has a new beta, getting back to the 2 weeks release cycle!
2019-08-19 23144, 2019
Freso
Plus PRs review and community support (incl. reupload of MB VM on FTP).
2019-08-19 23145, 2019
Freso
"""
2019-08-19 23145, 2019
Freso
ruaok: Go!
2019-08-19 23146, 2019
Freso
ruaok says:
2019-08-19 23146, 2019
Freso
"""
2019-08-19 23151, 2019
Freso
PRs. Background meb stuff. Conversations with Microsoft, not too much work. I hope to make it next week.
2019-08-19 23156, 2019
CatQuest
\o
2019-08-19 23158, 2019
Freso
"""
2019-08-19 23159, 2019
Freso
zas: Go!
2019-08-19 23104, 2019
zas
Hey
2019-08-19 23106, 2019
CatQuest
hi!
2019-08-19 23118, 2019
zas
Nothing fancy but usual stuff
2019-08-19 23137, 2019
zas
We had few network issues yesterday, but not under our control
2019-08-19 23106, 2019
zas
I upgraded grafana and all systems
2019-08-19 23125, 2019
zas
Also done quite a lot Picard code reviews (thanks to phw) :)
2019-08-19 23134, 2019
zas
fin. yvanzo ?
2019-08-19 23153, 2019
zas
Mr_Monkey ?
2019-08-19 23158, 2019
Mr_Monkey
Helo !
2019-08-19 23121, 2019
Mr_Monkey
Well, another slow and hot week, but I dutifully continued reviewing the API GSOC project. Glad to say it's moving along !
2019-08-19 23135, 2019
Mr_Monkey
Some minimal repo upkeep and dependency updates as well.
2019-08-19 23143, 2019
Mr_Monkey
That's all folks !
2019-08-19 23151, 2019
Mr_Monkey
CatQuest: go !
2019-08-19 23102, 2019
CatQuest
Meow! `😺`
2019-08-19 23109, 2019
CatQuest
Have worked quite a lot adding aliases and disambiguating glockenspiel(carillon in french) from carillon (glockenspiel/klokkespill in germanic languages) from music box (carillon(s) in italian) and chimes (general) from carillon (sometimes called chimes) from tubular bells (Orchestra bells/chimes in some slav languages) from finally back to glockenspiel again ( i.e. INST-809 & INST-825 (which is where this entire round-robin originally st
