#metabrainz

wb ruaok

ruaok: Time to go get lost in the Pyrinees instead? :D

Pyrenees, whatever

bitmap: did you manage to figure out anything about the weird CD stub arrays before your holiday?

metabrainz/picard#4870 (master - 79ac152 : Philipp Wolfer): The build passed.

Change view : https://github.com/metabrainz/picard/compare/b4...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

reosarevok: unfortunately not

If yvanzo gets his electricity back, maybe we can look into that on Wed?

okay, let's try (I can finish setting up the search stuff locally in the meantime)

ruaok: welcome back <3

Moin!

moooin!

"The local pole dance schools here just use Spotify"

Because I tried at some point, some friends are into it. I suck ass though, as expected

(no, it does not involve stripping nor nudity :p )

(which I'm sure everyone is thankful about)

[musicbrainz-server] reosarevok opened pull request #1187 (master…MBS-10337): MBS-10337: Load recording ISRCs and ratings on artist overview https://github.com/metabrainz/musicbrainz-serve...

MBS-10337: ISRCs and ratings not shown when artist overview consists of recordings only https://tickets.metabrainz.org/browse/MBS-10337

[musicbrainz-server] reosarevok opened pull request #1188 (master…MBS-10336): MBS-10336: Clarify disc#.track# cell in recording page https://github.com/metabrainz/musicbrainz-serve...

MBS-10336: Clarify disc.track on recording pages https://tickets.metabrainz.org/browse/MBS-10336

reosarevok: ( ͡° ͜ʖ ͡°)

Sigh :p

:D

Really, that shit is hardcore

You need to have super strong arms

yea i know. i read/saw soem documentary

there was this big woman who did it also, she was a bit fat but she must have been mad strong to be able to flex and lift herself up like that

s/strong/strong and fit

alastairp: ping

ruaok: hello

hiya. back from vacation yet?

doing review right now, thanks for the reminder, I already had it in my calendar

yeah, I was back last week

k, thanks.

I'm just not working hard to re-adjust. you never know how much you've disconnected until you need to reconnect.

you could always go on another holiday

I think that would kill me. :)

I suck at vacations. 200km+ of hiking/walking during this vacation.

some bad stuff happening in London at the moment: https://twitter.com/samuelpepys/status/11683436...

good. a lot of bad stuff needs to happen in London for that government to get tossed in the bin.

erhm

notsureif.png

hi!

hi!

yvanzo: wanna help with urlcleanup? :p

yay!

So, I dunno if you saw the Amazon Music tickets

Our current Amazon matching regex is this:

match: [new RegExp('^(https?://)?([^/]+\\.)?(amazon\\.(com|ca|co\\.uk|fr|at|de|it|co\\.jp|jp|cn|es|in|com\\.br|com\\.mx|com\\.au)|amzn\\.com)', 'i')],

I want to make it *not* match music.amazon

(which should be matched by a different cleanup, amazonmusic)

How do I do that? :)

(?!)

Is that a regex suggestion, or you being surprised? :D

is that a non-lookahead match token for regex, or an expression of surprise?

reosarevok: snap

:D

We have ([^/]+\\.)? now there which is catching "music."

How do I introduce the ?! in there, so that it's still matching everything else according to that regexp?

reosarevok: it's a suggestion :) try using negated lookahead (?!music) or negated look behind (?<!music)

reosarevok: e.g. ([^/]+(?<!music)\.)?

metabrainz/picard#4871 (master - 5c7a3b3 : Philipp Wolfer): The build passed.

Change view : https://github.com/metabrainz/picard/compare/79...

Build details : https://travis-ci.org/metabrainz/picard/builds/...

Ok

yvanzo:

What am I missing?

MBS-10331: Add new URL cleanup/autoselect/sidebar for Amazon Music URLs

reosarevok: syntactic error somewhere?

do you have more details available from tests log?

because your pastebin seems to refer to Uta-Net test https://github.com/metabrainz/musicbrainz-serve...

No, it's the new bit

Since it's streaming.*

reosarevok: should be music instead of www at https://github.com/reosarevok/musicbrainz-serve...

Oh god

I'm an idiot

Thanks!

alastairp: 4 hours left!

yvanzo: https://tickets.metabrainz.org/browse/MBS-10333

MBS-10333: Update Amazon URL cleanup

Do you remember how we changed from the obidos URL to the product one?

I assume we did change them all, since the report for bad Amazon URLs specifically searches for the gp/product structure

done, done!

I was just writing up the last stuff as you mentioned me

*phew*

yvanzo: I was thinking we should update to /dp/ but I'm not sure what to do with all the existing links

Final Evaluation, STATUS: Complete

Thanks ruaok, got the money pretty much as the same time as the "you got sent money" email

MBS-10331: Add new URL cleanup/autoselect/sidebar for Amazon Music URLs https://tickets.metabrainz.org/browse/MBS-10331

Impressive!

alastairp: thanks!

"Nice work! All MetaBrainz Foundation Inc evaluations are complete."

that gsoc is the in the bag!

\o/