#metabrainz

/

      • weirditude has quit
      • 2019-10-21 29423, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-10-21 29401, 2019

      • weirditude joined the channel
      • 2019-10-21 29438, 2019

      • weirditude has quit
      • 2019-10-21 29438, 2019

      • weirditude joined the channel
      • 2019-10-21 29415, 2019

      • sampsyo has quit
      • 2019-10-21 29437, 2019

      • sampsyo joined the channel
      • 2019-10-21 29419, 2019

      • weirditude has quit
      • 2019-10-21 29404, 2019

      • weirditude joined the channel
      • 2019-10-21 29433, 2019

      • BrainzGit
        [musicbrainz-server] mwiencek opened pull request #1244 (master…istanbul): JavaScript test coverage for Selenium https://github.com/metabrainz/musicbrainz-server/…
      • 2019-10-21 29400, 2019

      • weirditude
        Hello! proxy.listenbrainz.org is not usable still. Will it be fixed?
      • 2019-10-21 29431, 2019

      • chaban has quit
      • 2019-10-21 29421, 2019

      • chaban joined the channel
      • 2019-10-21 29412, 2019

      • weirditude has quit
      • 2019-10-21 29447, 2019

      • amCap1712
        Freso: +!
      • 2019-10-21 29449, 2019

      • amCap1712
        +1
      • 2019-10-21 29410, 2019

      • weirditude joined the channel
      • 2019-10-21 29436, 2019

      • pristine__
        Moin
      • 2019-10-21 29440, 2019

      • reosarevok
        SothoTalKer: back now, what did you want?
      • 2019-10-21 29455, 2019

      • BrainzGit
        [listenbrainz-labs] vansika merged pull request #54 (master…dataframe-metadata): Update model_metadata partially with create_dataframes https://github.com/metabrainz/listenbrainz-labs/p…
      • 2019-10-21 29415, 2019

      • antlarr joined the channel
      • 2019-10-21 29436, 2019

      • antlarr has quit
      • 2019-10-21 29458, 2019

      • antlarr joined the channel
      • 2019-10-21 29438, 2019

      • legoktm has quit
      • 2019-10-21 29459, 2019

      • legoktm joined the channel
      • 2019-10-21 29459, 2019

      • weirditu_ joined the channel
      • 2019-10-21 29408, 2019

      • weirditude has quit
      • 2019-10-21 29402, 2019

      • Gazooo has quit
      • 2019-10-21 29446, 2019

      • Gazooo joined the channel
      • 2019-10-21 29442, 2019

      • abhishekpanwar joined the channel
      • 2019-10-21 29424, 2019

      • reosarevok
        yvanzo: https://community.metabrainz.org/t/artist-release… does this seem like a solr-side bug?
      • 2019-10-21 29404, 2019

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #658 (master…dependabot/pip/psycopg2-binary-2.8.4): Bump psycopg2-binary from 2.8.3 to 2.8.4 https://github.com/metabrainz/listenbrainz-server…
      • 2019-10-21 29444, 2019

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #659 (master…dependabot/pip/flask-admin-1.5.4): Bump flask-admin from 1.5.3 to 1.5.4 https://github.com/metabrainz/listenbrainz-server…
      • 2019-10-21 29409, 2019

      • ferbncode
        There's now a specification being developed for a common way of describing events: https://cloudevents.io/ (Not sure if it becomes relevant in future for defined APIs)
      • 2019-10-21 29450, 2019

      • reosarevok
        ooh
      • 2019-10-21 29456, 2019

      • reosarevok
        I thought for a second it was about concert data :D
      • 2019-10-21 29403, 2019

      • ferbncode
        :D
      • 2019-10-21 29418, 2019

      • D4RK-PH0ENiX has quit
      • 2019-10-21 29450, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-10-21 29450, 2019

      • weirditude joined the channel
      • 2019-10-21 29458, 2019

      • D4RK-PH0ENiX has quit
      • 2019-10-21 29411, 2019

      • weirditu_ has quit
      • 2019-10-21 29407, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-10-21 29417, 2019

      • D4RK-PH0ENiX has quit
      • 2019-10-21 29428, 2019

      • D4RK-PH0ENiX joined the channel
      • 2019-10-21 29458, 2019

      • weirditu_ joined the channel
      • 2019-10-21 29447, 2019

      • weirditude has quit
      • 2019-10-21 29425, 2019

      • weirditude joined the channel
      • 2019-10-21 29414, 2019

      • weirditu_ has quit
      • 2019-10-21 29419, 2019

      • Mr_Monkey
        ruaok: When you find the time, could you have a look at proxy.LB status? Seems like it's been down over the weekend.
      • 2019-10-21 29409, 2019

      • weirditude has quit
      • 2019-10-21 29451, 2019

      • abhishekpanwar has quit
      • 2019-10-21 29446, 2019

      • bitmap
        yvanzo: hey, we're supposed to merge mommy shark stuff to beta today, are you planning to review more PRs?
      • 2019-10-21 29417, 2019

      • rdswift has quit
      • 2019-10-21 29450, 2019

      • yvanzo
        bitmap: yes
      • 2019-10-21 29442, 2019

      • bitmap
        ok, but for the future waiting until merge-day doesn't really give us time to address your feedback :\
      • 2019-10-21 29402, 2019

      • bitmap
        we could merge them later in the week if they're small I guess, but it would be nice for the bigger ones to have a full week of testing
      • 2019-10-21 29414, 2019

      • amCap1712
        ruaok, pristine: around?
      • 2019-10-21 29459, 2019

      • amCap1712
        i am sending the following request to listenbrainz server
      • 2019-10-21 29403, 2019

      • amCap1712
      • 2019-10-21 29444, 2019

      • amCap1712
        the response from server is
      • 2019-10-21 29449, 2019

      • iliekcomputers
        Hi amCap1712, what is the problem
      • 2019-10-21 29450, 2019

      • amCap1712
      • 2019-10-21 29419, 2019

      • amCap1712
        iliekcomputers: i don't know whether there is some issue with the request or what is the problem?
      • 2019-10-21 29433, 2019

      • iliekcomputers
        Looks like the json is ill formed
      • 2019-10-21 29448, 2019

      • amCap1712
        i pasted the wrong snippet here
      • 2019-10-21 29450, 2019

      • iliekcomputers
        I see two commas
      • 2019-10-21 29407, 2019

      • amCap1712
        those 2 commas are not present in the request i send
      • 2019-10-21 29412, 2019

      • yvanzo
        bitmap: sorry about that, I just tried to complete some tickets for PR, won't make it in-time either.
      • 2019-10-21 29432, 2019

      • bitmap
        no problem
      • 2019-10-21 29404, 2019

      • bitmap
        we should probably just use the meeting before the merge week a bit more to decide if the milestone is still feasible :)
      • 2019-10-21 29420, 2019

      • reosarevok
        I mean, we would have, we just didn't have one this week :)
      • 2019-10-21 29429, 2019

      • reosarevok
        (last week, whatevs)
      • 2019-10-21 29451, 2019

      • bitmap
        oh, right. the timing didn't work out
      • 2019-10-21 29432, 2019

      • reosarevok
      • 2019-10-21 29442, 2019

      • reosarevok
        Stuff that won't make it for sure into MS can already be moved there I guess
      • 2019-10-21 29413, 2019

      • amCap1712
        iliekcomputers: see this is the request i tried again with but the response ws sae
      • 2019-10-21 29424, 2019

      • amCap1712
      • 2019-10-21 29451, 2019

      • reosarevok
        yvanzo: up for quick checking stuff ATM if desired
      • 2019-10-21 29415, 2019

      • reosarevok
        bitmap: https://github.com/metabrainz/musicbrainz-server/… - please still put the ticket link in the description, because for some reason the PR title does *not* become a link
      • 2019-10-21 29431, 2019

      • rdswift joined the channel
      • 2019-10-21 29434, 2019

      • bitmap
        ahh sorry, will do
      • 2019-10-21 29440, 2019

      • bitmap
        how do you make headings in markdown again?
      • 2019-10-21 29450, 2019

      • yvanzo
        # head
      • 2019-10-21 29450, 2019

      • kahu joined the channel
      • 2019-10-21 29459, 2019

      • bitmap
        thx
      • 2019-10-21 29415, 2019

      • yvanzo
        and thanks to reference autolinks you can just write # MBS-XXXX now
      • 2019-10-21 29439, 2019

      • bitmap
        magic! thanks
      • 2019-10-21 29400, 2019

      • pristine__
        amCap1712:
      • 2019-10-21 29417, 2019

      • pristine__
      • 2019-10-21 29424, 2019

      • Cyna
        Meetings started ?
      • 2019-10-21 29426, 2019

      • pristine__
        Min payload req. May help
      • 2019-10-21 29437, 2019

      • pristine__
        amCap1712: ^
      • 2019-10-21 29413, 2019

      • Cyna
        bitmap: I'll have a look at both the PRs in an hour. See what bugs I introduced 🤔
      • 2019-10-21 29444, 2019

      • amCap1712
        pristine__: the request contains these parameters
      • 2019-10-21 29447, 2019

      • bitmap
        Cyna: don't worry, I force-pushed a commit to fix the ones I found
      • 2019-10-21 29406, 2019

      • pristine__
        They should be within track metadata I think
      • 2019-10-21 29422, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1233 (master…MBS-9468): MBS-9468: Missing check for remove rel edits in search https://github.com/metabrainz/musicbrainz-server/…
      • 2019-10-21 29423, 2019

      • BrainzBot
        MBS-9468: Edit search finds no "remove (download for free) relationship" edits https://tickets.metabrainz.org/browse/MBS-9468
      • 2019-10-21 29434, 2019

      • bitmap
        in the alias PR at least (you can click on the force-push link there to see the changes I made)
      • 2019-10-21 29448, 2019

      • pristine__
        amCap1712: I mean the artist and track name should be a value of track metadata as key
      • 2019-10-21 29455, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1235 (master…MBS-10408): MBS-10408: Stop AC edits_pending overwriting artist one https://github.com/metabrainz/musicbrainz-server/…
      • 2019-10-21 29456, 2019

      • BrainzBot
        MBS-10408: Artists are not marked as pending in that recording merge edit https://tickets.metabrainz.org/browse/MBS-10408
      • 2019-10-21 29424, 2019

      • CatQuest
        mommy shark duttdu du du duttdu
      • 2019-10-21 29438, 2019

      • reosarevok
        Exactly
      • 2019-10-21 29453, 2019

      • ruaok returns home and hears stories of riots
      • 2019-10-21 29415, 2019

      • CatQuest
        hi reosarevok
      • 2019-10-21 29427, 2019

      • pristine__
        amCap1712: worked?
      • 2019-10-21 29428, 2019

      • reosarevok
        hi CatQuest
      • 2019-10-21 29437, 2019

      • pristine__
        Hi ruaok CatQuest reosarevok
      • 2019-10-21 29429, 2019

      • CatQuest
        can you look over the descriptions on https://beta.musicbrainz.org/instrument/9b3d2812-… and linked isntruments so that there arent any dumb mistakes (I'm making thme fast ;O)
      • 2019-10-21 29450, 2019

      • CatQuest
        hi pristine__
      • 2019-10-21 29412, 2019

      • reosarevok
        CatQuest: kendang itself has "Used in many Southeast Asian countries besides" - do you mean besides Indonesia or?
      • 2019-10-21 29421, 2019

      • CatQuest
        i guess?
      • 2019-10-21 29437, 2019

      • CatQuest
        first paragraph here i guess somehow condensed https://en.wikipedia.org/wiki/Kendang
      • 2019-10-21 29402, 2019

      • ruaok waves
      • 2019-10-21 29457, 2019

      • amCap1712
        pristine__: trying it
      • 2019-10-21 29437, 2019

      • yvanzo
        reosarevok: just reviewed last bug-fixing PR <3
      • 2019-10-21 29407, 2019

      • reosarevok
        yvanzo, bitmap: actually the last comment by yvanzo on https://github.com/metabrainz/musicbrainz-server/… made me think that maybe I should still check for release_country.country in is_empty. It's indeed irrelevant for can_delete, but it might not be irrelevant if we eventually want to check if something is just, well, empty :/
      • 2019-10-21 29410, 2019

      • amCap1712
        pristine__:
      • 2019-10-21 29417, 2019

      • Cyna
        could you tell me what bugs were there ?
      • 2019-10-21 29418, 2019

      • amCap1712
        does not work still
      • 2019-10-21 29420, 2019

      • amCap1712
        {"listen_type":"single","payload":[{"listened_at": 1571676033, "track_metadata": {"artist_name": "Mankirt%20Aulakh%20", "track_name": "Kaka%20Ji%20", "release_name": "Kaka%20Ji%20"}}]}
      • 2019-10-21 29427, 2019

      • Cyna
        bitmap: ^
      • 2019-10-21 29431, 2019

      • CatQuest
        Freso: I cna go last/late in the meeting
      • 2019-10-21 29449, 2019

      • amCap1712
      • 2019-10-21 29453, 2019

      • yvanzo
        reosarevok: depends on how is_empty is used but yes.
      • 2019-10-21 29419, 2019

      • bitmap
        Cyna: you removed `method edit_kind` from Edit::Alias::Add and there were a couple places where possibly-null values were being dereferenced
      • 2019-10-21 29456, 2019

      • reosarevok
        yvanzo: well, right now it's only used there :)
      • 2019-10-21 29413, 2019

      • reosarevok
        But it just feels that without that, it's not really answering whether is_empty :)
      • 2019-10-21 29426, 2019

      • bitmap
        and you hard-coded add-${entityType}-alias in the table class name instead of using the edit_kind there
      • 2019-10-21 29427, 2019

      • Cyna
        huh ? I guess I put it there. damn diff. I didnt have a look at that
      • 2019-10-21 29456, 2019

      • Cyna
        nvm I'll check the diff better from now
      • 2019-10-21 29437, 2019

      • pristine__
        amCap1712: Can you paste the error
      • 2019-10-21 29443, 2019

      • pristine__
        The Json looks good to me
      • 2019-10-21 29456, 2019

      • amCap1712
        pristine__:
      • 2019-10-21 29400, 2019

      • amCap1712
      • 2019-10-21 29404, 2019

      • yvanzo
        reosarevok: I don’t think it’s useful to add unnecessary checks, just rename to is_empty_but_country (or smt that makes more sense to human).
      • 2019-10-21 29431, 2019

      • Freso
        <BANG>
      • 2019-10-21 29431, 2019

      • Freso
        It’s Monday!
      • 2019-10-21 29431, 2019

      • Freso
        (Have been too tired to be able to look up what day it is today and to find a matching song.)
      • 2019-10-21 29431, 2019

      • Freso
        People up for reviews: zas, Mr_Monkey, pristine__, bitmap, Freso, iliekcomputers, yvanzo, reosarevok, ruaok, aidanlw17, Cyna, CatQuest – anyone else who would like to give a review, please let me know (explicitly) ASAP.
      • 2019-10-21 29431, 2019

      • Freso
        zas: Go!
      • 2019-10-21 29439, 2019

      • Freso
        zas says…
      • 2019-10-21 29439, 2019

      • Freso
        """
      • 2019-10-21 29439, 2019

      • Freso
        - usual supervision, maintenance, upgrades
      • 2019-10-21 29439, 2019

      • Freso
        - Picard PRs reviews
      • 2019-10-21 29439, 2019

      • Freso
        - read KeyDB (redis replacement) full documentation, and did local tests
      • 2019-10-21 29440, 2019

      • Freso
        - deployed 2 KeyDB containers (active replication) on cage for testing purposes, used by test.mb.o
      • 2019-10-21 29440, 2019

      • Freso
        - started to work on a fully redundant with failover setup for KeyDB, based on haproxy and keepalived along Hetzner failover IP (more or less similar to what we have in front of solr cloud)