#metabrainz

[musicbrainz-server] mwiencek opened pull request #1244 (master…istanbul): JavaScript test coverage for Selenium https://github.com/metabrainz/musicbrainz-serve...

Hello! proxy.listenbrainz.org is not usable still. Will it be fixed?

Freso: +!

+1

Moin

SothoTalKer: back now, what did you want?

[listenbrainz-labs] vansika merged pull request #54 (master…dataframe-metadata): Update model_metadata partially with create_dataframes https://github.com/metabrainz/listenbrainz-labs...

yvanzo: https://community.metabrainz.org/t/artist-relea... does this seem like a solr-side bug?

[listenbrainz-server] dependabot-preview[bot] opened pull request #658 (master…dependabot/pip/psycopg2-binary-2.8.4): Bump psycopg2-binary from 2.8.3 to 2.8.4 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] dependabot-preview[bot] opened pull request #659 (master…dependabot/pip/flask-admin-1.5.4): Bump flask-admin from 1.5.3 to 1.5.4 https://github.com/metabrainz/listenbrainz-serv...

There's now a specification being developed for a common way of describing events: https://cloudevents.io/ (Not sure if it becomes relevant in future for defined APIs)

ooh

I thought for a second it was about concert data :D

:D

ruaok: When you find the time, could you have a look at proxy.LB status? Seems like it's been down over the weekend.

yvanzo: hey, we're supposed to merge mommy shark stuff to beta today, are you planning to review more PRs?

bitmap: yes

ok, but for the future waiting until merge-day doesn't really give us time to address your feedback :\

ruaok, pristine: around?

i am sending the following request to listenbrainz server

the response from server is

Hi amCap1712, what is the problem

iliekcomputers: i don't know whether there is some issue with the request or what is the problem?

Looks like the json is ill formed

i pasted the wrong snippet here

I see two commas

those 2 commas are not present in the request i send

bitmap: sorry about that, I just tried to complete some tickets for PR, won't make it in-time either.

no problem

we should probably just use the meeting before the merge week a bit more to decide if the milestone is still feasible :)

I mean, we would have, we just didn't have one this week :)

(last week, whatevs)

oh, right. the timing didn't work out

I created https://github.com/metabrainz/musicbrainz-serve...

Stuff that won't make it for sure into MS can already be moved there I guess

iliekcomputers: see this is the request i tried again with but the response ws sae

yvanzo: up for quick checking stuff ATM if desired

bitmap: https://github.com/metabrainz/musicbrainz-serve... - please still put the ticket link in the description, because for some reason the PR title does *not* become a link

ahh sorry, will do

how do you make headings in markdown again?

# head

thx

and thanks to reference autolinks you can just write # MBS-XXXX now

magic! thanks

amCap1712:

Meetings started ?

Min payload req. May help

amCap1712: ^

bitmap: I'll have a look at both the PRs in an hour. See what bugs I introduced 🤔

pristine__: the request contains these parameters

Cyna: don't worry, I force-pushed a commit to fix the ones I found

They should be within track metadata I think

[musicbrainz-server] reosarevok merged pull request #1233 (master…MBS-9468): MBS-9468: Missing check for remove rel edits in search https://github.com/metabrainz/musicbrainz-serve...

MBS-9468: Edit search finds no "remove (download for free) relationship" edits https://tickets.metabrainz.org/browse/MBS-9468

in the alias PR at least (you can click on the force-push link there to see the changes I made)

amCap1712: I mean the artist and track name should be a value of track metadata as key

[musicbrainz-server] reosarevok merged pull request #1235 (master…MBS-10408): MBS-10408: Stop AC edits_pending overwriting artist one https://github.com/metabrainz/musicbrainz-serve...

MBS-10408: Artists are not marked as pending in that recording merge edit https://tickets.metabrainz.org/browse/MBS-10408

mommy shark duttdu du du duttdu

Exactly

hi reosarevok

amCap1712: worked?

hi CatQuest

Hi ruaok CatQuest reosarevok

can you look over the descriptions on https://beta.musicbrainz.org/instrument/9b3d281... and linked isntruments so that there arent any dumb mistakes (I'm making thme fast ;O)

hi pristine__

CatQuest: kendang itself has "Used in many Southeast Asian countries besides" - do you mean besides Indonesia or?

i guess?

first paragraph here i guess somehow condensed https://en.wikipedia.org/wiki/Kendang

pristine__: trying it

reosarevok: just reviewed last bug-fixing PR <3

yvanzo, bitmap: actually the last comment by yvanzo on https://github.com/metabrainz/musicbrainz-serve... made me think that maybe I should still check for release_country.country in is_empty. It's indeed irrelevant for can_delete, but it might not be irrelevant if we eventually want to check if something is just, well, empty :/

pristine__:

could you tell me what bugs were there ?

does not work still

{"listen_type":"single","payload":[{"listened_at": 1571676033, "track_metadata": {"artist_name": "Mankirt%20Aulakh%20", "track_name": "Kaka%20Ji%20", "release_name": "Kaka%20Ji%20"}}]}

bitmap: ^

Freso: I cna go last/late in the meeting

pristine__: https://www.irccloud.com/pastebin/4Y4VqVaP/

reosarevok: depends on how is_empty is used but yes.

Cyna: you removed `method edit_kind` from Edit::Alias::Add and there were a couple places where possibly-null values were being dereferenced

yvanzo: well, right now it's only used there :)

But it just feels that without that, it's not really answering whether is_empty :)

and you hard-coded add-${entityType}-alias in the table class name instead of using the edit_kind there

huh ? I guess I put it there. damn diff. I didnt have a look at that

nvm I'll check the diff better from now

amCap1712: Can you paste the error

The Json looks good to me

pristine__:

reosarevok: I don’t think it’s useful to add unnecessary checks, just rename to is_empty_but_country (or smt that makes more sense to human).

<BANG>

It’s Monday!

(Have been too tired to be able to look up what day it is today and to find a matching song.)

People up for reviews: zas, Mr_Monkey, pristine__, bitmap, Freso, iliekcomputers, yvanzo, reosarevok, ruaok, aidanlw17, Cyna, CatQuest – anyone else who would like to give a review, please let me know (explicitly) ASAP.

zas: Go!

zas says…

"""

- usual supervision, maintenance, upgrades

- Picard PRs reviews

- read KeyDB (redis replacement) full documentation, and did local tests

- deployed 2 KeyDB containers (active replication) on cage for testing purposes, used by test.mb.o

- started to work on a fully redundant with failover setup for KeyDB, based on haproxy and keepalived along Hetzner failover IP (more or less similar to what we have in front of solr cloud)