There's been a lot of work on dates generally, so small issues found themselves part of a longer testing/release cycle
2019-11-18 32200, 2019
D4RK-PH0ENiX has quit
2019-11-18 32217, 2019
pristine__
ruaok: moin
2019-11-18 32223, 2019
ruaok
moin!
2019-11-18 32249, 2019
pristine__
> so, given that you have data that has an array of mbids, it needs to be matched an artist_credit. this avoids the explosion problem.
2019-11-18 32202, 2019
pristine__
I am still not sure how to do it. Can you give a lil example about what is there in your mind, I mean any pseudo query involving ar-ar JSON and ar-credit JSON?
2019-11-18 32211, 2019
ruaok
here is what I am going to do to make this easier...
2019-11-18 32232, 2019
BestSteve has quit
2019-11-18 32236, 2019
ruaok
I'm going to have the MSID mapping output artist_credit_is, instead of an array of artist MBIDs.
2019-11-18 32242, 2019
ruaok
_id
2019-11-18 32254, 2019
ruaok
that should make this change trivial for you, yes?
2019-11-18 32254, 2019
BestSteve joined the channel
2019-11-18 32206, 2019
D4RK-PH0ENiX joined the channel
2019-11-18 32227, 2019
D4RK-PH0ENiX has quit
2019-11-18 32235, 2019
D4RK-PH0ENiX joined the channel
2019-11-18 32252, 2019
pristine__
ruaok: so I match the artist_credit_ids to get artist_names from artist_credit_relation? Can you make a gist a with a sample table of a few rows ( like I posted one before with A,B,C) so that we better understand everything and know what suits us best before you start on modifying mapping or stuff? So in particular a gist of MSID mapping output artist_credit_id with correct col names but random col values, I can then just
2019-11-18 32252, 2019
pristine__
perform joins and stuff on that gist and inference results so that in order to make things better we don't miss out on some points and land on the point from where we started.
2019-11-18 32212, 2019
pristine__
Also, you have been putting in so much time so let's just be sure.
2019-11-18 32220, 2019
thomasross has quit
2019-11-18 32246, 2019
thomasross joined the channel
2019-11-18 32235, 2019
ruaok
ok, i'll get you something in the course of the day.
pristine__: honestly, I can't even follow your comments right now.
2019-11-18 32205, 2019
pristine__
:(
2019-11-18 32238, 2019
pristine__
I wish I could explain you face to face with pen and paper. Okay give me some time
2019-11-18 32241, 2019
ruaok
what is more important? the artist_credit mapping stuff or providing feedback on this PR?
2019-11-18 32203, 2019
pristine__
I will prepare a gist with tables and every step
2019-11-18 32204, 2019
pristine__
former
2019-11-18 32216, 2019
ruaok
no, please don't.
2019-11-18 32223, 2019
pristine__
Okay.
2019-11-18 32225, 2019
abhishekpanwar
Mr_Monkey: Do you have a minute to talk?
2019-11-18 32225, 2019
ruaok
I just want to ask you questions.
2019-11-18 32232, 2019
Mr_Monkey
abhishekpanwar: I do !
2019-11-18 32235, 2019
ruaok
but first, what should I focus on first?
2019-11-18 32236, 2019
pristine__
cool. Sounds good
2019-11-18 32243, 2019
ruaok
PR or ac question?
2019-11-18 32255, 2019
pristine__
artist_credit IMO
2019-11-18 32200, 2019
ruaok
ok.
2019-11-18 32201, 2019
abhishekpanwar
Yeah So I think there is something wrong in hosts used in the config
2019-11-18 32205, 2019
pristine__
:)
2019-11-18 32229, 2019
abhishekpanwar
Like when I do what is mentioned in the new debug docs then debugging works fine but normal develop.sh dont
2019-11-18 32255, 2019
abhishekpanwar
But If I follow normal setup procedure then debug doesnt work but develop.sh works
2019-11-18 32216, 2019
abhishekpanwar
Regarding elasticsearch
2019-11-18 32224, 2019
abhishekpanwar
I think the hosts are not matching
2019-11-18 32241, 2019
abhishekpanwar
Somewhere elasticsearch:9200 is usedand somewhere localhist:9200
2019-11-18 32248, 2019
abhishekpanwar
*localhost
2019-11-18 32202, 2019
abhishekpanwar
Do you think there is a chance of some descrepancy?
2019-11-18 32249, 2019
abhishekpanwar
I dont think this issue is only specific to me
2019-11-18 32251, 2019
Mr_Monkey
Right. So if you're using develop.sh, everything is run using Docker, so the hostnames in the config should be the same as the docker container names (defined in docker-compose.yml).
2019-11-18 32251, 2019
Mr_Monkey
If you're running the server locally with node, or through vscode, then you need to modify the config to point to `localhost` instead of the container names, which won't mean anything in that case.
2019-11-18 32251, 2019
Mr_Monkey
Does that clarify things for you?
2019-11-18 32218, 2019
abhishekpanwar
So we can make them the same so we dont have to switch the config file everytime we debug or develop?
2019-11-18 32219, 2019
Mr_Monkey
So depending on which way you run the server, you'll need to change the config accordingly
2019-11-18 32244, 2019
Mr_Monkey
I'm afraid we cannot make them the same
2019-11-18 32209, 2019
Mr_Monkey
But I sure can try to document it better
2019-11-18 32246, 2019
abhishekpanwar
I guess if someone has basics of docker clear, might be able to understand it. Ill look into docker I guess.
2019-11-18 32251, 2019
abhishekpanwar
Thanks
2019-11-18 32219, 2019
sbvkrishna
If you want, you can create two configurations and just switch the file names depending on debug or develop
2019-11-18 32241, 2019
abhishekpanwar
Yeah, good idea. Will do this only.
2019-11-18 32219, 2019
Mr_Monkey
That's also what I do, but I agree it's cumbersome. I'll think of a way to start the server and pass a config file path to load. Ideally, develop.sh would work the same as today, and you'll also be able to run, say `npm start --config ./config/config.local.json`
2019-11-18 32200, 2019
abhishekpanwar
Yes, would be great if it was an option
2019-11-18 32230, 2019
sbvkrishna
To make it more clear for you, assuming all dependencies are running in docker. If you run 'develop.sh', server will run inside docker, thus to connect to other docker instances (dependencies), we need to tell it their 'names'. If we run the server locally, it's outside of docker, and it doesn't understand those 'docker names' we have given before, so we pass the location they are running (localost with port)
I was curious to know that when schema of MusicBrainz, LB and other projects was built how did the developers interacted with each other to arrive on a sol and make each other understand there thought process? I mean was/is there a dedicated platform? might help.
2019-11-18 32244, 2019
Pac23 joined the channel
2019-11-18 32245, 2019
abhishekpanwar
Good, It would make the development process easier.
2019-11-18 32252, 2019
iliekcomputers
IRC?
2019-11-18 32241, 2019
pristine__
:(
2019-11-18 32201, 2019
ruaok
well, the MB schema was far more than that.
2019-11-18 32205, 2019
pristine__
then I don't know how to explain :(
2019-11-18 32220, 2019
ruaok
5 years of planning and 3 separate in person summits focused on the new schema.
