bitmap: I just found out that login code is not working at the moment just because musicbrainz_db is not yet created
2020-01-19 01927, 2020
Cyna
The code should have use musicbrainz_selenium instead right ?
2020-01-19 01950, 2020
Cyna
That is probably the reason I was facing the user exist even thought I reset the databases except musicbrainz_db. Let me know how do I make plackup use musicbrainz_selenium instead of musicbrainz_db
2020-01-19 01904, 2020
bitmap
yes... do you have sub USE_SET_DATABASE_HEADER { 1 } in DBDefs.pm?
2020-01-19 01911, 2020
Cyna
Yes
2020-01-19 01940, 2020
bitmap
how did you determine it's using musicbrainz_db?
2020-01-19 01935, 2020
Cyna
When I ran the test with plackup working... It ran the first test which when clicked on signup and gave the following error
oh! chrome broke something recently where they don't send localhost requests through any configured proxy anymore
2020-01-19 01947, 2020
bitmap
it works for me since I just started using a host alias for localhost with plackup etc.
2020-01-19 01959, 2020
bitmap
I'm trying to see if I can get this proxy-bypass-list option working on the spawned chrome instance
2020-01-19 01959, 2020
Cyna
ohh
2020-01-19 01926, 2020
rahul24 joined the channel
2020-01-19 01936, 2020
rahul24 has quit
2020-01-19 01915, 2020
shivam-kapila joined the channel
2020-01-19 01924, 2020
c1e0 joined the channel
2020-01-19 01901, 2020
bitmap
anyway in the meantime you can get it working by adding something like `127.0.0.1 mycoolpc` to /etc/hosts and starting plackup with --host mycoolpc or whatever hostname you use
2020-01-19 01951, 2020
bitmap
replace localhost:5000 with that hostname in DBDefs.pm too
2020-01-19 01942, 2020
bitmap
proxy-bypass-list doesn't want to work here so I'm trying to come up with a better solution
2020-01-19 01927, 2020
Cyna
ohh I'll try making the change
2020-01-19 01936, 2020
yvanzo
hi Cyna: which “performance issues” did you experience?
2020-01-19 01907, 2020
Cyna
Latency on each requests
2020-01-19 01928, 2020
Cyna
I used containers... Not the current mb-docker support
2020-01-19 01913, 2020
iliekcomputers
ruaok: we should seriously consider merging labs and listenbrainz. the fact that we have to open two different pull requests in two different repos to build any actual feature is a PITA.
2020-01-19 01927, 2020
Gazooo has quit
2020-01-19 01922, 2020
Gazooo joined the channel
2020-01-19 01943, 2020
BrainzGit
[listenbrainz-server] paramsingh opened pull request #691 (master…param/merge-labs-into-listenbrainz): [wip] Merge listenbrainz-labs into listenbrainz https://github.com/metabrainz/listenbrainz-server…
MBS-10572: Pages that display release events trigger an error when a non-English UI language is selected: "Domain `countries` was not found." https://tickets.metabrainz.org/browse/MBS-10572
2020-01-19 01923, 2020
Cyna
bitmap: using a different name worked
2020-01-19 01906, 2020
Cyna
running selenium test suite is seriously a joke :(
i am in total favour of merging this and archiving labs, it is annoying to have to change code in two different repositories and get two pull requests reviewed for what is almost always one piece of work.
2020-01-19 01956, 2020
iliekcomputers
surprised that labs is only around 4.4k LOC
2020-01-19 01901, 2020
Nyanko-sensei has quit
2020-01-19 01901, 2020
shivam-kapila has quit
2020-01-19 01932, 2020
sumedh has quit
2020-01-19 01943, 2020
c1e0 has quit
2020-01-19 01944, 2020
cleo joined the channel
2020-01-19 01920, 2020
cleo is now known as Guest34712
2020-01-19 01954, 2020
Nyanko-sensei joined the channel
2020-01-19 01956, 2020
shivam-kapila joined the channel
2020-01-19 01905, 2020
ruaok
iliekcomputers: ok, let's do it.
2020-01-19 01901, 2020
iliekcomputers
🥳🥳
2020-01-19 01948, 2020
CODEin_JDB joined the channel
2020-01-19 01949, 2020
iliekcomputers
all of the code in the PR is from labs and is code reviewed. this is the commit that fixes tests and seperates the manage.py files for spark and server (https://github.com/metabrainz/listenbrainz-server…)
2020-01-19 01926, 2020
CODEin_JDB
Hey CatQuest can i make a whole new family tree about sri lankan intruments.
> <iliekcomputers> We'd have to add labs as a remote and merge the branch in progress to master:
2020-01-19 01909, 2020
ruaok
duh. forgetting how git works, lol.
2020-01-19 01909, 2020
iliekcomputers
sure, let's wait for pristine__.
2020-01-19 01915, 2020
ruaok approves the PR
2020-01-19 01933, 2020
ruaok
since its all previously reviewed code, I'm good with it.
2020-01-19 01959, 2020
iliekcomputers
👍🏽
2020-01-19 01942, 2020
pristine__
Hey. So the I think that all-changes-mapping and master diverge. We may have merge conflicts and test fails after merging it into master. Otherwise it is to merge
2020-01-19 01952, 2020
pristine__
fine*
2020-01-19 01910, 2020
iliekcomputers
pristine__: i'll fix the merge conflicts after merging this.
2020-01-19 01939, 2020
pristine__
Cool
2020-01-19 01902, 2020
iliekcomputers
pristine__: ok to merge?
2020-01-19 01953, 2020
iliekcomputers
thanks for the reviews on a weekend, pristine__ and ruaok :)
