#metabrainz

^^

Lotheric: just sign up to the apple partner program and you can get access to the apple music feed ;)

another way for metabrainz to make money =D https://affiliate.itunes.apple.com/resources/do...

Hi iliekcomputers. Are we talking of something like this ? https://github.com/metabrainz/listenbrainz-serv...

[musicbrainz-server] mwiencek opened pull request #1358 (master…mbs-10571): MBS-10571: Fix "localized" ModBot email display https://github.com/metabrainz/musicbrainz-serve...

MBS-10571: Localized modbot notes are not properly formatted when sent via email https://tickets.metabrainz.org/browse/MBS-10571

bitmap: I just found out that login code is not working at the moment just because musicbrainz_db is not yet created

The code should have use musicbrainz_selenium instead right ?

That is probably the reason I was facing the user exist even thought I reset the databases except musicbrainz_db. Let me know how do I make plackup use musicbrainz_selenium instead of musicbrainz_db

yes... do you have sub USE_SET_DATABASE_HEADER { 1 } in DBDefs.pm?

Yes

how did you determine it's using musicbrainz_db?

When I ran the test with plackup working... It ran the first test which when clicked on signup and gave the following error

I'm not sure I understand how the user can exist if "musicbrainz_db is not yet created"

and plus it should be using the musicbrainz_selenium database instead

right

are you using docker or?

Nope

I'm using everything locally on mac

Docker had some performance issues

can you paste your lib/DBDefs.pm somewhere?

Sure

thanks

oh! chrome broke something recently where they don't send localhost requests through any configured proxy anymore

it works for me since I just started using a host alias for localhost with plackup etc.

I'm trying to see if I can get this proxy-bypass-list option working on the spawned chrome instance

ohh

anyway in the meantime you can get it working by adding something like `127.0.0.1 mycoolpc` to /etc/hosts and starting plackup with --host mycoolpc or whatever hostname you use

replace localhost:5000 with that hostname in DBDefs.pm too

proxy-bypass-list doesn't want to work here so I'm trying to come up with a better solution

ohh I'll try making the change

hi Cyna: which “performance issues” did you experience?

Latency on each requests

I used containers... Not the current mb-docker support

ruaok: we should seriously consider merging labs and listenbrainz. the fact that we have to open two different pull requests in two different repos to build any actual feature is a PITA.

[listenbrainz-server] paramsingh opened pull request #691 (master…param/merge-labs-into-listenbrainz): [wip] Merge listenbrainz-labs into listenbrainz https://github.com/metabrainz/listenbrainz-serv...

[musicbrainz-server] mwiencek opened pull request #1359 (master…mbs-10572): Fix MBS-10572: Have one Jed bundle per language https://github.com/metabrainz/musicbrainz-serve...

MBS-10572: Pages that display release events trigger an error when a non-English UI language is selected: "Domain `countries` was not found." https://tickets.metabrainz.org/browse/MBS-10572

bitmap: using a different name worked

running selenium test suite is seriously a joke :(

How does it even work with the CI

ruaok: pristine__: https://github.com/metabrainz/listenbrainz-serv...

i am in total favour of merging this and archiving labs, it is annoying to have to change code in two different repositories and get two pull requests reviewed for what is almost always one piece of work.

surprised that labs is only around 4.4k LOC

iliekcomputers: ok, let's do it.

🥳🥳

all of the code in the PR is from labs and is code reviewed. this is the commit that fixes tests and seperates the manage.py files for spark and server (https://github.com/metabrainz/listenbrainz-serv...)

Hey CatQuest can i make a whole new family tree about sri lankan intruments.

lol i literally just asnwered that on the task :D

literally

check time mark

ok and answer is https://codein.withgoogle.com/dashboard/task-in...

eh

CODEin_JDB: You definitely can! That would be very cool :D

Oh okay

I look forward to that :)

Thank you

:D

iliekcomputers: cool -- how do we merge branches are in progress right now?

We'd have to add labs as a remote and merge the branch in progress to master: https://stackoverflow.com/questions/1425892/how...

I can move all current branches to server for now

(once the big merge pr is in master)

https://github.com/metabrainz/listenbrainz-labs... seems the only one that's relevant and not stale

shall we consult pristine__ before we merge this?

> <iliekcomputers> We'd have to add labs as a remote and merge the branch in progress to master:

duh. forgetting how git works, lol.

sure, let's wait for pristine__.

since its all previously reviewed code, I'm good with it.

👍🏽

Hey. So the I think that all-changes-mapping and master diverge. We may have merge conflicts and test fails after merging it into master. Otherwise it is to merge

fine*

pristine__: i'll fix the merge conflicts after merging this.

Cool

pristine__: ok to merge?

thanks for the reviews on a weekend, pristine__ and ruaok :)

[listenbrainz-server] paramsingh merged pull request #691 (master…param/merge-labs-into-listenbrainz): Merge listenbrainz-labs into listenbrainz-server https://github.com/metabrainz/listenbrainz-serv...

thanks for hacking. pristine__: I'll keep reviewing your PR later today.

No problem. I am away the next week.

Take your time :)

pristine__: looks like all-changes-mapping has conflicts with the labs master

I don't have any context with these conflicts.

if you can rebase all-changes-mapping over master once, it would make the merge to listenbrainz-server much easier

So I rebase make changes and push to all-changes-mapping right?

yes, in labs.

I see conflict on in manage.py and docker-compose.test

which master are you rebasing on?

I tried rebasing on the labs master and got conflicts in these files:

Labs?

A sec

I merged master into all-changes-mapping :(

[listenbrainz-labs] paramsingh opened pull request #81 (master…all-changes-mapping): [wip] All changes mapping https://github.com/metabrainz/listenbrainz-labs...