#metabrainz

/

      • rahul24_ joined the channel
      • 2020-01-19 01929, 2020

      • rahul24 has quit
      • 2020-01-19 01929, 2020

      • rahul24_ is now known as rahul24
      • 2020-01-19 01938, 2020

      • rahul24_ joined the channel
      • 2020-01-19 01914, 2020

      • rahul24 has quit
      • 2020-01-19 01915, 2020

      • rahul24_ is now known as rahul24
      • 2020-01-19 01955, 2020

      • Lotheric
      • 2020-01-19 01956, 2020

      • Lotheric
        ^^
      • 2020-01-19 01917, 2020

      • MajorLurker joined the channel
      • 2020-01-19 01951, 2020

      • SothoTalKer
        Lotheric: just sign up to the apple partner program and you can get access to the apple music feed ;)
      • 2020-01-19 01937, 2020

      • SothoTalKer
        another way for metabrainz to make money =D https://affiliate.itunes.apple.com/resources/docu…
      • 2020-01-19 01945, 2020

      • Gore|woerk joined the channel
      • 2020-01-19 01935, 2020

      • Gore has quit
      • 2020-01-19 01926, 2020

      • rdswift_lt has quit
      • 2020-01-19 01914, 2020

      • sumedh joined the channel
      • 2020-01-19 01913, 2020

      • rahul24 has quit
      • 2020-01-19 01943, 2020

      • rahul24 joined the channel
      • 2020-01-19 01928, 2020

      • sarthak_jain joined the channel
      • 2020-01-19 01959, 2020

      • sarthak_jain
        Hi iliekcomputers. Are we talking of something like this ? https://github.com/metabrainz/listenbrainz-server…
      • 2020-01-19 01934, 2020

      • Gazooo joined the channel
      • 2020-01-19 01958, 2020

      • Nyanko-sensei has quit
      • 2020-01-19 01943, 2020

      • antara joined the channel
      • 2020-01-19 01922, 2020

      • Nyanko-sensei joined the channel
      • 2020-01-19 01939, 2020

      • Nyanko-sensei has quit
      • 2020-01-19 01916, 2020

      • Nyanko-sensei joined the channel
      • 2020-01-19 01903, 2020

      • Nyanko-sensei has quit
      • 2020-01-19 01918, 2020

      • Nyanko-sensei joined the channel
      • 2020-01-19 01921, 2020

      • sarthak_jain has quit
      • 2020-01-19 01956, 2020

      • rahul24_ joined the channel
      • 2020-01-19 01911, 2020

      • rahul24 has quit
      • 2020-01-19 01912, 2020

      • rahul24_ is now known as rahul24
      • 2020-01-19 01932, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek opened pull request #1358 (master…mbs-10571): MBS-10571: Fix "localized" ModBot email display https://github.com/metabrainz/musicbrainz-server/…
      • 2020-01-19 01933, 2020

      • BrainzBot
        MBS-10571: Localized modbot notes are not properly formatted when sent via email https://tickets.metabrainz.org/browse/MBS-10571
      • 2020-01-19 01952, 2020

      • rahul24 has quit
      • 2020-01-19 01906, 2020

      • Cyna
        bitmap: I just found out that login code is not working at the moment just because musicbrainz_db is not yet created
      • 2020-01-19 01927, 2020

      • Cyna
        The code should have use musicbrainz_selenium instead right ?
      • 2020-01-19 01950, 2020

      • Cyna
        That is probably the reason I was facing the user exist even thought I reset the databases except musicbrainz_db. Let me know how do I make plackup use musicbrainz_selenium instead of musicbrainz_db
      • 2020-01-19 01904, 2020

      • bitmap
        yes... do you have sub USE_SET_DATABASE_HEADER { 1 } in DBDefs.pm?
      • 2020-01-19 01911, 2020

      • Cyna
        Yes
      • 2020-01-19 01940, 2020

      • bitmap
        how did you determine it's using musicbrainz_db?
      • 2020-01-19 01935, 2020

      • Cyna
        When I ran the test with plackup working... It ran the first test which when clicked on signup and gave the following error
      • 2020-01-19 01955, 2020

      • Cyna
      • 2020-01-19 01900, 2020

      • bitmap
        I'm not sure I understand how the user can exist if "musicbrainz_db is not yet created"
      • 2020-01-19 01929, 2020

      • Cyna
        Its a signup script right
      • 2020-01-19 01948, 2020

      • Cyna
        and plus it should be using the musicbrainz_selenium database instead
      • 2020-01-19 01909, 2020

      • bitmap
        right
      • 2020-01-19 01914, 2020

      • bitmap
        are you using docker or?
      • 2020-01-19 01923, 2020

      • Cyna
        Nope
      • 2020-01-19 01937, 2020

      • Cyna
        I'm using everything locally on mac
      • 2020-01-19 01945, 2020

      • Cyna
        Docker had some performance issues
      • 2020-01-19 01901, 2020

      • bitmap
        can you paste your lib/DBDefs.pm somewhere?
      • 2020-01-19 01906, 2020

      • Cyna
        Sure
      • 2020-01-19 01924, 2020

      • Cyna
      • 2020-01-19 01959, 2020

      • bitmap
        thanks
      • 2020-01-19 01949, 2020

      • bitmap
        oh! chrome broke something recently where they don't send localhost requests through any configured proxy anymore
      • 2020-01-19 01947, 2020

      • bitmap
        it works for me since I just started using a host alias for localhost with plackup etc.
      • 2020-01-19 01959, 2020

      • bitmap
        I'm trying to see if I can get this proxy-bypass-list option working on the spawned chrome instance
      • 2020-01-19 01959, 2020

      • Cyna
        ohh
      • 2020-01-19 01926, 2020

      • rahul24 joined the channel
      • 2020-01-19 01936, 2020

      • rahul24 has quit
      • 2020-01-19 01915, 2020

      • shivam-kapila joined the channel
      • 2020-01-19 01924, 2020

      • c1e0 joined the channel
      • 2020-01-19 01901, 2020

      • bitmap
        anyway in the meantime you can get it working by adding something like `127.0.0.1 mycoolpc` to /etc/hosts and starting plackup with --host mycoolpc or whatever hostname you use
      • 2020-01-19 01951, 2020

      • bitmap
        replace localhost:5000 with that hostname in DBDefs.pm too
      • 2020-01-19 01942, 2020

      • bitmap
        proxy-bypass-list doesn't want to work here so I'm trying to come up with a better solution
      • 2020-01-19 01927, 2020

      • Cyna
        ohh I'll try making the change
      • 2020-01-19 01936, 2020

      • yvanzo
        hi Cyna: which “performance issues” did you experience?
      • 2020-01-19 01907, 2020

      • Cyna
        Latency on each requests
      • 2020-01-19 01928, 2020

      • Cyna
        I used containers... Not the current mb-docker support
      • 2020-01-19 01913, 2020

      • iliekcomputers
        ruaok: we should seriously consider merging labs and listenbrainz. the fact that we have to open two different pull requests in two different repos to build any actual feature is a PITA.
      • 2020-01-19 01927, 2020

      • Gazooo has quit
      • 2020-01-19 01922, 2020

      • Gazooo joined the channel
      • 2020-01-19 01943, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh opened pull request #691 (master…param/merge-labs-into-listenbrainz): [wip] Merge listenbrainz-labs into listenbrainz https://github.com/metabrainz/listenbrainz-server…
      • 2020-01-19 01954, 2020

      • MajorLurker has quit
      • 2020-01-19 01901, 2020

      • Gazooo has quit
      • 2020-01-19 01944, 2020

      • Gazooo joined the channel
      • 2020-01-19 01925, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek opened pull request #1359 (master…mbs-10572): Fix MBS-10572: Have one Jed bundle per language https://github.com/metabrainz/musicbrainz-server/…
      • 2020-01-19 01926, 2020

      • BrainzBot
        MBS-10572: Pages that display release events trigger an error when a non-English UI language is selected: "Domain `countries` was not found." https://tickets.metabrainz.org/browse/MBS-10572
      • 2020-01-19 01923, 2020

      • Cyna
        bitmap: using a different name worked
      • 2020-01-19 01906, 2020

      • Cyna
        running selenium test suite is seriously a joke :(
      • 2020-01-19 01929, 2020

      • Cyna
        How does it even work with the CI
      • 2020-01-19 01958, 2020

      • samj1912 joined the channel
      • 2020-01-19 01926, 2020

      • iliekcomputers
      • 2020-01-19 01920, 2020

      • iliekcomputers
        i am in total favour of merging this and archiving labs, it is annoying to have to change code in two different repositories and get two pull requests reviewed for what is almost always one piece of work.
      • 2020-01-19 01956, 2020

      • iliekcomputers
        surprised that labs is only around 4.4k LOC
      • 2020-01-19 01901, 2020

      • Nyanko-sensei has quit
      • 2020-01-19 01901, 2020

      • shivam-kapila has quit
      • 2020-01-19 01932, 2020

      • sumedh has quit
      • 2020-01-19 01943, 2020

      • c1e0 has quit
      • 2020-01-19 01944, 2020

      • cleo joined the channel
      • 2020-01-19 01920, 2020

      • cleo is now known as Guest34712
      • 2020-01-19 01954, 2020

      • Nyanko-sensei joined the channel
      • 2020-01-19 01956, 2020

      • shivam-kapila joined the channel
      • 2020-01-19 01905, 2020

      • ruaok
        iliekcomputers: ok, let's do it.
      • 2020-01-19 01901, 2020

      • iliekcomputers
        🥳🥳
      • 2020-01-19 01948, 2020

      • CODEin_JDB joined the channel
      • 2020-01-19 01949, 2020

      • iliekcomputers
        all of the code in the PR is from labs and is code reviewed. this is the commit that fixes tests and seperates the manage.py files for spark and server (https://github.com/metabrainz/listenbrainz-server…)
      • 2020-01-19 01926, 2020

      • CODEin_JDB
        Hey CatQuest can i make a whole new family tree about sri lankan intruments.
      • 2020-01-19 01937, 2020

      • CatQuest
        lol i literally just asnwered that on the task :D
      • 2020-01-19 01943, 2020

      • CatQuest
      • 2020-01-19 01953, 2020

      • CatQuest
        literally
      • 2020-01-19 01959, 2020

      • CatQuest
        check time mark
      • 2020-01-19 01908, 2020

      • CatQuest
      • 2020-01-19 01910, 2020

      • CatQuest
        eh
      • 2020-01-19 01919, 2020

      • CatQuest
        CODEin_JDB: You definitely can! That would be very cool :D
      • 2020-01-19 01922, 2020

      • CODEin_JDB
        Oh okay
      • 2020-01-19 01932, 2020

      • CatQuest
        I look forward to that :)
      • 2020-01-19 01940, 2020

      • CODEin_JDB
        Thank you
      • 2020-01-19 01944, 2020

      • CatQuest
        :D
      • 2020-01-19 01927, 2020

      • CODEin_JDB has quit
      • 2020-01-19 01942, 2020

      • pprkut has quit
      • 2020-01-19 01958, 2020

      • pprkut joined the channel
      • 2020-01-19 01920, 2020

      • ruaok
        iliekcomputers: cool -- how do we merge branches are in progress right now?
      • 2020-01-19 01920, 2020

      • iliekcomputers
        We'd have to add labs as a remote and merge the branch in progress to master: https://stackoverflow.com/questions/1425892/how-d…
      • 2020-01-19 01930, 2020

      • iliekcomputers
        I can move all current branches to server for now
      • 2020-01-19 01946, 2020

      • iliekcomputers
        (once the big merge pr is in master)
      • 2020-01-19 01930, 2020

      • iliekcomputers
        https://github.com/metabrainz/listenbrainz-labs/t… seems the only one that's relevant and not stale
      • 2020-01-19 01927, 2020

      • yokel has quit
      • 2020-01-19 01928, 2020

      • yokel joined the channel
      • 2020-01-19 01939, 2020

      • ruaok
        shall we consult pristine__ before we merge this?
      • 2020-01-19 01903, 2020

      • ruaok
        > <iliekcomputers> We'd have to add labs as a remote and merge the branch in progress to master:
      • 2020-01-19 01909, 2020

      • ruaok
        duh. forgetting how git works, lol.
      • 2020-01-19 01909, 2020

      • iliekcomputers
        sure, let's wait for pristine__.
      • 2020-01-19 01915, 2020

      • ruaok approves the PR
      • 2020-01-19 01933, 2020

      • ruaok
        since its all previously reviewed code, I'm good with it.
      • 2020-01-19 01959, 2020

      • iliekcomputers
        👍🏽
      • 2020-01-19 01942, 2020

      • pristine__
        Hey. So the I think that all-changes-mapping and master diverge. We may have merge conflicts and test fails after merging it into master. Otherwise it is to merge
      • 2020-01-19 01952, 2020

      • pristine__
        fine*
      • 2020-01-19 01910, 2020

      • iliekcomputers
        pristine__: i'll fix the merge conflicts after merging this.
      • 2020-01-19 01939, 2020

      • pristine__
        Cool
      • 2020-01-19 01902, 2020

      • iliekcomputers
        pristine__: ok to merge?
      • 2020-01-19 01953, 2020

      • iliekcomputers
        thanks for the reviews on a weekend, pristine__ and ruaok :)
      • 2020-01-19 01908, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #691 (master…param/merge-labs-into-listenbrainz): Merge listenbrainz-labs into listenbrainz-server https://github.com/metabrainz/listenbrainz-server…
      • 2020-01-19 01918, 2020

      • ruaok
        thanks for hacking. pristine__: I'll keep reviewing your PR later today.
      • 2020-01-19 01939, 2020

      • pristine__
        No problem. I am away the next week.
      • 2020-01-19 01944, 2020

      • pristine__
        Take your time :)
      • 2020-01-19 01955, 2020

      • iliekcomputers
        pristine__: looks like all-changes-mapping has conflicts with the labs master
      • 2020-01-19 01913, 2020

      • iliekcomputers
        I don't have any context with these conflicts.
      • 2020-01-19 01933, 2020

      • iliekcomputers
        if you can rebase all-changes-mapping over master once, it would make the merge to listenbrainz-server much easier
      • 2020-01-19 01928, 2020

      • samj1912 has quit
      • 2020-01-19 01954, 2020

      • pristine__
        So I rebase make changes and push to all-changes-mapping right?
      • 2020-01-19 01906, 2020

      • iliekcomputers
        yes, in labs.
      • 2020-01-19 01943, 2020

      • pristine__
        I see conflict on in manage.py and docker-compose.test
      • 2020-01-19 01904, 2020

      • iliekcomputers
        which master are you rebasing on?
      • 2020-01-19 01901, 2020

      • iliekcomputers
        I tried rebasing on the labs master and got conflicts in these files:
      • 2020-01-19 01901, 2020

      • pristine__
        Labs?
      • 2020-01-19 01910, 2020

      • iliekcomputers
      • 2020-01-19 01929, 2020

      • pristine__
        A sec
      • 2020-01-19 01910, 2020

      • pristine__
        I merged master into all-changes-mapping :(
      • 2020-01-19 01913, 2020

      • BrainzGit
        [listenbrainz-labs] paramsingh opened pull request #81 (master…all-changes-mapping): [wip] All changes mapping https://github.com/metabrainz/listenbrainz-labs/p…