alastairp: for the data that I imported, all of them turned out to be correct
2020-04-01 09253, 2020
ishaanshah[m]
Maybe they fixed their db?
2020-04-01 09218, 2020
yvanzo
reosarevok, bitmap: since the blog post has not been published on yesterday, the blog url in the git tag message is outdated already, thus I will fix it and rename git tag to -31 at the same time.
2020-04-01 09218, 2020
alastairp
ishaanshah[m]: maybe the items that you imported were OK, however we believe that there are still lots of wrong ones. we often have people asking how to match mbids to musibrainz from lastfm, and many of their problems come from bad ids
2020-04-01 09239, 2020
alastairp
maybe we could import them, but indicate that the ids are from lastfm, so that we know to not trust the mcompletely
2020-04-01 09240, 2020
ishaanshah[m]
Oh, maybe true because linked my lastfm account to spotify
2020-04-01 09216, 2020
ishaanshah[m]
So they may be getting clean.metadata to make a match
2020-04-01 09218, 2020
yvanzo
reosarevok: updated git tag, blog post, and jira release
2020-04-01 09224, 2020
reosarevok
<3
2020-04-01 09235, 2020
yvanzo
you should remove previous git tag:
2020-04-01 09251, 2020
yvanzo
git tag -d v-2020-03-30 # removes it from your working copy
2020-04-01 09225, 2020
yvanzo
git push origin :v-2020-03-30 -f # removes it from your clone at github (since you pushed tag to it at first)
2020-04-01 09240, 2020
sweta05 has quit
2020-04-01 09207, 2020
reosarevok
You removed it from the metabrainz repo?
2020-04-01 09206, 2020
djwhitey_ joined the channel
2020-04-01 09232, 2020
yvanzo
reosarevok: yes
2020-04-01 09201, 2020
Gazooo has quit
2020-04-01 09244, 2020
Gazooo joined the channel
2020-04-01 09248, 2020
ruaok
mooooin!
2020-04-01 09248, 2020
shivam-kapila
morning
2020-04-01 09218, 2020
iliekcomputers
ishaanshah[m]: let's import them into different fields, for example `artist_mbid_from_lastfm`
2020-04-01 09236, 2020
iliekcomputers
that way we have the data and we can think about what to do with it later
2020-04-01 09228, 2020
ishaanshah[m]
Maybe we can add another import type as lastfm_import
2020-04-01 09208, 2020
ishaanshah[m]
So that fixing the recording_mbid will also become simple
2020-04-01 09219, 2020
ishaanshah[m]
What do you think about it?
2020-04-01 09234, 2020
iliekcomputers
i'd add a source field to the additional_info instead
but i'm still not convinced on keeping potentially incorrect artist mbids in the main field
2020-04-01 09234, 2020
iliekcomputers
we use the main field for links and incorrect links will end up on the user visible pages
2020-04-01 09225, 2020
ishaanshah[m]
Maybe for now I will keep them in different fields
2020-04-01 09204, 2020
iliekcomputers
sgtm
2020-04-01 09238, 2020
ishaanshah[m]
I actually wanted the mbids because more metadata made getting data from mb easier
2020-04-01 09231, 2020
ishaanshah[m]
But I did not know that the data was incorrect
2020-04-01 09255, 2020
iliekcomputers
no worries, we still thought of improvements to make.
2020-04-01 09240, 2020
iliekcomputers
anyways, it might be a good idea to just tell us once before starting on a task once
2020-04-01 09228, 2020
ishaanshah[m]
Ya, should have told you about this, sorry about that
2020-04-01 09236, 2020
shivam-kapila
A suggestion. After we fetch listens from last.fm whh not put the users listens into a queue to fetch the required data from MB? I will also need MB_IDs to fetch cover arts
2020-04-01 09237, 2020
iliekcomputers
it's not a trivial problem to get mbids from the listen data (which sometimes might be just artist name and track name). MessyBrainz tries to solve this (https://messybrainz.org)
2020-04-01 09228, 2020
alastairp
artist_mbid_from_lastfm !
2020-04-01 09230, 2020
Mr_Monkey
> <alastairp> that picture looks a little fishy
2020-04-01 09230, 2020
Mr_Monkey
That's because it was shot with a mackerel lens.
2020-04-01 09242, 2020
CatQuest has quit
2020-04-01 09242, 2020
alastairp
lastfm_artist_mbid might be better, iliekcomputers ;)
2020-04-01 09209, 2020
iliekcomputers
sounds good to me
2020-04-01 09209, 2020
alastairp
mmm, but those need quite a bit of fine-tunaing, no?
2020-04-01 09214, 2020
iliekcomputers
naming things is hard :D
2020-04-01 09224, 2020
Mr_Monkey giggles
2020-04-01 09236, 2020
Mr_Monkey
Wasn't there a thing about slapping people with trouts on IRC, back in the day?
2020-04-01 09202, 2020
alastairp
yep, some clients even had it built in as a command
2020-04-01 09221, 2020
iliekcomputers slaps Mr_Monkey around a bit with a large ilisha
2020-04-01 09226, 2020
iliekcomputers
/slap works
2020-04-01 09227, 2020
Mr_Monkey
I remember having that
2020-04-01 09233, 2020
iliekcomputers
wtf is an ilish
2020-04-01 09237, 2020
iliekcomputers
ilisha
2020-04-01 09237, 2020
Mr_Monkey slaps Mr_Monkey around a bit with a large tiger barb
2020-04-01 09245, 2020
Mr_Monkey
Hmm, thanks.
2020-04-01 09249, 2020
iliekcomputers
lol
2020-04-01 09257, 2020
Mr_Monkey
I got schooled. (<- get it?)
2020-04-01 09230, 2020
reosarevok slaps alastairp around a bit with a large rohu
2020-04-01 09216, 2020
shivam-kapila
Slapping around on April fools day... 🤣
2020-04-01 09256, 2020
Mr_Monkey
I seriously lack fish vocabulary in all the languages I speak.
2020-04-01 09238, 2020
moufl has quit
2020-04-01 09252, 2020
moufl joined the channel
2020-04-01 09250, 2020
zas
outsidecontext: it seems 2.3.2dev1 based on previous Qt version solves Network issue for users that reported it, so I guess we can conclude that's a Qt 5.14 issue. So now, not sure what we should do, as downgrading isn't really an option and 5.15 is still in beta (it might be interesting to build Picard against it though, and ask same users to test)
2020-04-01 09245, 2020
rohitdandamudi joined the channel
2020-04-01 09204, 2020
moufl has quit
2020-04-01 09225, 2020
moufl joined the channel
2020-04-01 09253, 2020
Freso
reosarevok: I think part of what, in turn, stalled the test writing was that alastairp wanted to revamp how testing is done (automate stuff more).
2020-04-01 09226, 2020
reosarevok
Oh no
2020-04-01 09230, 2020
Chinmay3199 joined the channel
2020-04-01 09216, 2020
alastairp
oh yeah, but I decided to just merge a bunch of stuff and get a new release out, and deal with tests later
2020-04-01 09219, 2020
alastairp
maybe that's a good thing to do
2020-04-01 09248, 2020
alastairp
Freso: in fact, I think we might both have been waiting for each other there - I think you said that you wanted to address my changes, but perhaps you were waiting for me to set up the test infrastructure before continuing?
2020-04-01 09227, 2020
Freso
I actually think I might have even said I had an idea about doing the infrastructure since I had been having similar thoughts re: whipper’s test suite.
2020-04-01 09237, 2020
Freso
Which also has yet to manifest. :)
2020-04-01 09246, 2020
alastairp
yeah, we very briefly discussed it, but I don't think we decided to go ahead
2020-04-01 09213, 2020
alastairp
I rearranged some issues in milestones, and I think I pushed the test infra back a bit
2020-04-01 09234, 2020
alastairp
I got a release out a few weeks ago, but I want to merge the open PRs and make another one, then we can focus on improvements
2020-04-01 09230, 2020
Freso nods
2020-04-01 09241, 2020
alastairp
Freso: if you specifically address my 2 points on that PR, we can merge it
I think the comments of https://github.com/alastair/python-musicbrainzngs… is sort of outside the scope of the PR. Those were issues present before the PR and the PR doesn’t really alter the state of that issue either. I can try and work on a separate PR for that, but I don’t think it should be part of this one. (In the spirit of keeping PRs somewhat on a single topic.)
2020-04-01 09231, 2020
Freso
But docstring and AUTH_REQUIRED_INCLUDES, sure.
2020-04-01 09227, 2020
alastairp
mmm, you're right, however I wanted to be in a situation where we leave code better than we find it
2020-04-01 09244, 2020
alastairp
I know it's not directly related to this feature, but it's touching the same code workflow
