i haven't deployed master to the production API yet, so the 404 makes sense
2020-06-01 15304, 2020
BrainzGit
[bookbrainz-site] prabalsingh24 opened pull request #435 (UserCollection…search-table-add-to-collection): UserCollection: Add to collections from search results https://github.com/bookbrainz/bookbrainz-site/pul…
2020-06-01 15357, 2020
BrainzGit
[listenbrainz-server] paramsingh merged pull request #884 (master…master): LB-610: The URL in the browser should update with parameters for the history page https://github.com/metabrainz/listenbrainz-server…
2020-06-01 15344, 2020
Leftmost
Mr_Monkey, I'd say we publish -data-js for now. I think what I've done is sufficient to cover the work I'm doing.
2020-06-01 15310, 2020
Mr_Monkey
OK, I'll aim to do that today
2020-06-01 15323, 2020
Leftmost
👍
2020-06-01 15335, 2020
Leftmost
And anyways, version numbers are cheap. :)
2020-06-01 15359, 2020
ishaanshah
iliekcomputers: Please ping me when you are free, had to discuss some stuff about the request consumer code
But as that function is used for recommendation too, we cant change it
2020-06-01 15358, 2020
ishaanshah
So I was thinking that we should have messenger_map similar to query_map
2020-06-01 15346, 2020
ishaanshah
the messenger_map will map the query type to the appropriate messaging function
2020-06-01 15344, 2020
jmp_music has quit
2020-06-01 15309, 2020
iliekcomputers
hmm, let me think
2020-06-01 15355, 2020
iliekcomputers
i was looking into exploring making classes that inherit from an abstract RequestConsumerQuery for each query
2020-06-01 15320, 2020
ishaanshah
So each class would implement its own handler and messenger?
2020-06-01 15351, 2020
iliekcomputers
right, we could have a default messenger, and the class could override it if it needs to
2020-06-01 15315, 2020
reosarevok
yvanzo: I guess the main issue is the lack of parity
2020-06-01 15304, 2020
ishaanshah
Hmm, that will work too, but wont we have multiple rmq connections open?
2020-06-01 15324, 2020
shivam-kapila
ruaok: Ping
2020-06-01 15325, 2020
iliekcomputers
hmm, i haven't fleshed it out yet. i'll try to write it up in some more detail today.
2020-06-01 15311, 2020
ishaanshah
Ok, I will keep the get_artist and get_release ready
2020-06-01 15333, 2020
ruaok
pong!
2020-06-01 15310, 2020
shivam-kapila
Hey
2020-06-01 15331, 2020
shivam-kapila
The failing dump manager test is also fixed now
2020-06-01 15340, 2020
ruaok
what was it?
2020-06-01 15355, 2020
shivam-kapila
Remember the 0 listens dumped log I sent you?
2020-06-01 15348, 2020
shivam-kapila
That was the cause. No listens had created in the dump formation range
2020-06-01 15307, 2020
ruaok
ah, yes.
2020-06-01 15312, 2020
ruaok
makes sense.
2020-06-01 15318, 2020
ruaok
push your change, please.
2020-06-01 15303, 2020
shivam-kapila
Pushed. timescale-rebased-again
2020-06-01 15319, 2020
shivam-kapila
This shouldn't happen though as the previous dump id is added before inserting listens. Anyways I just made the previous dump ID time to be less by 5 sec.
2020-06-01 15305, 2020
shivam-kapila
Took 2.5 days to finally dig the issue :-|
2020-06-01 15317, 2020
ruaok
one thing I was thinking of is that we should change the timestamps in our test data, to include a gap of more than 3 weeks.
2020-06-01 15341, 2020
ruaok
I'm glad you found it, it looked totally opaque to me.
2020-06-01 15311, 2020
shivam-kapila
> one thing I was thinking of is that we should change the timestamps in our test data, to include a gap of more than 3 weeks.
2020-06-01 15311, 2020
shivam-kapila
Why so?
2020-06-01 15347, 2020
iliekcomputers
ishaanshah: did you figure out the issue with CORS?
2020-06-01 15320, 2020
ishaanshah
Not yet, I am not sure why the server is not sending the header with 204 response
2020-06-01 15330, 2020
ruaok
shivam-kapila: that would force us to deal with the time-range issues correctly. I think having closely spaced listens may be hiding problems for us.
2020-06-01 15346, 2020
ishaanshah
Thats why the error boundary is not working
2020-06-01 15350, 2020
iliekcomputers
can you reproduce it in dev?
2020-06-01 15315, 2020
ishaanshah
It works on dev
2020-06-01 15352, 2020
shivam-kapila
ruaok: Hm. Yeah I will agree to that
2020-06-01 15309, 2020
iliekcomputers
yeah, it worked for me too.
2020-06-01 15325, 2020
iliekcomputers
i do wonder tho, why it works for the artist endpoint and not for the release endpoint
2020-06-01 15343, 2020
ruaok
shivam-kapila: can you please try it? add a few more listens that have a large gap and see what breaks?
2020-06-01 15353, 2020
ishaanshah
artist endpoint is on api
2020-06-01 15354, 2020
ruaok
integration tests pass!
2020-06-01 15357, 2020
ruaok
!m shivam-kapila
2020-06-01 15357, 2020
BrainzBot
You're doing good work, shivam-kapila!
2020-06-01 15358, 2020
ishaanshah
release is on beta-api
2020-06-01 15309, 2020
ishaanshah
maybe some config error on beta-api?
2020-06-01 15353, 2020
iliekcomputers
they're basically the same, but yeah, that could be a possibility
2020-06-01 15319, 2020
shivam-kapila
ruaok: Thanks.
2020-06-01 15346, 2020
shivam-kapila
> can you please try it? add a few more listens that have a large gap and see what breaks?
2020-06-01 15346, 2020
shivam-kapila
To the test JSON files right?
2020-06-01 15352, 2020
ruaok
yes
2020-06-01 15304, 2020
shivam-kapila
I will give that a try. If things break I guess they would be in timescale_listenstore tests only but lets see
