#metabrainz

[bookbrainz-site] snyk-bot opened pull request #441 (master…snyk-upgrade-dfdc0faf3894f6acaf9f0ab22d4d3026): [Snyk] Upgrade: react, react-dom https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] snyk-bot opened pull request #442 (master…snyk-upgrade-fdc91b2fe785ef517c5349481e176370): [Snyk] Upgrade react-datepicker from 2.8.0 to 2.15.0 https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] snyk-bot opened pull request #443 (master…snyk-upgrade-f0718c1cdcee12a10d88a63585edafd8): [Snyk] Upgrade react-tooltip from 3.8.4 to 3.11.6 https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] snyk-bot opened pull request #444 (master…snyk-upgrade-34f4fa972e2ba6dc66d4d57a7766233c): [Snyk] Upgrade influx from 5.0.7 to 5.5.1 https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] snyk-bot opened pull request #445 (master…snyk-upgrade-dd964d853e2032b54968593370b51c22): [Snyk] Upgrade bluebird from 3.5.2 to 3.7.2 https://github.com/bookbrainz/bookbrainz-site/p...

Project bookbrainz-site build #3048: passed in 3 min 13 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

Project bookbrainz-site build #3051: passed in 6 min 32 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

Project bookbrainz-site build #3057: passed in 3 min 12 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

Project bookbrainz-site build #3060: passed in 3 min 13 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

Weird, MBS-10853 doesn't seem to be effective. Subscription mails I receive still don't include that link.

MBS-10853: Link to overview page for edits by subscribed editors in subscription email https://tickets.metabrainz.org/browse/MBS-10853

bitmap, yvanzo ^ any idea why that might be?

musicbrainz-production-cron wasn't updated maybe? I can check

yeah it's 13 days old, I'll update it

!m bitmap

You're doing good work, bitmap!

Oops, I forgot that one.

I just reran https://musicbrainz.org/report/BadAmazonURLs to apply the fix for MBS-10850.

MBS-10850: Bad Amazon URLs report doesn't ignore "streaming page" relationship https://tickets.metabrainz.org/browse/MBS-10850

Total releases found: 7

Easy clap :)

!m yvanzo

You're doing good work, yvanzo!

lol, as soon as I was done I get an error: `TypeError: Cannot read property 'href_url' of null`

!m chaban

You're doing good work, chaban!

[listenbrainz-server] vansika opened pull request #902 (master…mapping-download): update mapping downloader with change in FTP mapping dir format https://github.com/metabrainz/listenbrainz-serv...

reosarevok: The PR you wanted to test is up at test.mb.o, I just rebased it on the IP sanitizing PR.

Only issue is the indexed search is not updated for now.

[musicbrainz-server] yvanzo merged pull request #1552 (master…sanitize-ip-hash): Sanitize IP hashes on staging servers https://github.com/metabrainz/musicbrainz-serve...

Just saw MeB has its first GitHub sponsor. Nice!!

Morning!!

that's pretty cool

Yup 10% goal reached 🔥🔥🔥

ruaok: does github match the sponsors money? I think they were doing that for individuals

[listenbrainz-server] paramsingh merged pull request #898 (master…cors_fix): LB-609: Fix TypeError if stats are not calculated https://github.com/metabrainz/listenbrainz-serv...

LB-609: Getting a TypeError if release stats are not calculated https://tickets.metabrainz.org/browse/LB-609

shivam-kapila: hi

Hi

what's the order in which your PRs should be reviewed?

883 and then 889? or reverse?

former

oh wait 883 is already approved.

Its mostly an improvement to the DB module

[listenbrainz-server] paramsingh merged pull request #883 (master…improve-feedback-module): Improve feedback module https://github.com/metabrainz/listenbrainz-serv...

the build fails on 869

Yes it needs a rebase now

Lemme rebase and push in a min

iliekcomputers: Pushed

thanks

Moiin!

hi jmp_music

I'll reply to it this afternoon after my meetings

hello alastairp

Thanks!

[listenbrainz-server] paramsingh merged pull request #869 (master…add-feedback-api-endpoint): Add Feedback API endpoint https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] paramsingh merged pull request #882 (master…use_origin_url): BrainzPlayer: Automatically detect listen datasource and use youtubeID if available https://github.com/metabrainz/listenbrainz-serv...

Could we also arrange a meeting next week?

This Monday is public holiday here in Greece too. Could I take a day off?

absolutely! no problem

[listenbrainz-server] ishaanshah closed pull request #901 (master…empty_release): LB-617: Fix empty fields in release stats https://github.com/metabrainz/listenbrainz-serv...

LB-617: Blank entries present in release graph for listens not having release name https://tickets.metabrainz.org/browse/LB-617

[listenbrainz-server] ishaanshah reopened pull request #901 (master…empty_release): LB-617: Fix empty fields in release stats https://github.com/metabrainz/listenbrainz-serv...

Moooin!

iliekcomputers: I saw no mention of that.

ah, maybe it was only a beta thing

i do remember they were initially matching each sponsor's donation

iliekcomputers: for PR 901, I have modified the testdata itself to test for the regression

ishaanshah: sorry, i missed that. I'd say we should still have an explicit test case, because it's not obvious that the third entry in the data file is significant for the test

Ok, I will add a test for that

thanks!

iliekcomputers: hi, some time in the coming week would you like to have a chat about the flask/react integration experiments that Mr_Monkey and I made yesterday?

alastairp: sure.

[listenbrainz-server] ishaanshah opened pull request #903 (master…ux_improv): [WIP]LB-613: Show artist name on the release graph https://github.com/metabrainz/listenbrainz-serv...

LB-613: Show artist name on the release graph https://tickets.metabrainz.org/browse/LB-613

[musicbrainz-server] yvanzo opened pull request #1553 (master…mbs-10885): MBS-10885: Fix error when URL has been removed https://github.com/metabrainz/musicbrainz-serve...

MBS-10885: BadAmazonURLs: TypeError: Cannot read property 'href_url' of null https://tickets.metabrainz.org/browse/MBS-10885

[listenbrainz-server] release v-2020-06-05.0 has been published by release-drafter[bot]: https://github.com/metabrainz/listenbrainz-serv...

ruaok: Hi. Did you read the message yesterday about the time_range thing?

everytime my plan is to code review -> merge -> release -> write my own code, i get too tired at step 3...

:D

lol

never had so much to review in LB before lol

iliekcomputers: Gah, forgot to make the requested change on PR 882! You should have poked me about it rather than merge, I think it was a good suggestion :)

I'll do that right now

Mr_Monkey: thanks! I really wanted to merge it before releasing :D

[listenbrainz-server] MonkeyDo opened pull request #904 (master…source-selection): BrainzPlayer: Refactor mechanism to detect datasource from listen https://github.com/metabrainz/listenbrainz-serv...

Well at least it's clean now.

And just tested the source detection in prod, works nicely !

!m Mr_Monkey

You're doing good work, Mr_Monkey!

Freso: Since you initiated the request of extracting youtube uri from listens, it's now deployed in prod

[listenbrainz-server] paramsingh merged pull request #904 (master…source-selection): BrainzPlayer: Refactor mechanism to detect datasource from listen https://github.com/metabrainz/listenbrainz-serv...

So… now to play from bandcamp, huh?

"How to Replace the Xiaomi Mi Max Screen" seems to be the current hip track.

I wonder what he's up to...

Ooh, soundcloud has a good controllable embedded player: https://w.soundcloud.com/player/api_playground....

no wai.

ruaok: can you confirm what the partition value you use on timescale is?

value?

time range per chunk you mean?

regarding views.

and the base table

432000 seconds = 5 days

ah, interesting

thanks

I'm looking at applying plain postgres paritions to a table

but for range partitioning you need to do it on the PK, and our date field isn't unique

so I'm trying to work out how people do this

iliekcomputers: I'm dumping the data from timescale, but it is really dog dog dog slow.

because we're making n passes over the DB, where n = count(users)

yeah

that's what i thought would happen.

given that timescale functions differently, we should reconsider how to dump them

any idea how many listens per sec?

500 -2000 /sec. quite poor

I guess we should ask ourselves if the organization of the dumps should be changed -- or at least what the goal is.

the dumps are very user centric right now, partly due to the nature of our influx setup.

is that a requirement? if not, let's just dump the table with pg_dump and be done with it.