#metabrainz

/

      • Zastai has quit
      • 2020-06-05 15751, 2020

      • thomasross has quit
      • 2020-06-05 15713, 2020

      • thomasross joined the channel
      • 2020-06-05 15700, 2020

      • elomatreb[m] has quit
      • 2020-06-05 15720, 2020

      • elomatreb[m] joined the channel
      • 2020-06-05 15756, 2020

      • BrainzGit
        [bookbrainz-site] snyk-bot opened pull request #441 (master…snyk-upgrade-dfdc0faf3894f6acaf9f0ab22d4d3026): [Snyk] Upgrade: react, react-dom https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-06-05 15702, 2020

      • BrainzGit
        [bookbrainz-site] snyk-bot opened pull request #442 (master…snyk-upgrade-fdc91b2fe785ef517c5349481e176370): [Snyk] Upgrade react-datepicker from 2.8.0 to 2.15.0 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-06-05 15707, 2020

      • BrainzGit
        [bookbrainz-site] snyk-bot opened pull request #443 (master…snyk-upgrade-f0718c1cdcee12a10d88a63585edafd8): [Snyk] Upgrade react-tooltip from 3.8.4 to 3.11.6 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-06-05 15714, 2020

      • BrainzGit
        [bookbrainz-site] snyk-bot opened pull request #444 (master…snyk-upgrade-34f4fa972e2ba6dc66d4d57a7766233c): [Snyk] Upgrade influx from 5.0.7 to 5.5.1 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-06-05 15723, 2020

      • BrainzGit
        [bookbrainz-site] snyk-bot opened pull request #445 (master…snyk-upgrade-dd964d853e2032b54968593370b51c22): [Snyk] Upgrade bluebird from 3.5.2 to 3.7.2 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-06-05 15739, 2020

      • travis-ci joined the channel
      • 2020-06-05 15739, 2020

      • travis-ci
        Project bookbrainz-site build #3048: passed in 3 min 13 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-06-05 15739, 2020

      • travis-ci has left the channel
      • 2020-06-05 15740, 2020

      • d4rkie has quit
      • 2020-06-05 15719, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-06-05 15710, 2020

      • travis-ci joined the channel
      • 2020-06-05 15710, 2020

      • travis-ci
        Project bookbrainz-site build #3051: passed in 6 min 32 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-06-05 15710, 2020

      • travis-ci has left the channel
      • 2020-06-05 15737, 2020

      • travis-ci joined the channel
      • 2020-06-05 15737, 2020

      • travis-ci
        Project bookbrainz-site build #3057: passed in 3 min 12 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-06-05 15737, 2020

      • travis-ci has left the channel
      • 2020-06-05 15700, 2020

      • travis-ci joined the channel
      • 2020-06-05 15700, 2020

      • travis-ci
        Project bookbrainz-site build #3060: passed in 3 min 13 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-06-05 15700, 2020

      • travis-ci has left the channel
      • 2020-06-05 15742, 2020

      • dseomn joined the channel
      • 2020-06-05 15713, 2020

      • MrBrave has quit
      • 2020-06-05 15747, 2020

      • chaban
        Weird, MBS-10853 doesn't seem to be effective. Subscription mails I receive still don't include that link.
      • 2020-06-05 15748, 2020

      • BrainzBot
        MBS-10853: Link to overview page for edits by subscribed editors in subscription email https://tickets.metabrainz.org/browse/MBS-10853
      • 2020-06-05 15718, 2020

      • reosarevok
        bitmap, yvanzo ^ any idea why that might be?
      • 2020-06-05 15720, 2020

      • bitmap
        musicbrainz-production-cron wasn't updated maybe? I can check
      • 2020-06-05 15716, 2020

      • bitmap
        yeah it's 13 days old, I'll update it
      • 2020-06-05 15753, 2020

      • reosarevok
        !m bitmap
      • 2020-06-05 15754, 2020

      • BrainzBot
        You're doing good work, bitmap!
      • 2020-06-05 15740, 2020

      • Chinmay3199 joined the channel
      • 2020-06-05 15724, 2020

      • D4RK-PH0ENiX has quit
      • 2020-06-05 15752, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-06-05 15759, 2020

      • yvanzo
        Oops, I forgot that one.
      • 2020-06-05 15700, 2020

      • yvanzo
        I just reran https://musicbrainz.org/report/BadAmazonURLs to apply the fix for MBS-10850.
      • 2020-06-05 15701, 2020

      • BrainzBot
        MBS-10850: Bad Amazon URLs report doesn't ignore "streaming page" relationship https://tickets.metabrainz.org/browse/MBS-10850
      • 2020-06-05 15748, 2020

      • MrBrave joined the channel
      • 2020-06-05 15724, 2020

      • chaban
        Total releases found: 7
      • 2020-06-05 15724, 2020

      • chaban
        Easy clap :)
      • 2020-06-05 15738, 2020

      • chaban
        !m yvanzo
      • 2020-06-05 15738, 2020

      • BrainzBot
        You're doing good work, yvanzo!
      • 2020-06-05 15725, 2020

      • chaban
        lol, as soon as I was done I get an error: `TypeError: Cannot read property 'href_url' of null`
      • 2020-06-05 15735, 2020

      • yvanzo
        !m chaban
      • 2020-06-05 15735, 2020

      • BrainzBot
        You're doing good work, chaban!
      • 2020-06-05 15731, 2020

      • BrainzGit
        [listenbrainz-server] vansika opened pull request #902 (master…mapping-download): update mapping downloader with change in FTP mapping dir format https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15723, 2020

      • yvanzo
        reosarevok: The PR you wanted to test is up at test.mb.o, I just rebased it on the IP sanitizing PR.
      • 2020-06-05 15729, 2020

      • yvanzo
        Only issue is the indexed search is not updated for now.
      • 2020-06-05 15713, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo merged pull request #1552 (master…sanitize-ip-hash): Sanitize IP hashes on staging servers https://github.com/metabrainz/musicbrainz-server/…
      • 2020-06-05 15757, 2020

      • shivam-kapila
        Just saw MeB has its first GitHub sponsor. Nice!!
      • 2020-06-05 15746, 2020

      • diru1100
        Morning!!
      • 2020-06-05 15742, 2020

      • iliekcomputers
        that's pretty cool
      • 2020-06-05 15705, 2020

      • diru1100
        Yup 10% goal reached 🔥🔥🔥
      • 2020-06-05 15723, 2020

      • iliekcomputers
        ruaok: does github match the sponsors money? I think they were doing that for individuals
      • 2020-06-05 15705, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #898 (master…cors_fix): LB-609: Fix TypeError if stats are not calculated https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15706, 2020

      • BrainzBot
        LB-609: Getting a TypeError if release stats are not calculated https://tickets.metabrainz.org/browse/LB-609
      • 2020-06-05 15738, 2020

      • iliekcomputers
        shivam-kapila: hi
      • 2020-06-05 15749, 2020

      • shivam-kapila
        Hi
      • 2020-06-05 15753, 2020

      • iliekcomputers
        what's the order in which your PRs should be reviewed?
      • 2020-06-05 15712, 2020

      • iliekcomputers
        883 and then 889? or reverse?
      • 2020-06-05 15719, 2020

      • shivam-kapila
        former
      • 2020-06-05 15731, 2020

      • iliekcomputers
        oh wait 883 is already approved.
      • 2020-06-05 15722, 2020

      • shivam-kapila
        Its mostly an improvement to the DB module
      • 2020-06-05 15706, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #883 (master…improve-feedback-module): Improve feedback module https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15709, 2020

      • iliekcomputers
        the build fails on 869
      • 2020-06-05 15726, 2020

      • shivam-kapila
        Yes it needs a rebase now
      • 2020-06-05 15741, 2020

      • shivam-kapila
        Lemme rebase and push in a min
      • 2020-06-05 15711, 2020

      • shivam-kapila
        iliekcomputers: Pushed
      • 2020-06-05 15705, 2020

      • iliekcomputers
        thanks
      • 2020-06-05 15720, 2020

      • jmp_music joined the channel
      • 2020-06-05 15735, 2020

      • jmp_music
        Moiin!
      • 2020-06-05 15748, 2020

      • alastairp
        hi jmp_music
      • 2020-06-05 15755, 2020

      • alastairp
        I saw your email, great work!
      • 2020-06-05 15704, 2020

      • alastairp
        I'll reply to it this afternoon after my meetings
      • 2020-06-05 15718, 2020

      • jmp_music
        hello alastairp
      • 2020-06-05 15721, 2020

      • jmp_music
        Thanks!
      • 2020-06-05 15756, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #869 (master…add-feedback-api-endpoint): Add Feedback API endpoint https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15706, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #882 (master…use_origin_url): BrainzPlayer: Automatically detect listen datasource and use youtubeID if available https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15706, 2020

      • jmp_music
        Could we also arrange a meeting next week?
      • 2020-06-05 15702, 2020

      • jmp_music
        This Monday is public holiday here in Greece too. Could I take a day off?
      • 2020-06-05 15731, 2020

      • alastairp
        absolutely! no problem
      • 2020-06-05 15740, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah closed pull request #901 (master…empty_release): LB-617: Fix empty fields in release stats https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15741, 2020

      • BrainzBot
        LB-617: Blank entries present in release graph for listens not having release name https://tickets.metabrainz.org/browse/LB-617
      • 2020-06-05 15748, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah reopened pull request #901 (master…empty_release): LB-617: Fix empty fields in release stats https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15757, 2020

      • ruaok
        Moooin!
      • 2020-06-05 15716, 2020

      • ruaok
        iliekcomputers: I saw no mention of that.
      • 2020-06-05 15732, 2020

      • iliekcomputers
        ah, maybe it was only a beta thing
      • 2020-06-05 15746, 2020

      • iliekcomputers
        i do remember they were initially matching each sponsor's donation
      • 2020-06-05 15717, 2020

      • ishaanshah
        iliekcomputers: for PR 901, I have modified the testdata itself to test for the regression
      • 2020-06-05 15746, 2020

      • iliekcomputers
        ishaanshah: sorry, i missed that. I'd say we should still have an explicit test case, because it's not obvious that the third entry in the data file is significant for the test
      • 2020-06-05 15720, 2020

      • ishaanshah
        Ok, I will add a test for that
      • 2020-06-05 15729, 2020

      • iliekcomputers
        thanks!
      • 2020-06-05 15750, 2020

      • alastairp
        iliekcomputers: hi, some time in the coming week would you like to have a chat about the flask/react integration experiments that Mr_Monkey and I made yesterday?
      • 2020-06-05 15711, 2020

      • iliekcomputers
        alastairp: sure.
      • 2020-06-05 15753, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah opened pull request #903 (master…ux_improv): [WIP]LB-613: Show artist name on the release graph https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15753, 2020

      • BrainzBot
        LB-613: Show artist name on the release graph https://tickets.metabrainz.org/browse/LB-613
      • 2020-06-05 15737, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo opened pull request #1553 (master…mbs-10885): MBS-10885: Fix error when URL has been removed https://github.com/metabrainz/musicbrainz-server/…
      • 2020-06-05 15738, 2020

      • BrainzBot
        MBS-10885: BadAmazonURLs: TypeError: Cannot read property 'href_url' of null https://tickets.metabrainz.org/browse/MBS-10885
      • 2020-06-05 15710, 2020

      • BrainzGit
        [listenbrainz-server] release v-2020-06-05.0 has been published by release-drafter[bot]: https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15734, 2020

      • jmp_music has quit
      • 2020-06-05 15731, 2020

      • shivam-kapila
        ruaok: Hi. Did you read the message yesterday about the time_range thing?
      • 2020-06-05 15749, 2020

      • iliekcomputers
        everytime my plan is to code review -> merge -> release -> write my own code, i get too tired at step 3...
      • 2020-06-05 15701, 2020

      • Mr_Monkey
        :D
      • 2020-06-05 15718, 2020

      • shivam-kapila
        lol
      • 2020-06-05 15726, 2020

      • iliekcomputers
        never had so much to review in LB before lol
      • 2020-06-05 15701, 2020

      • Gazooo has quit
      • 2020-06-05 15747, 2020

      • Gazooo joined the channel
      • 2020-06-05 15740, 2020

      • Mr_Monkey
        iliekcomputers: Gah, forgot to make the requested change on PR 882! You should have poked me about it rather than merge, I think it was a good suggestion :)
      • 2020-06-05 15752, 2020

      • Mr_Monkey
        I'll do that right now
      • 2020-06-05 15714, 2020

      • iliekcomputers
        Mr_Monkey: thanks! I really wanted to merge it before releasing :D
      • 2020-06-05 15728, 2020

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #904 (master…source-selection): BrainzPlayer: Refactor mechanism to detect datasource from listen https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15740, 2020

      • Mr_Monkey
        Well at least it's clean now.
      • 2020-06-05 15715, 2020

      • Mr_Monkey
        And just tested the source detection in prod, works nicely !
      • 2020-06-05 15710, 2020

      • iliekcomputers
        !m Mr_Monkey
      • 2020-06-05 15710, 2020

      • BrainzBot
        You're doing good work, Mr_Monkey!
      • 2020-06-05 15713, 2020

      • Mr_Monkey
        Freso: Since you initiated the request of extracting youtube uri from listens, it's now deployed in prod
      • 2020-06-05 15727, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #904 (master…source-selection): BrainzPlayer: Refactor mechanism to detect datasource from listen https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-05 15719, 2020

      • Mr_Monkey
        So… now to play from bandcamp, huh?
      • 2020-06-05 15747, 2020

      • Mr_Monkey goes foraging in zas' listens
      • 2020-06-05 15731, 2020

      • ruaok
        "How to Replace the Xiaomi Mi Max Screen" seems to be the current hip track.
      • 2020-06-05 15736, 2020

      • ruaok
        I wonder what he's up to...
      • 2020-06-05 15740, 2020

      • Mr_Monkey
        Ooh, soundcloud has a good controllable embedded player: https://w.soundcloud.com/player/api_playground.ht…
      • 2020-06-05 15716, 2020

      • Mr_Monkey discovers that, of course, he reinvented the wheel: https://github.com/adrienjoly/playemjs
      • 2020-06-05 15750, 2020

      • ruaok
        no wai.
      • 2020-06-05 15734, 2020

      • alastairp
        ruaok: can you confirm what the partition value you use on timescale is?
      • 2020-06-05 15749, 2020

      • ruaok
        value?
      • 2020-06-05 15758, 2020

      • ruaok
        time range per chunk you mean?
      • 2020-06-05 15747, 2020

      • ruaok
      • 2020-06-05 15758, 2020

      • ruaok
        regarding views.
      • 2020-06-05 15712, 2020

      • ruaok
        and the base table
      • 2020-06-05 15713, 2020

      • ruaok
      • 2020-06-05 15746, 2020

      • ruaok
        432000 seconds = 5 days
      • 2020-06-05 15710, 2020

      • alastairp
        ah, interesting
      • 2020-06-05 15711, 2020

      • alastairp
        thanks
      • 2020-06-05 15725, 2020

      • alastairp
        I'm looking at applying plain postgres paritions to a table
      • 2020-06-05 15709, 2020

      • alastairp
        but for range partitioning you need to do it on the PK, and our date field isn't unique
      • 2020-06-05 15724, 2020

      • alastairp
        so I'm trying to work out how people do this
      • 2020-06-05 15700, 2020

      • ruaok
        iliekcomputers: I'm dumping the data from timescale, but it is really dog dog dog slow.
      • 2020-06-05 15720, 2020

      • ruaok
        because we're making n passes over the DB, where n = count(users)
      • 2020-06-05 15734, 2020

      • iliekcomputers
        yeah
      • 2020-06-05 15748, 2020

      • iliekcomputers
        that's what i thought would happen.
      • 2020-06-05 15750, 2020

      • ruaok
        given that timescale functions differently, we should reconsider how to dump them
      • 2020-06-05 15755, 2020

      • iliekcomputers
        any idea how many listens per sec?
      • 2020-06-05 15742, 2020

      • ruaok
      • 2020-06-05 15704, 2020

      • ruaok
        500 -2000 /sec. quite poor
      • 2020-06-05 15758, 2020

      • ruaok
        I guess we should ask ourselves if the organization of the dumps should be changed -- or at least what the goal is.
      • 2020-06-05 15716, 2020

      • ruaok
        the dumps are very user centric right now, partly due to the nature of our influx setup.
      • 2020-06-05 15749, 2020

      • ruaok
        is that a requirement? if not, let's just dump the table with pg_dump and be done with it.