#metabrainz

/

      • supersandro2000 has quit
      • 2020-06-06 15857, 2020

      • supersandro20000 joined the channel
      • 2020-06-06 15849, 2020

      • supersandro20000 has quit
      • 2020-06-06 15806, 2020

      • supersandro2000 joined the channel
      • 2020-06-06 15839, 2020

      • d4rkie has quit
      • 2020-06-06 15801, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-06-06 15829, 2020

      • MusicbrainzB0T1 joined the channel
      • 2020-06-06 15811, 2020

      • MusicbrainzB0T has quit
      • 2020-06-06 15859, 2020

      • Leftmost
        Mr_Monkey, I think https://github.com/bookbrainz/bookbrainz-site/com… is in a reasonable state as far as functionality. Still ugly as sin, but I think it basically does what it ought to. If you wouldn't mind playing around with it and letting me know how it feels, I'd appreciate it.
      • 2020-06-06 15822, 2020

      • sumedh joined the channel
      • 2020-06-06 15849, 2020

      • Chinmay3199 joined the channel
      • 2020-06-06 15856, 2020

      • sumedh has quit
      • 2020-06-06 15829, 2020

      • RustyFork joined the channel
      • 2020-06-06 15812, 2020

      • sumedh joined the channel
      • 2020-06-06 15828, 2020

      • CatQuest
        !m Leftmost
      • 2020-06-06 15828, 2020

      • BrainzBot
        You're doing good work, Leftmost!
      • 2020-06-06 15829, 2020

      • CatQuest
        Leftmost: actually on line 21 it says "import {FontAwesomeIcon} from '@fortawesome/react-fontawesome';" should that say "fortawesome" ?
      • 2020-06-06 15825, 2020

      • CatQuest
        (in author-credit-editor.js )
      • 2020-06-06 15818, 2020

      • Leftmost
        Seemingly not. I believe fortawesome is the org. That's what the packages are named, certainly.
      • 2020-06-06 15845, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #874 (master…param/pydantic-stats-models): LB-540: Use a pydantic model for artist stats https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-06 15846, 2020

      • BrainzBot
        LB-540: Enforce a schema for the statistics stored in postgres https://tickets.metabrainz.org/browse/LB-540
      • 2020-06-06 15846, 2020

      • sumedh has quit
      • 2020-06-06 15832, 2020

      • sumedh joined the channel
      • 2020-06-06 15832, 2020

      • sumedh has quit
      • 2020-06-06 15834, 2020

      • sumedh joined the channel
      • 2020-06-06 15826, 2020

      • sumedh has quit
      • 2020-06-06 15817, 2020

      • sumedh joined the channel
      • 2020-06-06 15844, 2020

      • MrBrave joined the channel
      • 2020-06-06 15802, 2020

      • Gazooo has quit
      • 2020-06-06 15816, 2020

      • v6lur joined the channel
      • 2020-06-06 15841, 2020

      • Gazooo joined the channel
      • 2020-06-06 15828, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo opened pull request #1555 (master…fixup-435310dd54): Refactor 435310dd54: Check DBDefs instead of stash https://github.com/metabrainz/musicbrainz-server/…
      • 2020-06-06 15822, 2020

      • shivam-kapila
        ruaok: Hey. Did you get some solution to GRANT
      • 2020-06-06 15838, 2020

      • shivam-kapila
        I did some research but couldn't :(
      • 2020-06-06 15805, 2020

      • ruaok
        no, I was AFK for a bit.
      • 2020-06-06 15836, 2020

      • ruaok
        here is one thing to try: just before the call to create_tables, we should make a connection to TS and ask: what user am I?
      • 2020-06-06 15806, 2020

      • ruaok
        and if the user is root or something not listenbrainz_ts, then our code to change the DB connection string is not working.
      • 2020-06-06 15821, 2020

      • ruaok
        if the user is listenbrainz_ts, then we. uhm, need to dig more.
      • 2020-06-06 15826, 2020

      • ruaok
        can you run that one test for me please?
      • 2020-06-06 15836, 2020

      • shivam-kapila
        On it
      • 2020-06-06 15854, 2020

      • v6lur has quit
      • 2020-06-06 15826, 2020

      • CallerNo6 has quit
      • 2020-06-06 15814, 2020

      • sumedh has quit
      • 2020-06-06 15859, 2020

      • BrainzGit
        [musicbrainz-server] loujine opened pull request #1556 (master…MBS-8625-release_data_quality_icons): Mbs 8625 release data quality icons https://github.com/metabrainz/musicbrainz-server/…
      • 2020-06-06 15800, 2020

      • BrainzBot
        MBS-8625: Add data quality icons https://tickets.metabrainz.org/browse/MBS-8625
      • 2020-06-06 15846, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1545 (master…MBS-10856): MBS-10856: Trim whitespace on relationship credits https://github.com/metabrainz/musicbrainz-server/…
      • 2020-06-06 15847, 2020

      • BrainzBot
        MBS-10856: Relationship credit with whitespace causes error https://tickets.metabrainz.org/browse/MBS-10856
      • 2020-06-06 15855, 2020

      • yvanzo
        loujine: I can push it to test.mb.o if you want to check i18n.
      • 2020-06-06 15814, 2020

      • CallerNo6 joined the channel
      • 2020-06-06 15814, 2020

      • CallerNo6 has quit
      • 2020-06-06 15814, 2020

      • CallerNo6 joined the channel
      • 2020-06-06 15813, 2020

      • BrainzGit
        [musicbrainz-docker] loujine closed pull request #162 (master…perl-dev-setup): Fix 'cant locate JSON.pm' error in development setup https://github.com/metabrainz/musicbrainz-docker/…
      • 2020-06-06 15842, 2020

      • shivam-kapila
        ruaok: The user is listenbrainz_ts if we connect to SQLALCHEMY_TIMESCALE_URI
      • 2020-06-06 15827, 2020

      • ruaok
        ok, so then that is correct.
      • 2020-06-06 15840, 2020

      • ruaok
        and the tables that are created are owned by?
      • 2020-06-06 15825, 2020

      • shivam-kapila
      • 2020-06-06 15837, 2020

      • shivam-kapila
        listenbrainz_ts
      • 2020-06-06 15820, 2020

      • ruaok
        do you have the test failure error message to hand? lets look at that again.
      • 2020-06-06 15814, 2020

      • shivam-kapila
      • 2020-06-06 15832, 2020

      • ruaok
        ok, continuing out divide can conquer approach, let's do this: run the server without the GRANT and see if you can import listens from last. fm. if you can, then it means our tests have a bug. if you can't then we need to look at which error we get.
      • 2020-06-06 15835, 2020

      • ruaok
        make sense?
      • 2020-06-06 15855, 2020

      • ruaok
        I have to go out and buy some food for the weekend. when I get back I can help take a look.
      • 2020-06-06 15822, 2020

      • shivam-kapila
        okay. I will try this till then
      • 2020-06-06 15802, 2020

      • sumedh joined the channel
      • 2020-06-06 15843, 2020

      • shivam-kapila
        Strangely it worked
      • 2020-06-06 15803, 2020

      • ruaok
        I think the test setup is borked.
      • 2020-06-06 15818, 2020

      • shivam-kapila
        ruaok: How does this look :grin: https://www.irccloud.com/pastebin/JCfub1T8/
      • 2020-06-06 15802, 2020

      • ruaok
        better. what did you change?
      • 2020-06-06 15855, 2020

      • shivam-kapila
        The reset_timescale_db() in tests was still using postgres instead of listenbrainz_ts
      • 2020-06-06 15821, 2020

      • shivam-kapila
        I never looked there before to update the URI
      • 2020-06-06 15822, 2020

      • ruaok
        yes, that would do it.
      • 2020-06-06 15822, 2020

      • shivam-kapila
        The 2 failing are
      • 2020-06-06 15822, 2020

      • shivam-kapila
        1. The listen_count view dependent test
      • 2020-06-06 15822, 2020

      • shivam-kapila
        2. The test I added for try_harder which fails due to incomplete try_harder for `to_ts`
      • 2020-06-06 15839, 2020

      • shivam-kapila
        In crux, problem is solved now
      • 2020-06-06 15845, 2020

      • ruaok
        phew.
      • 2020-06-06 15837, 2020

      • shivam-kapila
        Huh. Finally. Thanks
      • 2020-06-06 15801, 2020

      • ruaok
        and now you know the divide and conquer method for debugging things like this.
      • 2020-06-06 15853, 2020

      • shivam-kapila
        Yup. Credits to you
      • 2020-06-06 15829, 2020

      • BrainzGit
        [musicbrainz-docker] yvanzo opened pull request #163 (master…set-db-shm-size): Set SHM size to 2 GB for database container https://github.com/metabrainz/musicbrainz-docker/…
      • 2020-06-06 15830, 2020

      • shivam-kapila
        ruaok: Fixed try_harder for `to_ts`, added test, updated try_harder to search_larger_time_range
      • 2020-06-06 15836, 2020

      • shivam-kapila
        and pushed
      • 2020-06-06 15859, 2020

      • ruaok
        great. did you resolve the conversations on the PR that correspond to the issues you've fixed?
      • 2020-06-06 15853, 2020

      • shivam-kapila
        No I didn't
      • 2020-06-06 15812, 2020

      • shivam-kapila
        Shall I do it now or wait till those commits get added into the PR?
      • 2020-06-06 15845, 2020

      • ruaok
        pulled, running tests. let's do it soon, hopefully.
      • 2020-06-06 15853, 2020

      • sumedh has quit
      • 2020-06-06 15808, 2020

      • ruaok
      • 2020-06-06 15813, 2020

      • ruaok
        much much better!
      • 2020-06-06 15819, 2020

      • ruaok
        let me push these changes now.
      • 2020-06-06 15841, 2020

      • shivam-kapila
        This test sometimes works sometimes doesnt
      • 2020-06-06 15855, 2020

      • ruaok
        timing issue?
      • 2020-06-06 15855, 2020

      • shivam-kapila
        Depends on did the view update in 2 sec or it didnt
      • 2020-06-06 15843, 2020

      • shivam-kapila
        > timing issue?
      • 2020-06-06 15843, 2020

      • shivam-kapila
        Yeah
      • 2020-06-06 15837, 2020

      • shivam-kapila
        Plus I can't resolve the conversations. I can only comment on them
      • 2020-06-06 15853, 2020

      • sumedh joined the channel
      • 2020-06-06 15837, 2020

      • ruaok
        I
      • 2020-06-06 15803, 2020

      • ruaok
        I've resolved all the issues we just closed. two more items left that I can handle... and dump improvements.
      • 2020-06-06 15808, 2020

      • ruaok
        thanks for all your help shivam-kapila.
      • 2020-06-06 15820, 2020

      • ruaok
        but, I think now its time for you to get back to your gsoc project.
      • 2020-06-06 15829, 2020

      • dseomn has quit
      • 2020-06-06 15857, 2020

      • shivam-kapila
        Sure thing. I was slowly slowly doing it sideways
      • 2020-06-06 15820, 2020

      • ruaok
        .. on the side ...
      • 2020-06-06 15855, 2020

      • dseomn joined the channel
      • 2020-06-06 15815, 2020

      • shivam-kapila
        oh 😅
      • 2020-06-06 15856, 2020

      • shivam-kapila
        GH android app is now out for everyone
      • 2020-06-06 15812, 2020

      • Sophist-UK joined the channel
      • 2020-06-06 15844, 2020

      • sumedh has quit
      • 2020-06-06 15857, 2020

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #905 (master…soundcloud-player): Soundcloud player https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-06 15827, 2020

      • MrBrave has quit
      • 2020-06-06 15817, 2020

      • Chinmay3199 has quit
      • 2020-06-06 15839, 2020

      • Sophist_UK joined the channel
      • 2020-06-06 15832, 2020

      • Sophist-UK has quit
      • 2020-06-06 15836, 2020

      • Sophist-UK joined the channel
      • 2020-06-06 15859, 2020

      • Sophist_UK has quit
      • 2020-06-06 15812, 2020

      • Sophist_UK joined the channel
      • 2020-06-06 15847, 2020

      • Sophist-UK has quit
      • 2020-06-06 15827, 2020

      • ishaanshah
        shivam-kapila: Updated the link
      • 2020-06-06 15837, 2020

      • shivam-kapila
        ishaanshah: Hey. Thanks
      • 2020-06-06 15856, 2020

      • shivam-kapila
        If we can do something like this with LB logo it will be really coook
      • 2020-06-06 15859, 2020

      • shivam-kapila
        coool*
      • 2020-06-06 15800, 2020

      • shivam-kapila
      • 2020-06-06 15840, 2020

      • ishaanshah
        It's a bit too much imo
      • 2020-06-06 15854, 2020

      • shivam-kapila
        Yeah
      • 2020-06-06 15809, 2020

      • ishaanshah
        But I would like to use bootstrap loader with orange or purple color
      • 2020-06-06 15822, 2020

      • ishaanshah
        But that is not present in Bootstrap 3
      • 2020-06-06 15843, 2020

      • shivam-kapila
        Hmm we should consider migrating to bootstrap 4
      • 2020-06-06 15811, 2020

      • ishaanshah
        Yep we definitely should
      • 2020-06-06 15851, 2020

      • Sophist-UK joined the channel
      • 2020-06-06 15832, 2020

      • Sophist_UK has quit
      • 2020-06-06 15822, 2020

      • shivam-kapila
        Just trying stuff :D
      • 2020-06-06 15822, 2020

      • shivam-kapila
      • 2020-06-06 15854, 2020

      • ishaanshah
        that looks really cool
      • 2020-06-06 15815, 2020

      • shivam-kapila
        I stole that 🤫
      • 2020-06-06 15825, 2020

      • KindTwo joined the channel
      • 2020-06-06 15809, 2020

      • KindOne has quit
      • 2020-06-06 15842, 2020

      • KindTwo is now known as KindOne
      • 2020-06-06 15834, 2020

      • KindTwo joined the channel
      • 2020-06-06 15809, 2020

      • KindOne has quit
      • 2020-06-06 15846, 2020

      • KindTwo is now known as KindOne
      • 2020-06-06 15816, 2020

      • Zastai joined the channel
      • 2020-06-06 15830, 2020

      • KindTwo joined the channel
      • 2020-06-06 15814, 2020

      • KindOne has quit
      • 2020-06-06 15850, 2020

      • KindTwo is now known as KindOne
      • 2020-06-06 15808, 2020

      • Chinmay3199 joined the channel
      • 2020-06-06 15829, 2020

      • jwf has quit
      • 2020-06-06 15829, 2020

      • ShraddhaAg has quit
      • 2020-06-06 15849, 2020

      • jwf joined the channel
      • 2020-06-06 15850, 2020

      • ShraddhaAg joined the channel