0:52 AM
supersandro2000 has quit
2020-06-06 15857, 2020
0:52 AM
supersandro20000 joined the channel
2020-06-06 15849, 2020
0:53 AM
supersandro20000 has quit
2020-06-06 15806, 2020
0:54 AM
supersandro2000 joined the channel
2020-06-06 15839, 2020
1:11 AM
d4rkie has quit
2020-06-06 15801, 2020
1:13 AM
D4RK-PH0ENiX joined the channel
2020-06-06 15829, 2020
4:08 AM
MusicbrainzB0T1 joined the channel
2020-06-06 15811, 2020
4:12 AM
MusicbrainzB0T has quit
2020-06-06 15859, 2020
4:38 AM
Leftmost
Mr_Monkey, I think
https://github.com/bookbrainz/bookbrainz-site/com… is in a reasonable state as far as functionality. Still ugly as sin, but I think it basically does what it ought to. If you wouldn't mind playing around with it and letting me know how it feels, I'd appreciate it.
2020-06-06 15822, 2020
4:45 AM
sumedh joined the channel
2020-06-06 15849, 2020
5:17 AM
Chinmay3199 joined the channel
2020-06-06 15856, 2020
5:54 AM
sumedh has quit
2020-06-06 15829, 2020
6:06 AM
RustyFork joined the channel
2020-06-06 15812, 2020
6:08 AM
sumedh joined the channel
2020-06-06 15828, 2020
6:48 AM
CatQuest
!m Leftmost
2020-06-06 15828, 2020
6:48 AM
BrainzBot
You're doing good work, Leftmost!
2020-06-06 15829, 2020
6:51 AM
CatQuest
Leftmost: actually on line 21 it says "import {FontAwesomeIcon} from '@fortawesome/react-fontawesome';" should that say "fortawesome" ?
2020-06-06 15825, 2020
6:52 AM
CatQuest
(in author-credit-editor.js )
2020-06-06 15818, 2020
6:55 AM
Leftmost
Seemingly not. I believe fortawesome is the org. That's what the packages are named, certainly.
2020-06-06 15845, 2020
7:02 AM
BrainzGit
2020-06-06 15846, 2020
7:02 AM
BrainzBot
2020-06-06 15846, 2020
7:51 AM
sumedh has quit
2020-06-06 15832, 2020
7:56 AM
sumedh joined the channel
2020-06-06 15832, 2020
8:13 AM
sumedh has quit
2020-06-06 15834, 2020
8:18 AM
sumedh joined the channel
2020-06-06 15826, 2020
8:32 AM
sumedh has quit
2020-06-06 15817, 2020
8:45 AM
sumedh joined the channel
2020-06-06 15844, 2020
9:03 AM
MrBrave joined the channel
2020-06-06 15802, 2020
9:05 AM
Gazooo has quit
2020-06-06 15816, 2020
9:06 AM
v6lur joined the channel
2020-06-06 15841, 2020
9:06 AM
Gazooo joined the channel
2020-06-06 15828, 2020
9:48 AM
BrainzGit
2020-06-06 15822, 2020
10:29 AM
shivam-kapila
ruaok: Hey. Did you get some solution to GRANT
2020-06-06 15838, 2020
10:29 AM
shivam-kapila
I did some research but couldn't :(
2020-06-06 15805, 2020
10:30 AM
ruaok
no, I was AFK for a bit.
2020-06-06 15836, 2020
10:30 AM
ruaok
here is one thing to try: just before the call to create_tables, we should make a connection to TS and ask: what user am I?
2020-06-06 15806, 2020
10:31 AM
ruaok
and if the user is root or something not listenbrainz_ts, then our code to change the DB connection string is not working.
2020-06-06 15821, 2020
10:31 AM
ruaok
if the user is listenbrainz_ts, then we. uhm, need to dig more.
2020-06-06 15826, 2020
10:31 AM
ruaok
can you run that one test for me please?
2020-06-06 15836, 2020
10:31 AM
shivam-kapila
On it
2020-06-06 15854, 2020
10:32 AM
v6lur has quit
2020-06-06 15826, 2020
10:38 AM
CallerNo6 has quit
2020-06-06 15814, 2020
10:41 AM
sumedh has quit
2020-06-06 15859, 2020
10:46 AM
BrainzGit
2020-06-06 15800, 2020
10:47 AM
BrainzBot
2020-06-06 15846, 2020
10:49 AM
BrainzGit
2020-06-06 15847, 2020
10:49 AM
BrainzBot
2020-06-06 15855, 2020
10:49 AM
yvanzo
loujine: I can push it to test.mb.o if you want to check i18n.
2020-06-06 15814, 2020
10:51 AM
CallerNo6 joined the channel
2020-06-06 15814, 2020
10:51 AM
CallerNo6 has quit
2020-06-06 15814, 2020
10:51 AM
CallerNo6 joined the channel
2020-06-06 15813, 2020
10:54 AM
BrainzGit
2020-06-06 15842, 2020
10:56 AM
shivam-kapila
ruaok: The user is listenbrainz_ts if we connect to SQLALCHEMY_TIMESCALE_URI
2020-06-06 15827, 2020
10:57 AM
ruaok
ok, so then that is correct.
2020-06-06 15840, 2020
10:57 AM
ruaok
and the tables that are created are owned by?
2020-06-06 15825, 2020
10:59 AM
shivam-kapila
2020-06-06 15837, 2020
11:00 AM
shivam-kapila
listenbrainz_ts
2020-06-06 15820, 2020
11:01 AM
ruaok
do you have the test failure error message to hand? lets look at that again.
2020-06-06 15814, 2020
11:06 AM
shivam-kapila
2020-06-06 15832, 2020
11:11 AM
ruaok
ok, continuing out divide can conquer approach, let's do this: run the server without the GRANT and see if you can import listens from last. fm. if you can, then it means our tests have a bug. if you can't then we need to look at which error we get.
2020-06-06 15835, 2020
11:11 AM
ruaok
make sense?
2020-06-06 15855, 2020
11:11 AM
ruaok
I have to go out and buy some food for the weekend. when I get back I can help take a look.
2020-06-06 15822, 2020
11:12 AM
shivam-kapila
okay. I will try this till then
2020-06-06 15802, 2020
11:25 AM
sumedh joined the channel
2020-06-06 15843, 2020
11:25 AM
shivam-kapila
Strangely it worked
2020-06-06 15803, 2020
11:27 AM
ruaok
I think the test setup is borked.
2020-06-06 15818, 2020
11:33 AM
shivam-kapila
2020-06-06 15802, 2020
11:34 AM
ruaok
better. what did you change?
2020-06-06 15855, 2020
11:34 AM
shivam-kapila
The reset_timescale_db() in tests was still using postgres instead of listenbrainz_ts
2020-06-06 15821, 2020
11:35 AM
shivam-kapila
I never looked there before to update the URI
2020-06-06 15822, 2020
11:35 AM
ruaok
yes, that would do it.
2020-06-06 15822, 2020
11:36 AM
shivam-kapila
The 2 failing are
2020-06-06 15822, 2020
11:36 AM
shivam-kapila
1. The listen_count view dependent test
2020-06-06 15822, 2020
11:36 AM
shivam-kapila
2. The test I added for try_harder which fails due to incomplete try_harder for `to_ts`
2020-06-06 15839, 2020
11:36 AM
shivam-kapila
In crux, problem is solved now
2020-06-06 15845, 2020
11:36 AM
ruaok
phew.
2020-06-06 15837, 2020
11:37 AM
shivam-kapila
Huh. Finally. Thanks
2020-06-06 15801, 2020
11:38 AM
ruaok
and now you know the divide and conquer method for debugging things like this.
2020-06-06 15853, 2020
11:38 AM
shivam-kapila
Yup. Credits to you
2020-06-06 15829, 2020
11:55 AM
BrainzGit
2020-06-06 15830, 2020
12:30 PM
shivam-kapila
ruaok: Fixed try_harder for `to_ts`, added test, updated try_harder to search_larger_time_range
2020-06-06 15836, 2020
12:30 PM
shivam-kapila
and pushed
2020-06-06 15859, 2020
12:58 PM
ruaok
great. did you resolve the conversations on the PR that correspond to the issues you've fixed?
2020-06-06 15853, 2020
13:01 PM
shivam-kapila
No I didn't
2020-06-06 15812, 2020
13:02 PM
shivam-kapila
Shall I do it now or wait till those commits get added into the PR?
2020-06-06 15845, 2020
13:04 PM
ruaok
pulled, running tests. let's do it soon, hopefully.
2020-06-06 15853, 2020
13:07 PM
sumedh has quit
2020-06-06 15808, 2020
13:08 PM
ruaok
2020-06-06 15813, 2020
13:08 PM
ruaok
much much better!
2020-06-06 15819, 2020
13:08 PM
ruaok
let me push these changes now.
2020-06-06 15841, 2020
13:08 PM
shivam-kapila
This test sometimes works sometimes doesnt
2020-06-06 15855, 2020
13:08 PM
ruaok
timing issue?
2020-06-06 15855, 2020
13:08 PM
shivam-kapila
Depends on did the view update in 2 sec or it didnt
2020-06-06 15843, 2020
13:09 PM
shivam-kapila
> timing issue?
2020-06-06 15843, 2020
13:09 PM
shivam-kapila
Yeah
2020-06-06 15837, 2020
13:10 PM
shivam-kapila
Plus I can't resolve the conversations. I can only comment on them
2020-06-06 15853, 2020
13:10 PM
sumedh joined the channel
2020-06-06 15837, 2020
13:13 PM
ruaok
I
2020-06-06 15803, 2020
13:14 PM
ruaok
I've resolved all the issues we just closed. two more items left that I can handle... and dump improvements.
2020-06-06 15808, 2020
13:14 PM
ruaok
thanks for all your help shivam-kapila.
2020-06-06 15820, 2020
13:14 PM
ruaok
but, I think now its time for you to get back to your gsoc project.
2020-06-06 15829, 2020
13:14 PM
dseomn has quit
2020-06-06 15857, 2020
13:14 PM
shivam-kapila
Sure thing. I was slowly slowly doing it sideways
2020-06-06 15820, 2020
13:22 PM
ruaok
.. on the side ...
2020-06-06 15855, 2020
13:23 PM
dseomn joined the channel
2020-06-06 15815, 2020
13:27 PM
shivam-kapila
oh 😅
2020-06-06 15856, 2020
13:38 PM
shivam-kapila
GH android app is now out for everyone
2020-06-06 15812, 2020
14:05 PM
Sophist-UK joined the channel
2020-06-06 15844, 2020
14:13 PM
sumedh has quit
2020-06-06 15857, 2020
14:40 PM
BrainzGit
2020-06-06 15827, 2020
14:48 PM
MrBrave has quit
2020-06-06 15817, 2020
14:53 PM
Chinmay3199 has quit
2020-06-06 15839, 2020
15:11 PM
Sophist_UK joined the channel
2020-06-06 15832, 2020
15:13 PM
Sophist-UK has quit
2020-06-06 15836, 2020
15:14 PM
Sophist-UK joined the channel
2020-06-06 15859, 2020
15:15 PM
Sophist_UK has quit
2020-06-06 15812, 2020
15:17 PM
Sophist_UK joined the channel
2020-06-06 15847, 2020
15:18 PM
Sophist-UK has quit
2020-06-06 15827, 2020
16:15 PM
ishaanshah
shivam-kapila: Updated the link
2020-06-06 15837, 2020
16:15 PM
shivam-kapila
ishaanshah: Hey. Thanks
2020-06-06 15856, 2020
16:15 PM
shivam-kapila
If we can do something like this with LB logo it will be really coook
2020-06-06 15859, 2020
16:15 PM
shivam-kapila
coool*
2020-06-06 15800, 2020
16:16 PM
shivam-kapila
2020-06-06 15840, 2020
16:16 PM
ishaanshah
It's a bit too much imo
2020-06-06 15854, 2020
16:16 PM
shivam-kapila
Yeah
2020-06-06 15809, 2020
16:17 PM
ishaanshah
But I would like to use bootstrap loader with orange or purple color
2020-06-06 15822, 2020
16:17 PM
ishaanshah
But that is not present in Bootstrap 3
2020-06-06 15843, 2020
16:17 PM
shivam-kapila
Hmm we should consider migrating to bootstrap 4
2020-06-06 15811, 2020
16:18 PM
ishaanshah
Yep we definitely should
2020-06-06 15851, 2020
16:21 PM
Sophist-UK joined the channel
2020-06-06 15832, 2020
16:23 PM
Sophist_UK has quit
2020-06-06 15822, 2020
16:24 PM
shivam-kapila
Just trying stuff :D
2020-06-06 15822, 2020
16:24 PM
shivam-kapila
2020-06-06 15854, 2020
16:27 PM
ishaanshah
that looks really cool
2020-06-06 15815, 2020
16:28 PM
shivam-kapila
I stole that 🤫
2020-06-06 15825, 2020
16:42 PM
KindTwo joined the channel
2020-06-06 15809, 2020
16:43 PM
KindOne has quit
2020-06-06 15842, 2020
16:46 PM
KindTwo is now known as KindOne
2020-06-06 15834, 2020
16:54 PM
KindTwo joined the channel
2020-06-06 15809, 2020
16:56 PM
KindOne has quit
2020-06-06 15846, 2020
16:58 PM
KindTwo is now known as KindOne
2020-06-06 15816, 2020
17:22 PM
Zastai joined the channel
2020-06-06 15830, 2020
17:31 PM
KindTwo joined the channel
2020-06-06 15814, 2020
17:33 PM
KindOne has quit
2020-06-06 15850, 2020
17:35 PM
KindTwo is now known as KindOne
2020-06-06 15808, 2020
17:52 PM
Chinmay3199 joined the channel
2020-06-06 15829, 2020
18:01 PM
jwf has quit
2020-06-06 15829, 2020
18:01 PM
ShraddhaAg has quit
2020-06-06 15849, 2020
18:54 PM
jwf joined the channel
2020-06-06 15850, 2020
18:55 PM
ShraddhaAg joined the channel
