#metabrainz

Mr_Monkey, I think https://github.com/bookbrainz/bookbrainz-site/c... is in a reasonable state as far as functionality. Still ugly as sin, but I think it basically does what it ought to. If you wouldn't mind playing around with it and letting me know how it feels, I'd appreciate it.

!m Leftmost

You're doing good work, Leftmost!

Leftmost: actually on line 21 it says "import {FontAwesomeIcon} from '@fortawesome/react-fontawesome';" should that say "fortawesome" ?

(in author-credit-editor.js )

Seemingly not. I believe fortawesome is the org. That's what the packages are named, certainly.

[listenbrainz-server] paramsingh merged pull request #874 (master…param/pydantic-stats-models): LB-540: Use a pydantic model for artist stats https://github.com/metabrainz/listenbrainz-serv...

LB-540: Enforce a schema for the statistics stored in postgres https://tickets.metabrainz.org/browse/LB-540

[musicbrainz-server] yvanzo opened pull request #1555 (master…fixup-435310dd54): Refactor 435310dd54: Check DBDefs instead of stash https://github.com/metabrainz/musicbrainz-serve...

ruaok: Hey. Did you get some solution to GRANT

I did some research but couldn't :(

no, I was AFK for a bit.

here is one thing to try: just before the call to create_tables, we should make a connection to TS and ask: what user am I?

and if the user is root or something not listenbrainz_ts, then our code to change the DB connection string is not working.

if the user is listenbrainz_ts, then we. uhm, need to dig more.

can you run that one test for me please?

On it

[musicbrainz-server] loujine opened pull request #1556 (master…MBS-8625-release_data_quality_icons): Mbs 8625 release data quality icons https://github.com/metabrainz/musicbrainz-serve...

MBS-8625: Add data quality icons https://tickets.metabrainz.org/browse/MBS-8625

[musicbrainz-server] reosarevok merged pull request #1545 (master…MBS-10856): MBS-10856: Trim whitespace on relationship credits https://github.com/metabrainz/musicbrainz-serve...

MBS-10856: Relationship credit with whitespace causes error https://tickets.metabrainz.org/browse/MBS-10856

loujine: I can push it to test.mb.o if you want to check i18n.

[musicbrainz-docker] loujine closed pull request #162 (master…perl-dev-setup): Fix 'cant locate JSON.pm' error in development setup https://github.com/metabrainz/musicbrainz-docke...

ruaok: The user is listenbrainz_ts if we connect to SQLALCHEMY_TIMESCALE_URI

ok, so then that is correct.

and the tables that are created are owned by?

listenbrainz_ts

do you have the test failure error message to hand? lets look at that again.

ok, continuing out divide can conquer approach, let's do this: run the server without the GRANT and see if you can import listens from last. fm. if you can, then it means our tests have a bug. if you can't then we need to look at which error we get.

make sense?

I have to go out and buy some food for the weekend. when I get back I can help take a look.

okay. I will try this till then

Strangely it worked

I think the test setup is borked.

ruaok: How does this look :grin: https://www.irccloud.com/pastebin/JCfub1T8/

better. what did you change?

The reset_timescale_db() in tests was still using postgres instead of listenbrainz_ts

I never looked there before to update the URI

yes, that would do it.

The 2 failing are

1. The listen_count view dependent test

2. The test I added for try_harder which fails due to incomplete try_harder for `to_ts`

In crux, problem is solved now

phew.

Huh. Finally. Thanks

and now you know the divide and conquer method for debugging things like this.

Yup. Credits to you

[musicbrainz-docker] yvanzo opened pull request #163 (master…set-db-shm-size): Set SHM size to 2 GB for database container https://github.com/metabrainz/musicbrainz-docke...

ruaok: Fixed try_harder for `to_ts`, added test, updated try_harder to search_larger_time_range

and pushed

great. did you resolve the conversations on the PR that correspond to the issues you've fixed?

No I didn't

Shall I do it now or wait till those commits get added into the PR?

pulled, running tests. let's do it soon, hopefully.

one test failed. https://gist.github.com/mayhem/dc17594a9a7f207d...

much much better!

let me push these changes now.

This test sometimes works sometimes doesnt

timing issue?

Depends on did the view update in 2 sec or it didnt

> timing issue?

Yeah

Plus I can't resolve the conversations. I can only comment on them

I

I've resolved all the issues we just closed. two more items left that I can handle... and dump improvements.

thanks for all your help shivam-kapila.

but, I think now its time for you to get back to your gsoc project.

Sure thing. I was slowly slowly doing it sideways

.. on the side ...

oh 😅

GH android app is now out for everyone

[listenbrainz-server] MonkeyDo opened pull request #905 (master…soundcloud-player): Soundcloud player https://github.com/metabrainz/listenbrainz-serv...

shivam-kapila: Updated the link

If we can do something like this with LB logo it will be really coook

coool*

It's a bit too much imo

Yeah

But I would like to use bootstrap loader with orange or purple color

But that is not present in Bootstrap 3

Hmm we should consider migrating to bootstrap 4

Yep we definitely should

Just trying stuff :D

that looks really cool

I stole that 🤫