12 hours for the ISP to figure out it's not fixable remotely…
2020-07-08 19037, 2020
sumedh has quit
2020-07-08 19030, 2020
sumedh joined the channel
2020-07-08 19045, 2020
v6lur joined the channel
2020-07-08 19052, 2020
CatQuest
iliekcomputers: huh, so I was wondering whytf ircloud wasn't connecting on mobile. thnx for info
2020-07-08 19057, 2020
Darkloke has quit
2020-07-08 19019, 2020
iliekcomputers has quit
2020-07-08 19031, 2020
chaban joined the channel
2020-07-08 19019, 2020
iliekcomputers joined the channel
2020-07-08 19048, 2020
ishaanshah has quit
2020-07-08 19003, 2020
iliekcomputers has quit
2020-07-08 19007, 2020
jmp_music joined the channel
2020-07-08 19056, 2020
supersandro2000 has quit
2020-07-08 19030, 2020
supersandro2000 joined the channel
2020-07-08 19034, 2020
alastairp has quit
2020-07-08 19053, 2020
prabal joined the channel
2020-07-08 19034, 2020
prabal
Mr_Monkey: `<th style={{width: '50%'}}>Name</th>` is this alrigh? or do you prefer to have css class in `style.less` ?
2020-07-08 19019, 2020
mr_monkey
prabal: that's good. If we have to do any more styling we'll move it to a css class
2020-07-08 19042, 2020
prabal
okayy. I made that change
2020-07-08 19054, 2020
prabal
It can be merged now
2020-07-08 19023, 2020
mr_monkey
I'll have a look in a minute.
2020-07-08 19022, 2020
mr_monkey
A quick question prabal: I'm working on having pagination show in the address bar, and stumbled on this line: https://github.com/bookbrainz/bookbrainz-site/blo… Is it supposed to have that "q=" at the end? There's no query needed for revisions, right?
2020-07-08 19036, 2020
mr_monkey
Same for editor revisions tab. I suppose they're just a copy paste leftover that isn't causing any problem, but don't serve any purpose in this case
2020-07-08 19035, 2020
prabal
I did same in collections too
2020-07-08 19013, 2020
prabal
but q is required for search tables
2020-07-08 19004, 2020
prabal
in case of revision, collection, q is empty string and in case of search q is the query
2020-07-08 19017, 2020
mr_monkey
Right.
2020-07-08 19029, 2020
mr_monkey
IK, I'm going to remove it from the revisions pagination
2020-07-08 19040, 2020
mr_monkey
just ends with "?"
2020-07-08 19047, 2020
mr_monkey
OK*
2020-07-08 19007, 2020
mr_monkey
I'd suggest doing the same to the collection pagination endpoints at some point
mr_monkey feels dirty. Gonna find a better way to do this
2020-07-08 19053, 2020
iliekcomputers joined the channel
2020-07-08 19055, 2020
mr_monkey
Yuck.
2020-07-08 19006, 2020
prabal
xD
2020-07-08 19039, 2020
mr_monkey
prabal: Regarding the `<th>` element on PR 468, I don't think you need any other hardcoded width apart from the first column (name). The rest will take the appropriate amount of space as necessary instead of wrapping around
[bookbrainz-site] prabalsingh24 opened pull request #469 (UserCollection…disableEditTypeForNonEmptyCollection): fix: disable edit EntityType field for non empty collection https://github.com/bookbrainz/bookbrainz-site/pul…
2020-07-08 19057, 2020
mr_monkey
Woot
2020-07-08 19059, 2020
mr_monkey has quit
2020-07-08 19049, 2020
prabal has quit
2020-07-08 19058, 2020
chaban joined the channel
2020-07-08 19014, 2020
jmp_music has quit
2020-07-08 19008, 2020
ishaanshah joined the channel
2020-07-08 19029, 2020
iliekcomputers
some of those twitter replies on the irccloud thread are getting mean
2020-07-08 19021, 2020
ishaanshah has quit
2020-07-08 19004, 2020
ishaanshah joined the channel
2020-07-08 19021, 2020
ishaanshah
iliekcomputers: hey
2020-07-08 19030, 2020
iliekcomputers
heyo
2020-07-08 19059, 2020
ishaanshah
IRCcloud was down today
2020-07-08 19010, 2020
ishaanshah
didn't realise that until now
2020-07-08 19028, 2020
ishaanshah
You didn't have any messages before now right?
2020-07-08 19038, 2020
iliekcomputers
nope!
2020-07-08 19003, 2020
ishaanshah
cool
2020-07-08 19012, 2020
iliekcomputers
my personal laptop has been dying randomly, i haven't been able to review PRs, but I will try to today.
2020-07-08 19051, 2020
ishaanshah
cool, let me know if any changes should be made
2020-07-08 19056, 2020
iliekcomputers
mhmm
2020-07-08 19004, 2020
ishaanshah
I worked on the top 10 entities today
2020-07-08 19024, 2020
ishaanshah
the UI is ready, I will complete the tests by tomorrow afternoon
2020-07-08 19034, 2020
iliekcomputers
nice nice
2020-07-08 19011, 2020
ishaanshah
Thats all I had for today
2020-07-08 19017, 2020
iliekcomputers
me too!
2020-07-08 19036, 2020
iliekcomputers
have a nice evening, hopefully irccloud is back tomorrow :)
