MBS-10940: Allow filtering the artist Releases tab by date and country
bitmap
reosarevok: yes thanks, thought it already was
reosarevok
Ok!
BrainzGit
[listenbrainz-server] ishaanshah opened pull request #959 (master…revert_to_correct_dump): LB-659: Add ability to revert back to older dump if the import fails https://github.com/metabrainz/listenbrainz-serv...
Yes prabal I was thinking the same, deploying the collections on test.bb to get a bit more feedback. We'll have to remember to be smart about what we do with the feedback and focus on the GSOC project's plan first before working on improvements. I'll deploy it today.
supersandro2000 has quit
supersandro2000 joined the channel
Sophist-UK joined the channel
Reem has quit
yvanzo
GH is back
prabal
Mr_Monkey: i have to make a quick fix before you deploy
[04:55] <prabal> I was wondering if we can deploy UserCollection branch on test.bb
I don't know what mrm onky thought but *I would very much like ot test it by now
Mr_Monkey: :D
whoo hoo so i'll test it after i have a morning showever and breakfast. cool!
but guys. update test with all all the database additions that's been doen since bow (so i cna est with al lthe works and editions i've added since then!)
On clicking older the top listen is gone and all the other (24 listens) move up and 1 new listen is fetched. On clicking Newer now only the 1 listenthat earlier vanished is shown
In short page 2 is totally same as page 1 except 1 new listen
Did you get that? I am sometimes confusing
jmp_music joined the channel
ALso shouldnt newer and newest be hidden when I am on 1st page
Similarly older and oldest when I am on the last
Mr_Monkey
Yeah, I see it. I'll have to dig a bit to see what's happening
Thanks for reporting !
And I found another on: If you go to oldest, there's no "older" button. If you then go one page newer, then one page older again, you now have the option to go one more older page, with 1 listen in it.
Anyway, some details for me to work one
shivam-kapila
similar like newer one
Mr_Monkey
Something to do with how I use min_ts and max_ts, and whether the results are inclusive or exclusive of that timestamp, I suppose.
shivam-kapila
I have similar thoughts
I guess its exclusive now
But making it exclusive wont solve as then some listens might end up being unreachable
Mr_Monkey
There is also two different mechanisms at play: when the page is requested on the server and when results are fetched by the front-end from the API.
ruaok: My sem project submissions are this week. I will have to devote some time there. Is it ok if I am a lil busy there this week?
CatQuest
prabal: also, while it works well, it's a tiny bit cumbersome adding something - I have to first click "add to collection" then I have tick a fairly small box and *then* I can click "add to selected collection(s)"
is it really important ot be able ot add ot several colections at a time? how often is this a thing?
it'd imho be easier if each listed collection had a "add ot this collection" button next ot it and that'd be the only click in that box you needed to add something (alternativly, why not both boxes ot multi add AND a single button on each collection to add to it right away)
on mb sites, each collection is just a link in the sidebar "add to $collection" (which, admittedly, can fairly take up space) a click will add it immediately - and then that link will say "remove from $collection" (on the flipside these both will trigger a page reload wich i've always found annoying)
the popup modal should be more like the sidebar on mb. once an entity is in that collection the box should be ticket (and if we have buttons to "add" that button should now say "remove form collection" )
thne the button on the page itself can jsut say "collections" and be any other colour thna blue also
ah, prabal, when doing the "create new" routine while *adding* to a collection: it's not clear which button to press once you've entered all the information. I was expecting a "ok" or "submit" or something
it was "add to new collection" I guess?
hmm pages need a refresh before that new collection is "registered"
I like the little green information box! but the text inside is too msall