#metabrainz

/

      • supersandro2000 has quit
      • 2020-07-13 19503, 2020

      • supersandro2000 joined the channel
      • 2020-07-13 19518, 2020

      • supersandro2000 has quit
      • 2020-07-13 19542, 2020

      • supersandro2000 joined the channel
      • 2020-07-13 19508, 2020

      • dseomn has quit
      • 2020-07-13 19514, 2020

      • dseomn joined the channel
      • 2020-07-13 19506, 2020

      • d4rkie has quit
      • 2020-07-13 19543, 2020

      • Nyanko-sensei joined the channel
      • 2020-07-13 19524, 2020

      • Clint has quit
      • 2020-07-13 19534, 2020

      • Clint joined the channel
      • 2020-07-13 19510, 2020

      • djwhitey joined the channel
      • 2020-07-13 19558, 2020

      • CallerNo6 has quit
      • 2020-07-13 19533, 2020

      • CallerNo6 joined the channel
      • 2020-07-13 19533, 2020

      • CallerNo6 has quit
      • 2020-07-13 19533, 2020

      • CallerNo6 joined the channel
      • 2020-07-13 19549, 2020

      • prabal
        Hello Good morninggg
      • 2020-07-13 19524, 2020

      • prabal
        Mr_Monkey: i have started writing tests and will continue doing that this week.
      • 2020-07-13 19508, 2020

      • prabal
        I was wondering if we can deploy UserCollection branch on test.bb
      • 2020-07-13 19514, 2020

      • prabal
        What do you think?
      • 2020-07-13 19558, 2020

      • Darkloke joined the channel
      • 2020-07-13 19534, 2020

      • supersandro2000 has quit
      • 2020-07-13 19507, 2020

      • supersandro2000 joined the channel
      • 2020-07-13 19551, 2020

      • v6lur joined the channel
      • 2020-07-13 19534, 2020

      • reosarevok
        bitmap: you mentioned you have code for https://tickets.metabrainz.org/browse/MBS-10940 ? Should I assign it to you?
      • 2020-07-13 19535, 2020

      • BrainzBot
        MBS-10940: Allow filtering the artist Releases tab by date and country
      • 2020-07-13 19551, 2020

      • bitmap
        reosarevok: yes thanks, thought it already was
      • 2020-07-13 19514, 2020

      • reosarevok
        Ok!
      • 2020-07-13 19501, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah opened pull request #959 (master…revert_to_correct_dump): LB-659: Add ability to revert back to older dump if the import fails https://github.com/metabrainz/listenbrainz-server…
      • 2020-07-13 19501, 2020

      • BrainzBot
        LB-659: Add ability to revert back to older dump if the import fails https://tickets.metabrainz.org/browse/LB-659
      • 2020-07-13 19544, 2020

      • ishaanshah
        iliekcomputers: ^ ready for review
      • 2020-07-13 19517, 2020

      • supersandro2000 has quit
      • 2020-07-13 19501, 2020

      • supersandro2000 joined the channel
      • 2020-07-13 19525, 2020

      • jmp_music joined the channel
      • 2020-07-13 19527, 2020

      • jmp_music
        morning!
      • 2020-07-13 19512, 2020

      • shivam-kapila
        Morning!!
      • 2020-07-13 19541, 2020

      • zas
        github has serious issues atm
      • 2020-07-13 19543, 2020

      • BestSteve has quit
      • 2020-07-13 19521, 2020

      • BestSteve joined the channel
      • 2020-07-13 19538, 2020

      • shivam-kapila
        Yeah major outrage
      • 2020-07-13 19556, 2020

      • yvanzo
        shocking ;)
      • 2020-07-13 19552, 2020

      • supersandro2000 has quit
      • 2020-07-13 19521, 2020

      • yvanzo
        Reem: java processes are for Solr of musicbrainz-docker 'search' service, you can tune it, see README.md and https://lucene.apache.org/solr/guide/7_7/taking-s…
      • 2020-07-13 19534, 2020

      • diru1100
        Morning!
      • 2020-07-13 19516, 2020

      • supersandro2000 joined the channel
      • 2020-07-13 19503, 2020

      • djwhitey has quit
      • 2020-07-13 19502, 2020

      • Mr_Monkey
        Moin moin!
      • 2020-07-13 19507, 2020

      • Mr_Monkey
        Yes prabal I was thinking the same, deploying the collections on test.bb to get a bit more feedback. We'll have to remember to be smart about what we do with the feedback and focus on the GSOC project's plan first before working on improvements. I'll deploy it today.
      • 2020-07-13 19548, 2020

      • supersandro2000 has quit
      • 2020-07-13 19558, 2020

      • supersandro2000 joined the channel
      • 2020-07-13 19554, 2020

      • Sophist-UK joined the channel
      • 2020-07-13 19556, 2020

      • Reem has quit
      • 2020-07-13 19552, 2020

      • yvanzo
        GH is back
      • 2020-07-13 19507, 2020

      • prabal
        Mr_Monkey: i have to make a quick fix before you deploy
      • 2020-07-13 19527, 2020

      • prabal
        I'll open the PR in a while
      • 2020-07-13 19530, 2020

      • Mr_Monkey
        OK. There's no rush, let me know when it's ready.
      • 2020-07-13 19504, 2020

      • ruaok
        mooin!
      • 2020-07-13 19502, 2020

      • Gazooo has quit
      • 2020-07-13 19514, 2020

      • Gazooo joined the channel
      • 2020-07-13 19550, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #472 (UserCollection…userCollection-Search): show collection in dropDown list of searchField https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-07-13 19530, 2020

      • prabal
        Mr_Monkey: ^
      • 2020-07-13 19542, 2020

      • pristine___
        ruaok: thanks 😂
      • 2020-07-13 19524, 2020

      • djwhitey joined the channel
      • 2020-07-13 19559, 2020

      • CatQuest
        continue doing that this week.
      • 2020-07-13 19500, 2020

      • CatQuest
        [04:55] <prabal> I was wondering if we can deploy UserCollection branch on test.bb
      • 2020-07-13 19500, 2020

      • CatQuest
        I don't know what mrm onky thought but *I would very much like ot test it by now
      • 2020-07-13 19526, 2020

      • CatQuest
        Mr_Monkey: :D
      • 2020-07-13 19548, 2020

      • CatQuest
        whoo hoo so i'll test it after i have a morning showever and breakfast. cool!
      • 2020-07-13 19550, 2020

      • CatQuest
        but guys. update test with all all the database additions that's been doen since bow (so i cna est with al lthe works and editions i've added since then!)
      • 2020-07-13 19508, 2020

      • CatQuest
        Mr_Monkey: 🙏
      • 2020-07-13 19530, 2020

      • CatQuest
      • 2020-07-13 19555, 2020

      • Mr_Monkey
        CatQuest: I updated the database on test.bb . Collections aren't on there yet but the DB is refreshed.
      • 2020-07-13 19553, 2020

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #472 (UserCollection…userCollection-Search): show collection in dropDown list of searchField https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-07-13 19504, 2020

      • ruaok
        well, the first glance looks ok: https://test.listenbrainz.org/user/rob
      • 2020-07-13 19510, 2020

      • ruaok
        ^^ shivam-kapila iliekcomputers
      • 2020-07-13 19540, 2020

      • travis-ci joined the channel
      • 2020-07-13 19540, 2020

      • travis-ci
        Project bookbrainz-site build #3225: passed in 3 min 14 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-07-13 19540, 2020

      • travis-ci has left the channel
      • 2020-07-13 19503, 2020

      • shivam-kapila
        ruaok: that looks clean to me
      • 2020-07-13 19513, 2020

      • shivam-kapila
        Apparently my profile has 200 dups
      • 2020-07-13 19546, 2020

      • ruaok
        I'm half tempted to write a listen_diff script that fetches both listenstreams and shows a diff.
      • 2020-07-13 19512, 2020

      • ruaok
        let me switch which DB it uses and then I'll ask more people to look.
      • 2020-07-13 19548, 2020

      • shivam-kapila
        The diff can be really helpful
      • 2020-07-13 19508, 2020

      • ruaok
        careful what you say. I might just volunteer you to write that. :)
      • 2020-07-13 19526, 2020

      • ruaok
        oh wait.
      • 2020-07-13 19526, 2020

      • Mr_Monkey
        I agree. I'm happy to go trhough a long diff to check, but without it I wouldn't know where to start to compare
      • 2020-07-13 19539, 2020

      • ruaok
        download json, use diff.
      • 2020-07-13 19540, 2020

      • ruaok
        duh.
      • 2020-07-13 19515, 2020

      • Mr_Monkey
        prabal, CatQuest: User collections are up on test.bookbrainz.org !
      • 2020-07-13 19519, 2020

      • ruaok
        it will still need a script since there will be minor differences.
      • 2020-07-13 19547, 2020

      • Mr_Monkey
        It's really nice to see the project in good shape at this stage of GSoC, well done prabal
      • 2020-07-13 19504, 2020

      • shivam-kapila
        > careful what you say. I might just volunteer you to write that. :)
      • 2020-07-13 19504, 2020

      • shivam-kapila
        Woops
      • 2020-07-13 19503, 2020

      • ruaok
        if anyone if curious as to why the music industry is such a mess, read this: https://completemusicupdate.com/article/lady-a-th…
      • 2020-07-13 19508, 2020

      • ruaok
        grrr.
      • 2020-07-13 19524, 2020

      • prabal
      • 2020-07-13 19545, 2020

      • prabal
        I just realised there is no create Collection button :p
      • 2020-07-13 19539, 2020

      • prabal
        Mr_Monkey thanksss
      • 2020-07-13 19559, 2020

      • prabal
        These features are remaining
      • 2020-07-13 19513, 2020

      • prabal
        1. Adding to collection from search table
      • 2020-07-13 19502, 2020

      • prabal
        2. Adding entity to collection from collectionView page (by searching entitiy)
      • 2020-07-13 19526, 2020

      • prabal
        3. Remove yourself as a collaborator route
      • 2020-07-13 19559, 2020

      • imdeni joined the channel
      • 2020-07-13 19532, 2020

      • Darkloke has quit
      • 2020-07-13 19525, 2020

      • shivam-kapila
        Mr_Monkey: Bug detected
      • 2020-07-13 19533, 2020

      • shivam-kapila
        In pagination
      • 2020-07-13 19550, 2020

      • Mr_Monkey
        shivam-kapila: shoot !
      • 2020-07-13 19550, 2020

      • jmp_music has quit
      • 2020-07-13 19521, 2020

      • shivam-kapila
      • 2020-07-13 19521, 2020

      • shivam-kapila
        On clicking older the top listen is gone and all the other (24 listens) move up and 1 new listen is fetched. On clicking Newer now only the 1 listenthat earlier vanished is shown
      • 2020-07-13 19540, 2020

      • shivam-kapila
        In short page 2 is totally same as page 1 except 1 new listen
      • 2020-07-13 19523, 2020

      • shivam-kapila
        Did you get that? I am sometimes confusing
      • 2020-07-13 19532, 2020

      • jmp_music joined the channel
      • 2020-07-13 19510, 2020

      • shivam-kapila
        ALso shouldnt newer and newest be hidden when I am on 1st page
      • 2020-07-13 19500, 2020

      • shivam-kapila
        Similarly older and oldest when I am on the last
      • 2020-07-13 19505, 2020

      • Mr_Monkey
        Yeah, I see it. I'll have to dig a bit to see what's happening
      • 2020-07-13 19538, 2020

      • Mr_Monkey
        Thanks for reporting !
      • 2020-07-13 19529, 2020

      • Mr_Monkey
        And I found another on: If you go to oldest, there's no "older" button. If you then go one page newer, then one page older again, you now have the option to go one more older page, with 1 listen in it.
      • 2020-07-13 19540, 2020

      • Mr_Monkey
        Anyway, some details for me to work one
      • 2020-07-13 19515, 2020

      • shivam-kapila
        similar like newer one
      • 2020-07-13 19504, 2020

      • Mr_Monkey
        Something to do with how I use min_ts and max_ts, and whether the results are inclusive or exclusive of that timestamp, I suppose.
      • 2020-07-13 19523, 2020

      • shivam-kapila
        I have similar thoughts
      • 2020-07-13 19534, 2020

      • shivam-kapila
        I guess its exclusive now
      • 2020-07-13 19506, 2020

      • shivam-kapila
        But making it exclusive wont solve as then some listens might end up being unreachable
      • 2020-07-13 19503, 2020

      • Mr_Monkey
        There is also two different mechanisms at play: when the page is requested on the server and when results are fetched by the front-end from the API.
      • 2020-07-13 19521, 2020

      • Mr_Monkey
        I'll investigate this week
      • 2020-07-13 19529, 2020

      • Mr_Monkey
        Gotta run for now !
      • 2020-07-13 19544, 2020

      • v6lur has quit
      • 2020-07-13 19546, 2020

      • v6lur joined the channel
      • 2020-07-13 19522, 2020

      • CatQuest
        prabal: one thing right away: https://test.bookbrainz.org/collection/create (I dislike "create *your* collection") it'd much more like "create a collection" or "create collection"
      • 2020-07-13 19534, 2020

      • CatQuest
        prabal: there is no indication on a page that it's *part* of a collection: https://test.bookbrainz.org/edition/4458097c-f107…
      • 2020-07-13 19505, 2020

      • shivam-kapila
        ruaok: My sem project submissions are this week. I will have to devote some time there. Is it ok if I am a lil busy there this week?
      • 2020-07-13 19535, 2020

      • CatQuest
        prabal: also, while it works well, it's a tiny bit cumbersome adding something - I have to first click "add to collection" then I have tick a fairly small box and *then* I can click "add to selected collection(s)"
      • 2020-07-13 19535, 2020

      • CatQuest
        is it really important ot be able ot add ot several colections at a time? how often is this a thing?
      • 2020-07-13 19535, 2020

      • CatQuest
        it'd imho be easier if each listed collection had a "add ot this collection" button next ot it and that'd be the only click in that box you needed to add something (alternativly, why not both boxes ot multi add AND a single button on each collection to add to it right away)
      • 2020-07-13 19513, 2020

      • CatQuest
        on mb sites, each collection is just a link in the sidebar "add to $collection" (which, admittedly, can fairly take up space) a click will add it immediately - and then that link will say "remove from $collection" (on the flipside these both will trigger a page reload wich i've always found annoying)
      • 2020-07-13 19519, 2020

      • CatQuest
        the popup modal should be more like the sidebar on mb. once an entity is in that collection the box should be ticket (and if we have buttons to "add" that button should now say "remove form collection" )
      • 2020-07-13 19544, 2020

      • CatQuest
        thne the button on the page itself can jsut say "collections" and be any other colour thna blue also
      • 2020-07-13 19532, 2020

      • CatQuest
        https://test.bookbrainz.org/collectionsis insteresting! I don't think we have anythig equivalent on mb. neat!
      • 2020-07-13 19500, 2020

      • CatQuest
        there should be a column for "number" of things in the collection though, imho
      • 2020-07-13 19526, 2020

      • CatQuest
      • 2020-07-13 19556, 2020

      • CatQuest
        ah, prabal, when doing the "create new" routine while *adding* to a collection: it's not clear which button to press once you've entered all the information. I was expecting a "ok" or "submit" or something
      • 2020-07-13 19506, 2020

      • CatQuest
        it was "add to new collection" I guess?
      • 2020-07-13 19520, 2020

      • CatQuest
        hmm pages need a refresh before that new collection is "registered"
      • 2020-07-13 19558, 2020

      • CatQuest
        I like the little green information box! but the text inside is too msall
      • 2020-07-13 19541, 2020

      • CatQuest
        ah, I am wrong I had zoomed out too much :D
      • 2020-07-13 19524, 2020

      • CatQuest
        neat!
      • 2020-07-13 19525, 2020

      • CatQuest
      • 2020-07-13 19537, 2020

      • CatQuest
        i see that it so far sorts on "the order it was added"
      • 2020-07-13 19555, 2020

      • CatQuest
        on "edit collection" https://test.bookbrainz.org/collection/4cec9d8c-b… there is no "cancel/ go bakc witotuh changing anything" type button
      • 2020-07-13 19526, 2020

      • CatQuest
        (as an aside, we should have some new badges for collections too once everything is done :D)