#metabrainz

Hello Good morninggg

Mr_Monkey: i have started writing tests and will continue doing that this week.

I was wondering if we can deploy UserCollection branch on test.bb

What do you think?

bitmap: you mentioned you have code for https://tickets.metabrainz.org/browse/MBS-10940 ? Should I assign it to you?

MBS-10940: Allow filtering the artist Releases tab by date and country

reosarevok: yes thanks, thought it already was

Ok!

[listenbrainz-server] ishaanshah opened pull request #959 (master…revert_to_correct_dump): LB-659: Add ability to revert back to older dump if the import fails https://github.com/metabrainz/listenbrainz-serv...

LB-659: Add ability to revert back to older dump if the import fails https://tickets.metabrainz.org/browse/LB-659

iliekcomputers: ^ ready for review

morning!

Morning!!

github has serious issues atm

Yeah major outrage

shocking ;)

Reem: java processes are for Solr of musicbrainz-docker 'search' service, you can tune it, see README.md and https://lucene.apache.org/solr/guide/7_7/taking...

Morning!

Moin moin!

Yes prabal I was thinking the same, deploying the collections on test.bb to get a bit more feedback. We'll have to remember to be smart about what we do with the feedback and focus on the GSOC project's plan first before working on improvements. I'll deploy it today.

GH is back

Mr_Monkey: i have to make a quick fix before you deploy

I'll open the PR in a while

OK. There's no rush, let me know when it's ready.

mooin!

[bookbrainz-site] prabalsingh24 opened pull request #472 (UserCollection…userCollection-Search): show collection in dropDown list of searchField https://github.com/bookbrainz/bookbrainz-site/p...

Mr_Monkey: ^

ruaok: thanks 😂

continue doing that this week.

[04:55] <prabal> I was wondering if we can deploy UserCollection branch on test.bb

I don't know what mrm onky thought but *I would very much like ot test it by now

Mr_Monkey: :D

whoo hoo so i'll test it after i have a morning showever and breakfast. cool!

but guys. update test with all all the database additions that's been doen since bow (so i cna est with al lthe works and editions i've added since then!)

Mr_Monkey: 🙏

example: https://beta.bookbrainz.org/work/b42d4619-02ab-... isn't in test

CatQuest: I updated the database on test.bb . Collections aren't on there yet but the DB is refreshed.

[bookbrainz-site] MonkeyDo merged pull request #472 (UserCollection…userCollection-Search): show collection in dropDown list of searchField https://github.com/bookbrainz/bookbrainz-site/p...

well, the first glance looks ok: https://test.listenbrainz.org/user/rob

^^ shivam-kapila iliekcomputers

Project bookbrainz-site build #3225: passed in 3 min 14 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

ruaok: that looks clean to me

Apparently my profile has 200 dups

I'm half tempted to write a listen_diff script that fetches both listenstreams and shows a diff.

let me switch which DB it uses and then I'll ask more people to look.

The diff can be really helpful

careful what you say. I might just volunteer you to write that. :)

oh wait.

I agree. I'm happy to go trhough a long diff to check, but without it I wouldn't know where to start to compare

download json, use diff.

duh.

prabal, CatQuest: User collections are up on test.bookbrainz.org !

it will still need a script since there will be minor differences.

It's really nice to see the project in good shape at this stage of GSoC, well done prabal

> careful what you say. I might just volunteer you to write that. :)

Woops

if anyone if curious as to why the music industry is such a mess, read this: https://completemusicupdate.com/article/lady-a-...

grrr.

CatQuest: test.bookbrainz.org/collection/create

I just realised there is no create Collection button :p

Mr_Monkey thanksss

These features are remaining

1. Adding to collection from search table

2. Adding entity to collection from collectionView page (by searching entitiy)

3. Remove yourself as a collaborator route

Mr_Monkey: Bug detected

In pagination

On clicking older the top listen is gone and all the other (24 listens) move up and 1 new listen is fetched. On clicking Newer now only the 1 listenthat earlier vanished is shown

In short page 2 is totally same as page 1 except 1 new listen

Did you get that? I am sometimes confusing

ALso shouldnt newer and newest be hidden when I am on 1st page

Similarly older and oldest when I am on the last

Yeah, I see it. I'll have to dig a bit to see what's happening

Thanks for reporting !

And I found another on: If you go to oldest, there's no "older" button. If you then go one page newer, then one page older again, you now have the option to go one more older page, with 1 listen in it.

Anyway, some details for me to work one

similar like newer one

Something to do with how I use min_ts and max_ts, and whether the results are inclusive or exclusive of that timestamp, I suppose.

I have similar thoughts

I guess its exclusive now

But making it exclusive wont solve as then some listens might end up being unreachable

There is also two different mechanisms at play: when the page is requested on the server and when results are fetched by the front-end from the API.

I'll investigate this week

Gotta run for now !

prabal: one thing right away: https://test.bookbrainz.org/collection/create (I dislike "create *your* collection") it'd much more like "create a collection" or "create collection"

prabal: there is no indication on a page that it's *part* of a collection: https://test.bookbrainz.org/edition/4458097c-f1...

ruaok: My sem project submissions are this week. I will have to devote some time there. Is it ok if I am a lil busy there this week?

prabal: also, while it works well, it's a tiny bit cumbersome adding something - I have to first click "add to collection" then I have tick a fairly small box and *then* I can click "add to selected collection(s)"

is it really important ot be able ot add ot several colections at a time? how often is this a thing?

it'd imho be easier if each listed collection had a "add ot this collection" button next ot it and that'd be the only click in that box you needed to add something (alternativly, why not both boxes ot multi add AND a single button on each collection to add to it right away)

on mb sites, each collection is just a link in the sidebar "add to $collection" (which, admittedly, can fairly take up space) a click will add it immediately - and then that link will say "remove from $collection" (on the flipside these both will trigger a page reload wich i've always found annoying)

the popup modal should be more like the sidebar on mb. once an entity is in that collection the box should be ticket (and if we have buttons to "add" that button should now say "remove form collection" )

thne the button on the page itself can jsut say "collections" and be any other colour thna blue also

https://test.bookbrainz.org/collectionsis insteresting! I don't think we have anythig equivalent on mb. neat!

there should be a column for "number" of things in the collection though, imho

also https://test.bookbrainz.org/editor/16/collections should have it here

ah, prabal, when doing the "create new" routine while *adding* to a collection: it's not clear which button to press once you've entered all the information. I was expecting a "ok" or "submit" or something

it was "add to new collection" I guess?

hmm pages need a refresh before that new collection is "registered"

I like the little green information box! but the text inside is too msall

ah, I am wrong I had zoomed out too much :D

neat!

i see that it so far sorts on "the order it was added"

on "edit collection" https://test.bookbrainz.org/collection/4cec9d8c... there is no "cancel/ go bakc witotuh changing anything" type button

(as an aside, we should have some new badges for collections too once everything is done :D)