2:06 AM
Gore has quit
2020-08-13 22624, 2020
2:07 AM
Gore joined the channel
2020-08-13 22618, 2020
2:21 AM
ishaanshah
Morning!
2020-08-13 22630, 2020
3:52 AM
rdswift_lt has left the channel
2020-08-13 22625, 2020
4:14 AM
white_shadow joined the channel
2020-08-13 22649, 2020
4:43 AM
apetresc has quit
2020-08-13 22646, 2020
4:48 AM
apetresc joined the channel
2020-08-13 22610, 2020
5:11 AM
enlgin joined the channel
2020-08-13 22633, 2020
5:11 AM
nelgin has quit
2020-08-13 22624, 2020
5:21 AM
v6lur joined the channel
2020-08-13 22615, 2020
5:47 AM
sumedh joined the channel
2020-08-13 22650, 2020
6:09 AM
sumedh has quit
2020-08-13 22614, 2020
6:10 AM
sumedh joined the channel
2020-08-13 22654, 2020
6:38 AM
killme has quit
2020-08-13 22604, 2020
6:39 AM
killme joined the channel
2020-08-13 22646, 2020
6:42 AM
white_snack joined the channel
2020-08-13 22620, 2020
6:44 AM
CallerNo6 has quit
2020-08-13 22636, 2020
6:46 AM
white_shadow has quit
2020-08-13 22655, 2020
6:46 AM
reosarevok
LB question on support: "I was wondering if there is a way to filter my listens by artist, similar to Last.fm. For example, if I wanted to see a chart of my top Nirvana albums. Here's a link to what I'm talking about.
https://www.last.fm/user/<username>/library…
2020-08-13 22600, 2020
6:47 AM
reosarevok
iliekcomputers, ruaok: not yet? :)
2020-08-13 22627, 2020
6:47 AM
shivam-kapila
not yet
2020-08-13 22640, 2020
6:52 AM
reosarevok
Ok
2020-08-13 22644, 2020
6:52 AM
reosarevok
Is it planned?
2020-08-13 22642, 2020
6:57 AM
CallerNo6 joined the channel
2020-08-13 22642, 2020
6:57 AM
CallerNo6 has quit
2020-08-13 22642, 2020
6:57 AM
CallerNo6 joined the channel
2020-08-13 22619, 2020
7:13 AM
iliekcomputers
reosarevok: not in the short term
2020-08-13 22658, 2020
7:15 AM
white_shadow joined the channel
2020-08-13 22604, 2020
7:18 AM
white_shadow has quit
2020-08-13 22622, 2020
7:19 AM
white_shadow joined the channel
2020-08-13 22625, 2020
7:19 AM
white_snack has quit
2020-08-13 22632, 2020
7:28 AM
MajorLurker joined the channel
2020-08-13 22650, 2020
7:33 AM
v6lur has quit
2020-08-13 22637, 2020
7:38 AM
MajorLurker has quit
2020-08-13 22642, 2020
7:48 AM
iliekcomputers
reosarevok: i replied.
2020-08-13 22622, 2020
7:54 AM
CallerNo6 has quit
2020-08-13 22646, 2020
7:54 AM
CallerNo6 joined the channel
2020-08-13 22631, 2020
8:01 AM
reosarevok
Thanks!
2020-08-13 22615, 2020
8:07 AM
white_shadow has quit
2020-08-13 22640, 2020
8:07 AM
white_shadow joined the channel
2020-08-13 22642, 2020
8:29 AM
jmp_music_
Morning!
2020-08-13 22635, 2020
8:39 AM
BrainzGit
2020-08-13 22637, 2020
8:39 AM
BrainzBot
2020-08-13 22637, 2020
8:39 AM
BrainzBot
2020-08-13 22625, 2020
8:41 AM
ruaok
mooooin!
2020-08-13 22650, 2020
8:41 AM
ruaok
reosarevok: iliekcomputers : I like that we're getting inquiries like that. very promising.
2020-08-13 22613, 2020
8:43 AM
iliekcomputers
agree
2020-08-13 22627, 2020
8:43 AM
iliekcomputers
2020-08-13 22650, 2020
8:43 AM
ruaok
heheh, I was just thinking I should review that.
2020-08-13 22658, 2020
8:43 AM
iliekcomputers
:D
2020-08-13 22603, 2020
8:44 AM
iliekcomputers
thanks!
2020-08-13 22612, 2020
8:44 AM
ruaok
also, how much work work it be to re-activate spotify connections for people who had theirs dropped?
2020-08-13 22621, 2020
8:44 AM
ruaok
I'd really like to fix that inbound data stream.
2020-08-13 22639, 2020
8:44 AM
yvanzo
bitmap, reosarevok: updating test.mb.o with loujine's PR gh:MBS#1578
2020-08-13 22640, 2020
8:44 AM
BrainzBot
2020-08-13 22602, 2020
8:45 AM
iliekcomputers
we have a record_listens field that we could set to true and see what happens.
2020-08-13 22620, 2020
8:45 AM
ruaok
so, a SQL query?
2020-08-13 22600, 2020
8:46 AM
iliekcomputers
2020-08-13 22616, 2020
8:46 AM
iliekcomputers
to test what happens when the record_listens field is turned to true
2020-08-13 22625, 2020
8:46 AM
ruaok
I think we ought to follow it up with a PR that tunes the conditions under which a connection is broken
2020-08-13 22601, 2020
8:47 AM
reosarevok
yvanzo: huh, what the actual fuck is going on with that toc link. Will try and figure it out
2020-08-13 22604, 2020
8:47 AM
iliekcomputers
hmm, i don't remember when we exactly stop recording listens. but yeah, would be worth a look
2020-08-13 22611, 2020
8:47 AM
reosarevok
I thought it would be the TOC id, but it is not
2020-08-13 22618, 2020
8:47 AM
reosarevok
It's also not a real toc though
2020-08-13 22614, 2020
8:48 AM
reosarevok
sigh
2020-08-13 22625, 2020
8:48 AM
reosarevok
yvanzo: that's a medium_cdtoc rowid
2020-08-13 22631, 2020
8:48 AM
yvanzo
reosarevok: this has been reported before iirc
2020-08-13 22650, 2020
8:48 AM
reosarevok
So clearly we need to not call it "toc="
2020-08-13 22658, 2020
8:48 AM
reosarevok
And load the actual toc for seeding
2020-08-13 22603, 2020
8:49 AM
reosarevok
I'll look into it
2020-08-13 22612, 2020
8:49 AM
yvanzo
thanks
2020-08-13 22615, 2020
8:49 AM
reosarevok
Seems like a good break from react :)
2020-08-13 22620, 2020
8:49 AM
reosarevok
But the PR is otherwise fine then? ;p
2020-08-13 22638, 2020
8:49 AM
yvanzo
I did not test preview in release editor
2020-08-13 22648, 2020
8:49 AM
pristine___
ruaok: the commands we issued yesterday did not run :(
2020-08-13 22619, 2020
8:50 AM
pristine___
I think you need to restart request consumer. Not sure though
2020-08-13 22611, 2020
8:51 AM
yvanzo
reosarevok: I like guessing games but did not find another way to test that :)
2020-08-13 22625, 2020
8:53 AM
reosarevok
2020-08-13 22650, 2020
8:53 AM
ruaok
2020-08-13 22619, 2020
8:54 AM
reosarevok
(if it doesn't, then that's bad :D)
2020-08-13 22627, 2020
8:54 AM
pristine___
ruaok: yay
2020-08-13 22634, 2020
8:54 AM
pristine___
I will tell you why
2020-08-13 22644, 2020
8:54 AM
pristine___
I was, actually waiting for the error
2020-08-13 22607, 2020
8:55 AM
ruaok
failed successfully, then?
2020-08-13 22629, 2020
8:56 AM
yvanzo
reosarevok: thanks, I will test that
2020-08-13 22607, 2020
8:57 AM
ruaok
iliekcomputers: I ticked one users box and wait a few minutes. token refreshed, listen imported.
2020-08-13 22622, 2020
8:57 AM
iliekcomputers
heh
2020-08-13 22638, 2020
8:57 AM
ruaok
let me review your code, then I'll write a query and have you check it before I run it.
2020-08-13 22639, 2020
8:57 AM
iliekcomputers
yeah, let's switch them on. see what happens.
2020-08-13 22645, 2020
9:03 AM
reosarevok
yvanzo: I can't find a ticket for that issue, do you remember seeing one?
2020-08-13 22651, 2020
9:03 AM
reosarevok
(if not I can just add it, but :) )
2020-08-13 22607, 2020
9:04 AM
yvanzo
reosarevok: maybe on community or #musicbrainz then
2020-08-13 22617, 2020
9:04 AM
reosarevok
Ok, I'll just add a ticket
2020-08-13 22602, 2020
9:05 AM
Gazooo has quit
2020-08-13 22648, 2020
9:06 AM
Gazooo joined the channel
2020-08-13 22635, 2020
9:09 AM
BrainzGit
2020-08-13 22636, 2020
9:09 AM
BrainzBot
2020-08-13 22634, 2020
9:11 AM
reosarevok
Hmm. Wonder if "Add a new release" even does *move* the CDTOC
2020-08-13 22609, 2020
9:12 AM
reosarevok
Seeding normally would only add it but not actually remove it from the existing release
2020-08-13 22626, 2020
9:13 AM
reosarevok
Possibly we should just disable the "Add a new release" section for /move links honestly
2020-08-13 22640, 2020
9:13 AM
white_shadow has quit
2020-08-13 22614, 2020
9:14 AM
reosarevok
Unless we can think of a way to seed the disc ID, then remove it from the other release, but *only* if the seeded release is actually added and not just cancelled mid-add
2020-08-13 22619, 2020
9:19 AM
yvanzo
maybe this button could be moved to the disc id page
2020-08-13 22601, 2020
9:21 AM
reosarevok
You mean to have a separate "add a new release based on this discid" button?
2020-08-13 22655, 2020
9:21 AM
ruaok
iliekcomputers: reviewed. so if we restarted redis then we lose the accurate count and be off for 2 days? I can live with that.
2020-08-13 22606, 2020
9:22 AM
yvanzo
Yes but it might not be a good idea actually.
2020-08-13 22654, 2020
9:22 AM
iliekcomputers
our redis instance is persistent, no?
2020-08-13 22615, 2020
9:23 AM
yvanzo
Disc ID is supposed to match a physical disc. There is no reason for not using Picard to seed a new release with a computed disc ID instead.
2020-08-13 22620, 2020
9:23 AM
iliekcomputers
but even if not, i'm ok with being off on this data. it can be recalculated anyways.
2020-08-13 22610, 2020
9:24 AM
yvanzo
(Except being a lazy reviewer)
2020-08-13 22642, 2020
9:24 AM
pristine___
ruaok: so I was checking if our top artist query is correct. It is, as proved by the error. We don't have MBIDs in the mapping for artists listened to by shivam-kapila therefore the join discarded all the artists. I think the error we encountered earlier for Mr_Monkey is related to this. I won't close that ticket since I am not sure about it but I will definitely open a PR to add an exception, warning us about
2020-08-13 22642, 2020
9:24 AM
pristine___
the unavailability of MBIDs.
2020-08-13 22634, 2020
9:25 AM
white_shadow joined the channel
2020-08-13 22647, 2020
9:25 AM
reosarevok
yvanzo: yeah, true. I think we should just change the page so that if *moving* rather than attaching, it just hides the usual Add new release section and says "if you want to move this to a new release, please add the release (we can link to a standard release/add there) and reload this page" ?
2020-08-13 22650, 2020
9:26 AM
ruaok
reviewing the artist mapping is next-next on my list. hopefully we can sort that out this morning.
2020-08-13 22620, 2020
9:27 AM
ruaok
(spanish morning, not swiss morning. there are 32 minutes and 48 seconds left in the swiss morning.)
2020-08-13 22630, 2020
9:27 AM
ruaok
considerably more in the spanish morning. )
2020-08-13 22635, 2020
9:29 AM
pristine___
ruaok: the mapping I was talking about is MBID MSID mapping. I don't think we can do much about it because it depends on the data submitted to Musicbrainz I think
2020-08-13 22648, 2020
9:29 AM
BrainzGit
2020-08-13 22606, 2020
9:30 AM
pristine___
> reviewing the artist mapping is next-next on my list. hopefully we can sort that out this morning.
2020-08-13 22611, 2020
9:30 AM
pristine___
Yes. The join.
2020-08-13 22620, 2020
9:30 AM
ruaok
oh, so unrelated to the bug you opened yesterdat?
2020-08-13 22627, 2020
9:30 AM
ruaok
ok
2020-08-13 22633, 2020
9:30 AM
pristine___
> oh, so unrelated to the bug you opened yesterdat?
2020-08-13 22647, 2020
9:30 AM
ruaok
have you checked to see if any of the artists that were not matched actually exist in MB?
2020-08-13 22650, 2020
9:30 AM
pristine___
Yup. The ticket is realted to artist-artist relation
2020-08-13 22653, 2020
9:30 AM
pristine___
Not the mapping
2020-08-13 22601, 2020
9:31 AM
ruaok
ok.
2020-08-13 22619, 2020
9:31 AM
ruaok
because this issue you mention could be two things:
2020-08-13 22627, 2020
9:31 AM
ruaok
1. The mapping not matching these artists.
2020-08-13 22636, 2020
9:31 AM
ruaok
2. These artists not existing in MB.
2020-08-13 22647, 2020
9:31 AM
ruaok
#1 is a problem for me, and that is known.
2020-08-13 22603, 2020
9:32 AM
ruaok
#2 is an opportunity we can take advantage of.
2020-08-13 22642, 2020
9:32 AM
ruaok
if you could produce a report that basically states: user X has release Y by artist Z in their top listens, but its not in MB.
2020-08-13 22601, 2020
9:33 AM
ruaok
then we can publish that on LB and poke users to add those releases to MB. which is something we've been wanting to do for aaaaaages.
2020-08-13 22609, 2020
9:33 AM
pristine___
Okay. So I checked for the artists MBID on bono using artist MSID. Nothing was returned so I guess it's the second issue.
2020-08-13 22630, 2020
9:33 AM
pristine___
> if you could produce a report that basically states: user X has release Y by artist Z in their top listens, but its not in MB.
2020-08-13 22634, 2020
9:33 AM
pristine___
Sounds good.
2020-08-13 22623, 2020
9:34 AM
ruaok
pristine___: can you pastebin a couple of examples that you didn't find in the mapping? I would like to take a closer look.
2020-08-13 22638, 2020
9:34 AM
white_shadow has left the channel
2020-08-13 22638, 2020
9:34 AM
pristine___
A sec
2020-08-13 22630, 2020
9:35 AM
pristine___
2020-08-13 22636, 2020
9:35 AM
pristine___
All the artists in here.
2020-08-13 22650, 2020
9:35 AM
pristine___
I looked up artists using artist MBID.
2020-08-13 22657, 2020
9:35 AM
ruaok
iliekcomputers: "select count(*) from spotify_auth where record_listens = 'f';" -> 512
2020-08-13 22635, 2020
9:36 AM
pristine___
MSID*
2020-08-13 22654, 2020
9:36 AM
reosarevok
bitmap, yvanzo: please give opinions/suggestions on MBS-11036 and then I can implement whatever we decide :)
2020-08-13 22655, 2020
9:36 AM
BrainzBot
2020-08-13 22656, 2020
9:36 AM
ruaok
is there any reason for us not to just `update spotify_auth set record_listens = 't' where record_listens = 'f';`
2020-08-13 22606, 2020
9:37 AM
ruaok
are there conditions where we don't want that?
