-
supersandro2000 has quit
-
supersandro2000 joined the channel
-
supersandro2000 has quit
-
supersandro2000 joined the channel
-
ljunkie has quit
-
ljunkie joined the channel
-
Gore has quit
-
Gore joined the channel
-
hugo___ has quit
-
Gore has quit
-
Gore joined the channel
-
diru1100 has quit
-
imdeni has quit
-
diru1100 joined the channel
-
Mr_Monkey has quit
-
diru1100 has quit
-
pristine___ has quit
-
outsidecontext has quit
-
imdeni joined the channel
-
Mr_Monkey joined the channel
-
diru1100 joined the channel
-
pristine___ joined the channel
-
hugo___ joined the channel
-
outsidecontext joined the channel
-
MajorLurker joined the channel
-
ishaanshah
shivam-kapila: pong
-
supersandro2000 has quit
-
supersandro2000 joined the channel
-
Lotheric has quit
-
pristine___
shivam-kapila: I read that you have a PR on Brainzplayer. Can you explain me in brief what functionality you plan to add in there?
-
:)
-
v6lur_ joined the channel
-
shivam-kapila
pristine___: didnt get ya
-
pristine___
shivam-kapila: what are you working at in Brainzplayer?
-
shivam-kapila
Just changing its look
-
Anything in your mind
-
Gazooo has quit
-
v6lur_ has quit
-
pristine___
shivam-kapila: ah. Cool. Not really, was just checking if you are doing anything in the backend.
-
Gazooo joined the channel
-
v6lur joined the channel
-
shivam-kapila
iliekcomputers: ruaok: Do we have a global/admin LB Spotify access token
-
ruaok
and API key or a playnback key?
-
shivam-kapila
just a KEY for search
-
CoverArts
-
to*
-
I am currently using user's token but that wont work if the user hasnt connected Spotfiy
-
v6lur has quit
-
ruaok
-
shivam-kapila
yes I am using mine
-
I mean can I change my code to use that in prod
-
iliekcomputers
shivam-kapila: we wouldn't want to expose an API key on the frontend anyways, btw.
-
the user's client secrets are only exposed when they're logged in.
-
BestSteve has quit
-
BestSteve joined the channel
-
Lotheric joined the channel
-
shivam-kapila
iliekcomputers: Right. Can you tell me then how should I be fetching coverarts
-
youtube API also needs access token
-
ishaanshah
shivam-kapila: CAA?
-
iliekcomputers
coverartarchive seems the way to go
-
shivam-kapila
But we dont have much data in CAA
-
iliekcomputers
it also adds an incentive for people to add covers to coverartarchive
-
if there's no coverart, link them to a page which allows them to add the art
-
shivam-kapila
So CAA? getCAA(): loadNoCoverArtPhoto()?
-
iliekcomputers
with link, yes
-
shivam-kapila
and what should that link be in your opinion
-
MB home page?
-
I mean add data page
-
ishaanshah
one more option maybe routing through the backend?
-
shivam-kapila
ishaanshah: Sorry didnt get you
-
Can you elaborate
-
ishaanshah
like write an endpoint to fetch coverart url from spotify
-
and use that in the code
-
then we dont expose the API key
-
shivam-kapila
and that uses our backend key
-
ishaanshah
yeah exactly
-
shivam-kapila
oh that will be a very nice idea
-
ishaanshah
maybe even have some primitive caching mechanism
-
shivam-kapila
Spotify gives a coverart in 99.99% cases
-
I am gonna cache the data afterwards
-
iliekcomputers
there is the risk of making the page slow.
-
shivam-kapila
iliekcomputers: I dont render the coverart in the starting itself
-
iliekcomputers
i'd prefer to use coverartarchive just to reduce our dependency on spotify, not sure what ruaok thinks
-
ruaok
I'd like that too.
-
shivam-kapila
I have added the logic in componentDidMount() so that the coverarts cn be fetched after that component loaded
-
ruaok
however... loading them from the archive directly is a poor user experience.
-
ideally there could be a cache.
-
shivam-kapila
oh
-
ruaok
I'm open for suggestions.
-
ishaanshah
how does spotify cover art work?
-
shivam-kapila
ishaanshah: Sorry again didnt get you
-
ishaanshah
I mean you get an URL right?
-
not the image itself
-
shivam-kapila
yes
-
ishaanshah
and CAA the same?
-
shivam-kapila
we get a url in CAA too
-
ishaanshah
Then the speed will be same, no?
-
iliekcomputers
we should definitely make it as generic as possible, so that it's easy to plug in different sources as backups
-
ishaanshah
and are we allowed to store the links to the images in our DB?
-
not the image itself just the link
-
shivam-kapila
I proposed it way back and then ruaok suggested we shouldnt do so just for the sake of simplicity
-
ruaok
storing links is fine.
-
iliekcomputers: +10
-
ishaanshah
what I was thinking was we have a table in the DB linking MBID to coverart link
-
and expose it via endpoint
-
shivam-kapila
We can already get a coverart using MBID
-
ishaanshah
also allow POSTing to this endpoint so that we can send multiple items
-
shivam-kapila
I am up for makinng the solution generic but I will need some opinions on this thing
-
ishaanshah
> we should definitely make it as generic as possible, so that it's easy to plug in different sources as backups
-
I was talking about this
-
iliekcomputers
LB-701
-
BrainzBot
-
ishaanshah
this way we can have multiple sources
-
shivam-kapila
I mean we can add the url during imports
-
in additional_info
-
but what for the data already present
-
ishaanshah
ok, what I was thinking was, we do something similar to the artist map thing
-
in the beginning the DB will be empty
-
now when I make a request, by MBID or MSID
-
I lookup for the image in spotify, CAA...
-
store the link in the DB
-
next time the retrieval will be faster
-
this way we get both speed and generic data sources
-
I am not sure about the identifier, i.e MBID or MSID
-
or simply the release name
-
shivam-kapila
ew can make request via recording_msid and user_name
-
ew*
-
as the fields
-
or just recording_msid
-
wait I will list down the steps
-
ruaok
ishaanshah: I am not worried about fetching the links -- that is generally easy.
-
it loading images from the archive that is slow and very error prone.
-
shivam-kapila
+1
-
ishaanshah
ohh, so the archive is the problem?
-
ruaok
yes.
-
ishaanshah
ohk
-
ruaok
which is why an cache would solve the problem.
-
but we can't host such a thing.
-
ishaanshah
hmm, got it
-
we still can use spotify through the backend though
-
shivam-kapila
that seems the best way around here
-
ruaok
I think we should rely on spotify for now, and the CAA when we can't get an image from the IA.
-
make the system modular and then improve on as we can.
-
but given the time constraints for GSoC and shivam-kapila's insane schedule, lets just use spotify cover art.
-
shivam-kapila
-
does this sound good for now?
-
ishaanshah
yep, looks good to me
-
shivam-kapila
ruaok: iliekcomputers: you??
-
ruaok
which DB??
-
shivam-kapila
Timescale