-
supersandro2000 has quit
2020-08-15 22804, 2020
-
supersandro2000 joined the channel
2020-08-15 22837, 2020
-
supersandro2000 has quit
2020-08-15 22846, 2020
-
supersandro2000 joined the channel
2020-08-15 22800, 2020
-
ljunkie has quit
2020-08-15 22827, 2020
-
ljunkie joined the channel
2020-08-15 22852, 2020
-
Gore has quit
2020-08-15 22838, 2020
-
Gore joined the channel
2020-08-15 22815, 2020
-
hugo___ has quit
2020-08-15 22823, 2020
-
Gore has quit
2020-08-15 22804, 2020
-
Gore joined the channel
2020-08-15 22852, 2020
-
diru1100 has quit
2020-08-15 22811, 2020
-
imdeni has quit
2020-08-15 22837, 2020
-
diru1100 joined the channel
2020-08-15 22857, 2020
-
Mr_Monkey has quit
2020-08-15 22816, 2020
-
diru1100 has quit
2020-08-15 22827, 2020
-
pristine___ has quit
2020-08-15 22851, 2020
-
outsidecontext has quit
2020-08-15 22808, 2020
-
imdeni joined the channel
2020-08-15 22829, 2020
-
Mr_Monkey joined the channel
2020-08-15 22839, 2020
-
diru1100 joined the channel
2020-08-15 22846, 2020
-
pristine___ joined the channel
2020-08-15 22854, 2020
-
hugo___ joined the channel
2020-08-15 22859, 2020
-
outsidecontext joined the channel
2020-08-15 22807, 2020
-
MajorLurker joined the channel
2020-08-15 22807, 2020
-
ishaanshah
shivam-kapila: pong
2020-08-15 22845, 2020
-
supersandro2000 has quit
2020-08-15 22829, 2020
-
supersandro2000 joined the channel
2020-08-15 22836, 2020
-
Lotheric has quit
2020-08-15 22822, 2020
-
pristine___
shivam-kapila: I read that you have a PR on Brainzplayer. Can you explain me in brief what functionality you plan to add in there?
2020-08-15 22824, 2020
-
pristine___
:)
2020-08-15 22821, 2020
-
v6lur_ joined the channel
2020-08-15 22848, 2020
-
shivam-kapila
pristine___: didnt get ya
2020-08-15 22837, 2020
-
pristine___
shivam-kapila: what are you working at in Brainzplayer?
2020-08-15 22852, 2020
-
shivam-kapila
Just changing its look
2020-08-15 22812, 2020
-
shivam-kapila
Anything in your mind
2020-08-15 22801, 2020
-
Gazooo has quit
2020-08-15 22854, 2020
-
v6lur_ has quit
2020-08-15 22848, 2020
-
pristine___
shivam-kapila: ah. Cool. Not really, was just checking if you are doing anything in the backend.
2020-08-15 22849, 2020
-
Gazooo joined the channel
2020-08-15 22800, 2020
-
v6lur joined the channel
2020-08-15 22851, 2020
-
shivam-kapila
iliekcomputers: ruaok: Do we have a global/admin LB Spotify access token
2020-08-15 22811, 2020
-
ruaok
and API key or a playnback key?
2020-08-15 22849, 2020
-
shivam-kapila
just a KEY for search
2020-08-15 22852, 2020
-
shivam-kapila
CoverArts
2020-08-15 22856, 2020
-
shivam-kapila
to*
2020-08-15 22849, 2020
-
shivam-kapila
I am currently using user's token but that wont work if the user hasnt connected Spotfiy
2020-08-15 22822, 2020
-
v6lur has quit
2020-08-15 22835, 2020
-
ruaok
2020-08-15 22805, 2020
-
shivam-kapila
yes I am using mine
2020-08-15 22832, 2020
-
shivam-kapila
I mean can I change my code to use that in prod
2020-08-15 22841, 2020
-
iliekcomputers
shivam-kapila: we wouldn't want to expose an API key on the frontend anyways, btw.
2020-08-15 22858, 2020
-
iliekcomputers
the user's client secrets are only exposed when they're logged in.
2020-08-15 22809, 2020
-
BestSteve has quit
2020-08-15 22852, 2020
-
BestSteve joined the channel
2020-08-15 22835, 2020
-
Lotheric joined the channel
2020-08-15 22838, 2020
-
shivam-kapila
iliekcomputers: Right. Can you tell me then how should I be fetching coverarts
2020-08-15 22805, 2020
-
shivam-kapila
youtube API also needs access token
2020-08-15 22821, 2020
-
ishaanshah
shivam-kapila: CAA?
2020-08-15 22836, 2020
-
iliekcomputers
coverartarchive seems the way to go
2020-08-15 22847, 2020
-
shivam-kapila
But we dont have much data in CAA
2020-08-15 22850, 2020
-
iliekcomputers
it also adds an incentive for people to add covers to coverartarchive
2020-08-15 22812, 2020
-
iliekcomputers
if there's no coverart, link them to a page which allows them to add the art
2020-08-15 22824, 2020
-
shivam-kapila
So CAA? getCAA(): loadNoCoverArtPhoto()?
2020-08-15 22838, 2020
-
iliekcomputers
with link, yes
2020-08-15 22822, 2020
-
shivam-kapila
and what should that link be in your opinion
2020-08-15 22837, 2020
-
shivam-kapila
MB home page?
2020-08-15 22847, 2020
-
shivam-kapila
I mean add data page
2020-08-15 22800, 2020
-
ishaanshah
one more option maybe routing through the backend?
2020-08-15 22812, 2020
-
shivam-kapila
ishaanshah: Sorry didnt get you
2020-08-15 22821, 2020
-
shivam-kapila
Can you elaborate
2020-08-15 22828, 2020
-
ishaanshah
like write an endpoint to fetch coverart url from spotify
2020-08-15 22843, 2020
-
ishaanshah
and use that in the code
2020-08-15 22851, 2020
-
ishaanshah
then we dont expose the API key
2020-08-15 22856, 2020
-
shivam-kapila
and that uses our backend key
2020-08-15 22808, 2020
-
ishaanshah
yeah exactly
2020-08-15 22809, 2020
-
shivam-kapila
oh that will be a very nice idea
2020-08-15 22830, 2020
-
ishaanshah
maybe even have some primitive caching mechanism
2020-08-15 22830, 2020
-
shivam-kapila
Spotify gives a coverart in 99.99% cases
2020-08-15 22848, 2020
-
shivam-kapila
I am gonna cache the data afterwards
2020-08-15 22800, 2020
-
iliekcomputers
there is the risk of making the page slow.
2020-08-15 22823, 2020
-
shivam-kapila
iliekcomputers: I dont render the coverart in the starting itself
2020-08-15 22824, 2020
-
iliekcomputers
i'd prefer to use coverartarchive just to reduce our dependency on spotify, not sure what ruaok thinks
2020-08-15 22846, 2020
-
ruaok
I'd like that too.
2020-08-15 22801, 2020
-
shivam-kapila
I have added the logic in componentDidMount() so that the coverarts cn be fetched after that component loaded
2020-08-15 22805, 2020
-
ruaok
however... loading them from the archive directly is a poor user experience.
2020-08-15 22815, 2020
-
ruaok
ideally there could be a cache.
2020-08-15 22834, 2020
-
shivam-kapila
oh
2020-08-15 22852, 2020
-
ruaok
I'm open for suggestions.
2020-08-15 22805, 2020
-
ishaanshah
how does spotify cover art work?
2020-08-15 22819, 2020
-
shivam-kapila
ishaanshah: Sorry again didnt get you
2020-08-15 22827, 2020
-
ishaanshah
I mean you get an URL right?
2020-08-15 22834, 2020
-
ishaanshah
not the image itself
2020-08-15 22839, 2020
-
shivam-kapila
yes
2020-08-15 22845, 2020
-
ishaanshah
and CAA the same?
2020-08-15 22803, 2020
-
shivam-kapila
we get a url in CAA too
2020-08-15 22822, 2020
-
ishaanshah
Then the speed will be same, no?
2020-08-15 22836, 2020
-
iliekcomputers
we should definitely make it as generic as possible, so that it's easy to plug in different sources as backups
2020-08-15 22828, 2020
-
ishaanshah
and are we allowed to store the links to the images in our DB?
2020-08-15 22837, 2020
-
ishaanshah
not the image itself just the link
2020-08-15 22818, 2020
-
shivam-kapila
I proposed it way back and then ruaok suggested we shouldnt do so just for the sake of simplicity
2020-08-15 22857, 2020
-
ruaok
storing links is fine.
2020-08-15 22802, 2020
-
ruaok
iliekcomputers: +10
2020-08-15 22807, 2020
-
ishaanshah
what I was thinking was we have a table in the DB linking MBID to coverart link
2020-08-15 22823, 2020
-
ishaanshah
and expose it via endpoint
2020-08-15 22843, 2020
-
shivam-kapila
We can already get a coverart using MBID
2020-08-15 22846, 2020
-
ishaanshah
also allow POSTing to this endpoint so that we can send multiple items
2020-08-15 22834, 2020
-
shivam-kapila
I am up for makinng the solution generic but I will need some opinions on this thing
2020-08-15 22836, 2020
-
ishaanshah
> we should definitely make it as generic as possible, so that it's easy to plug in different sources as backups
2020-08-15 22836, 2020
-
ishaanshah
I was talking about this
2020-08-15 22846, 2020
-
iliekcomputers
LB-701
2020-08-15 22847, 2020
-
BrainzBot
2020-08-15 22852, 2020
-
ishaanshah
this way we can have multiple sources
2020-08-15 22817, 2020
-
shivam-kapila
I mean we can add the url during imports
2020-08-15 22824, 2020
-
shivam-kapila
in additional_info
2020-08-15 22834, 2020
-
shivam-kapila
but what for the data already present
2020-08-15 22804, 2020
-
ishaanshah
ok, what I was thinking was, we do something similar to the artist map thing
2020-08-15 22818, 2020
-
ishaanshah
in the beginning the DB will be empty
2020-08-15 22832, 2020
-
ishaanshah
now when I make a request, by MBID or MSID
2020-08-15 22848, 2020
-
ishaanshah
I lookup for the image in spotify, CAA...
2020-08-15 22853, 2020
-
ishaanshah
store the link in the DB
2020-08-15 22803, 2020
-
ishaanshah
next time the retrieval will be faster
2020-08-15 22814, 2020
-
ishaanshah
this way we get both speed and generic data sources
2020-08-15 22837, 2020
-
ishaanshah
I am not sure about the identifier, i.e MBID or MSID
2020-08-15 22859, 2020
-
ishaanshah
or simply the release name
2020-08-15 22812, 2020
-
shivam-kapila
ew can make request via recording_msid and user_name
2020-08-15 22814, 2020
-
shivam-kapila
ew*
2020-08-15 22819, 2020
-
shivam-kapila
as the fields
2020-08-15 22856, 2020
-
shivam-kapila
or just recording_msid
2020-08-15 22815, 2020
-
shivam-kapila
wait I will list down the steps
2020-08-15 22830, 2020
-
ruaok
ishaanshah: I am not worried about fetching the links -- that is generally easy.
2020-08-15 22840, 2020
-
ruaok
it loading images from the archive that is slow and very error prone.
2020-08-15 22850, 2020
-
shivam-kapila
+1
2020-08-15 22852, 2020
-
ishaanshah
ohh, so the archive is the problem?
2020-08-15 22857, 2020
-
ruaok
yes.
2020-08-15 22803, 2020
-
ishaanshah
ohk
2020-08-15 22808, 2020
-
ruaok
which is why an cache would solve the problem.
2020-08-15 22813, 2020
-
ruaok
but we can't host such a thing.
2020-08-15 22814, 2020
-
ishaanshah
hmm, got it
2020-08-15 22831, 2020
-
ishaanshah
we still can use spotify through the backend though
2020-08-15 22843, 2020
-
shivam-kapila
that seems the best way around here
2020-08-15 22856, 2020
-
ruaok
I think we should rely on spotify for now, and the CAA when we can't get an image from the IA.
2020-08-15 22808, 2020
-
ruaok
make the system modular and then improve on as we can.
2020-08-15 22828, 2020
-
ruaok
but given the time constraints for GSoC and shivam-kapila's insane schedule, lets just use spotify cover art.
2020-08-15 22855, 2020
-
shivam-kapila
2020-08-15 22806, 2020
-
shivam-kapila
does this sound good for now?
2020-08-15 22831, 2020
-
ishaanshah
yep, looks good to me
2020-08-15 22843, 2020
-
shivam-kapila
ruaok: iliekcomputers: you??
2020-08-15 22828, 2020
-
ruaok
which DB??
2020-08-15 22834, 2020
-
shivam-kapila
Timescale
