#metabrainz

/

      • apetresc has quit
      • 2020-09-29 27336, 2020

      • apetresc joined the channel
      • 2020-09-29 27332, 2020

      • d4rkie has quit
      • 2020-09-29 27325, 2020

      • Nyanko-sensei joined the channel
      • 2020-09-29 27342, 2020

      • BestSteve has quit
      • 2020-09-29 27326, 2020

      • BestSteve joined the channel
      • 2020-09-29 27303, 2020

      • thomasross joined the channel
      • 2020-09-29 27325, 2020

      • thomasross has quit
      • 2020-09-29 27305, 2020

      • blinky42 has quit
      • 2020-09-29 27307, 2020

      • Nyanko-sensei has quit
      • 2020-09-29 27311, 2020

      • Nyanko-sensei joined the channel
      • 2020-09-29 27319, 2020

      • Nyanko-sensei has quit
      • 2020-09-29 27333, 2020

      • Nyanko-sensei joined the channel
      • 2020-09-29 27353, 2020

      • supersandro2000 joined the channel
      • 2020-09-29 27332, 2020

      • _lucifer
        the wiki site is looking odd, https://wiki.musicbrainz.org/Main_Page
      • 2020-09-29 27330, 2020

      • _lucifer
        It seems like it is treating my desktop browser as a mobile
      • 2020-09-29 27312, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1707 (master…MBS-11033): MBS-11033: Update the Apple Music logo https://github.com/metabrainz/musicbrainz-server/…
      • 2020-09-29 27314, 2020

      • BrainzBot
        MBS-11033: Update the Apple Music logo used in the sidebar https://tickets.metabrainz.org/browse/MBS-11033
      • 2020-09-29 27303, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1713 (master…MBS-3116): MBS-3116: Warn when merging works with different ISWCs https://github.com/metabrainz/musicbrainz-server/…
      • 2020-09-29 27304, 2020

      • BrainzBot
        MBS-3116: Warn when merging works with different ISWCs https://tickets.metabrainz.org/browse/MBS-3116
      • 2020-09-29 27317, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1716 (master…MBS-6322): MBS-6322: Add report for releases with same barcodes in diff RGs https://github.com/metabrainz/musicbrainz-server/…
      • 2020-09-29 27318, 2020

      • BrainzBot
        MBS-6322: New Report: Releases with identical barcodes in different Release Groups https://tickets.metabrainz.org/browse/MBS-6322
      • 2020-09-29 27342, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1714 (master…MBS-4118): MBS-4118: Add full-icu to Node for locale strings https://github.com/metabrainz/musicbrainz-server/…
      • 2020-09-29 27343, 2020

      • BrainzBot
        MBS-4118: Date/Number.toLocaleString always uses English https://tickets.metabrainz.org/browse/MBS-4118
      • 2020-09-29 27339, 2020

      • d4rkie joined the channel
      • 2020-09-29 27307, 2020

      • Nyanko-sensei has quit
      • 2020-09-29 27338, 2020

      • d4rkie has quit
      • 2020-09-29 27307, 2020

      • Nyanko-sensei joined the channel
      • 2020-09-29 27310, 2020

      • yvanzo
        _lucifer: how odd?
      • 2020-09-29 27331, 2020

      • yvanzo
        I don't have any issue with it at least.
      • 2020-09-29 27357, 2020

      • _lucifer
      • 2020-09-29 27304, 2020

      • _lucifer
        This is how it shows up on my PC yvanzo
      • 2020-09-29 27338, 2020

      • _lucifer
        probably it is some misconfigured setting then
      • 2020-09-29 27346, 2020

      • _lucifer
        on y end
      • 2020-09-29 27349, 2020

      • _lucifer
        *my
      • 2020-09-29 27337, 2020

      • Rotab
        reset your zoom
      • 2020-09-29 27310, 2020

      • adhawkins
        Hi all. Seeing fairly regular OOM reports on my VM running MBserver under docker. Not generating search indexes. VM has 4 Gig of RAM and 2 processors.
      • 2020-09-29 27323, 2020

      • adhawkins
        Is this expected? 4 Gig is the recommended configuration I seem to recall?
      • 2020-09-29 27302, 2020

      • ruaok
        moin adhawkins. 4gig seems rather paltry for a VM. Go for 8 and I think you'll see some problems go awa.
      • 2020-09-29 27305, 2020

      • ruaok
        away even
      • 2020-09-29 27341, 2020

      • yvanzo
        If OOM occurs in db container, you can try increasing shared_buffers first.
      • 2020-09-29 27320, 2020

      • adhawkins
        yvanzo: How would I work that out?
      • 2020-09-29 27336, 2020

      • adhawkins
        ruaok: 8 Gig would be a quarter of the RAM in the host! :)
      • 2020-09-29 27358, 2020

      • ruaok
        only a quarter? fin, 16G then!
      • 2020-09-29 27301, 2020

      • ruaok
        :)
      • 2020-09-29 27320, 2020

      • adhawkins
        Wouldn't leave very much for the other VMs :)
      • 2020-09-29 27324, 2020

      • adhawkins
        This is only my home setup...
      • 2020-09-29 27322, 2020

      • adhawkins
        It's not happening a lot. These are since the VM was booted on 22nd Sept:
      • 2020-09-29 27340, 2020

      • adhawkins
      • 2020-09-29 27340, 2020

      • yvanzo
        adhawkins: docker-compose config | grep shared_buffers
      • 2020-09-29 27300, 2020

      • adhawkins
        2048M
      • 2020-09-29 27305, 2020

      • yvanzo
        but it seems that OOM is invoked on perl, that is musicbrainz server itself, so it's not related to pg shared_buffers.
      • 2020-09-29 27329, 2020

      • adhawkins
        I think OOM killer just looks for a candidate process to kill, not necessarily the one that's causing the OOM?
      • 2020-09-29 27352, 2020

      • reosarevok
      • 2020-09-29 27356, 2020

      • reosarevok
        I lol'd
      • 2020-09-29 27352, 2020

      • adhawkins
        3am is the time I run a local check of my entire library against the server. It usually finishes around an hour or so later.
      • 2020-09-29 27305, 2020

      • yvanzo
        adhawkins: try pushing it to 3GB, see https://github.com/metabrainz/musicbrainz-docker#… (just ignore the "search" part)
      • 2020-09-29 27323, 2020

      • adhawkins
        So there will be lots of XML WS requests during the hour between 3am and around 4 ish
      • 2020-09-29 27342, 2020

      • yvanzo
        if the problem comes from musicbrainz server itself, there should be hints from `docker-compose logs musicbrainz`
      • 2020-09-29 27340, 2020

      • yvanzo
        adhawkins: does your replication cron job run at the same time?
      • 2020-09-29 27302, 2020

      • adhawkins
        yvanzo: It runs at around 15 minutes past the hour I think
      • 2020-09-29 27339, 2020

      • yvanzo
        every hour?
      • 2020-09-29 27343, 2020

      • adhawkins
        Yes
      • 2020-09-29 27332, 2020

      • yvanzo
        ok, so there is only one replication packet to be retrieved and applied, that’s better than 24.
      • 2020-09-29 27301, 2020

      • adhawkins
        Yes
      • 2020-09-29 27315, 2020

      • adhawkins
        I could exclude the hours between say 3 and 6 too, see if that helps?
      • 2020-09-29 27328, 2020

      • yvanzo
        You can check slave.log.X for potential errors related to OOM.
      • 2020-09-29 27351, 2020

      • yvanzo
        Yes, excluding it during that time could possibly help.
      • 2020-09-29 27302, 2020

      • Gazooo794 has quit
      • 2020-09-29 27304, 2020

      • reosarevok
        Mr_Monkey: around?
      • 2020-09-29 27330, 2020

      • Mr_Monkey
        Hai !
      • 2020-09-29 27341, 2020

      • adhawkins
        Ok, I'll do that as well yvanzo and monitor.
      • 2020-09-29 27324, 2020

      • adhawkins
        If I change the replication crontab, what do I need to do to have it applied? Just restart the container?
      • 2020-09-29 27332, 2020

      • Mr_Monkey
        Let me guess, wanna talk about dates reo?
      • 2020-09-29 27344, 2020

      • Gazooo794 joined the channel
      • 2020-09-29 27350, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1710 (master…MBS-11121): MBS-11121: Normalize Apple Music beta links https://github.com/metabrainz/musicbrainz-server/…
      • 2020-09-29 27351, 2020

      • BrainzBot
        MBS-11121: Update iTunes/Apple Music URL cleanup https://tickets.metabrainz.org/browse/MBS-11121
      • 2020-09-29 27310, 2020

      • yvanzo
        adhawkins: you should check it with crontab -l
      • 2020-09-29 27335, 2020

      • pristine___
        ruaok: the travis build stops for some reason, can you have a look?
      • 2020-09-29 27336, 2020

      • yvanzo
        you can edit it directly in the container with crontab -e but if you modify it in docker compose config, you need to "up" it (which will stop, remove, recreate a container).
      • 2020-09-29 27336, 2020

      • pristine___
      • 2020-09-29 27347, 2020

      • reosarevok
        Mr_Monkey: I do!
      • 2020-09-29 27349, 2020

      • ruaok
        heh. travis is being rate limited by github.
      • 2020-09-29 27352, 2020

      • ruaok
        that's tricky
      • 2020-09-29 27357, 2020

      • yvanzo
        in any case, check with crontab -l
      • 2020-09-29 27300, 2020

      • reosarevok
        So, what do you do with year +0000 ?
      • 2020-09-29 27312, 2020

      • reosarevok
        Do you count that as -1 BCE -0001 is -2 BCE etc?
      • 2020-09-29 27315, 2020

      • ruaok
        pristine___: other than retriggering the build, not sure what else to do.
      • 2020-09-29 27322, 2020

      • ruaok
        is this for the simple logging changes?
      • 2020-09-29 27330, 2020

      • pristine___
        yes
      • 2020-09-29 27342, 2020

      • ruaok
        do the tests pass locally?
      • 2020-09-29 27344, 2020

      • yvanzo
        reosarevok: year 0 after covid spread? ;)
      • 2020-09-29 27336, 2020

      • Mr_Monkey
        So +0000 is year zero AD. The year before that is 1 BCE, which is equal to "-0001" if I remember correctly. There was some complications around year 0, I do remember that, but not the solution. Give me a moment to look that up again
      • 2020-09-29 27357, 2020

      • reosarevok
        Mr_Monkey: 0 AD doesn't exist though?
      • 2020-09-29 27309, 2020

      • Mr_Monkey
        Ah, that's the one.
      • 2020-09-29 27335, 2020

      • adhawkins
        yvanzo: 'up' doesn't appear to have recreated the container.
      • 2020-09-29 27340, 2020

      • adhawkins
        I'll manually down and up it.
      • 2020-09-29 27345, 2020

      • reosarevok
        An expanded year representation [±YYYYY] must have an agreed-upon number of extra year digits beyond the four-digit minimum, and it must be prefixed with a + or − sign[21] instead of the more common AD/BC (or CE/BCE) notation; by convention 1 BC is labelled +0000, 2 BC is labeled −0001, and so on.[22]
      • 2020-09-29 27350, 2020

      • Mr_Monkey
        Right. Ideally, you'll ignore year 0.
      • 2020-09-29 27300, 2020

      • reosarevok
        To represent years before 0000 or after 9999, the standard also permits the expansion of the year representation but only by prior agreement between the sender and the receiver.[20]
      • 2020-09-29 27313, 2020

      • adhawkins
        Which container's crontab should I be checking? musicbrainz-docker_musicbrainz?
      • 2020-09-29 27328, 2020

      • yvanzo
        adhawkins: yes: docker-compose exec musicbrainz crontab -l
      • 2020-09-29 27348, 2020

      • reosarevok
        The library we use does support years BCE but in this way, so I'm wondering whether to just give the user a BCE vs CE option (defaulting to CE) that on entering massages the year to the appropriate expanded year convention
      • 2020-09-29 27354, 2020

      • reosarevok
        (so if they enter 1 BCE it will store as 0000)
      • 2020-09-29 27310, 2020

      • reosarevok
        We do date calculations (age and such) so in that sense just skipping 0 would be complicated too
      • 2020-09-29 27330, 2020

      • yvanzo
        adhawkins: it recreates container if config changed, but if it is just the content of a bind mount maybe it does not need to recreate the container indeed.
      • 2020-09-29 27350, 2020

      • adhawkins
        Ok, crontab hasn't updated, even after docker-compose restart musicbrainz
      • 2020-09-29 27357, 2020

      • reosarevok
        bitmap: IIRC your change that caused MBS-10976 was intentional, but what should be done in a case like that edit? :)
      • 2020-09-29 27358, 2020

      • BrainzBot
        MBS-10976: Unicode Private Use Area characters are stripped during edit process https://tickets.metabrainz.org/browse/MBS-10976
      • 2020-09-29 27359, 2020

      • Mr_Monkey
        You suggestion seems ideal. BCE/AD checkbox or select, and a proper library to massage it in and out of the DB
      • 2020-09-29 27319, 2020

      • Mr_Monkey
        I went the other route for BB but I think it will need refactoring
      • 2020-09-29 27320, 2020

      • adhawkins
        Ah, now it has. I recall there's a job that runs at startup that applies the new crontab
      • 2020-09-29 27348, 2020

      • yvanzo
        Cool!
      • 2020-09-29 27327, 2020

      • Mr_Monkey
        reosarevok: Also, if it's relevant, I settled for this format (note the 6 digits for year) ±YYYYYY-MM-DD
      • 2020-09-29 27354, 2020

      • adhawkins
        Ok, I've stuck a cron job in the host that'll do the dmesg -T | grep oom and email it to me daily. WIll monitor. Thanks yvanzo
      • 2020-09-29 27341, 2020

      • reosarevok
        Mr_Monkey: heh, I think that's more relevant for books than music
      • 2020-09-29 27341, 2020

      • reosarevok
        For now I'm planning to stick to 4 digits (+ or -)
      • 2020-09-29 27351, 2020

      • Mr_Monkey
        And also possibly relevant (?), I opted for CE / BCE in order to leave christ out of all that.
      • 2020-09-29 27330, 2020

      • Mr_Monkey
        Granted, it does say christian, but…
      • 2020-09-29 27331, 2020

      • reosarevok
        Yeah, I was going to do that for sure
      • 2020-09-29 27344, 2020

      • reosarevok
        Depending on how you read it :p
      • 2020-09-29 27352, 2020

      • reosarevok
        or "Common"
      • 2020-09-29 27309, 2020

      • Mr_Monkey
        For the diehards who don't wanna let it go, i mean :p
      • 2020-09-29 27330, 2020

      • Mr_Monkey
        For the rest of us commoners it'll be a step forward.
      • 2020-09-29 27325, 2020

      • Mr_Monkey
        I swear if I ever get a time machine I'll go back and find the dummy who decided there would be no year 0 and give him a talking to.
      • 2020-09-29 27349, 2020

      • pristine___
        ruaok: yeah, tests pass on dev
      • 2020-09-29 27326, 2020

      • ruaok
        then I'm fine to merge and push to newleader.
      • 2020-09-29 27330, 2020

      • ruaok
        shall I do that?
      • 2020-09-29 27346, 2020

      • pristine___
        Yeah, there are only log changes. I think you can push to newleader
      • 2020-09-29 27353, 2020

      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #1113 (master…mapping-count): log listen count and mapped listen count https://github.com/metabrainz/listenbrainz-server…
      • 2020-09-29 27357, 2020

      • ruaok
        pristine___: done.
      • 2020-09-29 27355, 2020

      • pristine___
      • 2020-09-29 27300, 2020

      • pristine___
        ruaok: ^
      • 2020-09-29 27359, 2020

      • ruaok
        it increased 19 fold? O_O
      • 2020-09-29 27310, 2020

      • pristine___
        listen count increases joining with mapping. i didn't expect that
      • 2020-09-29 27332, 2020

      • pristine___
        writing few more log statements to understand what's happening.
      • 2020-09-29 27356, 2020

      • ruaok
        yes, please. this sounds like a query mistake; some join going bad.
      • 2020-09-29 27312, 2020

      • ruaok
        it should be less than the original amount, best case equal, no?
      • 2020-09-29 27317, 2020

      • pristine___
        > it should be less than the original amount, best case equal, no?
      • 2020-09-29 27319, 2020

      • pristine___
        yes!
      • 2020-09-29 27311, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1718 (master…MBS-7219): MBS-7219: Hide links to empty ArtistRecording subsets https://github.com/metabrainz/musicbrainz-server/…
      • 2020-09-29 27312, 2020

      • BrainzBot
        MBS-7219: "Show only standalone recordings instead" text should only appear when there actually are any standalone recordings https://tickets.metabrainz.org/browse/MBS-7219
      • 2020-09-29 27308, 2020

      • pristine___
      • 2020-09-29 27345, 2020

      • pristine___
        this is apparently causing that 19 fold increase! We should first filter all the distinct rows from the mapping and then perform the join.
      • 2020-09-29 27348, 2020

      • pristine___
        ruaok: ^
      • 2020-09-29 27357, 2020

      • d4rkie joined the channel
      • 2020-09-29 27344, 2020

      • ruaok
        yep, that would do it. :)
      • 2020-09-29 27312, 2020

      • pristine___
        removing `msb_recording_msid| msb_recording_name_matchable| msb_release_msid| msb_release_name_matchable`from the mapping before the join will do
      • 2020-09-29 27320, 2020

      • supersandro2000 has quit
      • 2020-09-29 27341, 2020

      • pristine___
        `msb_recording_msid|msb_release_msid|msb_release_name_matchable`