#metabrainz

shivam-kapila: up for a min?

Mr_Monkey: I want to have a discussion before I push changes to sync feedback, let me know when you are available today?

shivam-kapila: I have left some comments on a PR which had been merged.

Has*

pristine___: hi

Which PR should I look into for the comments?

1043

Didn't you get an email?

Strange

I checked gh app

gh app?

Github app

Usually shows there

Thanks for the link

pristine___: I got the point

Ideally all this is easily solvable using /delete-feedback only

So I will do that once I have a laptop :/

Do you have a delete-feedback endpoint?

Thanks for pointing out bad code

pristine___: not rn

Cool

But

Until you have your laptop

Please open two tickets, first ticket for points 1 and 2 (maybe as you say that they can be solved using del endpoint) and second ticket for point 3.

shivam-kapila: and then you can assign the tickets to yourself once you have your laptop

pristine___: I dont get point 3

Can you show me some code where we do this

Okay. Do what?

A sec, I will give you an example

I came across this beautiful video yesterday

Have a look!

Also you can read this convo between me and Mr_Monkey

Will help you understand!

pristine___: oh yes. I used the same way in tests actually. Now I got it. Thanks :)

Magic of `...`

See now you write better react than me too. Cheers

shivam-kapila: nice. Now can you please open the two tickets?

Will do

Thanks!

[musicbrainz-server] reosarevok merged pull request #1760 (master…MBS-11194): MBS-11194: Fix ISE when historic EditRelationship data is broken https://github.com/metabrainz/musicbrainz-serve...

MBS-11194: TypeError: Cannot read property 'linkTypeID' of undefined (part 2) https://tickets.metabrainz.org/browse/MBS-11194

hey I did some more SIR and DB optimizations. I think Im good with the DB now

but im doing a live index right now and with 12 import threads.... I only see 1 python SIR process with actual load. can anyone explain that?

load seems to be rising for all of the nodes now nevermind

still not using 12 cpu threads for all of my SIR processes. Anyway to debug why?