(frequency governs how we show them - by default we don't show them at all, because there are several thousands, and then we set it to higher frequency to show it and to even higher, guessing it was 2, to show them on top as "frequent languages")
what we could do in CB is have the list, and only show ones for which we have a review in that language, or a site translation, and have a way for users to request an additional language
2020-10-26 30002, 2020
reosarevok
That's also where we can change the frequency (without having to directly edit the DB)
2020-10-26 30019, 2020
alastairp
got it
2020-10-26 30033, 2020
alastairp
OK, I'll open a ticket to discuss this topic more
2020-10-26 30034, 2020
alastairp
thanks
2020-10-26 30035, 2020
reosarevok
"Hidden is used by default for ancient languages and languages only in ISO 639-3 (until requested by a user)."
2020-10-26 30046, 2020
reosarevok
So, we used to show everything that is in iso -2 at least
2020-10-26 30045, 2020
reosarevok
We do have Norwegian (frequently used), Norwegian BokmĂĄl, Norwegian Nynorsk (other = standard), Norwegian Sign Language, Traveller Norwegian (hidden)
2020-10-26 30025, 2020
reosarevok
Of course, I guess you *could* very well have a review in Norwegian Sign Language, so for you sign languages might not necessarily need to be hidden
2020-10-26 30044, 2020
reosarevok
(tracklists in sign language are unlikely but a book review sounds perfectly legit)
2020-10-26 30056, 2020
reosarevok
Do let me know whenever if you have more doubts!
2020-10-26 30011, 2020
alastairp
see, I knew you were the right person to talk to about langauges ;)
2020-10-26 30035, 2020
alastairp
_lucifer: for now your fix is fine, but this is something else that we should fix in detail
2020-10-26 30045, 2020
alastairp
I'll merge these 2 PRs
2020-10-26 30042, 2020
_lucifer
agreed :)
2020-10-26 30038, 2020
CatQuest
ohohhohoh norwegian sign languages
2020-10-26 30015, 2020
v6lur joined the channel
2020-10-26 30038, 2020
alastairp
_lucifer: you'll see that the exception is hit when a code is a 'macrolanguage'. If you look in the list (e.g. on the write a review page, in the dropdown), the macrolanguages are written in english, while the others are written in the native language or script
2020-10-26 30043, 2020
alastairp
this will be the reason that we were using babel.Locale, this maintains the name of the language in that language, whereas pycountry does the name in English... this is all quite confusing and I don't know much more than what I've learned this morning
[listenbrainz-server] alastair opened pull request #1155 (master…werkzeug-profile): Remove unused devserver and werkzeug profiler code from server startup https://github.com/metabrainz/listenbrainz-server…
2020-10-26 30058, 2020
_lucifer
alastairp: can you unhide the mising entity review so that we can see if the deleted entities fix is working
yes, we've got this eeerie orange glow going on right now
2020-10-26 30027, 2020
CatQuest has quit
2020-10-26 30054, 2020
CatQuest joined the channel
2020-10-26 30018, 2020
CatQuest
...
2020-10-26 30012, 2020
CatQuest
wait it's that thoing now right
2020-10-26 30020, 2020
CatQuest
ack, why cant we get rid of dts
2020-10-26 30009, 2020
ruaok
alastairp: wanna chat about next steps for troi?
2020-10-26 30035, 2020
alastairp
let's do it
2020-10-26 30016, 2020
ruaok
so, I'd be curious to see what else you think needs tests.
2020-10-26 30004, 2020
ruaok
I'm not too keen on writing detailed tests for the webserver portion of it. most everything critical now has a test, short of the annoy stuff.
2020-10-26 30059, 2020
alastairp
I think you're right, we don't need much more than what's there
2020-10-26 30016, 2020
ruaok
ok, if you find something else amiss, open a ticket.
2020-10-26 30023, 2020
alastairp
these tests don't help if the dataset hoster output changes, is that something that we should think about?
2020-10-26 30051, 2020
ruaok
yes, I think so.
2020-10-26 30014, 2020
ruaok
that might be as simple as making a call to the API to ensure that the inputs/outputs have not changed.
2020-10-26 30022, 2020
alastairp
going back to iliekcomputers's plan of integrating all of the repos... this would be easier if the code for both was together, but I'm not sure I like that
we can always merge it later, unmerging is harder. so I am more for keeping it as is.
2020-10-26 30042, 2020
alastairp
you annotate tests, and then can tell pytest "just run these ones", so we could have some integration tests marked as such, and perhaps run them less often, and not by default
well, given that its supposed to be a stable API and the requests will be fast I have no problems running them all the time, but I'll have a look.
2020-10-26 30012, 2020
alastairp
can I ask you to be more specific in your test descriptions? The problem with "as discussed in IRC" is that we forget. a link to chatlogs would be enough if you don't want to write in more detail
2020-10-26 30050, 2020
ruaok
yeah, I wish there was an easy/reliable way to get a link to the IRC chat.
2020-10-26 30014, 2020
ruaok
but finding the link and then getting the link to be useful is... nearly pointless
2020-10-26 30015, 2020
alastairp
right
2020-10-26 30021, 2020
alastairp
agreed
2020-10-26 30014, 2020
ruaok
but, my thinking is that these tickets are short lived and to be handled this week by you and I, so getting so detailed isn't that high on my list, tbh.
2020-10-26 30041, 2020
ruaok
I see debugging tickets, more docs and argparse.
2020-10-26 30030, 2020
ruaok
I think I'd leave the debugging tickets to you, since I don't quite feel the need for them. but I can take argparse which totally is needed and adding more docs to reflect recent changes.
2020-10-26 30044, 2020
alastairp
I hope that's the case. I was looking at some tickets last week which I'm sure I expected to be easy to do, but they ended up sticking around for months or years and we lose all context
oh, slightly OT. at somepoint we should get one takeout and have a design session for playlists support for our hackday next month.
2020-10-26 30011, 2020
alastairp
I'll see if I can work out what I want here
2020-10-26 30014, 2020
ruaok
742, 741
2020-10-26 30022, 2020
yvanzo
reosarevok: that would work if we really need to disable a field (which form is it?)
2020-10-26 30044, 2020
ruaok
740 is also pretty straightforward. if you didn't get to that when I've finished the others, then I'll do that one.
2020-10-26 30013, 2020
ruaok
once we have these open tickets sorted, we should work on annoy and good example patch that shows off the use of the annoy.
2020-10-26 30051, 2020
alastairp
cool. should we use 'start progress' buttons to track what we're working on, then? so that we can make sure that we're not duplicating tasks?
2020-10-26 30057, 2020
alastairp
yep, I'm just picking that up again now
2020-10-26 30004, 2020
alastairp
actually, I have a question for you:
2020-10-26 30020, 2020
ruaok
I just assigned tickets to us accordingly to that affect.
2020-10-26 30025, 2020
alastairp
I need both the given mbid and the redirected mbid in Recording. thoughts? just add another field?
2020-10-26 30033, 2020
Freso
(Meeting in 10 minutes!)
2020-10-26 30044, 2020
CatQuest
hi freso!
2020-10-26 30030, 2020
ruaok
alastairp: how about sticking that into the recording.musicbrainz dict? recording.musicbrainz.original_recording_mbid ?
2020-10-26 30048, 2020
ruaok
once we start using the MB, AB, LB dicts we should start documenting the keys that we're using.
2020-10-26 30036, 2020
Freso
(^^^ CatQuest, bitmap, shivam-kapila, _lucifer, jmp_music__, pristine___, possibly others? who don’t change DST together with the EU.)
2020-10-26 30048, 2020
CatQuest
🙋
2020-10-26 30012, 2020
CatQuest
pingreo too because h's often busy
2020-10-26 30036, 2020
Freso
But time hasn’t changed for him.
2020-10-26 30015, 2020
reosarevok
Alias edit when search hint is selected
2020-10-26 30016, 2020
alastairp
ruaok: that's a good place, thanks
2020-10-26 30032, 2020
CatQuest
ah you're there reo
2020-10-26 30042, 2020
ruaok
do you have a day planned when you are going to work on troi this week, alastairp ?
2020-10-26 30013, 2020
alastairp
wednesday
2020-10-26 30014, 2020
ruaok
if so, then I'll clear my schedule to work on troi the same day so we can do like we did last week. that was a nice feeling to just push a pile of stuff through.
2020-10-26 30025, 2020
alastairp
takeout + playlist planning sounds good too
2020-10-26 30043, 2020
ruaok
ok, wed for troi. playlist maybe next week?
2020-10-26 30001, 2020
alastairp
if we're allowed out by then, sure
2020-10-26 30011, 2020
ruaok
hehe, i nearly said that.
2020-10-26 30024, 2020
ruaok
I think the weekend lockdowns will come first before complete lockdowns.
2020-10-26 30028, 2020
alastairp
oh, next week tues/weds I'm unavailable for the full day
2020-10-26 30030, 2020
ruaok
next week I am all clear except thu.
2020-10-26 30002, 2020
alastairp
ok, maybe we could do monday then - by midday tues I'll know if I'm needed for the meeting on weds too
