#metabrainz

Morning!!

Hi!

pristine___: Saw your comment on the feedback PR, let me run it locally and see what's affecting the state, and how to best solve it

Cool. Thanks :)

Mr_Monkey: if you running it locally, can you also check the rendering in mobile view? . I think we may need `MediaQuery` for that

bitmap: can you please have a look at paco's disk space? we get alerts about it since yesterday, prolly related to pg

once again it happened once I logged in, but I really dont think it was me...

😇

mmm

someone told me that youtube's iframe api is being removed in a few weeks (what we use in acousticbrainz)

there's a "data api" to look up this info apparently, but it has data limits

I wonder if we should just add in BP here?

pristine___: It looks like the pagination in the recommendations page sets `currRecPage` wrong in `handleClickPrevious` and `handleClickNext` and should be inverted. When I navigate from page 1 to page 2 the url is changed to `?page=1` and going from page 2 to page 1 URL changes to `?page=2`

The feedback UI is looking good much better now, well done !

alastairp: what functionality of the iframe api does ab use ?

there's an iframe which takes an artist and track name and generates a playlist (we just show the first one)

the idea is to have a preview of the song

oh ok, actually that's the only part of the api being deprecated

haha

>This is a deprecation announcement for the embedded player functionality that lets you configure the player to load search results. This announcement affects the IFrame Player API's queueing functions for lists, cuePlaylist and loadPlaylist.

bp sounds a great idea then. we can also put it in cb also.

Hi people

[bookbrainz-site] MonkeyDo opened pull request #529 (master…update-pg-node-lts-14): chore: Update bookbrainz-data package https://github.com/bookbrainz/bookbrainz-site/p...

Zastai: Hi! Thanks for reporting the issues on LB. I think there are two separate issues. I can't comment on the playing-now functionality, but I also see the issue you're talking about.

Let's see about the embedded player issues.

I can't seem to reproduce either of your issues (interrupted playback in spotify app and switching between three recent tracks), so I'll start by asking you to unlink and re-link your spotify account on https://listenbrainz.org/profile/connect-spotify , and see if the player and playing-now functionality behave any better.

What browser and version are you using? Perhaps I can try to replicate on your browser.

latest firefox

Thanks, I'll try

i can't reproduce the issue now either. I don't suppose API calls are likely to have any effect on the behaviour

after unlinking and relinking, playing-now still returns nothing, despite a track being played

aha - i reproduced the player issue by accident

music was playing. switching between reports and listense did nothing special

going to listens shows an empty player at first, then fills it with the track playing in spotify (which is not shown in the listen list)

so far so good

i then checked the API call for playing now - no result

I then refreshed the LB page (at listens)

player is empty, might have briefly loaded the playing track but then shows alternatingly the last three listened tracks

playback has stopped

Project bookbrainz-site build #3510: passed in 4 min 39 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

going to the spotify app, it says "listening on ListenBrainz player"; playback queue (the release radar playlist) is empty except for the supposed active song

trying to play a track in the app does nothing (switches back to the track shown on LB)

had to switch the device back to the app in order to regain control

going to try to see if the API call is what triggered it

started playback again (in app). LB player shows that track just fine. F5 reloads it fine

after API call and F5: still fine

so it looks like semi-random intermittent behaviour, sadly

https://beta-api.listenbrainz.org/1/user/Zastai... is still reporting nothing, even though I'm on the second track since the player issue (which was after relinking)

and now after refreshing LB again, it shows a playing now (actually the previous track, not the current one) - API returns it too

Hmm, weird behaviour. I'll keep trying to trigger it.

Ozric Tentacles <3

iliekcomputers: Could we get together at some point and fix the issue with websockets in LB? I think the "playing now" feature on the listens page might be broken because of a CORS issue with socket.io

Zastai: Next time you see that player issue happen, could you please open the developer console and copy the entire console logs into a pastebin ? I keep refreshing and trying different scenarios but can't reproduce the issue so far.

ok, will try to reproduce it again later

Thanks for your help

zas: looking into it

[bookbrainz-site] MonkeyDo merged pull request #529 (master…update-pg-node-lts-14): chore: Update bookbrainz-data package https://github.com/bookbrainz/bookbrainz-site/p...

zas: ruaok: afaik what's growing on paco is /var/lib/postgresql/data/base/pgsql_tmp, but I'm not sure what queries are creating these or why they aren't being cleaned up. we'll probably have to enable log_temp_files and restart PG to see

let me make sure that I don;t accidentally have some large tables laying around.

> pristine___: It looks like the pagination in the recommendations page sets `currRecPage` wrong in `handleClickPrevious` and `handleClickNext` and should be inverted. When I navigate from page 1 to page 2 the url is changed to `?page=1` and going from page 2 to page 1 URL changes to `?page=2`

Mr_Monkey: it's because I am using the previous state value here (not the updated one)

On it

Ah, right !

bitmap: nothing abnormal here.

should we do "vacuum analyze full" maybe?

hmm

I did try to run a bad query yesterday that OOMed PG. I wonder if there is fallout from that.

#rookiemove

yeah, I'm not sure. maybe we should stop PG and just clear this dir and restart

atm it's 115GB and has too many files for ls to even list :) for comparison w/ floyd it's empty there

Mr_Monkey: so I was thinking, what should the page look like for user != currentUser. Maybe we can disable the drop down in this case and only show the feedback.

Project bookbrainz-site build #3512: passed in 4 min 58 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

bitmap: feel free to do that. all of my stuff can be regenerated should something get borked.

aight, running the delete. didn't have to restart PG since they weren't used by any process (the backend they were created by no longer exists)

thx

pristine___: Disabled dropdown, surely. Which feedback do you show though? For example, if I go to see your recommendations, do I see your feedback? It would need to be very very clear that it is yours and not mine.

Is there any interest in allowing me to give feedback to your suggestions? I don't think so.

So if I visit /recs/Mr_Monkey, I should ideally see your recs and feedback given by you, no?

If it's shown in exactly the same way as for my feedback, that would be confusing ("I don't remember giving feedback to these songs, what's going on?". It'll need to be made clear that it is your feedback, but I'm not sure how.

The user name, in this case 'Rob' is good enough for me to understand that's it's not my feedback, no?

Mr_Monkey: or we fade the color lil to show it is disabled something like that.

Not sure either, though I somehow feel user name should do the trick

This showing "Your top artist playlist" if it's not you is not very good

What about printing "This" instead of "Your" if user != profile?

We generally differentiate in MB

I agree with that reo, although it's a separate concern for another PR

ruaok, alastairp : Any opinion on whether we want to show another user's feedback when looking at their recommendations? i.e. if I look at Rob's recommendations, should I see the feedback Rob gave?

I don't think so.

because if I am spending time with someone else and a song comes on that I like, I want to go to their timeline and like the song from there.

conversely I'd like to see if I've already liked it.

It feels uneasy for me UX-wise to see someone else's feedback at the same spot where I'm supposed to give feedback on mine.

I share that.

Hmm... What should the other user see there?

I dont feel strongly about showing my feedback on someone else's feed. I do care about being able to like a track from anywhere its shown.

Are we completely replacing the current love/hate hearts with the 'faces' feedback component?

No.

Not for now at least

If not, I would keep the faces feedback component for currentUsers's recs pages, and show the love/hate component instead if != currentUser

Mr_Monkey: I don't understand this completely. What exactly will be shown in that case?

We can't show the heart and heart_broken icons

Why is that?

So we are allowing people to give feedback if they load someone else's rec page, but this feedback will essentially be for "listens" (1, -1) and not "recs" (The five emoticons)

Is that?