pristine___: Saw your comment on the feedback PR, let me run it locally and see what's affecting the state, and how to best solve it
2020-10-30 30418, 2020
pristine___
Cool. Thanks :)
2020-10-30 30449, 2020
pristine___
Mr_Monkey: if you running it locally, can you also check the rendering in mobile view? . I think we may need `MediaQuery` for that
2020-10-30 30425, 2020
reosarevok has quit
2020-10-30 30442, 2020
reosarevok joined the channel
2020-10-30 30420, 2020
zas
bitmap: can you please have a look at paco's disk space? we get alerts about it since yesterday, prolly related to pg
2020-10-30 30447, 2020
ruaok
once again it happened once I logged in, but I really dont think it was me...
2020-10-30 30456, 2020
ruaok
😇
2020-10-30 30401, 2020
alastairp
mmm
2020-10-30 30428, 2020
alastairp
someone told me that youtube's iframe api is being removed in a few weeks (what we use in acousticbrainz)
2020-10-30 30450, 2020
alastairp
there's a "data api" to look up this info apparently, but it has data limits
2020-10-30 30457, 2020
alastairp
I wonder if we should just add in BP here?
2020-10-30 30414, 2020
Mr_Monkey
pristine___: It looks like the pagination in the recommendations page sets `currRecPage` wrong in `handleClickPrevious` and `handleClickNext` and should be inverted. When I navigate from page 1 to page 2 the url is changed to `?page=1` and going from page 2 to page 1 URL changes to `?page=2`
2020-10-30 30444, 2020
sumedh has quit
2020-10-30 30433, 2020
Mr_Monkey
The feedback UI is looking good much better now, well done !
2020-10-30 30457, 2020
_lucifer
alastairp: what functionality of the iframe api does ab use ?
2020-10-30 30458, 2020
alastairp
there's an iframe which takes an artist and track name and generates a playlist (we just show the first one)
2020-10-30 30439, 2020
alastairp
the idea is to have a preview of the song
2020-10-30 30451, 2020
_lucifer
oh ok, actually that's the only part of the api being deprecated
2020-10-30 30458, 2020
alastairp
haha
2020-10-30 30459, 2020
_lucifer
>This is a deprecation announcement for the embedded player functionality that lets you configure the player to load search results. This announcement affects the IFrame Player API's queueing functions for lists, cuePlaylist and loadPlaylist.
2020-10-30 30421, 2020
sumedh joined the channel
2020-10-30 30450, 2020
_lucifer
bp sounds a great idea then. we can also put it in cb also.
Zastai: Hi! Thanks for reporting the issues on LB. I think there are two separate issues. I can't comment on the playing-now functionality, but I also see the issue you're talking about.
2020-10-30 30429, 2020
Mr_Monkey
Let's see about the embedded player issues.
2020-10-30 30430, 2020
Mr_Monkey
I can't seem to reproduce either of your issues (interrupted playback in spotify app and switching between three recent tracks), so I'll start by asking you to unlink and re-link your spotify account on https://listenbrainz.org/profile/connect-spotify , and see if the player and playing-now functionality behave any better.
2020-10-30 30430, 2020
Mr_Monkey
What browser and version are you using? Perhaps I can try to replicate on your browser.
2020-10-30 30431, 2020
Zastai
latest firefox
2020-10-30 30414, 2020
Mr_Monkey
Thanks, I'll try
2020-10-30 30439, 2020
Zastai
i can't reproduce the issue now either. I don't suppose API calls are likely to have any effect on the behaviour
2020-10-30 30441, 2020
Zastai
after unlinking and relinking, playing-now still returns nothing, despite a track being played
2020-10-30 30406, 2020
Zastai
aha - i reproduced the player issue by accident
2020-10-30 30438, 2020
Zastai
music was playing. switching between reports and listense did nothing special
2020-10-30 30405, 2020
Zastai
going to listens shows an empty player at first, then fills it with the track playing in spotify (which is not shown in the listen list)
2020-10-30 30411, 2020
Zastai
so far so good
2020-10-30 30417, 2020
Zastai
i then checked the API call for playing now - no result
2020-10-30 30427, 2020
Zastai
I then refreshed the LB page (at listens)
2020-10-30 30400, 2020
Zastai
player is empty, might have briefly loaded the playing track but then shows alternatingly the last three listened tracks
going to the spotify app, it says "listening on ListenBrainz player"; playback queue (the release radar playlist) is empty except for the supposed active song
2020-10-30 30425, 2020
Zastai
trying to play a track in the app does nothing (switches back to the track shown on LB)
2020-10-30 30444, 2020
Zastai
had to switch the device back to the app in order to regain control
2020-10-30 30459, 2020
Zastai
going to try to see if the API call is what triggered it
2020-10-30 30417, 2020
Zastai
started playback again (in app). LB player shows that track just fine. F5 reloads it fine
2020-10-30 30447, 2020
Zastai
after API call and F5: still fine
2020-10-30 30407, 2020
Zastai
so it looks like semi-random intermittent behaviour, sadly
and now after refreshing LB again, it shows a playing now (actually the previous track, not the current one) - API returns it too
2020-10-30 30446, 2020
Mr_Monkey back from lunch
2020-10-30 30459, 2020
Mr_Monkey
Hmm, weird behaviour. I'll keep trying to trigger it.
2020-10-30 30421, 2020
Mr_Monkey
Ozric Tentacles <3
2020-10-30 30416, 2020
Mr_Monkey
iliekcomputers: Could we get together at some point and fix the issue with websockets in LB? I think the "playing now" feature on the listens page might be broken because of a CORS issue with socket.io
2020-10-30 30427, 2020
Mr_Monkey
Zastai: Next time you see that player issue happen, could you please open the developer console and copy the entire console logs into a pastebin ? I keep refreshing and trying different scenarios but can't reproduce the issue so far.
zas: ruaok: afaik what's growing on paco is /var/lib/postgresql/data/base/pgsql_tmp, but I'm not sure what queries are creating these or why they aren't being cleaned up. we'll probably have to enable log_temp_files and restart PG to see
2020-10-30 30427, 2020
ruaok
let me make sure that I don;t accidentally have some large tables laying around.
2020-10-30 30447, 2020
pristine___
> pristine___: It looks like the pagination in the recommendations page sets `currRecPage` wrong in `handleClickPrevious` and `handleClickNext` and should be inverted. When I navigate from page 1 to page 2 the url is changed to `?page=1` and going from page 2 to page 1 URL changes to `?page=2`
2020-10-30 30421, 2020
pristine___
Mr_Monkey: it's because I am using the previous state value here (not the updated one)
I did try to run a bad query yesterday that OOMed PG. I wonder if there is fallout from that.
2020-10-30 30454, 2020
ruaok
#rookiemove
2020-10-30 30406, 2020
bitmap
iiuc pgsql_tmp is supposed to just have temporary files for queries that don't fit in work_mem and should be deleted once the query is done
2020-10-30 30447, 2020
bitmap
yeah, I'm not sure. maybe we should stop PG and just clear this dir and restart
2020-10-30 30421, 2020
bitmap
atm it's 115GB and has too many files for ls to even list :) for comparison w/ floyd it's empty there
2020-10-30 30430, 2020
pristine___
Mr_Monkey: so I was thinking, what should the page look like for user != currentUser. Maybe we can disable the drop down in this case and only show the feedback.
bitmap: feel free to do that. all of my stuff can be regenerated should something get borked.
2020-10-30 30419, 2020
bitmap
aight, running the delete. didn't have to restart PG since they weren't used by any process (the backend they were created by no longer exists)
2020-10-30 30433, 2020
ruaok
thx
2020-10-30 30443, 2020
Mr_Monkey
pristine___: Disabled dropdown, surely. Which feedback do you show though? For example, if I go to see your recommendations, do I see your feedback? It would need to be very very clear that it is yours and not mine.
2020-10-30 30426, 2020
Mr_Monkey
Is there any interest in allowing me to give feedback to your suggestions? I don't think so.
2020-10-30 30415, 2020
pristine___
So if I visit /recs/Mr_Monkey, I should ideally see your recs and feedback given by you, no?
2020-10-30 30457, 2020
Mr_Monkey
If it's shown in exactly the same way as for my feedback, that would be confusing ("I don't remember giving feedback to these songs, what's going on?". It'll need to be made clear that it is your feedback, but I'm not sure how.
The user name, in this case 'Rob' is good enough for me to understand that's it's not my feedback, no?
2020-10-30 30440, 2020
pristine___
Mr_Monkey: or we fade the color lil to show it is disabled something like that.
2020-10-30 30457, 2020
pristine___
Not sure either, though I somehow feel user name should do the trick
2020-10-30 30433, 2020
reosarevok
This showing "Your top artist playlist" if it's not you is not very good
2020-10-30 30456, 2020
reosarevok
What about printing "This" instead of "Your" if user != profile?
2020-10-30 30404, 2020
reosarevok
We generally differentiate in MB
2020-10-30 30443, 2020
Mr_Monkey
I agree with that reo, although it's a separate concern for another PR
2020-10-30 30449, 2020
Mr_Monkey
ruaok, alastairp : Any opinion on whether we want to show another user's feedback when looking at their recommendations? i.e. if I look at Rob's recommendations, should I see the feedback Rob gave?
2020-10-30 30416, 2020
ruaok
I don't think so.
2020-10-30 30446, 2020
ruaok
because if I am spending time with someone else and a song comes on that I like, I want to go to their timeline and like the song from there.
2020-10-30 30402, 2020
ruaok
conversely I'd like to see if I've already liked it.
2020-10-30 30436, 2020
Mr_Monkey
It feels uneasy for me UX-wise to see someone else's feedback at the same spot where I'm supposed to give feedback on mine.
2020-10-30 30451, 2020
ruaok
I share that.
2020-10-30 30407, 2020
pristine___
Hmm... What should the other user see there?
2020-10-30 30443, 2020
ruaok
I dont feel strongly about showing my feedback on someone else's feed. I do care about being able to like a track from anywhere its shown.
2020-10-30 30400, 2020
Mr_Monkey
Are we completely replacing the current love/hate hearts with the 'faces' feedback component?
2020-10-30 30419, 2020
pristine___
No.
2020-10-30 30425, 2020
pristine___
Not for now at least
2020-10-30 30455, 2020
Mr_Monkey
If not, I would keep the faces feedback component for currentUsers's recs pages, and show the love/hate component instead if != currentUser
2020-10-30 30451, 2020
pristine___
Mr_Monkey: I don't understand this completely. What exactly will be shown in that case?
2020-10-30 30414, 2020
pristine___
We can't show the heart and heart_broken icons
2020-10-30 30422, 2020
Mr_Monkey
Why is that?
2020-10-30 30454, 2020
pristine___
So we are allowing people to give feedback if they load someone else's rec page, but this feedback will essentially be for "listens" (1, -1) and not "recs" (The five emoticons)
