are you suggesting to change bg to white when text is follow?
2020-11-25 33059, 2020
shivam-kapila
on hover
2020-11-25 33042, 2020
shivam-kapila
That green orange color will go with the other PR
2020-11-25 33048, 2020
shivam-kapila
that is open
2020-11-25 33010, 2020
Mr_Monkey
Well, if the button is blue background in normal state (not following), then it should change to something else when you hover it, yes
2020-11-25 33046, 2020
shivam-kapila
ohk thanls
2020-11-25 33050, 2020
shivam-kapila
thanks?
2020-11-25 33052, 2020
shivam-kapila
!
2020-11-25 33011, 2020
Mr_Monkey
And since the way we're doing that with the other style, I guess it's the logical way to go.
2020-11-25 33052, 2020
shivam-kapila
makes sense. I was confused to keep blue or white bg for "Follow" on hover
2020-11-25 33001, 2020
Gazooo79494 has quit
2020-11-25 33043, 2020
Gazooo79494 joined the channel
2020-11-25 33032, 2020
Gore joined the channel
2020-11-25 33043, 2020
supersandro2000 has quit
2020-11-25 33002, 2020
supersandro2000 joined the channel
2020-11-25 33038, 2020
MajorLurker_ has quit
2020-11-25 33047, 2020
Rotab has quit
2020-11-25 33016, 2020
sumedh has quit
2020-11-25 33030, 2020
sumedh joined the channel
2020-11-25 33009, 2020
MajorLur_ joined the channel
2020-11-25 33009, 2020
MajorLur_ is now known as MajorLurker_
2020-11-25 33036, 2020
MajorLurker_ has quit
2020-11-25 33031, 2020
SothoTalKer has quit
2020-11-25 33049, 2020
SothoTalKer joined the channel
2020-11-25 33030, 2020
MajorLur_ joined the channel
2020-11-25 33036, 2020
Rotab joined the channel
2020-11-25 33005, 2020
sumedh has quit
2020-11-25 33003, 2020
MajorLur_ has quit
2020-11-25 33054, 2020
sumedh joined the channel
2020-11-25 33037, 2020
v6lur joined the channel
2020-11-25 33001, 2020
supersandro2000 has quit
2020-11-25 33018, 2020
supersandro2000 joined the channel
2020-11-25 33026, 2020
v6lur has quit
2020-11-25 33044, 2020
MajorLur_ joined the channel
2020-11-25 33045, 2020
MajorLur_ has quit
2020-11-25 33023, 2020
sumedh has quit
2020-11-25 33031, 2020
sumedh joined the channel
2020-11-25 33013, 2020
v6lur joined the channel
2020-11-25 33037, 2020
Gore has quit
2020-11-25 33025, 2020
v6lur has quit
2020-11-25 33006, 2020
v6lur joined the channel
2020-11-25 33031, 2020
MajorLur_ joined the channel
2020-11-25 33025, 2020
MajorLur_ has quit
2020-11-25 33005, 2020
MajorLur_ joined the channel
2020-11-25 33005, 2020
MajorLur_ is now known as MajorLurker_
2020-11-25 33032, 2020
MajorLurker_ has quit
2020-11-25 33036, 2020
sumedh has quit
2020-11-25 33013, 2020
supersandro2000 has quit
2020-11-25 33042, 2020
supersandro2000 joined the channel
2020-11-25 33034, 2020
dseomn1 joined the channel
2020-11-25 33056, 2020
dseomn has quit
2020-11-25 33048, 2020
reosarevok
yvanzo, bitmap: around? :)
2020-11-25 33037, 2020
bitmap
hey
2020-11-25 33049, 2020
bitmap
I am working on updating https://github.com/metabrainz/musicbrainz-server/… and hope to respond to some points made in the community forums asap, so probably not going to review stuff until that's done
2020-11-25 33042, 2020
bitmap
but I can probably rubber-stamp some simple ones if you link them
2020-11-25 33000, 2020
reosarevok
Anything you'd want me to go through related to the forums and whatnot?
2020-11-25 33005, 2020
reosarevok
And/or this code
2020-11-25 33056, 2020
bitmap
I'm mostly just responding to the question about the timline
2020-11-25 33029, 2020
bitmap
and for the PR I'm seeing about reducing a couple uses of UnsanitizedEditorT
2020-11-25 33027, 2020
bitmap
reviewing the checkForUnsanitizedEditorData function would be helpful, if you see a way to improve that further
2020-11-25 33012, 2020
reosarevok
So basically: if it's a dev build, every hydration should check every key for anything that looks like an editor, and make sure it only has the sanitized content, and just in case it also checks anything that doesn't claim to be an editor and looks for birth(date), email, password?
That we really should look out for, since all the other data is public if it exists AFAICT
2020-11-25 33008, 2020
reosarevok
Well I guess preferences aren't, technically
2020-11-25 33056, 2020
bitmap
yeah, it might make sense to check for preferences here
2020-11-25 33031, 2020
dseomn1 has quit
2020-11-25 33044, 2020
yvanzo
hi
2020-11-25 33023, 2020
yvanzo
bitmap: is 1801 ready for merge now or of lesser priority?
2020-11-25 33007, 2020
bitmap
it is ready, I just haven't had time to deploy it yet (requires running scripts on floyd)
2020-11-25 33052, 2020
yvanzo
reosarevok: do/did you/we have any direct contact with BBC Music? would be interesting to know why they removed artist pages.
2020-11-25 33026, 2020
reosarevok
We kinda-sorta do, but IIRC they've been moving away from those for a while. I guess people weren't using them much? tbh they didn't have much content
2020-11-25 33000, 2020
reosarevok
I don't think it's anything with us or the data (as ruaok mentioned they still use MB in many places), just probably cost-cutting really
2020-11-25 33057, 2020
yvanzo
IIRC, the rel was already limited to pages with extra content, so they did show extra content (interviews, lives, samples)?
2020-11-25 33045, 2020
dseomn joined the channel
2020-11-25 33038, 2020
reosarevok
Well, they sometimes did, but by far most of them did not :)
2020-11-25 33009, 2020
reosarevok
Apparently a few redirect to kinda "tag" pages
2020-11-25 33025, 2020
reosarevok
So if you go to what used to be the page for Adele, now it just shows you all the articles for Adele
2020-11-25 33033, 2020
reosarevok
Most don't do that either
2020-11-25 33051, 2020
yvanzo
bitmap: I guess we need 1801 to run for a couple of days on beta before releasing anything then?
2020-11-25 33053, 2020
reosarevok
I guess it might not matter - the triggers will be in the DB either way, right?
2020-11-25 33001, 2020
reosarevok
So either it makes a mess in both again or it works :D
2020-11-25 33009, 2020
yvanzo
let's try not to release something that makes a mess again :)
2020-11-25 33006, 2020
reosarevok
Well, it's been tested and seems fine, but the other had been tested too and it struggled with real editing
2020-11-25 33014, 2020
reosarevok
But I don't think we have a better way of doing this
2020-11-25 33048, 2020
reosarevok
We just need to release when we're around to revert if 504s come back :)
2020-11-25 33001, 2020
reosarevok
(and I guess have the reverting script ready just in case)
2020-11-25 33049, 2020
yvanzo
I agree on "we [don't] have a better way of [testing] [the trigger] [with real editing]" but it still does not require to update the production branch with and to make a server release.
2020-11-25 33043, 2020
reosarevok
Oh sure, my point is that releasing the trigger will affect prod anyway
2020-11-25 33059, 2020
reosarevok
Not suggesting releasing the whole thing to prod necessarily
2020-11-25 33037, 2020
yvanzo
Yes, when I wrote "releasing", that was about MBS production branch.
2020-11-25 33041, 2020
reosarevok
But since that's the only potentially breaky thing, it's probably not much of a difference if we just release after a few hours of not breaking
2020-11-25 33057, 2020
reosarevok
Since if it does break we should notice fast :)
2020-11-25 33048, 2020
yvanzo
It makes a difference if "it struggled with real editing" again.
2020-11-25 33036, 2020
reosarevok
The only thing that did that was the one released on all servers though? But anyway, sure, let's test it for a couple days
