ruaok: whenever you have some time, do check the "Edit notes linking to a download server with MP3" email and make sure you agree with my take, please :)
2021-01-04 00400, 2021
D4RK-PH0_ has quit
2021-01-04 00436, 2021
Nyanko-sensei joined the channel
2021-01-04 00450, 2021
hlecuanda has quit
2021-01-04 00453, 2021
sumedh joined the channel
2021-01-04 00421, 2021
CatQuest
reosarevok: tha's it's a bad idea?
2021-01-04 00456, 2021
sumedh has quit
2021-01-04 00405, 2021
alastairp
morning
2021-01-04 00406, 2021
alastairp
!
2021-01-04 00444, 2021
yvanzo
mo’’in’
2021-01-04 00453, 2021
davic joined the channel
2021-01-04 00457, 2021
ruaok
moin!
2021-01-04 00433, 2021
BrainzGit
[listenbrainz-server] alastair merged pull request #1215 (master…docs-content-type): Document that Content-Type header is required for submit-listens https://github.com/metabrainz/listenbrainz-server…
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='labs.api.listenbrainz.org', port=443): Max retries exceeded with url: /recording-mbid-lookup/json?count=1 (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7ff9f15d7fd0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))
2021-01-04 00429, 2021
alastairp
I wondered if it was docker networking issues due to the docker-in-docker setup that we have for jenkins, but I tried to simulate it myself and it seemed to work fine
2021-01-04 00401, 2021
Gazooo79494 has quit
2021-01-04 00445, 2021
Gazooo79494 joined the channel
2021-01-04 00424, 2021
sumedh joined the channel
2021-01-04 00450, 2021
ruaok
Zas is better at that i...
2021-01-04 00457, 2021
zas
alastairp: likely missing dns config somewhere
2021-01-04 00448, 2021
zas
it'd be intesting to dump content of /etc/resolv.conf
2021-01-04 00407, 2021
zas
and /etc/docker/daemon.json for docker daemon config
2021-01-04 00445, 2021
alastairp
I'll have a look
2021-01-04 00454, 2021
zas
check if you have any resolver set ('dns' key for /etc/docker/daemon.json)
2021-01-04 00412, 2021
alastairp
however I did log into williams, docker exec to jenkins, then docker run a container. and inside there, `ping` successfully resolved the domain name
2021-01-04 00452, 2021
zas
hmmm, perhaps a python thing then
2021-01-04 00407, 2021
alastairp
yes, I'll look at that next
2021-01-04 00420, 2021
ruaok
zas: perhaps review the lb.org DNS records? did I make a mistake?
zas: yes, there are a number of exceptions there, and it's possible that the cause is due to that
2021-01-04 00441, 2021
alastairp
however, tests succeed when run locally, they only fail on williams/jenkins
2021-01-04 00440, 2021
alastairp
_lucifer: hi, what do you mean by "the follow server is going to be removed soon"?
2021-01-04 00456, 2021
alastairp
I wasn't aware of that, maybe we had some discussions in the office that we didn't share to you about our plans
2021-01-04 00421, 2021
_lucifer
alastairp: ruaok had shared some days ago that the playlist feature is to replace the follow server
2021-01-04 00451, 2021
alastairp
right, that's possible :)
2021-01-04 00428, 2021
alastairp
zas: I have reproduced the error. it doesn't appear when I use `docker run` from inside jenkins, but it appears when we use docker-compose and our compose config file
2021-01-04 00437, 2021
alastairp
so it's very likely that it's due to the docker-compose network
2021-01-04 00416, 2021
zas
do you have dns: key in docker-compose.yml ?
2021-01-04 00444, 2021
alastairp
no
2021-01-04 00425, 2021
sumedh has quit
2021-01-04 00409, 2021
zas
alastairp: try adding one pointing at 8.8.8.8 to see if it changes anything
2021-01-04 00426, 2021
alastairp
yes, I just noticed. jenkins has 8.8.8.8 in its resolv.conf, lb tests have 127.0.0.11
it doesn't seem to be overriding the dns of the container. I'm looking into it more to see if it's because of our docker-in-docker setup
2021-01-04 00400, 2021
alastairp
it's using a new network - jenkins is on 172.17.0.blah, but inside the listenbrainz container it's using 192.168.112.6
2021-01-04 00415, 2021
alastairp
I'm going to configure it to use the host network instead of making its own
2021-01-04 00413, 2021
ruaok
reosarevok: I kinda think we ought to be more proactive and remove that link from that edit.
2021-01-04 00429, 2021
sumedh joined the channel
2021-01-04 00449, 2021
reosarevok
Ok, in that case we also need to be more clear about that (IIRC we only mention "don't link to such sites" on relationships)
2021-01-04 00415, 2021
reosarevok
We have to think about what happens when such a link is being given to prove a bootleg release, too :)
2021-01-04 00425, 2021
reosarevok
(since that might be the only proof the whole thing exists)
2021-01-04 00435, 2021
ruaok
let's be more clear, please. can you adjust the docs and follow up with the user?
2021-01-04 00446, 2021
reosarevok
Not until we know how to do so
2021-01-04 00458, 2021
reosarevok
Do we want to block *any* links on any edit notes to any download sites / pages?
2021-01-04 00459, 2021
ruaok
zas: our hosting credits with Google cloud have run out and we're unlikely to get any more.
2021-01-04 00414, 2021
reosarevok
And if so, what do we do with cases where that's the only available source of data
2021-01-04 00419, 2021
reosarevok
Do we make an exception for those?
2021-01-04 00420, 2021
ruaok
going forward lets make sure that we use our resources there wisely and see if we can run most of our stuff at hetzner.
2021-01-04 00429, 2021
ruaok
reosarevok: seems fine.
2021-01-04 00415, 2021
reosarevok
We will also need a way to modify edit notes that doesn't require direct DB editing
2021-01-04 00423, 2021
reosarevok
But I guess that'd then be my job :p
2021-01-04 00434, 2021
ruaok snickers
2021-01-04 00442, 2021
reosarevok
And I guess a COC of who is allowed to do so (admins?) and for what reasons
2021-01-04 00401, 2021
reosarevok
(since this isn't something we've actively done before)
2021-01-04 00406, 2021
ruaok
jeez, lots of work. :(
2021-01-04 00417, 2021
ruaok
I just wanted to remove one little link, lol.
2021-01-04 00431, 2021
reosarevok
I know :D That's why I was going with "well, it's an edit note, it's not really public unless logged in, maybe it doesn't matter" :p
2021-01-04 00445, 2021
ruaok
aight, lets leave it be then.
2021-01-04 00402, 2021
reosarevok
But long term anyway we *will* want a proper way of doing this (also for like "X insults Y" or even "X doxxes Y" situations)
2021-01-04 00418, 2021
reosarevok
I'd suggest leaving it be for now, but starting work on a good way to do all this
2021-01-04 00455, 2021
reosarevok
And once we have that, we can be more proactive and also ask the community to report infringing links for us to remove
2021-01-04 00438, 2021
reosarevok
We will need to do that if we ever want to open edit notes to logged-out viewing anyway (which is not something we will certainly want, but it's also not something we will certainly never want)
2021-01-04 00447, 2021
reosarevok
Sounds good to you?
2021-01-04 00412, 2021
ruaok
it does, thanks.
2021-01-04 00417, 2021
ruaok
good forward thinking!
2021-01-04 00403, 2021
reosarevok
I also recently wrote some "search in edit notes" code, so that would allow us to find more links if we are pointed to one
2021-01-04 00436, 2021
reosarevok
(it also allowed me to find a fair amount of notes containing "fuck you" :p Although not all are directed against another person)
2021-01-04 00405, 2021
ruaok
wow. the UK won't extradite assange. he got really lucky.
2021-01-04 00457, 2021
reosarevok
yvanzo: assigned some more https cleanup to you, hope you don't mind :)
2021-01-04 00452, 2021
ruaok
Mr_Monkey: alastairp Freso zas : invoices please!
2021-01-04 00406, 2021
Mr_Monkey
Oh, right. New year.
2021-01-04 00415, 2021
alastairp
wait, what day is it?
2021-01-04 00418, 2021
alastairp
is it bed time yet?
2021-01-04 00423, 2021
ruaok
ah, no not Freso, sorry.
2021-01-04 00429, 2021
alastairp
zas: I think I'm going to need your help on this. It's possible that there's a firewall issue preventing things from getting out of williams
2021-01-04 00403, 2021
reosarevok
"preventing things getting out of williams" seems like an euphemism of some sort for keeping stuff under control
2021-01-04 00413, 2021
reosarevok
I like it
2021-01-04 00437, 2021
alastairp
we're using this docker-in-docker pattern, by mounting the docker control socket of williams into the jenkins container. This means that inside jenkins running `docker whatever` will use the main williams container without having to actually run docker twice
however, when we run docker-compose for our tests, it creates a new network (e.g. 192.168.114.0/20). The gateway of this network appears on williams (192.168.114.1), and I can ping it from the container
2021-01-04 00403, 2021
yvanzo
reosarevok: no problem, will check after lunch.
2021-01-04 00400, 2021
alastairp
I was thinking of flattening the network out, and using the jenkins network as an `external`. However this won't work, because we run the same tests multiple times simultaneously. If we shared a network then we'd have a conflict with the same container names in different test executions
2021-01-04 00408, 2021
ruaok
hmmm, I think SEPA and even US wire payments all got faster in 2021. neat.
2021-01-04 00438, 2021
alastairp
maybe some banks rolled out sepa instant? transferwise -> bbva is always immediate for me
2021-01-04 00435, 2021
ruaok
likely. paying freso got faster. lets see if zas did as well.
2021-01-04 00428, 2021
ruaok
zas: let me know when the payment arrives, please.
and end of year. no technical work for me until wednesday at the earliest.
2021-01-04 00402, 2021
reosarevok
Not a believer in Ballmer peak?
2021-01-04 00437, 2021
reosarevok
Here all the celebrations are gone. I kinda wish we had Reyes Magos now :p
2021-01-04 00403, 2021
alastairp
didn't you hear? we turned them away at the port for not having a negative test
2021-01-04 00421, 2021
alastairp
yeah, they're "here", and letter delivery is open, but that's about it
2021-01-04 00436, 2021
reosarevok
Heh. Two of my friends flew in from Scandinavia and back for Christmas (very responsible of them, I know...)
2021-01-04 00443, 2021
reosarevok
Nobody even checked their tests or anything
2021-01-04 00445, 2021
ruaok
alastairp: ha, that would be the first time someone was *actually* checked at a spanish border that is not an airport.
2021-01-04 00457, 2021
ruaok
the requirement of a negative PCR test seems to only apply to people flying.
2021-01-04 00405, 2021
alastairp
yeah, I thought it sounded a bit far-fetched even as I wrote it
2021-01-04 00426, 2021
reosarevok
This was flying, FWIW, so they don't even check that properly
2021-01-04 00447, 2021
reosarevok
Freso: I'd love your feedback on MBS-11312 and especially on the things that should qualify as "we will remove this from an edit note". I'm expecting "personal info" on self-request, and "spam, insults and piracy" on report, but :)
