#metabrainz

/

      • BrainzGit
        [bookbrainz-site] MonkeyDo opened pull request #549 (master…snyk-upgrade-7c07eebc0481fcb385cc7232d7696f2d): [Snyk] Upgrade @babel/runtime from 7.10.1 to 7.12.5 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-01-22 02239, 2021

      • d4rkie has quit
      • 2021-01-22 02223, 2021

      • Nyanko-sensei joined the channel
      • 2021-01-22 02236, 2021

      • BestSteve has quit
      • 2021-01-22 02228, 2021

      • BestSteve joined the channel
      • 2021-01-22 02227, 2021

      • BrainzGit
        [listenbrainz-server] jdaok opened pull request #1251 (master…LB-802): LB-802: Last.fm importer user friendliness improvements https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-22 02232, 2021

      • travis-ci joined the channel
      • 2021-01-22 02233, 2021

      • travis-ci
        Project bookbrainz-site build #3617: passed in 4 min 23 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-01-22 02233, 2021

      • travis-ci has left the channel
      • 2021-01-22 02255, 2021

      • reosarevok
        Mr_Monkey: since BB seems to do things right, wanna explain MBS-11287 to me? :D What should we be adding?
      • 2021-01-22 02256, 2021

      • BrainzBot
        MBS-11287: Add Apple Touch icon to the MusicBrainz website https://tickets.metabrainz.org/browse/MBS-11287
      • 2021-01-22 02234, 2021

      • yokel has quit
      • 2021-01-22 02224, 2021

      • yokel joined the channel
      • 2021-01-22 02226, 2021

      • flamingspinach has quit
      • 2021-01-22 02229, 2021

      • flamingspinach_ joined the channel
      • 2021-01-22 02219, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1874 (master…MBS-8700): MBS-8700: List genres in JSON-LD https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-22 02201, 2021

      • Darkloke joined the channel
      • 2021-01-22 02246, 2021

      • CatQuest
      • 2021-01-22 02211, 2021

      • reosarevok
        Hmm. yvanzo: MBS-11325 - is there a reason we even return this for JSON search? We don't return it for JSON lookup/browse AFAIC
      • 2021-01-22 02212, 2021

      • BrainzBot
        MBS-11325: Documentation Unclear on Definition of Count Property in Release object https://tickets.metabrainz.org/browse/MBS-11325
      • 2021-01-22 02213, 2021

      • reosarevok
        *T
      • 2021-01-22 02232, 2021

      • CatQuest
        (this was even linked in norwegian news site! :P)
      • 2021-01-22 02202, 2021

      • CatQuest
        we have extreme weather here. named (Frank)
      • 2021-01-22 02228, 2021

      • yvanzo
        reosarevok: it is the JSON equivalent to XML "count" attribute of "medium" child element.
      • 2021-01-22 02255, 2021

      • yvanzo
        sorry, "medium-list" element
      • 2021-01-22 02202, 2021

      • reosarevok
        I got that much, but we should probably either add it to lookup/browse or remove it from search?
      • 2021-01-22 02208, 2021

      • yvanzo
        it should probably be renamed "media-count" in JSON.
      • 2021-01-22 02208, 2021

      • reosarevok
        Or am I missing something :)
      • 2021-01-22 02232, 2021

      • reosarevok
        Yeah, that'd be useful for documentation, although maybe someone is using it and we'd break stuff :/ I guess we could always keep both...
      • 2021-01-22 02205, 2021

      • yvanzo
        Actually, there is a "count" in XML release lookup too
      • 2021-01-22 02250, 2021

      • yvanzo
        Oops, sorry, it's about cover art.
      • 2021-01-22 02212, 2021

      • reosarevok
        We have count attributes in XML
      • 2021-01-22 02216, 2021

      • reosarevok
      • 2021-01-22 02219, 2021

      • reosarevok
        (other than cover art)
      • 2021-01-22 02227, 2021

      • reosarevok
        Maybe we should have it, dunno :)
      • 2021-01-22 02246, 2021

      • yvanzo
        there is no such thing as inc=mediums, is it?
      • 2021-01-22 02215, 2021

      • yvanzo
        Use inc=recordings for having "count" attribute to "medium-list" element in XML.
      • 2021-01-22 02241, 2021

      • yvanzo
        reosarevok: "inc=mediums" is working but not documented at https://musicbrainz.org/doc/MusicBrainz_API#Subqu…
      • 2021-01-22 02200, 2021

      • reosarevok
        Heh, I just tried at random :D
      • 2021-01-22 02207, 2021

      • yvanzo
        "working" as it doesn't throw an error
      • 2021-01-22 02237, 2021

      • yvanzo
        if you use "inc=random" you should get an error (for now at least)
      • 2021-01-22 02238, 2021

      • Mr_Monkey
        reosarevok: You just need the right tool that will take an image and export all the icons you can imagine in one go.
      • 2021-01-22 02239, 2021

      • Mr_Monkey
        Couldn't find the one I used for BB, but this one looks neat and even has reporting :) :https://realfavicongenerator.net/favicon_checker?protocol=http&site=www.musicbrainz.org
      • 2021-01-22 02244, 2021

      • reosarevok
        We do have inc=media
      • 2021-01-22 02255, 2021

      • reosarevok
        Documented
      • 2021-01-22 02234, 2021

      • Mr_Monkey
        You'll need to make sure the image you give it is 1) high quality 2) the right —square— format and 3) with the background color you want (I guess white)
      • 2021-01-22 02240, 2021

      • reosarevok
        Funnily, inc=medium seems to give the same results? :D
      • 2021-01-22 02231, 2021

      • Mr_Monkey
        reosarevok: Tell you what, since I'm already checking it out, do you want me to send you a zip file containing all the finished icons?
      • 2021-01-22 02250, 2021

      • yvanzo
        Mr_Monkey: some tools have a small rendering issue with LB logo
      • 2021-01-22 02208, 2021

      • Mr_Monkey
        Oh? What sort?
      • 2021-01-22 02216, 2021

      • yvanzo
      • 2021-01-22 02217, 2021

      • yvanzo
      • 2021-01-22 02249, 2021

      • _lucifer
        yvanzo: i was interested in working some more on the search stuff. do you have any suggestions ?
      • 2021-01-22 02250, 2021

      • Mr_Monkey
        Oh wow, yeah that doesn't look too good…
      • 2021-01-22 02253, 2021

      • yvanzo
        on both the circuits in the orange part, and the "t" letter
      • 2021-01-22 02255, 2021

      • Mr_Monkey
        Thanks for reporting.
      • 2021-01-22 02218, 2021

      • yvanzo
        _lucifer: yes :)
      • 2021-01-22 02241, 2021

      • reosarevok
        Mr_Monkey: that'd be neat :D
      • 2021-01-22 02252, 2021

      • Mr_Monkey
        👍
      • 2021-01-22 02203, 2021

      • reosarevok
        yvanzo: mediums also doesn't error and gives the same results. But I don't see where the code is to do this transform :D
      • 2021-01-22 02208, 2021

      • mruszczyk has quit
      • 2021-01-22 02226, 2021

      • reosarevok
        Oh!
      • 2021-01-22 02238, 2021

      • reosarevok
      • 2021-01-22 02204, 2021

      • mruszczyk joined the channel
      • 2021-01-22 02225, 2021

      • SamThursfield[m] has quit
      • 2021-01-22 02211, 2021

      • reg[m] has quit
      • 2021-01-22 02256, 2021

      • maxlath[m] has quit
      • 2021-01-22 02222, 2021

      • kepstin has quit
      • 2021-01-22 02224, 2021

      • Mr_Monkey
        yvanzo: I see similar weird artifacts when I try to open the MB logo in Inkscape. https://usercontent.irccloud-cdn.com/file/KA4YMMZ…
      • 2021-01-22 02226, 2021

      • goldenshimmer has quit
      • 2021-01-22 02226, 2021

      • joshuaboniface has quit
      • 2021-01-22 02234, 2021

      • Mr_Monkey
        Not great news, I'll have to look into that.
      • 2021-01-22 02238, 2021

      • reosarevok
        Same in validator ( $i =~ s/mediums/media/;)
      • 2021-01-22 02243, 2021

      • devorizon[m] has quit
      • 2021-01-22 02251, 2021

      • yvanzo
        _lucifer: which size?
      • 2021-01-22 02202, 2021

      • nobodyrocks[m] has quit
      • 2021-01-22 02202, 2021

      • lorenzuru has quit
      • 2021-01-22 02204, 2021

      • reosarevok
        So I guess it's not documented because it's deprecated
      • 2021-01-22 02212, 2021

      • MagnusSvensson[m has quit
      • 2021-01-22 02207, 2021

      • yvanzo
        _lucifer: there are small issues such as making search results to comply with lookup/browse results, medium issues as adding support for collections, large issues such as porting to python 3.
      • 2021-01-22 02228, 2021

      • reosarevok
        Anyway. Re: the counts, we should probably try to be consistent, so either have them on both search and lookup/browse for JSON, or on neither. Removing is more dangerous than adding, but at the same time I'm not sure how useful this data is... :/
      • 2021-01-22 02245, 2021

      • BrainzGit has quit
      • 2021-01-22 02242, 2021

      • yvanzo
        _lucifer: there are other possible improvements for continuous integration (e.g. by testing sir against mbsssss), and documentation (e.g. adding more details about search fields).
      • 2021-01-22 02222, 2021

      • yvanzo
        reosarevok: So adding a duplicate JSON element named "media-count"?
      • 2021-01-22 02241, 2021

      • reosarevok
        Might be best. The same is probably true of all other count attributes/elements, FWIW
      • 2021-01-22 02254, 2021

      • BrainzGit joined the channel
      • 2021-01-22 02257, 2021

      • reosarevok
        bitmap: ^ when you're back, I'd like an opinion on that too
      • 2021-01-22 02213, 2021

      • reosarevok
        yvanzo: if you have some smaller stuff that might not require setting up the whole infrastructure locally to test, I could also give a hand
      • 2021-01-22 02219, 2021

      • reosarevok
        With search stuff I mean
      • 2021-01-22 02237, 2021

      • reosarevok
        Documentation might be a thing, if you have a clear idea of what's missing
      • 2021-01-22 02213, 2021

      • reosarevok
        I do have a couple free hours today and no clear ticket to do next
      • 2021-01-22 02229, 2021

      • yvanzo
        reosarevok: I found that https://musicbrainz.org/doc/Indexed_Search_Syntax is incomplete as in: 1) the expected values for search fields is not always documented, 2) some search fields are just missing.
      • 2021-01-22 02243, 2021

      • reosarevok
        Do you have a couple examples?
      • 2021-01-22 02201, 2021

      • reosarevok
        I can look into that. Do we have a good file with all possible search fields on github? :)
      • 2021-01-22 02249, 2021

      • yvanzo
        for example, the "lang" search field for Work should be ISO-639-3
      • 2021-01-22 02204, 2021

      • yvanzo
        there is a script to generate the list of search fields in "sir" repo
      • 2021-01-22 02217, 2021

      • reosarevok
        Ok, I'll take a look :)
      • 2021-01-22 02251, 2021

      • yvanzo
        reosarevok: sorry, in "mbsssss" ^
      • 2021-01-22 02245, 2021

      • ruaok
      • 2021-01-22 02226, 2021

      • ruaok
        douchy services provider's response: https://aws.amazon.com/blogs/opensource/stepping-…
      • 2021-01-22 02255, 2021

      • ruaok
      • 2021-01-22 02219, 2021

      • ruaok
        and all of this is focused on shit software to start with.
      • 2021-01-22 02223, 2021

      • ruaok
        good mooorning!
      • 2021-01-22 02214, 2021

      • reosarevok
        And nobody looks good. Fun.
      • 2021-01-22 02238, 2021

      • reosarevok
        yvanzo: is there a reason aliasaccent is not a thing?
      • 2021-01-22 02238, 2021

      • reosarevok
        (I mean, other than "we haven't implemented it" :) )
      • 2021-01-22 02256, 2021

      • reosarevok
        Also, huh. beginarea and endarea take names, not MBIDs?
      • 2021-01-22 02202, 2021

      • Gazooo79494 has quit
      • 2021-01-22 02246, 2021

      • Gazooo79494 joined the channel
      • 2021-01-22 02211, 2021

      • yvanzo
        reosarevok: no
      • 2021-01-22 02217, 2021

      • yvanzo
        (about aliases)
      • 2021-01-22 02235, 2021

      • SamThursfield[m] joined the channel
      • 2021-01-22 02253, 2021

      • reosarevok
        Also, sigh. So http://musicbrainz.org/ws/2/artist?query=end:%222… matches also anything ended in 2020 with no month and day, or 2020-02 with no day
      • 2021-01-22 02200, 2021

      • reosarevok
        Is this intentional and if so, is there a workaround?
      • 2021-01-22 02218, 2021

      • yvanzo
        there is no workaround afaik
      • 2021-01-22 02213, 2021

      • reosarevok
        Is there a ticket?
      • 2021-01-22 02253, 2021

      • yvanzo
        that seems to be SEARCH-634
      • 2021-01-22 02254, 2021

      • BrainzBot
        SEARCH-634: Cannot search for partial or exact dates using advanced query syntax anymore https://tickets.metabrainz.org/browse/SEARCH-634
      • 2021-01-22 02256, 2021

      • reosarevok
        Ok.
      • 2021-01-22 02220, 2021

      • reosarevok
      • 2021-01-22 02253, 2021

      • reosarevok
        I'll add something about SEARCH-634 to the Notes section of the search page
      • 2021-01-22 02254, 2021

      • BrainzBot
        SEARCH-634: Cannot search for partial or exact dates using advanced query syntax anymore https://tickets.metabrainz.org/browse/SEARCH-634
      • 2021-01-22 02220, 2021

      • reosarevok
        Also, is there a specific ticket for updating these docs, or should I make one? :)
      • 2021-01-22 02254, 2021

      • yvanzo
        it looks much better, thanks, there is no ticket afaik
      • 2021-01-22 02235, 2021

      • yvanzo
        I did some research about how to document search fields directly in mbsssss but it seems uneasy to do/maintain.
      • 2021-01-22 02258, 2021

      • reosarevok
        Ok, I'll add a ticket (so I can track the work better) and keep doing other entities
      • 2021-01-22 02259, 2021

      • reosarevok
        Well, doing it directly in mbssssssssssssss I guess would imply having a JSON file where you map a key (probably "entity/field") to a description string.
      • 2021-01-22 02219, 2021

      • reosarevok
        And then have the python script take the description from the file
      • 2021-01-22 02231, 2021

      • yvanzo
        Ideally, I'd like to put that directly in a "summary" attribute for each search field defined in */conf/schema.xml but I did not test if that would break Solr.
      • 2021-01-22 02210, 2021

      • reosarevok
        Well, I'll update the summaries for now and we can always move them to the schema later
      • 2021-01-22 02217, 2021

      • yvanzo
        +1
      • 2021-01-22 02254, 2021

      • reosarevok
        Also, is there a ticket to search more stuff by MBIDs?
      • 2021-01-22 02212, 2021

      • reosarevok
        It would be good to have area search that doesn't depend on English names that might change, at the very least
      • 2021-01-22 02249, 2021

      • yvanzo
        +1
      • 2021-01-22 02200, 2021

      • yvanzo
        there is no ticket about that so far
      • 2021-01-22 02208, 2021

      • _lucifer
        ruaok: i read about that but didn't quite understand what's going on. (elasticsearch)
      • 2021-01-22 02223, 2021

      • yvanzo
        searching by MBID is available for some fields but not for area (but in area search index)
      • 2021-01-22 02225, 2021

      • ruaok
        _lucifer: is it clear to you now?
      • 2021-01-22 02215, 2021

      • yvanzo
        reosarevok: so adding search fields "aid", "beginaid", "endaid", right?
      • 2021-01-22 02222, 2021

      • reosarevok
        Yeah
      • 2021-01-22 02237, 2021

      • _lucifer
        ruaok: not yet but still reading up the link you shared above.
      • 2021-01-22 02247, 2021

      • yvanzo
        in general, there is no problem with adding search fields, but to recording search index (which is not related to area, so it's ok)
      • 2021-01-22 02253, 2021

      • reosarevok
        Eventually probably the same for gender and type for example, but I guess we would need to document those gids properly later :p
      • 2021-01-22 02208, 2021

      • reosarevok
        Why is recording a problem? Just because it's huge and would require a full reindex?
      • 2021-01-22 02210, 2021

      • yvanzo
        (the problem with adding data to recording search index is: it's too large already)
      • 2021-01-22 02223, 2021

      • reosarevok
        Recording seems to have nothing of the sort, so that's ok
      • 2021-01-22 02250, 2021

      • reosarevok
        Ok, RG types, but :p
      • 2021-01-22 02255, 2021

      • reosarevok
        We can live without
      • 2021-01-22 02203, 2021

      • reosarevok
        Are you adding a ticket or should I?
      • 2021-01-22 02209, 2021

      • reosarevok
        For area at first