#metabrainz

You're doing good work, _lucifer!

alastairp: https://github.com/metabrainz/docker-server-con...

_lucifer: that's good, but we should also update all other services to this image

for now, let's just start it manually

👍

i have pulled the latest image on lemmy

source scripts/services.sh; docker stop listenbrainz-labs-api-prod && docker rm listenbrainz-labs-api-prod; start_listenbrainz_labs_api 'prod' 'v-2021-03-02.0'

run those as separate commands

!m _lucifer

You're doing good work, _lucifer!

labs api fixed.

sweet

_lucifer: go ahead and update that PR to include the other version numbers

it seems to be broken for me :(

it's OK to use yesterday's image on all other services and today's on labs api

yeah, I just noticed that one.

this works: https://labs.api.listenbrainz.org/mbid-mapping?...

found it, fixed it, testing now.

I think a commit may have gotten lost here. I recall importing the name of the index from the mbid_mapping module.

_lucifer: after you make a commit for updating the image versions, can you make another one which reorders items in lemmy.sh to put all prod items first, and then a newline and then all beta items

yes, sure will do that

we should look into the automating image building sometime soon, it'll help ease out the release process

ruaok: when you're done with this testing lmk, got a question to run past you about mb2wikidatabot

go, I'm idle, waiting for tests.

_lucifer: absolutely. please write a ticket that includes all of the "strange" things that you've learned about deploy

but reosarevok is more of the maintainer of that now.

ruaok: in other python apps, we now have this pattern of creating runit scripts, adding `down` to all of them, and then in rc.local looking at $CONTAINER_NAME and removing the down. However mb2wdbot is only ever one service

so I guess we probably shouldn't over-complicate this one, and just making the service start unconditionally is fine. what do you think?

_lucifer: recording search fixed, deploy labs-api again? sorry for this. :(

sure, on it

starting unconditionally is fine, yes.

normally if we have problems with the service, we take it down.

I saw a great tweet a few weeks ago, it basically said "when you encounter a new project, make a wtf list. this contains all of the things that strike you as odd, it's likely that everyone on the project has become desensitised to all of them and think it as normal"

I did that with funkwhale, but the maintainer is burnt out and didn't really give a flying fuck about this feedback, which was sad.

ruaok: can you once take a look at the other queries as well?

so we only have this small period of time before _lucifer gets desensitised to our deploy process. we need him to say "wtf, why do you have to do such a convoluted process to deploy"

ruaok: yeah, that sucks

_lucifer: that's a backend data issue. please release for now, I'll see about building this index.

👍

[listenbrainz-server] release v-2021-03-02.1 has been published by github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

ruaok: deployed, recording search works fine :DD

great!

thx!

works in the LB UI as well.

the year search bit is fine for now, there are no users of that endpoint yet.

-> lunch

ruaok, _lucifer, alastairp and shivam-kapila : Can I get your eyes, feedback and preference on these timeline designs please? https://www.figma.com/file/YWWmKJUJHTYXSuIQt2Rg...

No giga rush, today would be good.

1st n 3rd look good to me

#2 stands out, but I feel that that is a bit non-standard.

#3 is my fave, I think.

Mine too

4th isnt much mobile friendly

Yeah I had the same worry about #4. It wouldn't have that right-left effect on mobile, and coding that would be challenging

Mr_Monkey: can you move the date/time to RHS in 3rd

#2 would be good for other types of data, but I think people have some ideas as to what a timeline should look like.

shivam-kapila: you should have edit powers, try now

i like 3 as well. how about also grouping cards? like if a user shared multiple songs, it says anonymous shared multiple songs and then the cards in that category.

I like that idea.

grouped by what time range, though?

yeah time range or if there is no other timeline activity between those two events

or a mix of both of those

If there is no other activity and the events take place within a given time range, then the similiar ones get grouped. (a group of likes, another of recommendations etc.)

Hmm. I like 2 because it doesn't say "I'm fucking Facebook"

But then, ruaok might be right "fucking Facebook" is what people expect from a timeline nowadays :D

Thanks for your feedback !

Anyway, none of them are bad, so if you do any of them, I'd be happy enough :D

+1 to 3

30 years today since the death of Serge Gainsbourg: https://www.youtube.com/watch?v=YRk2Btrc5Wo&...

ping serge # 0% packet loss

👏 yvanzo. well done.

I suppose we have a ghost server.

iliekcomputers: we should be careful about the index type on the enum field.

ruaok: i was gonna ask you to elaborate

if we end up doing searches for events with a particular type and we have 5 types and 10M rows (lets say spread evenly), and then we wish to do a search we will end up having to scan 2M rows that have the same type.

this used to be a big problem for MB and the edit table. but a lot of time has passed since those days and I don't know if this is still a concern.

googling hasn't really revealed any clear suggestions.

will we be doing queries that have just an event_type ? I added an index on user_id, event_type as well for queries like user_id = X and event_type = 'recording_recommendation'

I can't think of a use case right now, TBH. but given that I was burnt by this as a child, I try to prevent this from happening in the future. :)

mhmm, makes sense. I assume we might do queries in the future based on event_type and things in the metadata field, but then we can either extract those fields out of metadata and create indexes (or just create indexes on the json).

so about the timeline design, are we all ok to go with #3?

fine by me.

cool, then i guess next steps would be for Mr_Monkey to use the current endpoint to build the frontend and then we can change the endpoint to send better data. right now it sends all listens, we can filter those, and eventually add track recommendations etc as well.

Mr_Monkey: what do you think?

Mr_Monkey: sorry I had to go to get my phone repaired

iliekcomputers: I think that PR now looks good -- how about the spec for what to stuff into the metadata JSONB field?

i'll create a pydantic model in the next PR.

ok.

with the API endpoint.

iliekcomputers: may I take over the param/neighbours PR?

for sure.

Yes I think I can start building the page with the existing endpoint

I will make a new branch and cleanup first, then close that PR and replace it with another one later.

Mr_Monkey: awesome, thanks!

ruaok: sounds good.

I like the vertical line style on #2

[listenbrainz-server] mayhem closed pull request #967 (master…param/neighbours): [wip] Neighbours: User similarity based on Collaborative filtering on artist stats https://github.com/metabrainz/listenbrainz-serv...

makes it more readable to me for some reason

Good to know

that's my unsolicited opinion :P

we did solicit opinions. :P

[listenbrainz-server] paramsingh merged pull request #1309 (master…param-user-recommendation-event-table): Add new table for user recommendation events https://github.com/metabrainz/listenbrainz-serv...

they look great by the way, I look forward to seeing it live

[listenbrainz-server] mayhem opened pull request #1310 (master…user-similarity): User similarity, approach 2 https://github.com/metabrainz/listenbrainz-serv...

do draft pull requests also send notification emails on every push?

they do.

got it.

I can close it again after I get basic things squared away if you prefer that.

nah, no worries. i just like to open pull requests and push to see build results generally after testing things I've touched, but it's not really necessary if it's sending an email on push to everyone :)

yeah, same feelings here.

the PR page is just such a nice summary of the state of the branch.

ruaok: has anyone floated the idea of a "buy this track on Bandcamp" type link on LB?

not yet.

ah, that sucks

Bandcamp seem to be one of the "good guys" (although it's a low bar)

bandcamp would be a great company to work with, but they would like nothing to do with us. or me.

exactly.

_lucifer: for when alastairp lets you go, here is the branch for us to work on user similarity: https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] mayhem closed pull request #1310 (master…user-similarity): User similarity, approach 2 https://github.com/metabrainz/listenbrainz-serv...

reosarevok: iirc it had to do with the fact that linked_entities gets modified while it's being looped over. but there wasn't an easy fix outside of removing linked_entities

Mr_Monkey: https://www.figma.com/file/YWWmKJUJHTYXSuIQt2Rg...

I tried to bold names because I thing we should point them to user profiles

I agree with the name

how about time. Does it look good towards left or right

ot sure about the time. For this page I think it's important to be able to see it at a glance, along with who it relates to

Maybe under the name would be good though

I like LHS too tbh. was just trying what linkedin does

how about this one?

That could also work

anyone else has some feedback please :)

offtopic, but it feels so good to be writing python again lol

I had the same feeling last week lol

I think that's nice too shivam-kapila . I'm starting implementation, so I'll se what looks best

Mr_Monkey: why not random([list of date styles]) :p

something new everyday