0:18 AM
outsidecontext has quit
2021-04-01 09147, 2021
0:20 AM
outsidecontext joined the channel
2021-04-01 09157, 2021
0:29 AM
Lotheric has quit
2021-04-01 09115, 2021
0:38 AM
Lotheric joined the channel
2021-04-01 09152, 2021
2:44 AM
yef has quit
2021-04-01 09104, 2021
2:46 AM
yef joined the channel
2021-04-01 09104, 2021
2:46 AM
yef has quit
2021-04-01 09104, 2021
2:46 AM
yef joined the channel
2021-04-01 09117, 2021
2:49 AM
yef has quit
2021-04-01 09145, 2021
2:50 AM
yef joined the channel
2021-04-01 09145, 2021
2:50 AM
yef has quit
2021-04-01 09145, 2021
2:50 AM
yef joined the channel
2021-04-01 09103, 2021
3:15 AM
yef has quit
2021-04-01 09111, 2021
3:16 AM
yef joined the channel
2021-04-01 09111, 2021
3:16 AM
yef has quit
2021-04-01 09111, 2021
3:16 AM
yef joined the channel
2021-04-01 09134, 2021
3:17 AM
adhi001 joined the channel
2021-04-01 09116, 2021
3:20 AM
radioman
2021-04-01 09114, 2021
3:21 AM
yef has quit
2021-04-01 09120, 2021
3:22 AM
yef joined the channel
2021-04-01 09120, 2021
3:22 AM
yef has quit
2021-04-01 09120, 2021
3:22 AM
yef joined the channel
2021-04-01 09128, 2021
3:37 AM
davic joined the channel
2021-04-01 09125, 2021
3:52 AM
astroanax joined the channel
2021-04-01 09145, 2021
3:58 AM
Bharatkalluri joined the channel
2021-04-01 09114, 2021
4:03 AM
Bharatkalluri has quit
2021-04-01 09136, 2021
4:07 AM
yef has quit
2021-04-01 09142, 2021
4:08 AM
yef joined the channel
2021-04-01 09142, 2021
4:08 AM
yef has quit
2021-04-01 09142, 2021
4:08 AM
yef joined the channel
2021-04-01 09119, 2021
4:09 AM
Bharatkalluri joined the channel
2021-04-01 09109, 2021
4:49 AM
Bharatkalluri has quit
2021-04-01 09135, 2021
4:55 AM
Bharatkalluri joined the channel
2021-04-01 09108, 2021
4:56 AM
Bharatkalluri has quit
2021-04-01 09143, 2021
4:57 AM
MRiddickW joined the channel
2021-04-01 09119, 2021
5:13 AM
rdswift has quit
2021-04-01 09123, 2021
5:21 AM
Bharatkalluri joined the channel
2021-04-01 09140, 2021
5:23 AM
Bharatkalluri has quit
2021-04-01 09150, 2021
5:26 AM
rdswift joined the channel
2021-04-01 09138, 2021
5:28 AM
Bharatkalluri joined the channel
2021-04-01 09139, 2021
5:28 AM
Bharatkalluri has quit
2021-04-01 09148, 2021
5:39 AM
Bharatkalluri joined the channel
2021-04-01 09123, 2021
5:43 AM
sumedh joined the channel
2021-04-01 09157, 2021
5:43 AM
Bharatkalluri has quit
2021-04-01 09129, 2021
5:58 AM
yef has quit
2021-04-01 09105, 2021
6:00 AM
yef joined the channel
2021-04-01 09105, 2021
6:00 AM
yef has quit
2021-04-01 09105, 2021
6:00 AM
yef joined the channel
2021-04-01 09107, 2021
6:04 AM
BrainzGit
2021-04-01 09105, 2021
6:35 AM
BrainzGit
2021-04-01 09118, 2021
6:48 AM
BrainzGit
2021-04-01 09116, 2021
6:55 AM
BrainzGit
2021-04-01 09104, 2021
7:40 AM
alekhya joined the channel
2021-04-01 09148, 2021
7:47 AM
yef has quit
2021-04-01 09104, 2021
7:51 AM
yef joined the channel
2021-04-01 09104, 2021
7:51 AM
yef has quit
2021-04-01 09104, 2021
7:51 AM
yef joined the channel
2021-04-01 09155, 2021
7:51 AM
alekhya has quit
2021-04-01 09109, 2021
8:00 AM
ruaok
radioman: yep, we're in the process of fixing it. thanks for pointing it out.
2021-04-01 09156, 2021
8:03 AM
BharatKalluri joined the channel
2021-04-01 09113, 2021
8:10 AM
bharatkalluri_ joined the channel
2021-04-01 09125, 2021
8:10 AM
BharatKalluri has quit
2021-04-01 09125, 2021
8:10 AM
bharatkalluri_ is now known as bharatkalluri
2021-04-01 09135, 2021
8:21 AM
_lucifer
alastairp, now that we have updated sentry, i wanted to see sentry performance monitoring in action
https://docs.sentry.io/product/performance/ . I was thinking to put it in CB and if we find it useful we could add it to other services as well.
2021-04-01 09148, 2021
8:27 AM
_lucifer
ruaok, Mr_Monkey, iliekcomputers: with yesterday's upgrade, both LB prod and beta now share the same sentry project. The `listenbrainz` one. The errors will record whether they occured on prod or beta. There is also an environments label at the top right of the project issues page to filter errors based on environments.
2021-04-01 09158, 2021
8:29 AM
_lucifer
This configuration is also in place for lb test. next time, lb test is updated with changes from master, it will also start using the `listenbrainz` project in sentry.
2021-04-01 09111, 2021
8:30 AM
sumedh has quit
2021-04-01 09150, 2021
8:31 AM
ruaok
_lucifer: thx
2021-04-01 09158, 2021
8:33 AM
_lucifer
it was alastairp's idea :)
2021-04-01 09100, 2021
8:34 AM
_lucifer
!m alastairp
2021-04-01 09100, 2021
8:34 AM
BrainzBot
You're doing good work, alastairp!
2021-04-01 09126, 2021
8:34 AM
sumedh joined the channel
2021-04-01 09159, 2021
8:37 AM
alastairp
who me?
2021-04-01 09149, 2021
8:38 AM
alastairp
_lucifer: yeah, I 'm familiar with the tracing stuff. will it report correctly to sentry 9? or do we have to upgrade?
2021-04-01 09130, 2021
8:39 AM
alastairp
we should trace only a small portion of requests for now - 1-10%, just to ensure that it doesn't overload us with data
2021-04-01 09153, 2021
8:39 AM
_lucifer
alastairp: i think it should will need to test it. yes i agree.
2021-04-01 09119, 2021
8:40 AM
_lucifer
i was too thinking 5-10%.
2021-04-01 09152, 2021
8:44 AM
_lucifer
2021-04-01 09139, 2021
8:45 AM
alastairp
_lucifer: sentry_dsn is private (current value, unchanged). sentry/dsn is public (new value)
2021-04-01 09102, 2021
8:52 AM
_lucifer
alastairp: yes thats what i mean. sentry/dsn for consul/MeB/config.prod.json is using private dsn
2021-04-01 09129, 2021
8:53 AM
ruaok
alastairp: Mr_Monkey Freso yvanzo zas: invoices please!
2021-04-01 09147, 2021
8:58 AM
d4rkie joined the channel
2021-04-01 09153, 2021
9:00 AM
BrainzGit has quit
2021-04-01 09111, 2021
9:01 AM
BrainzGit joined the channel
2021-04-01 09147, 2021
9:02 AM
alastairp
ruaok: end of month, end of quarter, so much paperwork...
2021-04-01 09123, 2021
9:05 AM
ruaok
yep. let me know when you're ready for that accounting cross training!
2021-04-01 09125, 2021
9:05 AM
alastairp
_lucifer: what's on the table today? improvements to cache api, LB rate limiting api switchover, startup scripts?
2021-04-01 09136, 2021
9:05 AM
_lucifer
yes!
2021-04-01 09137, 2021
9:05 AM
alastairp
I just pay a guy to do my accounts, it's amazing
2021-04-01 09157, 2021
9:05 AM
_lucifer
and another LB Pr if we can slip it in
2021-04-01 09104, 2021
9:06 AM
ruaok
if we did that with MeB, we'd be paying a lot more than if I do it. lol.
2021-04-01 09110, 2021
9:06 AM
alastairp
yeah, I bet
2021-04-01 09119, 2021
9:06 AM
ruaok
#replaceaccountantswithscripts
2021-04-01 09121, 2021
9:06 AM
alastairp
2021-04-01 09136, 2021
9:06 AM
_lucifer
we also need to update MeB.
2021-04-01 09142, 2021
9:06 AM
ruaok
alastairp: you do not own your own company with them.
2021-04-01 09154, 2021
9:06 AM
alastairp
a friend of mine has xolo to help him run an estonia e-business, but they have this "we do all of your autonomo stuff" for spain too
2021-04-01 09156, 2021
9:06 AM
ruaok
you are legally entering into a joint venture with xolo when you sign up with them.
2021-04-01 09106, 2021
9:07 AM
alastairp
yeah, I think he knew that
2021-04-01 09122, 2021
9:07 AM
alastairp
the spanish one is expensive though - 5% of all of your incomings!
2021-04-01 09125, 2021
9:07 AM
ruaok
and this is a corporation. so, if they want to fuck you, its REALLY going to hurt.
2021-04-01 09137, 2021
9:07 AM
ruaok
> the spanish one is expensive though - 5% of all of your incomings!
2021-04-01 09143, 2021
9:07 AM
ruaok
just dont do business in spain. period.
2021-04-01 09152, 2021
9:07 AM
alastairp
well, that's a xolo fee
2021-04-01 09158, 2021
9:07 AM
alastairp
but in general, agreed :)
2021-04-01 09137, 2021
9:14 AM
_lucifer
alastairp, i am updating MeB PR to set a release. in the meantime, do you want to review CB cache PR?
2021-04-01 09147, 2021
9:14 AM
alastairp
yes, will do
2021-04-01 09105, 2021
9:15 AM
_lucifer
2021-04-01 09147, 2021
9:34 AM
alekhya joined the channel
2021-04-01 09101, 2021
9:37 AM
_lucifer
MeB PR updated.
2021-04-01 09108, 2021
9:55 AM
alastairp
_lucifer: great, I'm still looking at CB
2021-04-01 09146, 2021
9:55 AM
alastairp
how many changes are needed to add the expiry time to all downstream apps?
2021-04-01 09107, 2021
9:56 AM
_lucifer
none i think.
2021-04-01 09112, 2021
9:56 AM
alastairp
ah, great
2021-04-01 09136, 2021
9:56 AM
_lucifer
all downstream apps set expiry time and there's a BU pr to set the default to a non-zero value
2021-04-01 09107, 2021
9:57 AM
alastairp
ok
2021-04-01 09120, 2021
9:57 AM
alastairp
while we're working on this, I saw the function method:
2021-04-01 09122, 2021
9:57 AM
alastairp
def set_many(mapping, time=None, namespace=None, encode=True):
2021-04-01 09139, 2021
9:57 AM
alastairp
do we like `time` as a name? I wonder if it'd be better to call it `expirein`
2021-04-01 09122, 2021
9:58 AM
_lucifer
expirein would be more clear for sure.
2021-04-01 09103, 2021
9:59 AM
alekhya has quit
2021-04-01 09106, 2021
9:59 AM
_lucifer
2021-04-01 09123, 2021
9:59 AM
alastairp
cool
2021-04-01 09137, 2021
9:59 AM
alastairp
also, while we're there, there are bunch of comments that don't make sense
2021-04-01 09141, 2021
9:59 AM
_lucifer
we'll need to update downstream apps as well
2021-04-01 09142, 2021
9:59 AM
alastairp
# Note that both key and value are encoded before insertion.
2021-04-01 09151, 2021
9:59 AM
alastairp
not true, key is no longer encoded
2021-04-01 09103, 2021
10:00 AM
alastairp
# TODO: Fix return value
2021-04-01 09107, 2021
10:00 AM
_lucifer
i might have removed that in the relevant PR
2021-04-01 09112, 2021
10:00 AM
alastairp
this one looks like it's fine too
2021-04-01 09139, 2021
10:00 AM
alastairp
oh? maybe I'm out of date. ok, let's not worry about that and look at them once we get everything merged
2021-04-01 09141, 2021
10:00 AM
_lucifer
let me take a look at the open ones, otherwise i'll update this
2021-04-01 09157, 2021
10:00 AM
_lucifer
yeah let's do that
2021-04-01 09152, 2021
10:03 AM
Darkloke joined the channel
2021-04-01 09158, 2021
10:04 AM
v6lur joined the channel
2021-04-01 09106, 2021
10:10 AM
_lucifer
alastairp, which should we use `expire_in` or `expirein`? i prefer the first but elsewhere in the file we omit `_`
2021-04-01 09135, 2021
10:11 AM
alastairp
I don't mind too much either way. are you referring to the example of expireat? We also have db_number and ns_versions_loc in init
2021-04-01 09150, 2021
10:11 AM
alastairp
I don't mind either way. If you want to make everything have a _ then that's fine
2021-04-01 09122, 2021
10:12 AM
_lucifer
👍
2021-04-01 09130, 2021
10:12 AM
alastairp
from a selfish point of view, I feel that expirein is slightly easier to type
2021-04-01 09134, 2021
10:13 AM
alekhya joined the channel
2021-04-01 09136, 2021
10:14 AM
_lucifer
fair point. redis methods also seem to be named without `_`. `expirein` it is then.
2021-04-01 09149, 2021
10:16 AM
_lucifer
So today we'll be tackling the 2 hardest problems in software: naming things, cache invalidation and off by one errors?
2021-04-01 09110, 2021
10:18 AM
alastairp
🤣
2021-04-01 09132, 2021
10:20 AM
MRiddickW has quit
2021-04-01 09150, 2021
10:21 AM
_lucifer
2021-04-01 09142, 2021
10:23 AM
v6lur has quit
2021-04-01 09103, 2021
10:24 AM
reosarevok
!recall oh no.
2021-04-01 09103, 2021
10:24 AM
BrainzBot
2021-04-01 09143, 2021
10:24 AM
v6lur joined the channel
