I updated test.listenbrainz.org again with the datepicker navigation PR, if anyone wants to try it (recent listens page).
2021-05-10 13030, 2021
Mr_Monkey
It works swimmingly!
2021-05-10 13031, 2021
Mr_Monkey
I had to hard refresh to get the newer css file, I'm going to try to solve that first.
2021-05-10 13015, 2021
alastairp
Mr_Monkey: ah, that was because we don't use webpack to generate css I believe?
2021-05-10 13025, 2021
Mr_Monkey
Correct
2021-05-10 13006, 2021
Mr_Monkey
And we don't have a hash in the name in a manifest file like we do for the js files
2021-05-10 13025, 2021
shivam-kapila
Unrelated but when en want to migrate to BS5 we might wanna switch to Sass as BS now come bundled ad Sass
2021-05-10 13032, 2021
_lucifer
ruaok: yup, the email arrived.
2021-05-10 13035, 2021
_lucifer
!m ruaok
2021-05-10 13036, 2021
BrainzBot
You're doing good work, ruaok!
2021-05-10 13007, 2021
alastairp
here's an interesting observation: I just loaded some local files into spotify. They expose the metadata of the currently playing song in now_playing, but the songs don't appear in the playback history on spotify api (I think this makes sense from their perspective). Do we want to try and do anything about these?
2021-05-10 13032, 2021
ruaok
how could we?
2021-05-10 13042, 2021
alastairp
I guess that's the question. we could special-case Spotify somehow: If it's now-playing and a local file, keep track of it and submit it ourselves when a new now-playing comes in
2021-05-10 13005, 2021
alastairp
however my feeling is that we shouldn't treat them as a special case, and just continue to ignore it as we currently do
2021-05-10 13026, 2021
ruaok
if users end up complaining that this is a problem, lets revisit.
2021-05-10 13004, 2021
ruaok
alastairp: _lucifer : I also just shuffled cron jobs around so that incremental dumps are imported BEFORE daily stats. lol.
2021-05-10 13045, 2021
_lucifer
lol, i thought that was the case always.
2021-05-10 13026, 2021
ruaok
heh, yeah. we should also collapse all those cron entries for stats into one action. We never plan to run the separately, so might as well do them in one swoop and compact our schedule.
2021-05-10 13027, 2021
CatQuest
ruaok: someone in #musicbrainz mentioned something about funkwhale/tagging/picard
2021-05-10 13044, 2021
CatQuest
(if interested :D)
2021-05-10 13048, 2021
ruaok
k, happy to answer questions.
2021-05-10 13058, 2021
ruaok
speaking of which, I just realized...
2021-05-10 13035, 2021
ruaok
Mr_Monkey: _lucifer : could we somehow use the new music services feature to add funkwhale as a local music service?
2021-05-10 13045, 2021
CatQuest
oooohhh cool
2021-05-10 13021, 2021
ruaok
I know it would't work out of the box, but if the user could specify the funkwhale IP:PORT and login credentials, then brainzplayer could play from funkwhale.
2021-05-10 13022, 2021
_lucifer
ruaok, i don't know about funkwhale. what should an integration with funkwhale do?
2021-05-10 13031, 2021
ruaok
one sec.
2021-05-10 13048, 2021
_lucifer
+1 to the collapsing the cron entries into one action.
2021-05-10 13000, 2021
Mr_Monkey
I think it would be doable ruaok
2021-05-10 13019, 2021
ruaok
it would be nerdvana.
2021-05-10 13026, 2021
Mr_Monkey
Haven't looked at the API on the funkwhale side for embedding or streaming content though
ruaok, the client id and client secrets are not stored in the current tables. we could make another table to store those creds. right now there is only youtube and spotify so it works in consul but if the number of services increase we would probably move to a table anywyas.
_lucifer: outsidecontext already wrote a funkwhale plugin for submitting LB listens.
2021-05-10 13025, 2021
ruaok
and its been merged into their codebase. but yes, I would like to explore adding funkwhale support. but not right this second. too man loose ends still
2021-05-10 13012, 2021
CatQuest
too man 🤔
2021-05-10 13020, 2021
ruaok
that too.
2021-05-10 13022, 2021
CatQuest
:D
2021-05-10 13051, 2021
_lucifer
oh nice! so we are looking at a BrainzPlayer integration here. i have opened LB-889 for now, will look into it later and update with my findings.
People up for reviews today include: zas, alastairp, _lucifer, bitmap, Mr_Monkey, yvanzo, ruaok, Freso, reosarevok, CatQuest – anyone else who might want to give review, let me know ASAP. :)
last week we took LB down to check the fan on gaga (I think that was last week?)
2021-05-10 13024, 2021
alastairp
it involved a bit of dev work to ensure that we could take the db down but leave the submissions api up.
2021-05-10 13033, 2021
alastairp
it worked well, we had a few hiccups but solved them
2021-05-10 13049, 2021
reosarevok
Oh, neat, wanna run our MBS schema change then?
2021-05-10 13009, 2021
alastairp
with ruaok and _lucifer a few days later we upgraded the timescale db on listenbrainz. this had a few small hiccups too regarding free disk space, but we worked around those too. we now have a pretty solid workflow to do this, which is great
2021-05-10 13049, 2021
alastairp
the end of this stream of tasks was to review ruaok's changes to improve the way that we count listens in LB. it's _muuuuuuch_ faster now
2021-05-10 13051, 2021
alastairp
!m ruaok
2021-05-10 13051, 2021
BrainzBot
You're doing good work, ruaok!
2021-05-10 13005, 2021
alastairp
I did some other small reviews of LB tasks too
2021-05-10 13010, 2021
ruaok
but with terrible listen counts apparently. lol
2021-05-10 13039, 2021
zas
btw, I'm there, I didn't notice it was meeting time already
2021-05-10 13040, 2021
alastairp
I migrated AB unit tests to github, and with zas's help set up AB downloads over http as web browsers are starting to remove support for FTP
2021-05-10 13009, 2021
alastairp
a few small other upgrade tasks that don't require more detail
2021-05-10 13014, 2021
alastairp
next? zas is here now!
2021-05-10 13020, 2021
zas
hey
2021-05-10 13046, 2021
zas
I did usual maintenance, upgrades, user support, etc
2021-05-10 13011, 2021
zas
also Picard PRs reviews & testing (massive ones in the queue)
2021-05-10 13041, 2021
zas
also deployed AB http(s) preliminary support
2021-05-10 13059, 2021
zas
question: should we deprecate ftp?
2021-05-10 13024, 2021
zas
that's it for me. yvanzo ?
2021-05-10 13028, 2021
Freso
IMHO, if it makes things easier for you, sure. If not, might as well keep.
