#metabrainz

[musicbrainz-server] reosarevok opened pull request #2100 (master…MBS-11662): MBS-11662: Lowercase untitled/unknown if in brackets https://github.com/metabrainz/musicbrainz-serve...

Wb reosarevok 👋

Hi! I got a break, it was nice, can recommend

Hope nothing got too messed up while I was away

We managed. Welcome back !

and happy birthday too!

(mooin!)

Thanks!

"Instrucció per a la recuperació progressiva de la presencialitat del PAS a la UPF"

:(

as in its time to go back to the office?

yep, starting from next week!

that was fast

no way to say "nope, not until vaccine!" ?

well, that's definitely what I'm going to say

we'll see if there's any fallout from it

[listenbrainz-server] amCap1712 opened pull request #1463 (master…master): Use docker buildx to build production images https://github.com/metabrainz/listenbrainz-serv...

ruaok (and Freso maybe?): opinions on https://wiki.musicbrainz.org/index.php?title=Da... ?

alastairp, based on your whether cron is running PR, how about we also add an action to validate and display the crontabs in human readable form if a crontab is modified?

we do not need to do this now but seems a useful future enhancement

reosarevok: seems good.

I would remove the "if you ask nicely", but otherwise seems good.

mmm, maybe itercron will raise an exception if a pattern is invalid? I don't know if it can turn a pattern into a descriptive text

there's a is_valid function to check if the pattern is valid

I guess ruaok and I have been around long enough that (most of the time) we know how to write a cron without screwing it up

would be happy to add additional cron management commands if you'd find it useful

Freso: well, the point is we are not obliged to remove the name AFAICT and I certainly won't do it if they are dicks about it

👍, human readable text would have been nice but i do not see that in the library docs so let's leave it.

So I thought a word of warning might be useful

https://bradymholt.github.io/cron-expression-de... it looks like there are tools to do it, though?

"At 12:00 AM, on day 1 and 15 of the month"

"At 04:00 AM, only on Monday"

thanks! bookmarked, that should do the job

what's not human readable about crontabs? there is a perfect translator available. its called "man"

man 5 crontab not on Macs :( I always have to ssh somewhere else

yep. another reason why macs are being phased out of my life.

linux on the desktop has quietly arrived.

I thought it had been here for 10 years

though, mixing up 0 and * in the minutes column can be problematic

`0 * * * * dd if=/dev/null of=/dev/md0` is my favorite crontab entry

long walk off a short pier.

don't do this at home, kids

okk, less destructive... `while 1: fork()`

dont do that one at home or on our servers, either. :)

hmm. interesting. I should read up on the USB-3 spec. I wonder how the data is multiplexed

there's so much going on there

usbc/thunderbolt/alt modes, etc

a friend of mine has a 4k monitor with built in ethernet and usb hub, and if he wants 60hz he can't run the hub at usb-3/gigabit ethernet because there's not enough bandwidth

[musicbrainz-server] reosarevok opened pull request #2101 (master…MBS-10205): MBS-10205: Readd link to the Data Removal Policy to the menu https://github.com/metabrainz/musicbrainz-serve...

alastairp, ruaok: we do not have buildx on bono. can we install that?

*docker buildx

sure, have at it. bono is our wild west, right?

you'll have to install a new version of docker

lol

i checked we have 19.03 so it should work

only need to install buildx

maybe there's a setting to add in the daemon.json file

alastairp: for `COPY ./docker/services/spark_reader/consul-template-spark-reader.conf /etc/consul-template-spark-reader.conf` how does the base image know to look at this file?

ruaok: sorry - missed one more item

we add `down` to all services

and then in rc.local rm the down based on env variables

understood, but this is a one service container that I always want up. so I should not need down, right?

right, so add a new runit service with a `run` file

got that.

`exec run-consul-template -config /etc/consul-template-spotify-reader.conf`

`exec /code/metrics/metric_writer.py`

oh, I see.

got it.

👍

because the exec that I was missing in in template...conf

yep, right

render the config file with consul _then_ call the thing in the exec block

https://github.com/docker/buildx/#docker-ce does mention that it can be enabled by adding a entry to config.json

for metric support, what should my base image be?

I think the python one is a good choice

clearly. but which version?

ARG PYTHON_BASE_IMAGE_VERSION=3.7-20210115

for this I might as well go with 3.9.

yeah, I see no reason not to

but 20210115 won't have metric support in, will it?

where do I find what versions we have available?

metric support is part of BU

so just add that in requirements

images are listed at https://github.com/metabrainz/docker-python

ah and BU is not part of the base image. I see.

_lucifer: got it, thanks.

so requirements.txt has `git+https://github.com/metabrainz/brainzutils-python.git@v2.0.1` ?

yes

ok, i think that completes all the pieces. time to give it whirl.

any tips on how to debug this? the flags for run-consul-template are not terribly helpful.

are you just running it from a `docker run`?

i woudl suggest copying stuff from the statup improvements PR

consul-agent requires syslog to be started up (which runit will do)

the container just restarts, so I am doing a `docker run --rm -it ... bash`

yep, i have a valid looking /etc/service/syslog-ng/run

I normally see this happening - consul-template starts up, doesn't see syslog, prints the error, syslog starts up, consul-template restarts, connects to syslog, and goes silent

reosarevok, i need to create a couple of fake users on MB for testing. can't use test.mb. what's the best way to go about it. i go ahead and create. after i am done, delete the account?

but I'm unsure about the restart, sorry. I'm in a call, but can take a look at it afterwards if you get the code up

_lucifer: or don't delete them

I see no problem with having ListenBrainz Test User or something

cool, thanks!

_lucifer: copy bits from here? https://github.com/metabrainz/listenbrainz-serv...

any bits in particular?

yes, one sec. let me see which ones are needed.

these 3 files, you can leave out the sentry stuff

plus you'll need a few changes to consul config like https://github.com/metabrainz/listenbrainz-serv...

if you have the code in a repo, i can set it up

<3 <3 <3

one sec

ruaok: is `run` +x ?

yes

👍

_lucifer: git@github.com:metabrainz/metric-writer.git

👍

ruaok, just saw your consul template, i think the startup improvements won't benefit you :(. those improvements are useful when loading stuff like keys from consul.

ah, I feel better now. I looked at your links and wasn't certain what I should be copying.

thanks though.

one thing though, you might need a `cd /code/metrics` somewhere.

for example we have this in LB

i see you do specify the complete file name, but i am not sure we don't do that in LB so thought to mention.

did that, no change.

:(

also not related to current errors but https://github.com/metabrainz/metric-writer/blo... you probably want to lowercase REDIS_SERVERS here.

thx, fixed that already, just not committed yet.

happy to hit THAT error. :)

:D

next up, try passing -log-level debug to run-consul-template

did, that seems to be the case already, no change.

even with no stuff in consul_config.py.ctmpl nothing gets generated.

alastairp: when you're done with your meeting, I would love help on this.

one option would be to not enable syslog. i think for testing that's fine?

can't hurt to try, but I doubt the error messages it is printing are really relevant. those are ALWAYS printed. 🙄