#metabrainz

@ListenBrainz/@MusicBrainz android app devs, I have the MusicBrainz android app installed and I get a toast message that a "user token has not been set!" everytime I play some videos. In the app I set my LB token but I still get this message... Any idea what is happening ?

<Lotheric_ " @ListenBrainz/@MusicBrainz andr"> Hi Lotheric_ ! I will go through the code today regarding this and get back to you as soon as I find any bugs and try to fix it. Else we always have _lucifer to help us out.

ruaok: i'd take a look at it but stats.me seems to be down currentyl ;)

Lotheric_: thanks for the report. can you please also share your android version?

akshaaatt[m]: thanks for taking a look at it. let me know if you need any help.

mo’’in’

moin!

yvanzo: with https://github.com/metabrainz/musicbrainz-serve... the second should be regexp_replace('a.b.c', '\.', '', 'g') ⇒ 'abc', right?

reosarevok: right

ruaok, stats back up so i took a look. looks nice :D but why is there a steep rise in total counts here between 04:00 and 06:00 https://stats.metabrainz.org/d/OGg5QUCGz/listen...

[musicbrainz-server] reosarevok opened pull request #2104 (master…MBS-11663): MBS-11663: Load RGs also when moving CDTOCs https://github.com/metabrainz/musicbrainz-serve...

mooin!

_lucifer: yes, it seems that stats was down (or at least unreachable for a while) I

I'll have to harden things more still.

and the rise is because the MB mapper doesn't load old stats from disk when it starts -- I'll need to do that next.

ah ok, makes sense.

also, we should apply for Youtube OAuth verification today methinks

let's go over it once again others are available and then fill the verification form?

ok, lets do that this afternoon.

sure

_lucifer: the dumps failed AGAIN, because one prerequisite temp dir was missing. grr. I've made a ticket for that and the full dump is finishing mogrifying.

and somehow, we still didn't get a dumps are outdated email. sigh.

damn

in fact, cron seems to have done nothing at all overnight.

I'll let the dump finish before I investigate.

docker logs only shows entries from run stats crontab, but nothing from dumps crontab. ideas why that is so?

did you check /logs/dumps.log ?

that is where the dump logs go.

also, can you have a look at https://github.com/metabrainz/brainzutils-pytho... ?

and then put out a 2.0.2, please?

yes, i checked /logs/dumps.log. there's permission errors for incremental dumps.

ah ok, makes sense now.

yes, i checked /logs/dumps.log. there's permission errors for incremental dumps.

ah ok, makes sense now.

on the BU PR.

hello

lots of work over the weekend!

the actual implementation of stats is considerably more tricky that I'd hoped. (as fucking usual)

drat

doesn't help that the stats server sits on a different contient.

I have a call now, but will jump into it in ~an hour if you want to make a list :)

ruaok: a couple of minor fixes on the BU. i have made the changes. will merge and release once you take a look

looks good, thanks!

👍

clearly I shouldn't have been working this weekend and relaxing. that was a piss poor tiny PR. 🤦

thanks!

[brainzutils-python] amCap1712 merged pull request #70 (master…fix-float-values): Fix float values https://github.com/metabrainz/brainzutils-pytho...

[brainzutils-python] release v2.0.2 has been published by amCap1712: https://github.com/metabrainz/brainzutils-pytho...

[brainzutils-python] release v2.0.3 has been published by github-actions[bot]: https://github.com/metabrainz/brainzutils-pytho...

thank you!

I'm back. what's going on?

_lucifer: I saw your comment showing ruaok how to source services.sh in prod. Do you want to have a brainstorm about how we can make a 'deploy.sh' to do all of these steps

alastairp, sure

take a project/service/date; pull image; stop old one; start new one; optionally update config file

Yes, I do

there is a script somewhere in docker-server-configs which does 90% of this

I think yvanzo wrote it, and Mr_Monkey uses it sometimes

https://github.com/metabrainz/docker-server-con... ?

that's the one

That one

for me, the main disadvantage of this script is that it still starts services by running start_services.sh, this means that 1) if the image isn't pulled yet, there is an extended downtime between when the service is shut down and when it starts up again after the pull, and 2) if the service we want to start is at the end of the node file it also takes a while to get to it

we were talking with ruaok and Mr_Monkey in the office a few weeks ago - one option is to try and make the `start_listenbrainz_web` function similar enough to the container name (listenbrainz-web-$DEPLOY_ENV) that we can automatically convert from one to the other

if that means that we have to rename some startup functions or some container names then that's fine

interesting, yeah makes sense.

I don't know if you can call a function in bash given a string containing the name of that function. atj ?

i think we can.

because $VERSION errors with no command with value inside the variable found.

yup works

nice

let me throw a quick prototype together

👍

we could possibly even take a recommendation from your book and use python for this, just fork out to a shell for the startup. let me see how well it comes together

i was going to suggest that because bash is magic :).

eval "$function_name" # given the variable function_name contains the name of a function

_lucifer: I think we could do most of the deploy items in this document as a test, and then if it works we could get something like fabric/ansible for the final step

alastairp, yup makes sense.

good luck to all MB deployers!

[musicbrainz-server] reosarevok opened pull request #2105 (master…MBS-11664): MBS-11664 / MBS-11666: Enable discID tab for releases that wrongly have discids + add report https://github.com/metabrainz/musicbrainz-serve...

Cancel culture has gone too far. Cancelling entire days now. 😭

Mr_Monkey, let's deploy calendar nav?

👍

Want me to build the image?

no need. github will do it for us

what magic is this :-P

:D

Ah, I keep forgetting we have that now :p

[listenbrainz-server] release v-2021-05-17.0 has been published by github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

Automation displacing Mr_Monkey’s labour 😢

actually every one of us' labour ;)

plenty of less dumb labor to go round still.

automate the stupid stuff, give us more time to work on the fun stuff

Oh no, someone is going to automate me

reosarevok: you're safe. it is hard to make technology as lazy as you.

alastairp, _lucifer: we did exactly the opposite thing for MB last year: moving from fabric to bash, see: https://github.com/metabrainz/musicbrainz-serve...

oh! interesting.

i think these scripts already cover a lot of the functionality we are looking for. thanks! :D

yvanzo: of course you would have had to rewrite it at some point from fabric 2, so I guess the options were fabric 3 or bash, and you chose bash?

alastairp: unrelated to this but did you see the docker pull issue yestrerday? we were unable to pull metric-writer images on williams because the rate limit was exceeded. and were wondering if its finally time for our own image registry?

_lucifer: ah, I did see that in the history.

well, it was fixed by logging in.

someone asked if it was logged in

I recall seeing `docker login` somewhere in some script

right, the issue was solved with login.

oh, interesting. _jenkins_ does a login

I think our own registry would be nice, but unless its less than 1 hour of work, perhaps lets do it later when we have fewer open things.

I guess because it does lots of docker pulling

I think it'd be just as easy to ensure that we login on all nodes

in fact, much less work than our own registry

right makes sense.

good short term solution. but I suspect that docker will tighten these rules over time. eventually we will want to do this.

yeah, possible

there's some weird issue with the latest lb release.

ohh, the FAIL ALL button becomes available today. eggciting!

i reverted to last release for now.

|1 looks like we tried to update a startup script and we incorrectly wrote a || in a bash command

wow. great insight, alastairp.

i don't remember such a change but let me check to be sure

the last change to dockerfile or anything in docker directory was in v-2021-05-13.0 which is working fine :/

yeah, strange. I'm just inspecting the image now

_lucifer: mmm. did you switch to buildx on github?

no not yet. that PR is not merged.

alastairp: fabric 1/2 indeed, and also to combine it with docker-server-configs for hosts discovery.

_lucifer: interesting, that useradd is the last thing on the base image

if we decide to move some services to other hosts in docker-server-configs, we don't have to update musicbrainz-server.

alastairp, where do you see that output. for me its.

docker inspect metabrainz/listenbrainz:v-2021-05-17.0

yeah i did the same.

uhhh