@ListenBrainz/@MusicBrainz android app devs, I have the MusicBrainz android app installed and I get a toast message that a "user token has not been set!" everytime I play some videos. In the app I set my LB token but I still get this message... Any idea what is happening ?
2021-05-17 13720, 2021
akshaaatt[m]
<Lotheric_ " @ListenBrainz/@MusicBrainz andr"> Hi Lotheric_ ! I will go through the code today regarding this and get back to you as soon as I find any bugs and try to fix it. Else we always have _lucifer to help us out.
2021-05-17 13724, 2021
MRiddickW has quit
2021-05-17 13720, 2021
sumedh joined the channel
2021-05-17 13727, 2021
_lucifer
ruaok: i'd take a look at it but stats.me seems to be down currentyl ;)
2021-05-17 13758, 2021
_lucifer
Lotheric_: thanks for the report. can you please also share your android version?
2021-05-17 13722, 2021
_lucifer
akshaaatt[m]: thanks for taking a look at it. let me know if you need any help.
reosarevok wonders if editor merging would be a thing we could consider (so, moving someone's edits with a second account to their main one). Someone asked support about it - I expect it's less likely to be a problem now that we block email reuse tho
2021-05-17 13707, 2021
sumedh joined the channel
2021-05-17 13701, 2021
ruaok
mooin!
2021-05-17 13731, 2021
ruaok
_lucifer: yes, it seems that stats was down (or at least unreachable for a while) I
2021-05-17 13741, 2021
ruaok
I'll have to harden things more still.
2021-05-17 13717, 2021
ruaok
and the rise is because the MB mapper doesn't load old stats from disk when it starts -- I'll need to do that next.
2021-05-17 13752, 2021
_lucifer
ah ok, makes sense.
2021-05-17 13725, 2021
_lucifer
also, we should apply for Youtube OAuth verification today methinks
2021-05-17 13749, 2021
_lucifer
let's go over it once again others are available and then fill the verification form?
2021-05-17 13750, 2021
ruaok
ok, lets do that this afternoon.
2021-05-17 13759, 2021
ruaok
sure
2021-05-17 13702, 2021
ruaok
_lucifer: the dumps failed AGAIN, because one prerequisite temp dir was missing. grr. I've made a ticket for that and the full dump is finishing mogrifying.
2021-05-17 13726, 2021
ruaok
and somehow, we still didn't get a dumps are outdated email. sigh.
2021-05-17 13700, 2021
_lucifer
damn
2021-05-17 13736, 2021
ruaok
in fact, cron seems to have done nothing at all overnight.
2021-05-17 13749, 2021
ruaok
I'll let the dump finish before I investigate.
2021-05-17 13745, 2021
_lucifer
docker logs only shows entries from run stats crontab, but nothing from dumps crontab. ideas why that is so?
_lucifer: I saw your comment showing ruaok how to source services.sh in prod. Do you want to have a brainstorm about how we can make a 'deploy.sh' to do all of these steps
2021-05-17 13727, 2021
_lucifer
alastairp, sure
2021-05-17 13728, 2021
alastairp
take a project/service/date; pull image; stop old one; start new one; optionally update config file
2021-05-17 13737, 2021
ruaok
Yes, I do
2021-05-17 13743, 2021
alastairp
there is a script somewhere in docker-server-configs which does 90% of this
2021-05-17 13701, 2021
alastairp
I think yvanzo wrote it, and Mr_Monkey uses it sometimes
for me, the main disadvantage of this script is that it still starts services by running start_services.sh, this means that 1) if the image isn't pulled yet, there is an extended downtime between when the service is shut down and when it starts up again after the pull, and 2) if the service we want to start is at the end of the node file it also takes a while to get to it
2021-05-17 13717, 2021
alastairp
we were talking with ruaok and Mr_Monkey in the office a few weeks ago - one option is to try and make the `start_listenbrainz_web` function similar enough to the container name (listenbrainz-web-$DEPLOY_ENV) that we can automatically convert from one to the other
2021-05-17 13743, 2021
alastairp
if that means that we have to rename some startup functions or some container names then that's fine
2021-05-17 13756, 2021
_lucifer
interesting, yeah makes sense.
2021-05-17 13740, 2021
alastairp
I don't know if you can call a function in bash given a string containing the name of that function. atj ?
2021-05-17 13720, 2021
_lucifer
i think we can.
2021-05-17 13700, 2021
_lucifer
because $VERSION errors with no command with value inside the variable found.
we could possibly even take a recommendation from your book and use python for this, just fork out to a shell for the startup. let me see how well it comes together
2021-05-17 13754, 2021
_lucifer
i was going to suggest that because bash is magic :).
2021-05-17 13728, 2021
yvanzo
eval "$function_name" # given the variable function_name contains the name of a function
_lucifer: I think we could do most of the deploy items in this document as a test, and then if it works we could get something like fabric/ansible for the final step
2021-05-17 13734, 2021
_lucifer
alastairp, yup makes sense.
2021-05-17 13724, 2021
Etua joined the channel
2021-05-17 13716, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda (May 17th is cancelled; next meeting: 2021-05-24): Reviews
2021-05-17 13745, 2021
alastairp
good luck to all MB deployers!
2021-05-17 13730, 2021
sumedh has quit
2021-05-17 13743, 2021
BrainzGit
[musicbrainz-server] reosarevok opened pull request #2105 (master…MBS-11664): MBS-11664 / MBS-11666: Enable discID tab for releases that wrongly have discids + add report https://github.com/metabrainz/musicbrainz-server/…
2021-05-17 13722, 2021
Freso
Cancel culture has gone too far. Cancelling entire days now. 😭
i think these scripts already cover a lot of the functionality we are looking for. thanks! :D
2021-05-17 13709, 2021
alastairp
yvanzo: of course you would have had to rewrite it at some point from fabric 2, so I guess the options were fabric 3 or bash, and you chose bash?
2021-05-17 13735, 2021
_lucifer
alastairp: unrelated to this but did you see the docker pull issue yestrerday? we were unable to pull metric-writer images on williams because the rate limit was exceeded. and were wondering if its finally time for our own image registry?
2021-05-17 13757, 2021
alastairp
_lucifer: ah, I did see that in the history.
2021-05-17 13758, 2021
ruaok
well, it was fixed by logging in.
2021-05-17 13707, 2021
alastairp
someone asked if it was logged in
2021-05-17 13716, 2021
alastairp
I recall seeing `docker login` somewhere in some script
2021-05-17 13722, 2021
_lucifer
right, the issue was solved with login.
2021-05-17 13736, 2021
alastairp
oh, interesting. _jenkins_ does a login
2021-05-17 13744, 2021
ruaok
I think our own registry would be nice, but unless its less than 1 hour of work, perhaps lets do it later when we have fewer open things.
2021-05-17 13748, 2021
alastairp
I guess because it does lots of docker pulling
2021-05-17 13705, 2021
alastairp
I think it'd be just as easy to ensure that we login on all nodes
2021-05-17 13718, 2021
alastairp
in fact, much less work than our own registry
2021-05-17 13726, 2021
_lucifer
right makes sense.
2021-05-17 13733, 2021
ruaok
good short term solution. but I suspect that docker will tighten these rules over time. eventually we will want to do this.
2021-05-17 13747, 2021
alastairp
yeah, possible
2021-05-17 13727, 2021
_lucifer
there's some weird issue with the latest lb release.
2021-05-17 13730, 2021
ruaok
ohh, the FAIL ALL button becomes available today. eggciting!
